GNU bug report logs - #38459
[PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable 128 bit long double for POWER9.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38459 in the body.
You can then email your comments to 38459 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable 128 bit long
 double for POWER9.
Date: Mon, 2 Dec 2019 20:20:31 +0100

[Message part 1 (text/plain, inline)]

Hello,

This is to be applied against core-updates and fixes:

$ guix build --target=powerpc64le-linux-gnu bootstrap-tarballs

dftxbs3e

[0002-gnu-cross-gcc-arguments-Enable-128-bit-long-double-f.patch (text/x-patch, attachment)]

[0001-gnu-gcc-boot0-Enable-128-bit-long-double-for-POWER9.patch (text/x-patch, attachment)]

Message #8 received at 38459 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 38459 <at> debbugs.gnu.org
Subject: Re: [bug#38459] [PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable
 128 bit long double for POWER9.
Date: Mon, 02 Dec 2019 20:57:13 +0100

[Message part 1 (text/plain, inline)]

dftxbs3e,

dftxbs3e 写道：
> This is to be applied against core-updates and fixes:
>
> $ guix build --target=powerpc64le-linux-gnu bootstrap-tarballs

Thanks for sending this in!  I'll be sure to merge it if no one 
else has objections.

I'm really not familiar with this part of Guix, though.  I'd 
naively expect this to be guarded with an (if …) so it only 
applies to POWER.  (Why) is that not possible or desirable?

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: guix-patches <at> gnu.org
Subject: Re: [bug#38459] [PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable
 128 bit long double for POWER9.
Date: Mon, 2 Dec 2019 21:03:06 +0100

Yes, it should certainly be guarded by an if to avoid breaking other 
platforms, even if it shouldnt hurt much.

Issue is I do not know Scheme enough to figure out the syntax for an 
inline if like that. So I would appreciate if you could help me on that?

On 12/2/19 8:57 PM, Tobias Geerinckx-Rice via Guix-patches via wrote:
> dftxbs3e,
>
> dftxbs3e 写道：
>> This is to be applied against core-updates and fixes:
>>
>> $ guix build --target=powerpc64le-linux-gnu bootstrap-tarballs
>
> Thanks for sending this in!  I'll be sure to merge it if no one else 
> has objections.
>
> I'm really not familiar with this part of Guix, though.  I'd naively 
> expect this to be guarded with an (if …) so it only applies to POWER.  
> (Why) is that not possible or desirable?
>
> Kind regards,
>
> T G-R

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: guix-patches <at> gnu.org
Subject: Re: [bug#38459] [PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable
 128 bit long double for POWER9.
Date: Sat, 7 Dec 2019 20:28:18 +0100

[Message part 1 (text/plain, inline)]

I could figure it out myself.

Attached new patches!

On 12/2/19 9:03 PM, dftxbs3e wrote:
> Yes, it should certainly be guarded by an if to avoid breaking other 
> platforms, even if it shouldnt hurt much.
>
> Issue is I do not know Scheme enough to figure out the syntax for an 
> inline if like that. So I would appreciate if you could help me on that?
>
> On 12/2/19 8:57 PM, Tobias Geerinckx-Rice via Guix-patches via wrote:
>> dftxbs3e,
>>
>> dftxbs3e 写道：
>>> This is to be applied against core-updates and fixes:
>>>
>>> $ guix build --target=powerpc64le-linux-gnu bootstrap-tarballs
>>
>> Thanks for sending this in!  I'll be sure to merge it if no one else 
>> has objections.
>>
>> I'm really not familiar with this part of Guix, though.  I'd naively 
>> expect this to be guarded with an (if …) so it only applies to 
>> POWER.  (Why) is that not possible or desirable?
>>
>> Kind regards,
>>
>> T G-R
>
>
>

[0002-gnu-cross-gcc-arguments-Enable-128-bit-long-double-f.patch (text/x-patch, attachment)]

[0001-gnu-gcc-boot0-Enable-128-bit-long-double-for-POWER9.patch (text/x-patch, attachment)]

Message #17 received at 38459 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: dftxbs3e <dftxbs3e <at> free.fr>
Cc: 38459 <at> debbugs.gnu.org
Subject: Re: [bug#38459] [PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable
 128 bit long double for POWER9.
Date: Wed, 11 Dec 2019 01:04:02 +0100

[Message part 1 (text/plain, inline)]

dftxbs3e,

dftxbs3e 写道：
> I could figure it out myself.
>
> Attached new patches!

Thanks!

> +   ,@(if (equal? "powerpc64le-linux-gnu" boot-triplet)
                                           ^^^^^^^^^^^^

This doesn't look right to my tired eyes.

BOOT-TRIPLET isn't a string, but a procedure that returns a 
string.  As I see it, this comparison will always be false, on any 
platform, and the "--with-long-double-128" option will never be 
used.

How did you tests this?  The other patch looks correct: perhaps 
you were somehow testing only its effects?

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 38459 <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: 38459 <at> debbugs.gnu.org
Subject: [PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable 128 bit long
 double for POWER9.
Date: Sat, 21 Nov 2020 00:21:42 +0100

[Message part 1 (text/plain, inline)]

You are right, I can't test the commencement.scm patch yet because
bootstrap-tarballs are not built and included in GNU Guix yet. This
patch is intended to allow them to build.

Attached new patches.

[0001-gnu-gcc-boot0-Enable-128-bit-long-double-for-POWER9.patch (text/x-patch, attachment)]

[0002-gnu-cross-gcc-arguments-Enable-128-bit-long-double-f.patch (text/x-patch, attachment)]

Message #23 received at 38459 <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: 38459 <at> debbugs.gnu.org
Subject: [PATCH] gnu: (cross-gcc-arguments|gcc-boot0): Enable 128 bit long
 double for POWER9.
Date: Sat, 21 Nov 2020 00:30:43 +0100

Note: this can be applied on master by now since core-updates was
merged into it since then.

Message #28 received at 38459-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: dftxbs3e <dftxbs3e <at> free.fr>
Cc: 38459-done <at> debbugs.gnu.org
Subject: Re: [bug#38459] [PATCH] gnu: (cross-gcc-arguments|gcc-boot0):
 Enable 128 bit long double for POWER9.
Date: Thu, 26 Nov 2020 23:28:17 +0100

Hi,

dftxbs3e <dftxbs3e <at> free.fr> skribis:

>>From 66bcaaebe1761499a60518dc83975006aa30b58f Mon Sep 17 00:00:00 2001
> From: dftxbs3e <dftxbs3e <at> free.fr>
> Date: Sat, 7 Dec 2019 20:26:51 +0100
> Subject: [PATCH 1/2] gnu: gcc-boot0: Enable 128 bit long double for POWER9.
>
> ---
>  gnu/packages/commencement.scm | 5 +++++

[...]

>>From 0628808608a0b0851de913a88d626234358100c5 Mon Sep 17 00:00:00 2001
> From: dftxbs3e <dftxbs3e <at> free.fr>
> Date: Sat, 7 Dec 2019 20:27:12 +0100
> Subject: [PATCH 2/2] gnu: cross-gcc-arguments: Enable 128 bit long double for
>  POWER9.
>
> ---
>  gnu/packages/cross-base.scm | 5 +++++

I’ve applied both as a single commit with a commit message that follows
our conventions.  At last.  :-)

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.