GNU bug report logs - #38477
[PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38477 in the body.
You can then email your comments to 38477 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd
 services.
Date: Tue,  3 Dec 2019 15:00:27 -0500

This should improve the "user experience" when querying the status of
the SSH service.  We could even add program specific strings like
"lshd", "dropbear", and "openssh".  Thoughts?

* gnu/services/ssh.scm (lsh-shepherd-service, dropbear-shepherd-service,
openssh-sheperd-service): Add 'ssh' and 'sshd' to provision.
---
 gnu/services/ssh.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
index ced1991fba..7e25810eff 100644
--- a/gnu/services/ssh.scm
+++ b/gnu/services/ssh.scm
@@ -174,7 +174,7 @@
 
   (list (shepherd-service
          (documentation "GNU lsh SSH server")
-         (provision '(ssh-daemon))
+         (provision '(ssh-daemon ssh sshd))
          (requirement requires)
          (start #~(make-forkexec-constructor (list #$@lsh-command)))
          (stop  #~(make-kill-destructor)))))
@@ -511,7 +511,7 @@ of user-name/file-like tuples."
   (list (shepherd-service
          (documentation "OpenSSH server.")
          (requirement '(syslogd loopback))
-         (provision '(ssh-daemon))
+         (provision '(ssh-daemon ssh sshd))
          (start #~(make-forkexec-constructor #$openssh-command
                                              #:pid-file #$pid-file))
          (stop #~(make-kill-destructor))
@@ -620,7 +620,7 @@ of user-name/file-like tuples."
   (list (shepherd-service
          (documentation "Dropbear SSH server.")
          (requirement requires)
-         (provision '(ssh-daemon))
+         (provision '(ssh-daemon ssh sshd))
          (start #~(make-forkexec-constructor #$dropbear-command
                                              #:pid-file #$pid-file))
          (stop #~(make-kill-destructor)))))
-- 
2.24.0

Message #8 received at 38477 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 38477 <at> debbugs.gnu.org
Subject: Re: [bug#38477] [PATCH] services: SSH services: Provide 'ssh' and
 'sshd' Shepherd services.
Date: Tue, 03 Dec 2019 21:06:28 -0600

Leo Famulari <leo <at> famulari.name> writes:

> This should improve the "user experience" when querying the status of
> the SSH service.  We could even add program specific strings like
> "lshd", "dropbear", and "openssh".  Thoughts?

I think this is a good idea. It would add a lot of granular
control. However, we would need to make sure this is a standard used for
other SSH options in the future.

> * gnu/services/ssh.scm (lsh-shepherd-service, dropbear-shepherd-service,
> openssh-sheperd-service): Add 'ssh' and 'sshd' to provision.
> ---
>  gnu/services/ssh.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
> index ced1991fba..7e25810eff 100644
> --- a/gnu/services/ssh.scm
> +++ b/gnu/services/ssh.scm
> @@ -174,7 +174,7 @@
>  
>    (list (shepherd-service
>           (documentation "GNU lsh SSH server")
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (requirement requires)
>           (start #~(make-forkexec-constructor (list #$@lsh-command)))
>           (stop  #~(make-kill-destructor)))))
> @@ -511,7 +511,7 @@ of user-name/file-like tuples."
>    (list (shepherd-service
>           (documentation "OpenSSH server.")
>           (requirement '(syslogd loopback))
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (start #~(make-forkexec-constructor #$openssh-command
>                                               #:pid-file #$pid-file))
>           (stop #~(make-kill-destructor))
> @@ -620,7 +620,7 @@ of user-name/file-like tuples."
>    (list (shepherd-service
>           (documentation "Dropbear SSH server.")
>           (requirement requires)
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (start #~(make-forkexec-constructor #$dropbear-command
>                                               #:pid-file #$pid-file))
>           (stop #~(make-kill-destructor)))))

LGTM! Very simple solution. Should be easy to cross-implement to other uses.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Message #13 received at 38477-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 38477-done <at> debbugs.gnu.org
Subject: Re: [bug#38477] [PATCH] services: SSH services: Provide 'ssh' and
 'sshd' Shepherd services.
Date: Wed, 4 Dec 2019 08:32:31 -0500

On Tue, Dec 03, 2019 at 09:06:28PM -0600, Brett Gilio wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> 
> > This should improve the "user experience" when querying the status of
> > the SSH service.  We could even add program specific strings like
> > "lshd", "dropbear", and "openssh".  Thoughts?
> 
> I think this is a good idea. It would add a lot of granular
> control. However, we would need to make sure this is a standard used for
> other SSH options in the future.

Okay, all are welcome to make this change :)

> LGTM! Very simple solution. Should be easy to cross-implement to other uses.

Thanks! Pushed as 1a7633c2397714c492482282da670e47f7dc8177

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.