GNU bug report logs - #38480
[PATCH] gnu: Add lolcat

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38480 in the body.
You can then email your comments to 38480 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add lolcat
Date: Wed,  4 Dec 2019 02:46:44 +0100

* gnu/packages/games.scm (lolcat): New package.
---
 gnu/packages/games.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 8dd08844ee..b15016e4bb 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -498,6 +498,47 @@ cows can think too: all you have to do is run @command{cowthink}.  If you're
 tired of cows, a variety of other ASCII-art messengers are available.")
     (license license:gpl3+)))
 
+(define-public lolcat
+  (let ((commit "35dca3d0a381496d7195cd78f5b24aa7b62f2154")
+        (revision "0"))
+    (package
+      (name "lolcat")
+      (version (git-version "1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/jaseg/lolcat.git")
+               (commit commit)))
+         (sha256
+          (base32
+           "0jjbkqcc2ikjxd1xgdyv4rb0vsw218181h89f2ywg29ffs3ypd8g"))
+         (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ;; tests don't exist
+         #:make-flags (list "CC=gcc")
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'bootstrap)
+           (delete 'configure)
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((dest (map (lambda (path) (string-append path "/bin"))
+                                (list (assoc-ref outputs "out")
+                                      (assoc-ref outputs "censor")))))
+                 (for-each mkdir-p dest)
+                 (install-file "lolcat" (car dest))
+                 (install-file "censor" (cadr dest))
+                 #t))))))
+      (outputs (list "out" "censor"))
+      (home-page "https://github.com/jaseg/lolcat")
+      (synopsis "Rainbow coloring effect for text console display")
+      (description "Lolcat concatenates files and streams like regular cat,
+but it also adds terminal escape codes between characters and lines resulting
+in a rainbow effect.")
+      (license license:wtfpl2))))
+
 (define-public freedoom
   (package
     (name "freedoom")
-- 
2.24.0

Message #8 received at 38480 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 38480 <at> debbugs.gnu.org
Subject: Re: [bug#38480] [PATCH] gnu: Add lolcat
Date: Tue, 03 Dec 2019 21:00:35 -0600

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> +       `(#:tests? #f ;; tests don't exist

LGTM! Though, perhaps an aesthetic issue. I usually prefer (and see)
"no check target". Carry on!

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Message #11 received at 38480 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 38480 <at> debbugs.gnu.org
Subject: Re: [bug#38480] [PATCH] gnu: Add lolcat
Date: Thu, 05 Dec 2019 18:41:40 +0100

[Message part 1 (text/plain, inline)]

Hi Brett,

Am Dienstag, den 03.12.2019, 21:00 -0600 schrieb Brett Gilio:
> Leo Prikler <leo.prikler <at> student.tugraz.at> writes:
> 
> > +       `(#:tests? #f ;; tests don't exist
> 
> LGTM! Though, perhaps an aesthetic issue. I usually prefer (and see)
> "no check target". Carry on!
Fair enough, I've adapted the patch.

Regards,
Leo

[0001-gnu-Add-lolcat.patch (text/x-patch, attachment)]

Message #14 received at 38480 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 38480 <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#38480] [PATCH] gnu: Add lolcat
Date: Sun, 15 Dec 2019 00:28:34 +0100

Hello!

Leo Prikler <leo.prikler <at> student.tugraz.at> skribis:

> From: Leo Prikler <leo.prikler <at> student.tugraz.at>
> Date: Wed,  4 Dec 2019 02:46:44 +0100
> Subject: [PATCH] gnu: Add lolcat
>
> * gnu/packages/games.scm (lolcat): New package.

[...]

> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((dest (map (lambda (path) (string-append path "/bin"))
> +                                (list (assoc-ref outputs "out")
> +                                      (assoc-ref outputs "censor")))))
> +                 (for-each mkdir-p dest)
> +                 (install-file "lolcat" (car dest))
> +                 (install-file "censor" (cadr dest))
> +                 #t))))))
> +      (outputs (list "out" "censor"))

Can’t we keep them both in the same output?  Separate outputs are
normally only used when it helps save space, but I don’t think that’s a
concern here.  :-)

> +      (home-page "https://github.com/jaseg/lolcat")
> +      (synopsis "Rainbow coloring effect for text console display")
> +      (description "Lolcat concatenates files and streams like regular cat,
                       ^                                                  ^
Maybe @command{cat} and @command{lolcat}.

Could you send an updated patch?

Thanks,
Ludo’.

Message #17 received at 38480 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38480 <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#38480] [PATCH] gnu: Add lolcat
Date: Sun, 15 Dec 2019 01:10:30 +0100

[Message part 1 (text/plain, inline)]

Hello!

Am Sonntag, den 15.12.2019, 00:28 +0100 schrieb Ludovic Courtès:
> Hello!
> 
> Leo Prikler <leo.prikler <at> student.tugraz.at> skribis:
> 
> > From: Leo Prikler <leo.prikler <at> student.tugraz.at>
> > Date: Wed,  4 Dec 2019 02:46:44 +0100
> > Subject: [PATCH] gnu: Add lolcat
> > 
> > * gnu/packages/games.scm (lolcat): New package.
> 
> [...]
> 
> > +           (replace 'install
> > +             (lambda* (#:key outputs #:allow-other-keys)
> > +               (let ((dest (map (lambda (path) (string-append path
> > "/bin"))
> > +                                (list (assoc-ref outputs "out")
> > +                                      (assoc-ref outputs
> > "censor")))))
> > +                 (for-each mkdir-p dest)
> > +                 (install-file "lolcat" (car dest))
> > +                 (install-file "censor" (cadr dest))
> > +                 #t))))))
> > +      (outputs (list "out" "censor"))
> 
> Can’t we keep them both in the same output?  Separate outputs are
> normally only used when it helps save space, but I don’t think that’s
> a
> concern here.  :-)
Of course we can.  I initially separated them, because it's really two
very different programs put into one git repo, but of course the
separation serves no real purpose.

> > +      (home-page "https://github.com/jaseg/lolcat")
> > +      (synopsis "Rainbow coloring effect for text console
> > display")
> > +      (description "Lolcat concatenates files and streams like
> > regular cat,
>                        ^                                             
>      ^
> Maybe @command{cat} and @command{lolcat}.
Not sure about @command{lolcat}, since it's at the start of the
sentence, but okay.

> Could you send an updated patch?
> 
> Thanks,
> Ludo’.
Patch is attached.

Regards,
Leo

[0001-gnu-Add-lolcat.patch (text/x-patch, attachment)]

Message #22 received at 38480-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 38480-done <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#38480] [PATCH] gnu: Add lolcat
Date: Sun, 15 Dec 2019 21:59:34 +0100

[Message part 1 (text/plain, inline)]

Hi!

Leo Prikler <leo.prikler <at> student.tugraz.at> skribis:

> From 42827748e50fe20fdf23ff1137067a7d6c80c87e Mon Sep 17 00:00:00 2001
> From: Leo Prikler <leo.prikler <at> student.tugraz.at>
> Date: Wed, 4 Dec 2019 02:46:44 +0100
> Subject: [PATCH] gnu: Add lolcat
>
> * gnu/packages/games.scm (lolcat): New package.

I made the changes below to make it work with a single output.

Committed, thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 1f08dd240a..c8d671bbdc 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -528,11 +528,12 @@ tired of cows, a variety of other ASCII-art messengers are available.")
            (delete 'configure)
            (replace 'install
              (lambda* (#:key outputs #:allow-other-keys)
-               (let ((dest (string-append path "/bin")))
+               (let* ((out  (assoc-ref outputs "out"))
+                      (dest (string-append out "/bin")))
                  (mkdir-p dest)
                  (install-file "lolcat" dest)
+                 (install-file "censor" dest)
                  #t))))))
-      (outputs (list "out" "censor"))
       (home-page "https://github.com/jaseg/lolcat")
       (synopsis "Rainbow coloring effect for text console display")
       (description "@command{lolcat} concatenates files and streams like

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.