GNU bug report logs - #38487
[PATCH] Add ghc-apply-refact

Previous Next

Package: guix-patches;

Reported by: Brian Leung <bkleung89 <at> gmail.com>

Date: Wed, 4 Dec 2019 07:06:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38487 in the body.
You can then email your comments to 38487 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38487; Package guix-patches. (Wed, 04 Dec 2019 07:06:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brian Leung <bkleung89 <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 04 Dec 2019 07:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add ghc-apply-refact
Date: Tue, 3 Dec 2019 23:04:56 -0800
[Message part 1 (text/plain, inline)]
See attached.
[Message part 2 (text/html, inline)]
[0001-gnu-Add-ghc-apply-refact.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#38487; Package guix-patches. (Fri, 17 Jan 2020 16:34:03 GMT) Full text and rfc822 format available.

Message #8 received at 38487 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 38487 <at> debbugs.gnu.org, bkleung89 <at> gmail.com
Subject: [PATCH] gnu: Add ghc-apply-refact.
Date: Fri, 17 Jan 2020 16:33:41 +0000
Hi Brian,

Thanks for another haskell tool! I built it this morning and it built.
I do not use apply-refact, though. Have you been using it with
success?

My only thought is to move this package to haskell-apps.scm and call
the package apply-refact. What do you think?

John




Information forwarded to guix-patches <at> gnu.org:
bug#38487; Package guix-patches. (Fri, 24 Jan 2020 04:46:01 GMT) Full text and rfc822 format available.

Message #11 received at 38487 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 38487 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add ghc-apply-refact.
Date: Thu, 23 Jan 2020 20:45:01 -0800
[Message part 1 (text/plain, inline)]
Hi John,

Thanks for your reply. I tested it just now and it seems to work. I've made
your suggested changes and also attached a related patch.

Best,
Brian

On Fri, Jan 17, 2020 at 8:33 AM John Soo <jsoo1 <at> asu.edu> wrote:

> Hi Brian,
>
> Thanks for another haskell tool! I built it this morning and it built.
> I do not use apply-refact, though. Have you been using it with
> success?
>
> My only thought is to move this package to haskell-apps.scm and call
> the package apply-refact. What do you think?
>
> John
>
[Message part 2 (text/html, inline)]
[0001-gnu-Add-apply-refact.patch (text/x-patch, attachment)]
[0002-gnu-Add-emacs-hlint-refactor-mode.patch (text/x-patch, attachment)]

Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Sun, 29 Mar 2020 19:06:02 GMT) Full text and rfc822 format available.

Notification sent to Brian Leung <bkleung89 <at> gmail.com>:
bug acknowledged by developer. (Sun, 29 Mar 2020 19:06:02 GMT) Full text and rfc822 format available.

Message #16 received at 38487-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Brian Leung <bkleung89 <at> gmail.com>, John Soo <jsoo1 <at> asu.edu>
Cc: 38487-done <at> debbugs.gnu.org
Subject: Re: [bug#38487] [PATCH] gnu: Add ghc-apply-refact.
Date: Sun, 29 Mar 2020 21:05:21 +0200
[Message part 1 (text/plain, inline)]
Brian Leung <bkleung89 <at> gmail.com> writes:

> Hi John,
>
> Thanks for your reply. I tested it just now and it seems to work. I've made
> your suggested changes and also attached a related patch.

Thanks!  I added copyright information for you, fixed some issues
reported by 'guix lint' as well as unnecessary linebreaks, and applied
both patches.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 27 Apr 2020 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 364 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.