GNU bug report logs - #38505
[PATCH] gnu: Add fast-screen.

Previous Next

Package: guix-patches;

Reported by: Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>

Date: Thu, 5 Dec 2019 21:22:01 UTC

Severity: normal

Tags: moreinfo, patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38505 in the body.
You can then email your comments to 38505 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38505; Package guix-patches. (Thu, 05 Dec 2019 21:22:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 05 Dec 2019 21:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Cc: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: [PATCH] gnu: Add fast-screen.
Date: Thu, 5 Dec 2019 22:21:14 +0100
* gnu/packages/bioinformatics.scm (fast-screen): New variable.
---
 gnu/packages/bioinformatics.scm | 53 +++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 74a44874ee..53e4c7296f 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -15341,3 +15341,56 @@ methylation metrics from them.  MethylDackel requires an indexed fasta file
 containing the reference genome as well.")
     ;; See https://github.com/dpryan79/MethylDackel/issues/85
     (license license:expat)))
+
+(define-public fastq-screen
+  (package
+    (name "fastq-screen")
+    (version "0.14.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://www.bioinformatics.babraham.ac.uk/projects/"
+			   "fastq_screen/fastq_screen_v" version ".tar.gz"))
+       (sha256
+        (base32
+         "0m7n9b1pr8rk1pd3va0mr69pd7gddcsvrvlk2s7907i02wkc1say"))))
+    (build-system trivial-build-system)
+    (arguments
+     ;; it is just an extraction processs
+     `(#:modules ((guix build utils))
+       #:builder
+       (begin
+	 (use-modules (guix build utils))
+	 (let* ((tar (assoc-ref %build-inputs "tar"))
+	        (gzip (assoc-ref %build-inputs "gzip"))
+	        (out (assoc-ref %outputs "out"))
+	        (doc (string-append out "/share/doc"))
+	        (bin (string-append out "/bin")))
+	   (setenv "PATH" (string-append tar "/bin:" gzip "/bin"))
+	   (invoke "tar" "xvf" (assoc-ref %build-inputs "source"))
+	   (chdir (string-append "fastq_screen_v" ,version))
+           (install-file "fastq_screen" bin)
+	   (install-file "fastq_screen.conf.example" doc)
+	   (install-file "fastq_screen_documentation.md" doc)
+	   (install-file "RELEASE_NOTES.txt" doc)
+	   #t))))
+    (inputs
+     `(("perl" ,perl)))
+    (native-inputs
+     `(("gzip" ,gzip)
+       ("tar" ,tar)))
+    (home-page "https://www.bioinformatics.babraham.ac.uk/projects/fastq_screen/")
+    (synopsis "FastQ Screen allows to search a large sequence dataset")
+    (description
+     "FastQ Screen is an application which allows you to search a large sequence
+dataset against a panel of different databases to build up a picture of where
+the sequences in your data originate.  The program was built as a quality
+control check for sequencing pipelines but may also have uses in metagenomics
+studies where mixed samples are expected.  The application generates both text
+and graphical output to inform you what proportion of your library was able to
+map, either uniquely or to more than one location, against each of your
+specified reference genomes.  The user should therefore be able to identify a
+clean sequencing experiment in which the overwhelming majority of reads are
+probably derived from a single genomic origin.")
+    (license license:gpl3+)))
+
-- 
2.17.1





Information forwarded to guix-patches <at> gnu.org:
bug#38505; Package guix-patches. (Wed, 11 Dec 2019 02:18:01 GMT) Full text and rfc822 format available.

Message #8 received at 38505 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: 38505 <at> debbugs.gnu.org
Subject: Re: [bug#38505] [PATCH] gnu: Add fast-screen.
Date: Wed, 11 Dec 2019 04:16:25 +0200
[Message part 1 (text/plain, inline)]
It's not clear to me what perl is used for in this package.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#38505; Package guix-patches. (Mon, 16 Dec 2019 22:42:01 GMT) Full text and rfc822 format available.

Message #11 received at 38505 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: 38505 <at> debbugs.gnu.org
Subject: Re: [bug#38505] [PATCH] gnu: Add fast-screen.
Date: Mon, 16 Dec 2019 23:41:47 +0100
Hi Mădălin,

> * gnu/packages/bioinformatics.scm (fast-screen): New variable.

I don’t think this package actually produces a usable output.

Frustratingly, this is a Perl script which calls out to tools that
happen to be on the user’s PATH, such as Bismark (which is written in
the same style, so it may be enlightening to read its package
definition), bwa, or bowtie.

Simply copying the script to the store won’t yield a usable tool I’m
afraid.

For Bismark I talked to the authors in the past in the hopes of
simplifying configuration at build time, but they were not interested in
changing the tool to accomodate any other case than the one Bismark was
designed for: to be unpacked in an already suitable environment.

This means that we can’t count on upstream to change this and patch the
source file by ourselves.  One way is to patch every invocation of an
external command; another is to wrap the script itself (with
“wrap-script”) in PATH and PERL5PATH to provide a suitable environment
at runtime.  (Wrapping PERL5PATH may be necessary anyway to ensure that
Perl can find the required modules.)

Good luck!

--
Ricardo





Added tag(s) moreinfo. Request was from Maxim Cournoyer <maxim.cournoyer <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 18 Mar 2022 04:13:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#38505; Package guix-patches. (Fri, 18 Mar 2022 04:14:02 GMT) Full text and rfc822 format available.

Message #16 received at 38505 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 38505 <at> debbugs.gnu.org,
 Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: Re: bug#38505: [PATCH] gnu: Add fast-screen.
Date: Fri, 18 Mar 2022 00:13:37 -0400
Hello,

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Hi Mădălin,
>
>> * gnu/packages/bioinformatics.scm (fast-screen): New variable.
>
> I don’t think this package actually produces a usable output.
>
> Frustratingly, this is a Perl script which calls out to tools that
> happen to be on the user’s PATH, such as Bismark (which is written in
> the same style, so it may be enlightening to read its package
> definition), bwa, or bowtie.
>
> Simply copying the script to the store won’t yield a usable tool I’m
> afraid.
>
> For Bismark I talked to the authors in the past in the hopes of
> simplifying configuration at build time, but they were not interested in
> changing the tool to accomodate any other case than the one Bismark was
> designed for: to be unpacked in an already suitable environment.
>
> This means that we can’t count on upstream to change this and patch the
> source file by ourselves.  One way is to patch every invocation of an
> external command; another is to wrap the script itself (with
> “wrap-script”) in PATH and PERL5PATH to provide a suitable environment
> at runtime.  (Wrapping PERL5PATH may be necessary anyway to ensure that
> Perl can find the required modules.)
>
> Good luck!

Some 2 years later, are you still up to the challenge hinted at by
Ricardo? :-)

Thanks,

Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#38505; Package guix-patches. (Fri, 21 Feb 2025 22:17:03 GMT) Full text and rfc822 format available.

Message #19 received at 38505 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 38505 <at> debbugs.gnu.org,
 Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: Re: [bug#38505] [PATCH] gnu: Add fast-screen.
Date: Fri, 21 Feb 2025 22:57:42 +0100
Hi,

For reference: https://issues.guix.gnu.org/issue/38505

On Fri, 18 Mar 2022 at 00:13, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

>>> * gnu/packages/bioinformatics.scm (fast-screen): New variable.
>>
>> I don’t think this package actually produces a usable output.
>>
>> Frustratingly, this is a Perl script which calls out to tools that
>> happen to be on the user’s PATH, such as Bismark (which is written in
>> the same style, so it may be enlightening to read its package
>> definition), bwa, or bowtie.
>>
>> Simply copying the script to the store won’t yield a usable tool I’m
>> afraid.
>>
>> For Bismark I talked to the authors in the past in the hopes of
>> simplifying configuration at build time, but they were not interested in
>> changing the tool to accomodate any other case than the one Bismark was
>> designed for: to be unpacked in an already suitable environment.
>>
>> This means that we can’t count on upstream to change this and patch the
>> source file by ourselves.  One way is to patch every invocation of an
>> external command; another is to wrap the script itself (with
>> “wrap-script”) in PATH and PERL5PATH to provide a suitable environment
>> at runtime.  (Wrapping PERL5PATH may be necessary anyway to ensure that
>> Perl can find the required modules.)
>>
>> Good luck!
>
> Some 2 years later, are you still up to the challenge hinted at by
> Ricardo? :-)

Hum, 2 years, 48 weeks, 5 days more, what about the challenge? :-)

I’m in favor to close it, WDYT?

Cheers,
simon




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Sat, 22 Feb 2025 12:57:02 GMT) Full text and rfc822 format available.

Notification sent to Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>:
bug acknowledged by developer. (Sat, 22 Feb 2025 12:57:03 GMT) Full text and rfc822 format available.

Message #24 received at 38505-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 38505-done <at> debbugs.gnu.org,
 Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: Re: [bug#38505] [PATCH] gnu: Add fast-screen.
Date: Sat, 22 Feb 2025 21:55:51 +0900
Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> For reference: https://issues.guix.gnu.org/issue/38505
>
> On Fri, 18 Mar 2022 at 00:13, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>>>> * gnu/packages/bioinformatics.scm (fast-screen): New variable.
>>>
>>> I don’t think this package actually produces a usable output.
>>>
>>> Frustratingly, this is a Perl script which calls out to tools that
>>> happen to be on the user’s PATH, such as Bismark (which is written in
>>> the same style, so it may be enlightening to read its package
>>> definition), bwa, or bowtie.
>>>
>>> Simply copying the script to the store won’t yield a usable tool I’m
>>> afraid.
>>>
>>> For Bismark I talked to the authors in the past in the hopes of
>>> simplifying configuration at build time, but they were not interested in
>>> changing the tool to accomodate any other case than the one Bismark was
>>> designed for: to be unpacked in an already suitable environment.
>>>
>>> This means that we can’t count on upstream to change this and patch the
>>> source file by ourselves.  One way is to patch every invocation of an
>>> external command; another is to wrap the script itself (with
>>> “wrap-script”) in PATH and PERL5PATH to provide a suitable environment
>>> at runtime.  (Wrapping PERL5PATH may be necessary anyway to ensure that
>>> Perl can find the required modules.)
>>>
>>> Good luck!
>>
>> Some 2 years later, are you still up to the challenge hinted at by
>> Ricardo? :-)
>
> Hum, 2 years, 48 weeks, 5 days more, what about the challenge? :-)
>
> I’m in favor to close it, WDYT?

Done.  Anyone still needing this feel to resubmit with this feedback
taken into account.

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#38505; Package guix-patches. (Sat, 22 Feb 2025 12:57:03 GMT) Full text and rfc822 format available.

Message #27 received at 38505-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 38505-done <at> debbugs.gnu.org,
 Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: Re: [bug#38505] [PATCH] gnu: Add fast-screen.
Date: Sat, 22 Feb 2025 21:56:11 +0900
Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> For reference: https://issues.guix.gnu.org/issue/38505
>
> On Fri, 18 Mar 2022 at 00:13, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>>>> * gnu/packages/bioinformatics.scm (fast-screen): New variable.
>>>
>>> I don’t think this package actually produces a usable output.
>>>
>>> Frustratingly, this is a Perl script which calls out to tools that
>>> happen to be on the user’s PATH, such as Bismark (which is written in
>>> the same style, so it may be enlightening to read its package
>>> definition), bwa, or bowtie.
>>>
>>> Simply copying the script to the store won’t yield a usable tool I’m
>>> afraid.
>>>
>>> For Bismark I talked to the authors in the past in the hopes of
>>> simplifying configuration at build time, but they were not interested in
>>> changing the tool to accomodate any other case than the one Bismark was
>>> designed for: to be unpacked in an already suitable environment.
>>>
>>> This means that we can’t count on upstream to change this and patch the
>>> source file by ourselves.  One way is to patch every invocation of an
>>> external command; another is to wrap the script itself (with
>>> “wrap-script”) in PATH and PERL5PATH to provide a suitable environment
>>> at runtime.  (Wrapping PERL5PATH may be necessary anyway to ensure that
>>> Perl can find the required modules.)
>>>
>>> Good luck!
>>
>> Some 2 years later, are you still up to the challenge hinted at by
>> Ricardo? :-)
>
> Hum, 2 years, 48 weeks, 5 days more, what about the challenge? :-)
>
> I’m in favor to close it, WDYT?

Done.  Anyone still needing this, please resubmit with the above
feedback taken into account.

-- 
Thanks,
Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 23 Mar 2025 11:24:14 GMT) Full text and rfc822 format available.

This bug report was last modified 47 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.