GNU bug report logs - #38509
[PATCH] gnu: libuv: Update to 1.34.0

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Andrew Miloradovsky <andrew@HIDDEN>; Keywords: patch; dated Fri, 6 Dec 2019 14:57:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 38509 <at> debbugs.gnu.org:


Received: (at 38509) by debbugs.gnu.org; 8 Dec 2019 02:38:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 07 21:38:57 2019
Received: from localhost ([127.0.0.1]:50008 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1idmTJ-0005zP-9I
	for submit <at> debbugs.gnu.org; Sat, 07 Dec 2019 21:38:57 -0500
Received: from mslow2.mail.gandi.net ([217.70.178.242]:44180)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andrew@HIDDEN>) id 1idmTH-0005zH-JG
 for 38509 <at> debbugs.gnu.org; Sat, 07 Dec 2019 21:38:56 -0500
Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198])
 by mslow2.mail.gandi.net (Postfix) with ESMTP id 4F57B3AFF2B
 for <38509 <at> debbugs.gnu.org>; Sat,  7 Dec 2019 13:31:32 +0000 (UTC)
X-Originating-IP: 46.226.110.13
Received: from [0.0.0.0] (xvm-110-13.dc2.ghst.net [46.226.110.13])
 (Authenticated sender: andrew@HIDDEN)
 by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id DB7C1C0005;
 Sat,  7 Dec 2019 13:31:29 +0000 (UTC)
Subject: Re: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
To: Brett Gilio <brettg@HIDDEN>
References: <20191206085713.27096-1-andrew@HIDDEN>
 <87d0d0org0.fsf@HIDDEN> <878snoor4q.fsf@HIDDEN>
From: Andrew Miloradovsky <andrew@HIDDEN>
Openpgp: preference=signencrypt
Autocrypt: addr=andrew@HIDDEN; prefer-encrypt=mutual; keydata=
 mQINBFg+3V4BEADLfrVu68AKRL40xssnIMe1IDv/UOjfT7ZpB7jZfN++q5hIiXg47xzgP6S1
 KCSHWvx+dlZt1Pgf9pu7snsMJxQ2SJkTOJxQvwpDlNaCbZKhuBc3MbdbU7KOwNi4IBtWWGKr
 WGmqi/njRaCARTR6SyThmTtik+upu1SHXA9QDHSczJ5IZBoE1vjgjuZmXSIaN7tpmfvTpu7x
 QNtYxT3hMjQe8HaeIUCdLzi4Nug+/HA48YU81s7arp9bpvV1CcmAKmpVbWBqqN51rDh1/d8D
 A5h3NDWj2Kg2JIbXJa3nP3jCJbX2SA+Gqe8ig61Lr6fnUS1X0hg72sK2Iw22UzdJT9pKDQd7
 1RbJO3mqM0cpihc9lZZM1AIUffSDg6q9NGHpmOJ4IKg4/CY7JN+VgfxFzIc93Hyf6zT0RaA/
 x/li1DBAQdSrWbeUtgKgbs0YC3AEqvH3LKp+I3Ej261iKiaWJ0IMxXZMvN/S5N3RTDJoqoqv
 azlb19a//s6i6PF++GqNeXQgIqsefVQ4qq8p06oqk7SZZbuyJPsxVgFIgxdvOqecSX7fMgyl
 cfI/x/4sWc53VPAC2bIkjZufdTEb+Sdaqxqmo780tFtuyitEr2k7EWAm6nDLcRgSaL5FTKCq
 VEtTfFzC6jfhR2kA+Hw9q2k3os/RzslkFR1VmMuXCg4JKpa+mQARAQABtC1BbmRyZXcgTWls
 b3JhZG92c2t5IDxhbmRyZXdAaW50ZXJwcmV0bWF0aC5wdz6JAlcEEwEIAEECGyMFCQlmAYAF
 CwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQSRiJ3v1HuG7azVLRA1XCWRxXBsiwUCXAGEAAIZ
 AQAKCRA1XCWRxXBsi+u0D/9eWEb3yxmBD/O3BqCBSfxfmoRhdQiYMAZNEsxkW6N44pvrogqo
 DiLaidk7nuK8/Ds+eF0OByRcPlXFv1u1SbjCS2+vAskLoyFie18ywL1eYPQu2b5W2lqPJ09p
 KlzD+k0/Ivkph3pxjL4uVbXRhGRV8FkKO7gQ9A3x6lVtaXhkYlafBphwsQh7GdDWi+5xRmjr
 HFYDJt4o3gfQVsO7Q3cLQImDtRz1s5lOayQ8XUwnET9skE9mXe/T5+JR5sug4oVCPKhP4tEt
 cNEFPbFtPURqjCuF5QVkGGv6zZAWLOLkWePP7jaWMhUD3IsYCRIl0pZk2rOprceEz1YA34xG
 tGah0drurp3I8eW02ClldbQpyiKkn5bjZtcjk25Q7yk9Upfxnn4y0F29aSQjrv/ZB4WZ0z76
 KERiUMXs9YIPn9qrXRj/R8zhJlMSx3+YTYJGlTvsQIfsCVrFzCz1lJvsLurF6iRIOslr2sAM
 Q6YZGteAPU4hFSC33ColyrmD/iom139dXpVHBs0+oYGSdXTVUgPQUjfvHLp/KSY7X2oihL18
 x+PzCibn4F4e2rmbK0kFhA0pCPcE9jmG2uyz1jrZ8ZcEzQIGPIMWbBkfyfuzvfN24uwgsoKJ
 Cx8OTeFSBFoajLRvzfxvaA/AW+P3eH/87Ppas3SSO+0vzpSm92HLxnSya7kCDQRYPt1eARAA
 v9hGlzMIiwpXcFLJCo3N7gq4ddAaEh4Oye59UsOwNEPumXbVOz1EmepywG0QkqKhiRxP+VnD
 KgpCBYZ6mrYMgqPliJUbkcG+6pEJD+REN++PmjiRaLDsLs/NkPUV97IVqQv2b2swFMzXuTxO
 iFn4e4jQIqVKGk6UY8E6ze0ggrQoQaUbzx/GgPtmH1Mw+i+wpb6K5fTC5CwA0Gq6vUfZ01E4
 YGCgcMsYD685gYKdOBDOGd7/zvWfwpeZIdsPSnmV8VkmzEib9WfsYK/bA1ZKRofSL+QSUnAD
 obt4dr0EAiMPrEcbr4SVyZo0ORfocy3hX8Zyk4vsp5u9QEGpI7h+X0FOuzZc3hzkXWcUfkMJ
 73RGjkT43MW4c/udNpO4snvgBDLK25VJtfuxkn/N+UzCuj8l2dwNDiuuhogaemnmHEk/Qodo
 3QJ7snUdWzSRV7TQBjn3Eu/OXeZ3eqUV0KS4dFCyrzl+ZiVsZj3x5Q2Nr6xj/L8vJdSN1IeZ
 RXSkTpVkdC2DWTgQbw/rb897MtHudwQhf/WLfK2Ww8uRR7T1zfd+xWw0ZTpKG20mx+IUYz5z
 88KxYD/zlasF5w5Q78DfygezBaDJwjmdpZdh8/+UwQc6q2f1ghC1j6zAyWe9LoFGlRXe5eAx
 R4OosfIjUSu8DciabzmX5PauvRvgFTKcTTsAEQEAAYkCJQQYAQgADwUCWD7dXgIbDAUJCWYB
 gAAKCRA1XCWRxXBsi+atEADHAUfi/EXToIo4JvorqCdhAHu5jcmvGTApSdEfoygz3H/v2S9l
 zJckh17ZicRjo++g97PA4YBb0nr4RwXmgAoyBrfG0WCmH6t8fbwxyBlOmj6YO/N6ck3a5Jsw
 BArz0VJnKTMC8DJGgTBdU+RiNTOnkRJj5+jfPoWGZhr/zbbH/VVew/lMPId0F2fquVmQEjdF
 6g6tMyOT8vIrI0HReKKhMI4GMbgBm0NQ8MZkVJutxp2qCqo13h33NWbuondhqQOh1v9fFlCo
 M/Q09v/pS+2wXs0mgAOAh6TJDp6QCTcNtF4PBdtjXd6lIsL9veBEStXjFp1AqhgIQHnc7pm4
 bu+k5tXv90c0q3PLeCieHFNIzkIIYbwhOVgPh3p4YemccelhP0vycAdoFEQnHUIFIULD3WvI
 NvWy6i1UQYFX+uPcZ4wv24sdJzSlOdZpcTSK02pJSTKtOYsigN0iI+QFauu3pjWwf+xso4mR
 Le/GVWNFdlo6ckOJr53roF3pjPnmFavIIiA46KvaBiNi3kp24RZlRZtLH/YjNFig9fKmU+dm
 31xw8be0aRd18xnC2xGA+beOFeQXeZaEev7o4r5WiD0kJUEtvHeXeWPz1MH4O4fMPhoLgPgR
 M5NoP1F3sJBDYBezSW0iXrm7Naie5w7Dra0a0uv3KNyv3dF2mJ/An70VGQ==
Message-ID: <8e8894cf-1ab3-374c-0444-70552ed425f3@HIDDEN>
Date: Sat, 7 Dec 2019 13:31:28 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <878snoor4q.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 38509
Cc: 38509 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi Brett,

WRT the differences, it seems to be mostly fixes and refactoring:

- https://github.com/libuv/libuv/tree/v1.34.0

WRT the failed tests, it is due to treating EAGAIN as the failure:

- https://github.com/libuv/libuv/issues/2531

Not sure how to properly fix it, fixing the tests themselves is
non-trivial, and retrying several more times likely won't work either.

On 12/7/19 1:34 AM, Brett Gilio wrote:
> Brett Gilio <brettg@HIDDEN> writes:
>
>> Andrew Miloradovsky <andrew@HIDDEN> writes:
>>
>>> -    (arguments
>>> -     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
>>> -       #:tests? #f))
>>> +    (arguments '(#:tests? #f))
>>> +    ;; tests 122-124 (getnameinfo_basic_ip*) fail
>>> +    ;; https://github.com/libuv/libuv/issues/2531
>> Hi Andrew,
>>
>> Thank you for your submission. I have some questions before we go
>> forward with this patch. First, I'd like to note that this change would
>> trigger a huge rebuild of thousands of dependent packages.
>>
>> brettg@oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
>> Building the following 2067 packages would ensure 5397 dependent packages are rebuilt:
>>
>> That said, is there some particular functionality or security that is
>> provided with this patch? If so, it would be great if you could
>> elaborate on that in the Git sub-header of the commit message.
>>
>> Since this patch would trigger such a massive rebuild it will need to go
>> to the `core-updates` branch to rest before it sees master. So having
>> that detail in the commit message will make it easier for us to see what
>> we are working with.
>>
>> Lastly, just curious if there is a way to work around the issues with
>> tests 122-124 as shown in your above snippet. I know that the tests were
>> blanket disabled before, so I am just curious if there is a _better_ way
>> to do this, maybe i'm wrong. If the issue is that the tests require
>> network functionality that can usually be spoofed with some
>> effort. Also, stylistically, comments not on the same line as the code
>> they are commenting usually go before the code in question.
>>
>> I hope that makes sense! Let me know if you have any questions, I am
>> happy to help.
> Actually, on further exploration of the `core-updates` branch, libuv is
> already at 1.34 there.
>




Information forwarded to guix-patches@HIDDEN:
bug#38509; Package guix-patches. Full text available.

Message received at 38509 <at> debbugs.gnu.org:


Received: (at 38509) by debbugs.gnu.org; 7 Dec 2019 01:34:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 06 20:34:44 2019
Received: from localhost ([127.0.0.1]:47216 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1idOzc-0007WI-5F
	for submit <at> debbugs.gnu.org; Fri, 06 Dec 2019 20:34:44 -0500
Received: from mout02.posteo.de ([185.67.36.66]:43801)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <brettg@HIDDEN>) id 1idOza-0007W2-3O
 for 38509 <at> debbugs.gnu.org; Fri, 06 Dec 2019 20:34:42 -0500
Received: from submission (posteo.de [89.146.220.130]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 03C312400FE
 for <38509 <at> debbugs.gnu.org>; Sat,  7 Dec 2019 02:34:34 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1575682475; bh=zbVYxnCtIP7RDaAPSuj+5CMh44aAIrv/KpD0xYBXhu0=;
 h=From:To:Cc:Subject:Date:From;
 b=i8hanRw8Kx8TkMogTcJX1UBLj/oQaZmstPaBsr0CLVdMrAMjkry1jV6PZu5upKSDR
 zNtMNpIX20ZizroKw7kBRj4ILpP3reoqhy/zHj5gP/WSJhx2MriF557cjh4qeAk4nX
 OF7Q88gYSlPmxn2apuL6PQcX9uzviHe4lXdXY35dWW9kiXCNVMDGYN1Zn8BP7PKB5t
 rc93D9t6yUfoWO50jbpM0A6bW+qze7/ctrisiKTCcwf6tY+Sfsz0/13b5XumYU3rpF
 VaejvDuzXNxN9VA0GNqeI2jlaaidpUAR3x5SrIF9qX9EHxo8f6YR5AqsaJ+xdHS2nr
 i5YX2DvfVG45g==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 47VBp15SkGz9rxK;
 Sat,  7 Dec 2019 02:34:33 +0100 (CET)
From: Brett Gilio <brettg@HIDDEN>
To: Andrew Miloradovsky <andrew@HIDDEN>
Subject: Re: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
References: <20191206085713.27096-1-andrew@HIDDEN>
 <87d0d0org0.fsf@HIDDEN>
Date: Fri, 06 Dec 2019 19:34:29 -0600
In-Reply-To: <87d0d0org0.fsf@HIDDEN> (Brett Gilio's message of "Fri, 06
 Dec 2019 19:27:43 -0600")
Message-ID: <878snoor4q.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 38509
Cc: 38509 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Brett Gilio <brettg@HIDDEN> writes:

> Andrew Miloradovsky <andrew@HIDDEN> writes:
>
>> -    (arguments
>> -     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
>> -       #:tests? #f))
>> +    (arguments '(#:tests? #f))
>> +    ;; tests 122-124 (getnameinfo_basic_ip*) fail
>> +    ;; https://github.com/libuv/libuv/issues/2531
>
> Hi Andrew,
>
> Thank you for your submission. I have some questions before we go
> forward with this patch. First, I'd like to note that this change would
> trigger a huge rebuild of thousands of dependent packages.
>
> brettg@oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
> Building the following 2067 packages would ensure 5397 dependent packages are rebuilt:
>
> That said, is there some particular functionality or security that is
> provided with this patch? If so, it would be great if you could
> elaborate on that in the Git sub-header of the commit message.
>
> Since this patch would trigger such a massive rebuild it will need to go
> to the `core-updates` branch to rest before it sees master. So having
> that detail in the commit message will make it easier for us to see what
> we are working with.
>
> Lastly, just curious if there is a way to work around the issues with
> tests 122-124 as shown in your above snippet. I know that the tests were
> blanket disabled before, so I am just curious if there is a _better_ way
> to do this, maybe i'm wrong. If the issue is that the tests require
> network functionality that can usually be spoofed with some
> effort. Also, stylistically, comments not on the same line as the code
> they are commenting usually go before the code in question.
>
> I hope that makes sense! Let me know if you have any questions, I am
> happy to help.

Actually, on further exploration of the `core-updates` branch, libuv is
already at 1.34 there.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/




Information forwarded to guix-patches@HIDDEN:
bug#38509; Package guix-patches. Full text available.

Message received at 38509 <at> debbugs.gnu.org:


Received: (at 38509) by debbugs.gnu.org; 7 Dec 2019 01:27:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 06 20:27:57 2019
Received: from localhost ([127.0.0.1]:47208 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1idOt3-0007J1-4V
	for submit <at> debbugs.gnu.org; Fri, 06 Dec 2019 20:27:57 -0500
Received: from mout02.posteo.de ([185.67.36.66]:54199)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <brettg@HIDDEN>) id 1idOsz-0007Ik-SI
 for 38509 <at> debbugs.gnu.org; Fri, 06 Dec 2019 20:27:55 -0500
Received: from submission (posteo.de [89.146.220.130]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 43F7E2400FE
 for <38509 <at> debbugs.gnu.org>; Sat,  7 Dec 2019 02:27:47 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1575682067; bh=kykl1ui/c27sirBNPqmYQSIfpYQqx7xekZgNW6mc9F0=;
 h=From:To:Cc:Subject:Date:From;
 b=PKgk9T3f4zvH8D+uwXI3Jph1mlEsuIjwyt/fAURrMxBnuYw8Q7RE+y9XQT8k/4aHF
 sdNdCQswzsDerBRpZI13V/NWJaZdxkFyfh9vKO3OgNmUx8acZDX9bAmhAwMoV8bQw+
 RNGS9Zoy7frI6EDq4geWMD5FXjrWoFBT0k8ZaOWURNbEsA60+gxd3kG7JJtCs+NGl/
 U6iHA2RqSd3tvSnKr7wfChQXkZXhLU5vkL5TpPQdW+Q4LfmcOfPhNvejORPFMTgHJG
 h2D75PrCCbMux5rAySqGEBOZV4EVT3QAmBU5c2TiagEq0ZdbPFe2AHhtwqCo5buW3r
 7muenvouE4AWQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 47VBf94N0Rz9rxD;
 Sat,  7 Dec 2019 02:27:45 +0100 (CET)
From: Brett Gilio <brettg@HIDDEN>
To: Andrew Miloradovsky <andrew@HIDDEN>
Subject: Re: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
References: <20191206085713.27096-1-andrew@HIDDEN>
Date: Fri, 06 Dec 2019 19:27:43 -0600
In-Reply-To: <20191206085713.27096-1-andrew@HIDDEN> (Andrew
 Miloradovsky's message of "Fri, 6 Dec 2019 11:57:13 +0300")
Message-ID: <87d0d0org0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 38509
Cc: 38509 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Andrew Miloradovsky <andrew@HIDDEN> writes:

> -    (arguments
> -     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
> -       #:tests? #f))
> +    (arguments '(#:tests? #f))
> +    ;; tests 122-124 (getnameinfo_basic_ip*) fail
> +    ;; https://github.com/libuv/libuv/issues/2531

Hi Andrew,

Thank you for your submission. I have some questions before we go
forward with this patch. First, I'd like to note that this change would
trigger a huge rebuild of thousands of dependent packages.

--8<---------------cut here---------------start------------->8---
brettg@oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
Building the following 2067 packages would ensure 5397 dependent packages are rebuilt:
--8<---------------cut here---------------end--------------->8---

That said, is there some particular functionality or security that is
provided with this patch? If so, it would be great if you could
elaborate on that in the Git sub-header of the commit message.

Since this patch would trigger such a massive rebuild it will need to go
to the `core-updates` branch to rest before it sees master. So having
that detail in the commit message will make it easier for us to see what
we are working with.

Lastly, just curious if there is a way to work around the issues with
tests 122-124 as shown in your above snippet. I know that the tests were
blanket disabled before, so I am just curious if there is a _better_ way
to do this, maybe i'm wrong. If the issue is that the tests require
network functionality that can usually be spoofed with some
effort. Also, stylistically, comments not on the same line as the code
they are commenting usually go before the code in question.

I hope that makes sense! Let me know if you have any questions, I am
happy to help.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/




Information forwarded to guix-patches@HIDDEN:
bug#38509; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Dec 2019 14:56:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 06 09:56:19 2019
Received: from localhost ([127.0.0.1]:46872 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1idF1n-0008QV-JM
	for submit <at> debbugs.gnu.org; Fri, 06 Dec 2019 09:56:19 -0500
Received: from lists.gnu.org ([209.51.188.17]:44886)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andrew@HIDDEN>) id 1idF1l-0008QN-P4
 for submit <at> debbugs.gnu.org; Fri, 06 Dec 2019 09:56:18 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:46044)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <andrew@HIDDEN>) id 1idF1j-0003pY-Kn
 for guix-patches@HIDDEN; Fri, 06 Dec 2019 09:56:16 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW,
 RCVD_IN_RP_RNBL,URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <andrew@HIDDEN>) id 1idF1i-00019V-1L
 for guix-patches@HIDDEN; Fri, 06 Dec 2019 09:56:15 -0500
Received: from mslow2.mail.gandi.net ([217.70.178.242]:35530)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <andrew@HIDDEN>)
 id 1idF1h-00016V-Qo
 for guix-patches@HIDDEN; Fri, 06 Dec 2019 09:56:13 -0500
Received: from relay8-d.mail.gandi.net (unknown [217.70.183.201])
 by mslow2.mail.gandi.net (Postfix) with ESMTP id 601473AA042
 for <guix-patches@HIDDEN>; Fri,  6 Dec 2019 08:58:44 +0000 (UTC)
X-Originating-IP: 109.73.36.242
Received: from localhost.localdomain (109-73-36-242.in-addr.mastertelecom.ru
 [109.73.36.242]) (Authenticated sender: andrew@HIDDEN)
 by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 718541BF218;
 Fri,  6 Dec 2019 08:58:22 +0000 (UTC)
From: Andrew Miloradovsky <andrew@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: libuv: Update to 1.34.0
Date: Fri,  6 Dec 2019 11:57:13 +0300
Message-Id: <20191206085713.27096-1-andrew@HIDDEN>
X-Mailer: git-send-email 2.24.0
MIME-Version: 1.0
X-GND-Spam-Score: 160
X-GND-Status: SPAM
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 217.70.178.242
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
Cc: Andrew Miloradovsky <andrew@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

* gnu/packages/libevent.scm (libuv): Update to 1.34.0 (from 1.30.1)
---
 gnu/packages/libevent.scm | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/libevent.scm b/gnu/packages/libevent.scm
index 465ed95eb2..aabc780bfe 100644
--- a/gnu/packages/libevent.scm
+++ b/gnu/packages/libevent.scm
@@ -99,22 +99,21 @@ limited support for fork events.")
 (define-public libuv
   (package
     (name "libuv")
-    (version "1.30.1")
+    (version "1.34.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://dist.libuv.org/dist/v" versio=
n
                                   "/libuv-v" version ".tar.gz"))
               (sha256
                (base32
-                "12s7ifwgbfxblhv46inqa8c2lsnl8cgmvd37y4a4248xhkx1d0s6"))=
))
+                "0j416x38cp6gh5isn3fwv331aw6bpfmrk8xgm07rq5py47kyqg52"))=
))
     (build-system gnu-build-system)
-    (arguments
-     '(;; XXX: Some tests want /dev/tty, attempt to make connections, et=
c.
-       #:tests? #f))
+    (arguments '(#:tests? #f))
+    ;; tests 122-124 (getnameinfo_basic_ip*) fail
+    ;; https://github.com/libuv/libuv/issues/2531
     (native-inputs `(("autoconf" ,autoconf-wrapper)
                      ("automake" ,automake)
                      ("libtool" ,libtool)
-
                      ;; libuv.pc is installed only when pkg-config is fo=
und.
                      ("pkg-config" ,pkg-config)))
     (home-page "https://github.com/libuv/libuv")
--=20
2.24.0





Acknowledgement sent to Andrew Miloradovsky <andrew@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#38509; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 8 Dec 2019 02:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.