GNU bug report logs - #38509
[PATCH] gnu: libuv: Update to 1.34.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38509 in the body.
You can then email your comments to 38509 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Miloradovsky <andrew <at> interpretmath.pw>
To: guix-patches <at> gnu.org
Cc: Andrew Miloradovsky <andrew <at> interpretmath.pw>
Subject: [PATCH] gnu: libuv: Update to 1.34.0
Date: Fri,  6 Dec 2019 11:57:13 +0300

* gnu/packages/libevent.scm (libuv): Update to 1.34.0 (from 1.30.1)
---
 gnu/packages/libevent.scm | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/libevent.scm b/gnu/packages/libevent.scm
index 465ed95eb2..aabc780bfe 100644
--- a/gnu/packages/libevent.scm
+++ b/gnu/packages/libevent.scm
@@ -99,22 +99,21 @@ limited support for fork events.")
 (define-public libuv
   (package
     (name "libuv")
-    (version "1.30.1")
+    (version "1.34.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://dist.libuv.org/dist/v" version
                                   "/libuv-v" version ".tar.gz"))
               (sha256
                (base32
-                "12s7ifwgbfxblhv46inqa8c2lsnl8cgmvd37y4a4248xhkx1d0s6"))))
+                "0j416x38cp6gh5isn3fwv331aw6bpfmrk8xgm07rq5py47kyqg52"))))
     (build-system gnu-build-system)
-    (arguments
-     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
-       #:tests? #f))
+    (arguments '(#:tests? #f))
+    ;; tests 122-124 (getnameinfo_basic_ip*) fail
+    ;; https://github.com/libuv/libuv/issues/2531
     (native-inputs `(("autoconf" ,autoconf-wrapper)
                      ("automake" ,automake)
                      ("libtool" ,libtool)
-
                      ;; libuv.pc is installed only when pkg-config is found.
                      ("pkg-config" ,pkg-config)))
     (home-page "https://github.com/libuv/libuv")
-- 
2.24.0

Message #8 received at 38509 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Andrew Miloradovsky <andrew <at> interpretmath.pw>
Cc: 38509 <at> debbugs.gnu.org
Subject: Re: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
Date: Fri, 06 Dec 2019 19:27:43 -0600

Andrew Miloradovsky <andrew <at> interpretmath.pw> writes:

> -    (arguments
> -     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
> -       #:tests? #f))
> +    (arguments '(#:tests? #f))
> +    ;; tests 122-124 (getnameinfo_basic_ip*) fail
> +    ;; https://github.com/libuv/libuv/issues/2531

Hi Andrew,

Thank you for your submission. I have some questions before we go
forward with this patch. First, I'd like to note that this change would
trigger a huge rebuild of thousands of dependent packages.

--8<---------------cut here---------------start------------->8---
brettg <at> oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
Building the following 2067 packages would ensure 5397 dependent packages are rebuilt:
--8<---------------cut here---------------end--------------->8---

That said, is there some particular functionality or security that is
provided with this patch? If so, it would be great if you could
elaborate on that in the Git sub-header of the commit message.

Since this patch would trigger such a massive rebuild it will need to go
to the `core-updates` branch to rest before it sees master. So having
that detail in the commit message will make it easier for us to see what
we are working with.

Lastly, just curious if there is a way to work around the issues with
tests 122-124 as shown in your above snippet. I know that the tests were
blanket disabled before, so I am just curious if there is a _better_ way
to do this, maybe i'm wrong. If the issue is that the tests require
network functionality that can usually be spoofed with some
effort. Also, stylistically, comments not on the same line as the code
they are commenting usually go before the code in question.

I hope that makes sense! Let me know if you have any questions, I am
happy to help.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Message #11 received at 38509 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Andrew Miloradovsky <andrew <at> interpretmath.pw>
Cc: 38509 <at> debbugs.gnu.org
Subject: Re: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
Date: Fri, 06 Dec 2019 19:34:29 -0600

Brett Gilio <brettg <at> posteo.net> writes:

> Andrew Miloradovsky <andrew <at> interpretmath.pw> writes:
>
>> -    (arguments
>> -     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
>> -       #:tests? #f))
>> +    (arguments '(#:tests? #f))
>> +    ;; tests 122-124 (getnameinfo_basic_ip*) fail
>> +    ;; https://github.com/libuv/libuv/issues/2531
>
> Hi Andrew,
>
> Thank you for your submission. I have some questions before we go
> forward with this patch. First, I'd like to note that this change would
> trigger a huge rebuild of thousands of dependent packages.
>
> brettg <at> oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
> Building the following 2067 packages would ensure 5397 dependent packages are rebuilt:
>
> That said, is there some particular functionality or security that is
> provided with this patch? If so, it would be great if you could
> elaborate on that in the Git sub-header of the commit message.
>
> Since this patch would trigger such a massive rebuild it will need to go
> to the `core-updates` branch to rest before it sees master. So having
> that detail in the commit message will make it easier for us to see what
> we are working with.
>
> Lastly, just curious if there is a way to work around the issues with
> tests 122-124 as shown in your above snippet. I know that the tests were
> blanket disabled before, so I am just curious if there is a _better_ way
> to do this, maybe i'm wrong. If the issue is that the tests require
> network functionality that can usually be spoofed with some
> effort. Also, stylistically, comments not on the same line as the code
> they are commenting usually go before the code in question.
>
> I hope that makes sense! Let me know if you have any questions, I am
> happy to help.

Actually, on further exploration of the `core-updates` branch, libuv is
already at 1.34 there.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Message #14 received at 38509 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Miloradovsky <andrew <at> interpretmath.pw>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 38509 <at> debbugs.gnu.org
Subject: Re: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
Date: Sat, 7 Dec 2019 13:31:28 +0000

Hi Brett,

WRT the differences, it seems to be mostly fixes and refactoring:

- https://github.com/libuv/libuv/tree/v1.34.0

WRT the failed tests, it is due to treating EAGAIN as the failure:

- https://github.com/libuv/libuv/issues/2531

Not sure how to properly fix it, fixing the tests themselves is
non-trivial, and retrying several more times likely won't work either.

On 12/7/19 1:34 AM, Brett Gilio wrote:
> Brett Gilio <brettg <at> posteo.net> writes:
>
>> Andrew Miloradovsky <andrew <at> interpretmath.pw> writes:
>>
>>> -    (arguments
>>> -     '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
>>> -       #:tests? #f))
>>> +    (arguments '(#:tests? #f))
>>> +    ;; tests 122-124 (getnameinfo_basic_ip*) fail
>>> +    ;; https://github.com/libuv/libuv/issues/2531
>> Hi Andrew,
>>
>> Thank you for your submission. I have some questions before we go
>> forward with this patch. First, I'd like to note that this change would
>> trigger a huge rebuild of thousands of dependent packages.
>>
>> brettg <at> oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
>> Building the following 2067 packages would ensure 5397 dependent packages are rebuilt:
>>
>> That said, is there some particular functionality or security that is
>> provided with this patch? If so, it would be great if you could
>> elaborate on that in the Git sub-header of the commit message.
>>
>> Since this patch would trigger such a massive rebuild it will need to go
>> to the `core-updates` branch to rest before it sees master. So having
>> that detail in the commit message will make it easier for us to see what
>> we are working with.
>>
>> Lastly, just curious if there is a way to work around the issues with
>> tests 122-124 as shown in your above snippet. I know that the tests were
>> blanket disabled before, so I am just curious if there is a _better_ way
>> to do this, maybe i'm wrong. If the issue is that the tests require
>> network functionality that can usually be spoofed with some
>> effort. Also, stylistically, comments not on the same line as the code
>> they are commenting usually go before the code in question.
>>
>> I hope that makes sense! Let me know if you have any questions, I am
>> happy to help.
> Actually, on further exploration of the `core-updates` branch, libuv is
> already at 1.34 there.
>

Message #19 received at 38509-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Andrew Miloradovsky <andrew <at> interpretmath.pw>,
 Brett Gilio <brettg <at> posteo.net>
Cc: 38509-done <at> debbugs.gnu.org
Subject: Re: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
Date: Tue, 28 Jan 2020 00:20:23 +0100

[Message part 1 (text/plain, inline)]

Andrew Miloradovsky <andrew <at> interpretmath.pw> writes:

> Hi Brett,
>
> WRT the differences, it seems to be mostly fixes and refactoring:
>
> - https://github.com/libuv/libuv/tree/v1.34.0
>
> WRT the failed tests, it is due to treating EAGAIN as the failure:
>
> - https://github.com/libuv/libuv/issues/2531
>
> Not sure how to properly fix it, fixing the tests themselves is
> non-trivial, and retrying several more times likely won't work either.

/etc/nsswitch.conf does not exist in the build container, which is
probably why the getnameinfo tests fail.  Could you submit a patch for
Guix that disables those, and enables the rest?

Meanwhile I'm closing this issue, as we have the latest LibUV on the
'core-updates' branch.

By the way, if you need a newer libuv on 'master', you can create a
separate variable as in e.g. ffec356a29a58d97ec34e1152aa3136e78471dc6.

Thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.