GNU bug report logs - #38521
perl-gtk2 check fails: Failed test 'Don't crash on partial pixmap data'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38521 in the body.
You can then email your comments to 38521 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: bug-guix <at> gnu.org
Subject: perl-gtk2 check fails: Failed test 'Don't crash on partial pixmap
 data'
Date: Sat, 07 Dec 2019 14:40:01 +0100

[Message part 1 (text/plain, inline)]

perl-gtk2 check phase fails with:

--8<---------------cut here---------------start------------->8---
t/GdkPango.t ....................... skipped: Gtk2->init_check failed, probably unable to open DISPLAY

#   Failed test 'Don't crash on partial pixmap data'
#   at t/GdkPixbuf.t line 126.
GdkPixbuf-LOG **: gdk_pixbuf_from_pixdata() called on: at t/GdkPixbuf.t line 185.
GdkPixbuf-LOG **: 	Encoding rle at t/GdkPixbuf.t line 185.
GdkPixbuf-LOG **: 	Dimensions: 4 x 5 at t/GdkPixbuf.t line 185.
GdkPixbuf-LOG **: 	Rowstride: 16, Length: 91 at t/GdkPixbuf.t line 185.
GdkPixbuf-LOG **: 	Copy pixels == true at t/GdkPixbuf.t line 185.
# Looks like you failed 1 test of 112.
t/GdkPixbuf.t ......................
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/112 subtests
	(less 7 skipped subtests: 104 okay)
t/GdkPixbufLoader.t ................ ok
t/GdkPixbufSimpleAnim.t ............ ok
t/GdkPixmap.t ...................... skipped: Gtk2->init_check failed, probably unable to open DISPLAY
--8<---------------cut here---------------end--------------->8---

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 38521 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: 38521 <at> debbugs.gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: Re: bug#38521: Acknowledgement (perl-gtk2 check fails: Failed test
 'Don't crash on partial pixmap data')
Date: Wed, 11 Dec 2019 22:30:29 +0100

[Message part 1 (text/plain, inline)]

CC-ing Alex since he is the original author of the package.

Cheers!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 38521 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>, Marius Bakke <mbakke <at> fastmail.com>,
 38521 <at> debbugs.gnu.org
Cc: sirgazil <sirgazil <at> zoho.com>, help-guix <at> gnu.org, alexvong1995 <at> gmail.com
Subject: Re: guix package: error: build of `...-youtube-viewer-3.5.8.drv'
 failed
Date: Mon, 30 Dec 2019 01:16:27 +0100

[Message part 1 (text/plain, inline)]

All, Marius,

Tobias Geerinckx-Rice 写道：
> Alas for my free evening:
>
>    commit 8524b1b8b4ba973864b67354d5d81ad1a691e764
>    Author: Tobias Geerinckx-Rice <me <at> tobias.gr>
>    Date:   Wed Oct 16 03:06:10 2019 +0200
>
>    gnu: perl-gtk2: Update to 1.24993.
>     * gnu/packages/gtk.scm (perl-gtk2): Update to 1.24993.

Bisecting from this known-good commit still took several hours, 
but paid off:

 080edbe949c67f88e4ca002fc919f4ead8d814ae is the first bad commit
 commit 080edbe949c67f88e4ca002fc919f4ead8d814ae
 Author: Marius Bakke <mbakke <at> fastmail.com>
 Date:   Tue Oct 8 20:36:00 2019 +0200

   gnu: gdk-pixbuf: Update to 2.40.0.
   
   * gnu/packages/gtk.scm (gdk-pixbuf): Update to 2.40.0.
   [arguments]: Remove obsolete phase.

  gnu/packages/gtk.scm | 15 +++------------
  1 file changed, 3 insertions(+), 12 deletions(-)
 bisect run success

Marius: I think you prefer the word ‘volunteering’?  ;-)

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 38521 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, Marius Bakke <mbakke <at> fastmail.com>,
 38521 <at> debbugs.gnu.org
Cc: sirgazil <sirgazil <at> zoho.com>, help-guix <at> gnu.org, alexvong1995 <at> gmail.com
Subject: Re: guix package: error: build of `...-youtube-viewer-3.5.8.drv'
 failed
Date: Fri, 03 Jan 2020 12:11:50 +0100

[Message part 1 (text/plain, inline)]

So what shall we do?  Build perl-gtk2 against the previous version of
gdk-pixbuf?
And ask upstream if this is a known issue?

Anyone willing to take this? :)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 38521 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Marius Bakke <mbakke <at> fastmail.com>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 help-guix <at> gnu.org, alexvong1995 <at> gmail.com, 38521 <at> debbugs.gnu.org
Subject: Re: guix package: error: build of `...-youtube-viewer-3.5.8.drv'
 failed
Date: Fri, 03 Jan 2020 12:33:44 +0100

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> So what shall we do?  Build perl-gtk2 against the previous version of
> gdk-pixbuf?
> And ask upstream if this is a known issue?

The developers of youtube-viewer are aware of this and plan to drop the
dependency on perl-gtk2 (moving to gtk3), but this takes time.

In the meantime we could do one of these things:

* build youtube-viewer without the GUI

* disable the single failing test in perl-gtk2 (as long as this doesn’t
  represent an actual problem)

I would prefer not to use an old version of gdk-pixbuf.

-- 
Ricardo

Message #20 received at 38521 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Marius Bakke <mbakke <at> fastmail.com>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 help-guix <at> gnu.org, alexvong1995 <at> gmail.com, 38521 <at> debbugs.gnu.org
Subject: Re: guix package: error: build of `...-youtube-viewer-3.5.8.drv'
 failed
Date: Mon, 13 Jan 2020 18:28:24 +0100

[Message part 1 (text/plain, inline)]

I've pushed a fix in 8fcb607780dc9809949c573865c5e1a04770d0c5.
The test was a benign check that didn't match pixbuf's behaviour:

https://gitlab.gnome.org/GNOME/perl-gtk2/issues/3

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 38521 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, help-guix <at> gnu.org,
 alexvong1995 <at> gmail.com, 38521 <at> debbugs.gnu.org
Subject: Re: bug#38521: guix package: error: build of
 `...-youtube-viewer-3.5.8.drv' failed
Date: Wed, 15 Jan 2020 23:16:51 +0100

Hi Pierre,

Pierre Neidhardt <mail <at> ambrevar.xyz> skribis:

> I've pushed a fix in 8fcb607780dc9809949c573865c5e1a04770d0c5.
> The test was a benign check that didn't match pixbuf's behaviour:
>
> https://gitlab.gnome.org/GNOME/perl-gtk2/issues/3

Thanks for fixing it, now we can upgrade ‘youtube-viewer’ again.  :-)

Ludo’.

Message #28 received at 38521 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Pierre Neidhardt <mail <at> ambrevar.xyz>, help-guix <help-guix <at> gnu.org>,
 alexvong1995 <at> gmail.com, 38521 <at> debbugs.gnu.org
Subject: Re: bug#38521: guix package: error: build of
 `...-youtube-viewer-3.5.8.drv' failed
Date: Mon, 20 Jan 2020 22:48:32 -0500 (EST)

FWIW, I recently updated youtube-viewer to version 3.7.0.  That version contains a new port to perl-gtk3, so whoever feels like packaging that perl module can go right ahead ;)

`~Eric

----- On Jan 15, 2020, at 10:16 PM, Ludovic Courtès ludo <at> gnu.org wrote:

> Hi Pierre,
> 
> Pierre Neidhardt <mail <at> ambrevar.xyz> skribis:
> 
>> I've pushed a fix in 8fcb607780dc9809949c573865c5e1a04770d0c5.
>> The test was a benign check that didn't match pixbuf's behaviour:
>>
>> https://gitlab.gnome.org/GNOME/perl-gtk2/issues/3
> 
> Thanks for fixing it, now we can upgrade ‘youtube-viewer’ again.  :-)
> 
> Ludo’.

-- 
`~Eric

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.