GNU bug report logs - #38679
[PATCH] gnu: add geary.

Previous Next

Package: guix-patches;

Reported by: Kasperi Keränen <kasperi.keranen <at> outlook.com>

Date: Thu, 19 Dec 2019 21:18:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38679 in the body.
You can then email your comments to 38679 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38679; Package guix-patches. (Thu, 19 Dec 2019 21:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kasperi Keränen <kasperi.keranen <at> outlook.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 19 Dec 2019 21:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kasperi Keränen <kasperi.keranen <at> outlook.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: add geary.
Date: Thu, 19 Dec 2019 21:15:07 +0000
[Message part 1 (text/plain, inline)]

[0001-gnu-add-geary.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#38679; Package guix-patches. (Sat, 21 Dec 2019 04:54:01 GMT) Full text and rfc822 format available.

Message #8 received at 38679 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Kasperi Keränen <kasperi.keranen <at> outlook.com>
Cc: 38679 <at> debbugs.gnu.org
Subject: Re: [bug#38679] [PATCH] gnu: add geary.
Date: Fri, 20 Dec 2019 22:53:31 -0600
Hi Kasperi,

I have a few helpful criticisms of your patch, if you do not mind! :)

Kasperi Keränen <kasperi.keranen <at> outlook.com> writes:

> From 3d3ff29798e203f6cf7861a3ecfbb3fd5834c10b Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Kasperi=20Ker=C3=A4nen?= <kasperi.keranen <at> outlook.com>
> Date: Thu, 19 Dec 2019 19:17:38 +0100
> Subject: [PATCH] gnu: add geary.

Usually, when using the GNU Emacs yasnippet form from /guix/etc/snippets
the "add" is capitalized like so, "gnu: Add geary."

>
> * gnu/packages/gnome.scm (geary): New variable.
> ---
>  gnu/packages/gnome.scm | 63 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 0a9087eaff..7b3c337d60 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -168,6 +168,7 @@
>    #:use-module (gnu packages xml)
>    #:use-module (gnu packages xorg)
>    #:use-module (gnu packages xorg)
> +  #:use-module (gnu packages libunwind)

Would you mind adding this in its alphabetical order?

>    #:use-module (gnu artwork)
>    #:use-module (guix build-system cargo)
>    #:use-module (guix build-system cmake)
> @@ -8684,6 +8685,68 @@ functionality.")
>                     license:openldap2.8 ; addressbook/gui/component/openldap-extract.h
>                     license:lgpl2.1+))))  ; smime/lib/*
>  
> +(define-public geary
> +  (package
> +    (name "geary")
> +    (version "3.32.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/geary/"
> +                                  (version-major+minor version) "/"
> +                                  "geary-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "0sg53zq81v28hdqiy5d048skwfgsa8ck0z7ywsagdh7iaqin68gq"))))
> +    (build-system meson-build-system)
> +    (arguments `(#:tests? #f ;; Client tests require a wayland/X11
> display.

A single ; comment will suffice here since it exists on the same line. I
also wonder if it is possible to spoof that display variable in the
tests or just remove that singular test? I might look into this if I
have some time. Maybe mark this as a TODO:?

> +                 #:glib-or-gtk? #t
> +                 #:phases (modify-phases %standard-phases
> +                            (add-after 'unpack 'skip-gtk-update-icon-cache
> +                              (lambda _
> +                                (substitute* "build-aux/post_install.py"
> +                                  (("gtk-update-icon-cache") "true"))
> +                                #t)))))
> +    (native-inputs
> +     `(("glib:bin" ,glib "bin")
> +       ("gettext" ,gettext-minimal)
> +       ("itstool" ,itstool)
> +       ("pkg-config" ,pkg-config)
> +       ("cmake" ,cmake)))
> +    (inputs
> +     `(("vala" ,vala)
> +       ("sqlite" ,sqlite)
> +       ("webkitgtk" ,webkitgtk)
> +       ("gtk+" ,gtk+)
> +       ("glib" ,glib)
> +       ("gmime" ,gmime-2.6)
> +       ("appstream-glib" ,appstream-glib)
> +       ("libarchive" ,libarchive)
> +       ("folks" ,folks)
> +       ("libgee" ,libgee)
> +       ("enchant" ,enchant)
> +       ("gcr" ,gcr)
> +       ("gnome-online-accounts:lib" ,gnome-online-accounts "lib")
> +       ("gspell" ,gspell)
> +       ("iso-codes" ,iso-codes)
> +       ("json-glib" ,json-glib)
> +       ;; ("libpeas" ,libpeas) ;; Required by a newer version of geary
> +       ("libnotify" ,libnotify)
> +       ("libsecret" ,libsecret)
> +       ("libunwind" ,libunwind)
> +       ("libcanberra" ,libcanberra)
> +       ("glib-networking" ,glib-networking)
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
> +    (home-page "https://gitlab.gnome.org/GNOME/geary")
> +    (synopsis "An email application built around conversations")
> +    (description "Geary is an email application built around conversations, for the
> +GNOME 3 desktop.  It allows you to read, find and send email with a
> +straightforward, modern interface.")
> +    (license (list license:lgpl2.1
> +                   license:cc-by3.0      ;;
> +                   license:cc-by-sa3.0   ;; icons
> +                   license:public-domain ;;
> +                   license:bsd-2))))     ;; snowball
> +
>  (define-public gthumb
>    (package
>      (name "gthumb")

Some of my other comments apply to other sections, name about the single
; for same-line comments. I will give this a build and test when I get a
moment. In the mean time, I would also look over some of the inputs some
more, because I wonder if things like "vala" should be native-inputs
instead? Just a thought, I could be wrong.

If you can reroll your patch for a V2 and send it to this tracker issue,
I would appreciate it :).

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg <at> gnu.org> <brettg <at> posteo.net>




Information forwarded to guix-patches <at> gnu.org:
bug#38679; Package guix-patches. (Fri, 10 Jan 2020 19:04:01 GMT) Full text and rfc822 format available.

Message #11 received at 38679 <at> debbugs.gnu.org (full text, mbox):

From: Kasperi Keränen <kasperi.keranen <at> outlook.com>
To: "38679 <at> debbugs.gnu.org" <38679 <at> debbugs.gnu.org>
Subject: [bug#38679] [PATCH] gnu: add geary.
Date: Fri, 10 Jan 2020 18:52:57 +0000
[Message part 1 (text/plain, inline)]
I've enabled the tests and made them pass.

There's still a small problem with icons not loading when entering the 
online accounts section of GNOME settings from geary, but given that 
the same happens with all applications I don't think anyone has a fix 
for it.

[0001-gnu-Add-geary.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#38679; Package guix-patches. (Sun, 12 Jan 2020 06:44:02 GMT) Full text and rfc822 format available.

Message #14 received at 38679 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Kasperi Keränen <kasperi.keranen <at> outlook.com>,
 38679 <at> debbugs.gnu.org
Subject: Re: [bug#38679] [PATCH] gnu: add geary.
Date: Sun, 12 Jan 2020 07:43:16 +0100
[Message part 1 (text/plain, inline)]
Kasperi,

Thank you for packaging Geary!  Unfortunately I can't test it 
right now, but here are two general points to help you apply 
Brett's suggestions.

Brett Gilio 写道:
>> +    (arguments `(#:tests? #f ;; Client tests require a 
>> wayland/X11
>> display.
>
> A single ; comment will suffice here since it exists on the same 
> line. I
> also wonder if it is possible to spoof that display variable in 
> the
> tests or just remove that singular test? I might look into this 
> if I
> have some time. Maybe mark this as a TODO:?

You can start a ‘virtual frame buffer’ (Xvfb) X server in the 
build environment:

 (add-before 'check 'start-xserver
  (lambda* (#:key inputs #:allow-other-keys)
     (let ((xorg-server (assoc-ref inputs "xorg-server"))
          (display ":1"))
       (setenv "DISPLAY" display)
       (system (format #f "~a/bin/Xvfb ~a &" xorg-server 
       display))
       #t)))

You'll find many other examples with ‘grep Xvfb 
gnu/packages/*scm’.

> In the mean time, I would also look over some of the inputs some
> more, because I wonder if things like "vala" should be 
> native-inputs
> instead? Just a thought, I could be wrong.

A rule of thumb is that inputs missing from

 $ guix gc --references $(guix build geary)

should probably be native.  It's likely that vala will be so 
missing.

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#38679; Package guix-patches. (Fri, 29 May 2020 21:27:02 GMT) Full text and rfc822 format available.

Message #17 received at 38679 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Kasperi Keränen <kasperi.keranen <at> outlook.com>,
 38679 <at> debbugs.gnu.org
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#38679] [PATCH] gnu: add geary.
Date: Sat, 30 May 2020 02:56:39 +0530
[Message part 1 (text/plain, inline)]
Hi,

It looks like geary has already been packaged. Sorry for the duplicated
effort! :-(

Regards,
Arun
[signature.asc (application/pgp-signature, inline)]

Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Thu, 19 Nov 2020 09:29:01 GMT) Full text and rfc822 format available.

Notification sent to Kasperi Keränen <kasperi.keranen <at> outlook.com>:
bug acknowledged by developer. (Thu, 19 Nov 2020 09:29:02 GMT) Full text and rfc822 format available.

Message #22 received at 38679-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 38679-done <at> debbugs.gnu.org
Subject: Re: [bug#38679] [PATCH] gnu: add geary.
Date: Thu, 19 Nov 2020 09:28:02 +0000
[Message part 1 (text/plain, inline)]
Arun Isaac <arunisaac <at> systemreboot.net> writes:

> It looks like geary has already been packaged. Sorry for the duplicated
> effort! :-(

As Geary is packaged, I'm closing this bug.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 17 Dec 2020 12:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 102 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.