GNU bug report logs - #38738
[PATCH WIP] etc: Add "tarball" snippet.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38738 in the body.
You can then email your comments to 38738 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH WIP] etc: Add "tarball" snippet.
Date: Tue, 24 Dec 2019 23:48:16 -0600

[Message part 1 (text/plain, inline)]

This patch is actually a WIP. I'd ideally like it if it could also
detect the addition of `(git-file-name ...)` and add that to the
sub-header commit message portion, but I am not so talented in Yasnippet
creation :).

If anybody wants to take a crack at it, please do. But I think this
snippet will prove useful as we will almost always have unstable
tarballs coming into our sources.

[0001-etc-Add-tarball-snippet.patch (text/x-patch, inline)]

From f4b14a47e3741c107ea83e2717674c8a032f8dba Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> gnu.org>
Date: Tue, 24 Dec 2019 23:42:27 -0600
Subject: [PATCH] etc: Add "tarball" snippet.

* etc/snippets/text-mode/guix-commit-message-unstable-tarball: New file.
---
 .../text-mode/guix-commit-message-unstable-tarball        | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 etc/snippets/text-mode/guix-commit-message-unstable-tarball

diff --git a/etc/snippets/text-mode/guix-commit-message-unstable-tarball b/etc/snippets/text-mode/guix-commit-message-unstable-tarball
new file mode 100644
index 0000000000..e82f522e54
--- /dev/null
+++ b/etc/snippets/text-mode/guix-commit-message-unstable-tarball
@@ -0,0 +1,8 @@
+# -*- mode: snippet -*-
+# name: guix-commit-message-unstable-tarball
+# key: tarball
+# condition: git-commit-mode
+# --
+gnu: $1: Don't use unstable tarball.
+
+* `(car (magit-staged-files))` ($1)[source]: Download using GIT-FETCH.
\ No newline at end of file
-- 
2.24.1

Message #8 received at 38738 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: 38738 <at> debbugs.gnu.org
Subject: [PATCH WIP v2] etc: Add "tarball" snippet
Date: Wed, 25 Dec 2019 00:42:15 -0600

[Message part 1 (text/plain, inline)]

This is a revised (but still ugly) revision of the original snippet that
I think details somewhat what I mean by detecting the relevant changes
to these types of commits and adding something to indicate this. I'd
really like to see this be on the same line, instead of having two
[source] blocks. But, as noted before, not a pro in Yasnippet by any
means. :) (not to mention, the elisp is not good, but it is a rough
concept).

[0001-etc-Add-tarball-snippet.patch (text/x-patch, inline)]

From 488faa8cabd298bb2d00f91a6056b26227089060 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> gnu.org>
Date: Wed, 25 Dec 2019 00:38:37 -0600
Subject: [PATCH] etc: Add "tarball" snippet

* etc/snippets/text-mode/guix-commit-message-unstable-tarball: New file.
---
 .../guix-commit-message-unstable-tarball      | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 etc/snippets/text-mode/guix-commit-message-unstable-tarball

diff --git a/etc/snippets/text-mode/guix-commit-message-unstable-tarball b/etc/snippets/text-mode/guix-commit-message-unstable-tarball
new file mode 100644
index 0000000000..6a41d2156a
--- /dev/null
+++ b/etc/snippets/text-mode/guix-commit-message-unstable-tarball
@@ -0,0 +1,20 @@
+# -*- mode: snippet -*-
+# name: guix-commit-message-unstable-tarball
+# key: tarball
+# condition: git-commit-mode
+# --
+gnu: $1: Don't use unstable tarball.
+
+* `(car (magit-staged-files))` ($1): Modify package to use stable git references.
+`(with-temp-buffer
+   (magit-git-wash #'magit-diff-wash-diffs
+     "diff" "--staged")
+   (beginning-of-buffer)
+   (when (search-forward "(method git-fetch" nil 'noerror)
+     (print "[source]: Use GIT-FETCH.")))`
+`(with-temp-buffer
+   (magit-git-wash #'magit-diff-wash-diffs
+     "diff" "--staged")
+   (beginning-of-buffer)
+   (when (search-forward "(file-name (git-file-name" nil 'noerror)
+     (print "[source]: Use GIT-FILE-NAME.")))`
-- 
2.24.1

Message #11 received at 38738 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Brett Gilio <brettg <at> gnu.org>
Cc: 38738 <at> debbugs.gnu.org
Subject: Re: [bug#38738] [PATCH WIP v2] etc: Add "tarball" snippet
Date: Thu, 27 Feb 2020 11:14:26 +0100

[Message part 1 (text/plain, inline)]

Looks good to me!

If you want to print only one "[source]:" I suggest the following,
untested:

* `(car (magit-staged-files))` ($1): Modify package to use stable git references.
`(with-temp-buffer
   (magit-git-wash #'magit-diff-wash-diffs
     "diff" "--staged")
   (let ((source-block "[source]: ")
         (wrote-source-block? nil))
     (beginning-of-buffer)
     (when (search-forward "(method git-fetch" nil 'noerror)
       (setq wrote-source-block? t)
       (print (format "%sUse GIT-FETCH." source-block)))
     (beginning-of-buffer)
     (when (search-forward "(file-name (git-file-name" nil 'noerror)
       (print (format "%sUse GIT-FILE-NAME." (if wrote-source-block? "" "[source]:"))))))`


-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 38738 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 38738 <at> debbugs.gnu.org, Brett Gilio <brettg <at> gnu.org>
Subject: Re: bug#38738: [PATCH WIP] etc: Add "tarball" snippet.
Date: Tue, 12 Apr 2022 12:40:40 +0200

Hi,


On Thu, 27 Feb 2020 at 11:14, Pierre Neidhardt <mail <at> ambrevar.xyz> wrote:

The last interaction of this patch #38738 [1] from 2 years, 6 weeks, 2
days ago ends with:

> Looks good to me!

and since it is still a WIP, I propose to close it.


1: <http://issues.guix.gnu.org/issue/38738>



Cheers,
simon

Message #19 received at 38738-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 38738-done <at> debbugs.gnu.org, Brett Gilio <brettg <at> gnu.org>
Subject: Re: bug#38738: [PATCH WIP] etc: Add "tarball" snippet.
Date: Thu, 19 May 2022 23:20:58 +0200

Hi,

On Tue, 12 Apr 2022 at 12:40, zimoun <zimon.toutoune <at> gmail.com> wrote:
> On Thu, 27 Feb 2020 at 11:14, Pierre Neidhardt <mail <at> ambrevar.xyz> wrote:
>
> The last interaction of this patch #38738 [1] from 2 years, 6 weeks, 2
> days ago ends with:
>
>> Looks good to me!
>
> and since it is still a WIP, I propose to close it.

Therefore, I am closing.


Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.