Received: (at 38738) by debbugs.gnu.org; 27 Feb 2020 10:14:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 27 05:14:39 2020
Received: from localhost ([127.0.0.1]:58697 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1j7GBi-0004gF-On
for submit <at> debbugs.gnu.org; Thu, 27 Feb 2020 05:14:39 -0500
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43179)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1j7GBg-0004fz-P6
for 38738 <at> debbugs.gnu.org; Thu, 27 Feb 2020 05:14:37 -0500
X-Originating-IP: 92.169.129.147
Received: from bababa (lfbn-idf2-1-1315-147.w92-169.abo.wanadoo.fr
[92.169.129.147]) (Authenticated sender: mail@HIDDEN)
by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 37DA220010;
Thu, 27 Feb 2020 10:14:29 +0000 (UTC)
From: Pierre Neidhardt <mail@HIDDEN>
To: Brett Gilio <brettg@HIDDEN>
Subject: Re: [bug#38738] [PATCH WIP v2] etc: Add "tarball" snippet
References: <87h81pymzj.fsf@HIDDEN> <87eewszz20.fsf@HIDDEN>
Date: Thu, 27 Feb 2020 11:14:26 +0100
In-Reply-To: <87eewszz20.fsf@HIDDEN> (Brett Gilio's message of "Wed, 25 Dec
2019 00:42:15 -0600")
Message-ID: <87wo8872wt.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 1.7 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Looks good to me! If you want to print only one "[source]:"
I suggest the following, untested: * `(car (magit-staged-files))` ($1): Modify
package to use stable git references. `(with-temp-buffer (magit-git-wash
#'magit-diff-wash-diffs "diff" "--staged") (let ((source-block "[source]:
") (wrote [...]
Content analysis details: (1.7 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was
blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information. [URIs: ambrevar.xyz]
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/,
low trust [217.70.183.200 listed in list.dnswl.org]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
1.9 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: ambrevar.xyz (xyz)]
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
X-Debbugs-Envelope-To: 38738
Cc: 38738 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.7 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Looks good to me! If you want to print only one "[source]:"
I suggest the following, untested: * `(car (magit-staged-files))` ($1): Modify
package to use stable git references. `(with-temp-buffer (magit-git-wash
#'magit-diff-wash-diffs "diff" "--staged") (let ((source-block "[source]:
") (wrote [...]
Content analysis details: (1.7 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was
blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information.
[URIs: ambrevar.xyz]
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/,
low trust
[217.70.183.200 listed in list.dnswl.org]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
1.9 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: ambrevar.xyz (xyz)]
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Looks good to me!
If you want to print only one "[source]:" I suggest the following,
untested:
* `(car (magit-staged-files))` ($1): Modify package to use stable git refer=
ences.
`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
(let ((source-block "[source]: ")
(wrote-source-block? nil))
(beginning-of-buffer)
(when (search-forward "(method git-fetch" nil 'noerror)
(setq wrote-source-block? t)
(print (format "%sUse GIT-FETCH." source-block)))
(beginning-of-buffer)
(when (search-forward "(file-name (git-file-name" nil 'noerror)
(print (format "%sUse GIT-FILE-NAME." (if wrote-source-block? "" "[s=
ource]:"))))))`
=2D-=20
Pierre Neidhardt
https://ambrevar.xyz/
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5XloIACgkQm9z0l6S7
zH/56wgAmSr/Dwtash1hoaudTY1DMtgfEpcbZNFuoUpOZDcbF16JN88wn6DjEth+
FZde8Q35OYdkWbNufzf9Xl9cZT89pS+oH8OFpq6oYyX6kXT6JFXJ6UGDt8B0pQmY
geE6ampU3VaLh0nwGqpV8CjyIR4VT4TcG7iRDWyECSdDsbVrpq1S8NHh6UNCLFSl
FSMyUMcz6JirZcz21W0pk4fvviCDxCGLuU7bM+ylxKciGu2+zveyFGWKyk9yuLrC
3+dbMO30AJqFlqcC+6+RXRD8qjvE2yKBOxSQ71aPaiuHgkRojfSZSYXPsLcF32db
kWgdLLhr+FkqGK3bHKN0+pTZmacmpw==
=w1Z+
-----END PGP SIGNATURE-----
--=-=-=--
guix-patches@HIDDEN:bug#38738; Package guix-patches.
Full text available.Received: (at 38738) by debbugs.gnu.org; 25 Dec 2019 06:42:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 25 01:42:16 2019 Received: from localhost ([127.0.0.1]:53228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ik0N5-0004HX-TL for submit <at> debbugs.gnu.org; Wed, 25 Dec 2019 01:42:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <brettg@HIDDEN>) id 1ik0N3-0004HK-N4 for 38738 <at> debbugs.gnu.org; Wed, 25 Dec 2019 01:42:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <brettg@HIDDEN>) id 1ik0My-0006C8-GS for 38738 <at> debbugs.gnu.org; Wed, 25 Dec 2019 01:42:08 -0500 Received: from [2605:6000:1a0d:6320::6a8] (port=39484 helo=oryx) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <brettg@HIDDEN>) id 1ik0My-0003FO-3w for 38738 <at> debbugs.gnu.org; Wed, 25 Dec 2019 01:42:08 -0500 From: Brett Gilio <brettg@HIDDEN> To: 38738 <at> debbugs.gnu.org Subject: [PATCH WIP v2] etc: Add "tarball" snippet Date: Wed, 25 Dec 2019 00:42:15 -0600 Message-ID: <87eewszz20.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38738 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain This is a revised (but still ugly) revision of the original snippet that I think details somewhat what I mean by detecting the relevant changes to these types of commits and adding something to indicate this. I'd really like to see this be on the same line, instead of having two [source] blocks. But, as noted before, not a pro in Yasnippet by any means. :) (not to mention, the elisp is not good, but it is a rough concept). --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-etc-Add-tarball-snippet.patch Content-Description: [PATCH] etc: Add "tarball" snippet From 488faa8cabd298bb2d00f91a6056b26227089060 Mon Sep 17 00:00:00 2001 From: Brett Gilio <brettg@HIDDEN> Date: Wed, 25 Dec 2019 00:38:37 -0600 Subject: [PATCH] etc: Add "tarball" snippet * etc/snippets/text-mode/guix-commit-message-unstable-tarball: New file. --- .../guix-commit-message-unstable-tarball | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 etc/snippets/text-mode/guix-commit-message-unstable-tarball diff --git a/etc/snippets/text-mode/guix-commit-message-unstable-tarball b/etc/snippets/text-mode/guix-commit-message-unstable-tarball new file mode 100644 index 0000000000..6a41d2156a --- /dev/null +++ b/etc/snippets/text-mode/guix-commit-message-unstable-tarball @@ -0,0 +1,20 @@ +# -*- mode: snippet -*- +# name: guix-commit-message-unstable-tarball +# key: tarball +# condition: git-commit-mode +# -- +gnu: $1: Don't use unstable tarball. + +* `(car (magit-staged-files))` ($1): Modify package to use stable git references. +`(with-temp-buffer + (magit-git-wash #'magit-diff-wash-diffs + "diff" "--staged") + (beginning-of-buffer) + (when (search-forward "(method git-fetch" nil 'noerror) + (print "[source]: Use GIT-FETCH.")))` +`(with-temp-buffer + (magit-git-wash #'magit-diff-wash-diffs + "diff" "--staged") + (beginning-of-buffer) + (when (search-forward "(file-name (git-file-name" nil 'noerror) + (print "[source]: Use GIT-FILE-NAME.")))` -- 2.24.1 --=-=-=--
guix-patches@HIDDEN:bug#38738; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 25 Dec 2019 05:48:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 25 00:48:17 2019 Received: from localhost ([127.0.0.1]:53220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ijzWr-0002Ze-IS for submit <at> debbugs.gnu.org; Wed, 25 Dec 2019 00:48:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:53180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <brettg@HIDDEN>) id 1ijzWp-0002ZW-8Y for submit <at> debbugs.gnu.org; Wed, 25 Dec 2019 00:48:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40119) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <brettg@HIDDEN>) id 1ijzWo-0007Za-24 for guix-patches@HIDDEN; Wed, 25 Dec 2019 00:48:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <brettg@HIDDEN>) id 1ijzWn-0000rl-T0 for guix-patches@HIDDEN; Wed, 25 Dec 2019 00:48:13 -0500 Received: from [2605:6000:1a0d:6320::6a8] (port=39206 helo=oryx) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <brettg@HIDDEN>) id 1ijzWn-0007PJ-54 for guix-patches@HIDDEN; Wed, 25 Dec 2019 00:48:13 -0500 From: Brett Gilio <brettg@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH WIP] etc: Add "tarball" snippet. Date: Tue, 24 Dec 2019 23:48:16 -0600 Message-ID: <87h81pymzj.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain This patch is actually a WIP. I'd ideally like it if it could also detect the addition of `(git-file-name ...)` and add that to the sub-header commit message portion, but I am not so talented in Yasnippet creation :). If anybody wants to take a crack at it, please do. But I think this snippet will prove useful as we will almost always have unstable tarballs coming into our sources. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-etc-Add-tarball-snippet.patch Content-Description: [PATCH] etc: Add "tarball" snippet. From f4b14a47e3741c107ea83e2717674c8a032f8dba Mon Sep 17 00:00:00 2001 From: Brett Gilio <brettg@HIDDEN> Date: Tue, 24 Dec 2019 23:42:27 -0600 Subject: [PATCH] etc: Add "tarball" snippet. * etc/snippets/text-mode/guix-commit-message-unstable-tarball: New file. --- .../text-mode/guix-commit-message-unstable-tarball | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 etc/snippets/text-mode/guix-commit-message-unstable-tarball diff --git a/etc/snippets/text-mode/guix-commit-message-unstable-tarball b/etc/snippets/text-mode/guix-commit-message-unstable-tarball new file mode 100644 index 0000000000..e82f522e54 --- /dev/null +++ b/etc/snippets/text-mode/guix-commit-message-unstable-tarball @@ -0,0 +1,8 @@ +# -*- mode: snippet -*- +# name: guix-commit-message-unstable-tarball +# key: tarball +# condition: git-commit-mode +# -- +gnu: $1: Don't use unstable tarball. + +* `(car (magit-staged-files))` ($1)[source]: Download using GIT-FETCH. \ No newline at end of file -- 2.24.1 --=-=-=--
Brett Gilio <brettg@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#38738; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.