GNU bug report logs - #38746
[PATCH] gnu: emacs-shroud: Update to 1.105.

Previous Next

Package: guix-patches;

Reported by: nly <at> disroot.org (Amar M. Singh)

Date: Thu, 26 Dec 2019 03:42:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38746 in the body.
You can then email your comments to 38746 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38746; Package guix-patches. (Thu, 26 Dec 2019 03:42:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to nly <at> disroot.org (Amar M. Singh):
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 26 Dec 2019 03:42:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: nly <at> disroot.org (Amar M. Singh)
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-shroud: Update to 1.105.
Date: Thu, 26 Dec 2019 09:10:54 +0530
[Message part 1 (text/plain, inline)]
New in this release:
1. Now uses Gnu build system, aka Autotools.
2. Comes with Texinfo documentation.

[0001-gnu-emacs-shroud-Update-to-1.105.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#38746; Package guix-patches. (Thu, 26 Dec 2019 03:52:02 GMT) Full text and rfc822 format available.

Message #8 received at 38746 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: "Amar M. Singh" <nly <at> disroot.org>
Cc: 38746 <at> debbugs.gnu.org
Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105.
Date: Thu, 26 Dec 2019 03:51:15 +0000 (UTC)

Dec 25, 2019 9:42:15 PM Amar M. Singh :

>
> New in this release:
> 1. Now uses Gnu build system, aka Autotools.
> 2. Comes with Texinfo documentation.
>

Hi Amar,

I am looking at this on my phone, so I might be wrong but it looks like the change to the gnu-build-system is not accompanied by any arguments installing any byte-compiled elc files to the emacs site-lisp. Did you test this change? Are the elc files getting installed? If so, how? Normally we have to work around this issue with mixing gnu and Emacs build system phases. Also, things like autoconf and automake are implicit in the gnu build system and are not needed.


-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
< brettg <at> gnu.org [mailto:brettg <at> gnu.org] > < brettg <at> posteo.net [mailto:brettg <at> posteo.net] >





Information forwarded to guix-patches <at> gnu.org:
bug#38746; Package guix-patches. (Thu, 26 Dec 2019 03:59:02 GMT) Full text and rfc822 format available.

Message #11 received at 38746 <at> debbugs.gnu.org (full text, mbox):

From: "Amar M. Singh" <nly <at> disroot.org>
To: Brett Gilio <brettg <at> gnu.org>
Cc: 38746 <at> debbugs.gnu.org
Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105.
Date: Thu, 26 Dec 2019 03:58:19 +0000
Hi Brett,

I am using autoconf macro 'dist_lisp_LISP' in src/Makefile.am which will install '.el' files. Autotools are automatically detecting and installing '.elc' files from 'lisp_LISP' variable.


-------- Original Message --------
From: Brett Gilio <brettg <at> gnu.org>
Sent: December 26, 2019 3:51:15 AM UTC
To: "Amar M. Singh" <nly <at> disroot.org>
Cc: 38746 <at> debbugs.gnu.org
Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105.



Dec 25, 2019 9:42:15 PM Amar M. Singh :

>
> New in this release:
> 1. Now uses Gnu build system, aka Autotools.
> 2. Comes with Texinfo documentation.
>

Hi Amar,

I am looking at this on my phone, so I might be wrong but it looks like the change to the gnu-build-system is not accompanied by any arguments installing any byte-compiled elc files to the emacs site-lisp. Did you test this change? Are the elc files getting installed? If so, how? Normally we have to work around this issue with mixing gnu and Emacs build system phases. Also, things like autoconf and automake are implicit in the gnu build system and are not needed.



Regards,
Amar Singh <nly <at> disroot.org>
https://o-nly.github.io

-------------------------------------------------------------
Sent from my Android device with Librem Mail. Please excuse my brevity.




Information forwarded to guix-patches <at> gnu.org:
bug#38746; Package guix-patches. (Thu, 26 Dec 2019 06:31:02 GMT) Full text and rfc822 format available.

Message #14 received at 38746 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: "Amar M. Singh" <nly <at> disroot.org>
Cc: 38746 <at> debbugs.gnu.org, Brett Gilio <brettg <at> gnu.org>
Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105.
Date: Thu, 26 Dec 2019 08:30:00 +0200
[Message part 1 (text/plain, inline)]
On Thu, Dec 26, 2019 at 03:58:19AM +0000, Amar M. Singh wrote:
> 
> Dec 25, 2019 9:42:15 PM Amar M. Singh :
> 
> >
> > New in this release:
> > 1. Now uses Gnu build system, aka Autotools.
> > 2. Comes with Texinfo documentation.
> >
> 
> Hi Amar,
> 
> I am looking at this on my phone, so I might be wrong but it looks like the change to the gnu-build-system is not accompanied by any arguments installing any byte-compiled elc files to the emacs site-lisp. Did you test this change? Are the elc files getting installed? If so, how? Normally we have to work around this issue with mixing gnu and Emacs build system phases. Also, things like autoconf and automake are implicit in the gnu build system and are not needed.
> 

tree /gnu/store/0m5irk4q5hf3pw2ral0gv9y51qic7m9x-emacs-shroud-1.83.4
/gnu/store/0m5irk4q5hf3pw2ral0gv9y51qic7m9x-emacs-shroud-1.83.4
└── share
    ├── doc
    │   └── emacs-shroud-1.83.4
    │       └── COPYING
    └── emacs
        └── site-lisp
            ├── shroud-autoloads.el
            ├── shroud-bui.el
            ├── shroud-bui.elc
            ├── shroud-cli.el
            ├── shroud-cli.elc
            ├── shroud.el
            ├── shroud.elc
            ├── shroud-el.el
            └── shroud-el.elc

tree /gnu/store/j0wmnl8gyzf4qwpxlml7hlvqpdzsw7p6-emacs-shroud-1.105
/gnu/store/j0wmnl8gyzf4qwpxlml7hlvqpdzsw7p6-emacs-shroud-1.105
└── share
    ├── doc
    │   ├── emacs-shroud
    │   │   ├── emacs-shroud.html
    │   │   └── README
    │   └── emacs-shroud-1.105
    │       └── COPYING
    ├── emacs
    │   └── site-lisp
    │       ├── shroud-bui.el
    │       ├── shroud-bui.elc
    │       ├── shroud-cli.el
    │       ├── shroud-cli.elc
    │       ├── shroud.el
    │       ├── shroud.elc
    │       ├── shroud-el.el
    │       └── shroud-el.elc
    └── info
        └── emacs-shroud.info.gz

> 
> Hi Brett,
> 
> I am using autoconf macro 'dist_lisp_LISP' in src/Makefile.am which will install '.el' files. Autotools are automatically detecting and installing '.elc' files from 'lisp_LISP' variable.
> 

I'm not an emacs user, do we need shroud-autoloads.el to be installed
also?

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#38746; Package guix-patches. (Thu, 26 Dec 2019 13:50:02 GMT) Full text and rfc822 format available.

Message #17 received at 38746 <at> debbugs.gnu.org (full text, mbox):

From: "Amar M. Singh" <nly <at> disroot.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38746 <at> debbugs.gnu.org, Brett Gilio <brettg <at> gnu.org>
Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105.
Date: Thu, 26 Dec 2019 13:49:24 +0000
Hi Efraim,

Autoloads.el is used to lazily load an Elisp package. It causes the main commands to be available to Emacs user before the whole package is loaded.

In Guix System, if a package doesn't have autoloads it won't be automatically loaded into Emacs. One will need to add '(require 'package) to '.emacs'.

In case of my package:
(require 'shroud)

without this Emacs wouldn't load Shroud.
Regards,
Amar Singh <nly <at> disroot.org>
https://o-nly.github.io

-------------------------------------------------------------
Sent from my Android device with Librem Mail. Please excuse my brevity.




Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Sat, 28 Dec 2019 19:41:02 GMT) Full text and rfc822 format available.

Notification sent to nly <at> disroot.org (Amar M. Singh):
bug acknowledged by developer. (Sat, 28 Dec 2019 19:41:02 GMT) Full text and rfc822 format available.

Message #22 received at 38746-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: "Amar M. Singh" <nly <at> disroot.org>
Cc: 38746-done <at> debbugs.gnu.org, Brett Gilio <brettg <at> gnu.org>
Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105.
Date: Sat, 28 Dec 2019 21:40:20 +0200
[Message part 1 (text/plain, inline)]
Sounds good. Patch pushed.

On Thu, Dec 26, 2019 at 01:49:24PM +0000, Amar M. Singh wrote:
> Hi Efraim,
> 
> Autoloads.el is used to lazily load an Elisp package. It causes the main commands to be available to Emacs user before the whole package is loaded.
> 
> In Guix System, if a package doesn't have autoloads it won't be automatically loaded into Emacs. One will need to add '(require 'package) to '.emacs'.
> 
> In case of my package:
> (require 'shroud)
> 
> without this Emacs wouldn't load Shroud.
> Regards,
> Amar Singh <nly <at> disroot.org>
> https://o-nly.github.io
> 
> -------------------------------------------------------------
> Sent from my Android device with Librem Mail. Please excuse my brevity.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#38746; Package guix-patches. (Sat, 28 Dec 2019 21:35:02 GMT) Full text and rfc822 format available.

Message #25 received at 38746-done <at> debbugs.gnu.org (full text, mbox):

From: "Amar M. Singh" <nly <at> disroot.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38746-done <at> debbugs.gnu.org, Brett Gilio <brettg <at> gnu.org>
Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105.
Date: Sat, 28 Dec 2019 21:34:48 +0000
Thanks Efraim.
Regards,
Amar Singh <nly <at> disroot.org>
https://o-nly.github.io

-------------------------------------------------------------
Sent from my Android device with Librem Mail. Please excuse my brevity.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 26 Jan 2020 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 62 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.