GNU bug report logs - #38755
icecat retains reference on clang

Previous Next

To reply to this bug, email your comments to 38755 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: bug-guix <at> gnu.org
Subject: icecat retains reference on clang
Date: Thu, 26 Dec 2019 21:49:09 +0100

Icecat retains a reference on clang.  This is because the file
./chrome/toolkit/content/global/buildconfig.html (inside of
lib/icecat/omni.ja) records configuration options, which include the
location of clang.

This should be removed.

-- 
Ricardo

Message #8 received at 38755 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 38755 <at> debbugs.gnu.org
Subject: icecat retains reference on clang
Date: Fri, 27 Dec 2019 00:08:04 +0100

[Message part 1 (text/plain, inline)]

This should do the trick:

[my.patch (text/x-patch, inline)]

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index d5d9839e1a..e9458037a5 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE."
                (format #t "configure flags: ~s~%" flags)
                (apply invoke bash
                       (string-append srcdir "/configure")
-                      flags))))
+                      flags)
+               ;; Remove references to store items
+               (substitute* "toolkit/content/buildconfig.html"
+                 (("/gnu/store") ""))
+               #t)))
          (replace 'build
            ;; The build system often spuriously fails.  See
            ;; <https://bugs.gentoo.org/show_bug.cgi?id=680934>.  To

[Message part 3 (text/plain, inline)]

-- 
Ricardo

Message #11 received at 38755 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 38755 <at> debbugs.gnu.org
Subject: Re: bug#38755: icecat retains reference on clang
Date: Sat, 28 Dec 2019 01:25:50 +0100

Hi,

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> This should do the trick:
>
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index d5d9839e1a..e9458037a5 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE."
>                 (format #t "configure flags: ~s~%" flags)
>                 (apply invoke bash
>                        (string-append srcdir "/configure")
> -                      flags))))
> +                      flags)
> +               ;; Remove references to store items
> +               (substitute* "toolkit/content/buildconfig.html"
> +                 (("/gnu/store") ""))

This should not be a literal “/gnu/store”, though.  Perhaps we should
just use ‘remove-store-references’ instead of ‘substitute*’?

Thanks,
Ludo’.

Message #14 received at 38755 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 38755 <at> debbugs.gnu.org
Subject: Re: bug#38755: icecat retains reference on clang
Date: Sat, 28 Dec 2019 21:47:40 +0200

[Message part 1 (text/plain, inline)]

On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote:
> Hi,
> 
> Ricardo Wurmus <rekado <at> elephly.net> skribis:
> 
> > This should do the trick:
> >
> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> > index d5d9839e1a..e9458037a5 100644
> > --- a/gnu/packages/gnuzilla.scm
> > +++ b/gnu/packages/gnuzilla.scm
> > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE."
> >                 (format #t "configure flags: ~s~%" flags)
> >                 (apply invoke bash
> >                        (string-append srcdir "/configure")
> > -                      flags))))
> > +                      flags)
> > +               ;; Remove references to store items
> > +               (substitute* "toolkit/content/buildconfig.html"
> > +                 (("/gnu/store") ""))
> 
> This should not be a literal “/gnu/store”, though.  Perhaps we should
> just use ‘remove-store-references’ instead of ‘substitute*’?
> 

This way we still get a listing of exactly which store items were used
without needing to refer to them exactly.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 38755 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38755 <at> debbugs.gnu.org
Subject: Re: bug#38755: icecat retains reference on clang
Date: Sun, 29 Dec 2019 00:05:28 +0100

Le 28 décembre 2019 20:47:40 GMT+01:00, Efraim Flashner <efraim <at> flashner.co.il> a écrit :
>On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote:
>> Hi,
>> 
>> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>> 
>> > This should do the trick:
>> >
>> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
>> > index d5d9839e1a..e9458037a5 100644
>> > --- a/gnu/packages/gnuzilla.scm
>> > +++ b/gnu/packages/gnuzilla.scm
>> > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE."
>> >                 (format #t "configure flags: ~s~%" flags)
>> >                 (apply invoke bash
>> >                        (string-append srcdir "/configure")
>> > -                      flags))))
>> > +                      flags)
>> > +               ;; Remove references to store items
>> > +               (substitute* "toolkit/content/buildconfig.html"
>> > +                 (("/gnu/store") ""))
>> 
>> This should not be a literal “/gnu/store”, though.  Perhaps we should
>> just use ‘remove-store-references’ instead of ‘substitute*’?
>> 
>
>This way we still get a listing of exactly which store items were used
>without needing to refer to them exactly.

It shouldn't be literaly /gnu/store, because one could use a different store path. Can we access the store path from a phase code?

Message #20 received at 38755 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 38755 <at> debbugs.gnu.org
Subject: Re: bug#38755: icecat retains reference on clang
Date: Sun, 29 Dec 2019 09:16:50 +0200

[Message part 1 (text/plain, inline)]

On Sun, Dec 29, 2019 at 12:05:28AM +0100, Julien Lepiller wrote:
> Le 28 décembre 2019 20:47:40 GMT+01:00, Efraim Flashner <efraim <at> flashner.co.il> a écrit :
> >On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote:
> >> Hi,
> >> 
> >> Ricardo Wurmus <rekado <at> elephly.net> skribis:
> >> 
> >> > This should do the trick:
> >> >
> >> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> >> > index d5d9839e1a..e9458037a5 100644
> >> > --- a/gnu/packages/gnuzilla.scm
> >> > +++ b/gnu/packages/gnuzilla.scm
> >> > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE."
> >> >                 (format #t "configure flags: ~s~%" flags)
> >> >                 (apply invoke bash
> >> >                        (string-append srcdir "/configure")
> >> > -                      flags))))
> >> > +                      flags)
> >> > +               ;; Remove references to store items
> >> > +               (substitute* "toolkit/content/buildconfig.html"
> >> > +                 (("/gnu/store") ""))
> >> 
> >> This should not be a literal “/gnu/store”, though.  Perhaps we should
> >> just use ‘remove-store-references’ instead of ‘substitute*’?
> >> 
> >
> >This way we still get a listing of exactly which store items were used
> >without needing to refer to them exactly.
> 
> It shouldn't be literaly /gnu/store, because one could use a different store path. Can we access the store path from a phase code?

Good point. Perhaps 'remove-store-references' would just be best.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.