GNU bug report logs - #38841
Enhancement request: Make show_help a bool

Previous Next

Package: grep;

Reported by: Emil Engler <me <at> emilengler.com>

Date: Wed, 1 Jan 2020 02:04:02 UTC

Severity: wishlist

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38841 in the body.
You can then email your comments to 38841 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-grep <at> gnu.org:
bug#38841; Package grep. (Wed, 01 Jan 2020 02:04:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Emil Engler <me <at> emilengler.com>:
New bug report received and forwarded. Copy sent to bug-grep <at> gnu.org. (Wed, 01 Jan 2020 02:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emil Engler <me <at> emilengler.com>
To: bug-grep <at> gnu.org
Subject: Enhancement request: Make show_help a bool
Date: Wed, 1 Jan 2020 02:52:14 +0100

Hi, why is "static int show_help on line65 in src/grep.c a int?
It's value is only set once in "src/grep.c:2704" to a 1.
Wouldn't it be better to make it a bool?

As this my first mail to a GNU project ever I don't know how to properly 
contribute code, are there methods like Pull Requests or do I need to 
submit a patch the traditional way through a diff on a mailing list?

Greetings and Happy New Year,
Emil Engler
Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Wed, 01 Jan 2020 07:19:01 GMT) Full text and rfc822 format available.
Notification sent to Emil Engler <me <at> emilengler.com>:
bug acknowledged by developer. (Wed, 01 Jan 2020 07:19:01 GMT) Full text and rfc822 format available.

Message #10 received at 38841-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emil Engler <me <at> emilengler.com>
Cc: 38841-done <at> debbugs.gnu.org
Subject: Re: bug#38841: Enhancement request: Make show_help a bool
Date: Tue, 31 Dec 2019 23:17:52 -0800

On 12/31/19 5:52 PM, Emil Engler wrote:
> Hi, why is "static int show_help on line65 in src/grep.c a int?

Its address is taken in a long_options initializer, where the context requires
an int *. You could have found that out by changing it to bool and trying to
compile.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 29 Jan 2020 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 82 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.