GNU bug report logs - #38848
Fix path substitution in IBus

Previous Next

Package: guix-patches;

Reported by: kanichos <at> yandex.ru

Date: Wed, 1 Jan 2020 17:24:02 UTC

Severity: normal

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38848 in the body.
You can then email your comments to 38848 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38848; Package guix-patches. (Wed, 01 Jan 2020 17:24:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to kanichos <at> yandex.ru:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 01 Jan 2020 17:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kanichos <at> yandex.ru
To: guix-patches <at> gnu.org
Subject: Fix path substitution in IBus
Date: Wed, 01 Jan 2020 13:15:49 +0300
The IBus package has been broken since forever because it substitutes paths to setxkbmap and xmodmap binaries with package directories.

---
gnu/packages/ibus.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
index 5057927174..42a8d5db32 100644
--- a/gnu/packages/ibus.scm
+++ b/gnu/packages/ibus.scm
@@ -116,7 +116,7 @@
                               "/share/X11/locale")))
             (substitute* "ui/gtk3/xkblayout.vala"
               (("\"(setxkbmap|xmodmap)\"" _ prog)
-                (string-append "\"" (assoc-ref inputs prog) "\"")))
+                (string-append "\"" (assoc-ref inputs prog) "/bin/" prog "\"")))
             #t))
         (add-after 'wrap-program 'wrap-with-additional-paths
           (lambda* (#:key outputs #:allow-other-keys)
--
2.23.0




Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Wed, 01 Jan 2020 22:57:01 GMT) Full text and rfc822 format available.

Notification sent to kanichos <at> yandex.ru:
bug acknowledged by developer. (Wed, 01 Jan 2020 22:57:01 GMT) Full text and rfc822 format available.

Message #10 received at 38848-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: kanichos <at> yandex.ru
Cc: 38848-done <at> debbugs.gnu.org
Subject: Re: [bug#38848] Fix path substitution in IBus
Date: Wed, 01 Jan 2020 23:56:26 +0100
kanichos <at> yandex.ru writes:

> The IBus package has been broken since forever because it substitutes
> paths to setxkbmap and xmodmap binaries with package directories.

Oh, good catch!  Thanks!
(I’ve only ever been using libpinyin, so I never noticed…)

Pushed to the master branch with commit 92d7f5b45d.

--
Ricardo





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 30 Jan 2020 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.