GNU bug report logs - #38852
[PATCH] gnu: python-py3status: Fix patch of file path

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38852 in the body.
You can then email your comments to 38852 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-py3status: Fix patch of file path
Date: Wed, 1 Jan 2020 19:43:49 +0100

* gnu/packages/python-xyz.scm (python-py3status): Fix patch of file
  path.
  [arguments]: Replace single-quotes with double-quotes so that the
  regex matches again. The "replace-with" value is not changed as it's
  not necessary and would introduce escaping noise.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9b71982c3a..7001c69762 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9908,7 +9908,7 @@ to occurrences in strings and comments.")
            (lambda* (#:key inputs #:allow-other-keys)
              (let ((file-path (assoc-ref inputs "file")))
                (substitute* "py3status/parse_config.py"
-                 (("\\['file', '-b'")
+                 (("\\[\"file\", \"-b\"")
                   (string-append "['" file-path "/bin/file', '-b'")))
                #t))))
        #:tests? #f)) ; TODO: Requires many libraries not in Guix.
-- 
2.24.1

Message #10 received at 38852-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 38852-done <at> debbugs.gnu.org
Subject: Re: [bug#38852] [PATCH] gnu: python-py3status: Fix patch of file path
Date: Mon, 06 Jan 2020 15:35:41 +0100

Hello,

Jakub Kądziołka <kuba <at> kadziolka.net> skribis:

> * gnu/packages/python-xyz.scm (python-py3status): Fix patch of file
>   path.
>   [arguments]: Replace single-quotes with double-quotes so that the
>   regex matches again. The "replace-with" value is not changed as it's
>   not necessary and would introduce escaping noise.

Good catch.  Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.