GNU bug report logs - #38882
[PATCH] Add SameBoy

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38882 in the body.
You can then email your comments to 38882 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add SameBoy
Date: Fri, 3 Jan 2020 01:32:02 +0100

[Message part 1 (text/plain, inline)]

Hello Guix,

please find attached a patchset that adds SameBoy and RGBDS to the
available packages. The latter is a dependency of the former, but is
also quite useful on its own.

Regards,
Jakub Kądziołka

[0001-gnu-Add-rgbds.patch (text/x-diff, attachment)]

[0002-gnu-Add-sameboy.patch (text/x-diff, attachment)]

Message #8 received at 38882 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 38882 <at> debbugs.gnu.org
Subject: Re: [bug#38882] [PATCH] Add SameBoy
Date: Fri, 03 Jan 2020 01:56:36 +0100

Hello,

Jakub Kądziołka <kuba <at> kadziolka.net> writes:

> please find attached a patchset that adds SameBoy and RGBDS to the
> available packages. The latter is a dependency of the former, but is
> also quite useful on its own.

Thank you.

> +(define-public rgbds
> +  (package
> +    (name "rgbds")
> +    (version "v0.3.9")

This should be "0.3.9".

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/rednex/rgbds.git")
> +                    (commit version)))

You can add the missing "v" above : (commit (string-append "v" version))

> +(define-public sameboy
> +  (package
> +    (name "sameboy")
> +    (version "v0.12.3")

See above.

> +    (description "SameBoy is a user friendly Game Boy, Game Boy Color
> +and Super Game Boy emulator.  SameBoy is extremely accurate and includes a wide
> +range of powerful debugging features, making it ideal for both casual players
> +and developers.  In addition to accuracy and developer capabilities, SameBoy
> +has all the features one would expect from an emulator---from save states to
> +scaling filters.")

I think there are a lot of buzzwords in this description: "extremely
accurate", "powerful debugging features", "making it ideal"... What
about something like the following boring description:

    (description "SameBoy is a user friendly Game Boy, Game Boy Color
and Super Game Boy emulator.  SameBoy is accurate and includes a wide
range of debugging features.  It has all the features one would expect
from an emulator---from save states to scaling filters.")

Otherwise, LGTM.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #13 received at 38882-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 38882-done <at> debbugs.gnu.org
Subject: Re: [bug#38882] [PATCH] Add SameBoy
Date: Fri, 03 Jan 2020 10:01:54 +0100

Hello,

Jakub Kądziołka <kuba <at> kadziolka.net> writes:

> Understandable. I thought about whether to leave this "v" here, but when
> I grepped for 'version "v' and took a quick look at the results, I
> deduced that this must be acceptable.

Other occurrences may be mistakes. In any case, the official version
number for Sameboy, per its homepage, is 0.12.3, not v0.12.3.

> I didn't even realize that, but it would make sense that there is quite
> a few buzzwords, since I copied this description verbatim from the
> homepage.

True, but some homepages are more humble than others. :)

I applied your patches with the following changes:

1. I removed "free" from the description of rgbds, since everything is
   free in GNU Guix.
2. I added a copyright header line with your name in each modified file.

Thank you!

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.