GNU bug report logs - #38892
28.0.50: Hash table printing oddities

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38892 in the body.
You can then email your comments to 38892 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50: Hash table printing oddities
Date: Fri, 3 Jan 2020 12:13:28 +0000

[Message part 1 (text/plain, inline)]

The hash table printing code has some oddities: it will print extra
spaces sometimes, won't print as many elements as requested under all
circumstances, and behave oddly for empty hash tables when
print-length is 0.

Currently, this code will result in extra spaces in the hash table output:

(let ((h (make-hash-table)))
  (puthash 1 2 h)
  (puthash 2 3 h)
  (remhash 1 h)
  (format "%S" h))

(let ((h (make-hash-table)))
  (let ((print-length 0))
    (format "%S" h)))

In the latter case, the output actually includes "data ( ...)", though
"data ()" would be shorter and more accurate.

Also, the current code contains an oddity that would make it print
fewer than print-length hash cells in the data list:

(let ((h (make-hash-table)))
  (dotimes (i 100)
    (puthash i i h))
  (dotimes (i 99)
    (remhash i h))
  (let ((print-length 1))
    (format "%S" h)))

will produce "data ( ...)", when it should produce "data (99 99)".

Proposed patch attached.

[0001-Fix-hash-table-printing.patch (text/x-patch, attachment)]

Message #8 received at 38892 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Pip Cet <pipcet <at> gmail.com>
Cc: 38892 <at> debbugs.gnu.org
Subject: Re: bug#38892: 28.0.50: Hash table printing oddities
Date: Sat, 11 Jan 2020 11:42:09 +0200

> From: Pip Cet <pipcet <at> gmail.com>
> Date: Fri, 3 Jan 2020 12:13:28 +0000
> 
> Proposed patch attached.

Thanks.  Can you add a few tests to make sure this works as expected?

Message #11 received at 38892 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 38892 <at> debbugs.gnu.org, Pip Cet <pipcet <at> gmail.com>
Subject: Re: bug#38892: 28.0.50: Hash table printing oddities
Date: Sun, 20 Sep 2020 12:24:54 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Proposed patch attached.
>
> Thanks.  Can you add a few tests to make sure this works as expected?

I've now applied Pip's patch and added the examples from the bug report
as tests.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.