GNU bug report logs - #38897
[PATCH] gnu: Add ghc-pointedlist.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38897 in the body.
You can then email your comments to 38897 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Alexandru-Sergiu Marton <brown121407 <at> member.fsf.org>
Subject: [PATCH] gnu: Add ghc-pointedlist.
Date: Fri,  3 Jan 2020 18:21:20 +0200

* gnu/packages/haskell-xyz.scm (ghc-pointedlist): New variable.
---
 gnu/packages/haskell-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index 03ae83d50e..835380a69e 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -8615,6 +8615,31 @@ system dependencies.")
 functions for the ghc-persistent package.")
     (license license:expat)))
 
+(define-public ghc-pointedlist
+  (package
+    (name "ghc-pointedlist")
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://hackage.haskell.org/package/pointedlist/"
+             "pointedlist-" version ".tar.gz"))
+       (sha256
+        (base32
+         "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l"))))
+    (build-system haskell-build-system)
+    (home-page
+     "http://hackage.haskell.org/package/pointedlist")
+    (synopsis
+     "A zipper-like comonad which works as a list, tracking a position.")
+    (description
+     "A PointedList tracks the position in a non-empty list which works
+similarly to a zipper. A current item is always required, and therefore
+the list may never be empty. A circular PointedList wraps around to the
+other end when progressing past the actual edge.")
+    (license license:bsd-3)))
+
 (define-public ghc-polyparse
   (package
     (name "ghc-polyparse")
-- 
2.24.1

Message #8 received at 38897 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Alexandru-Sergiu Marton <brown121407 <at> gmail.com>
Cc: 38897 <at> debbugs.gnu.org, Alexandru-Sergiu Marton <brown121407 <at> member.fsf.org>
Subject: Re: [bug#38897] [PATCH] gnu: Add ghc-pointedlist.
Date: Fri, 03 Jan 2020 22:27:36 -0600

Alexandru-Sergiu Marton <brown121407 <at> gmail.com> writes:

> +(define-public ghc-pointedlist
> +  (package
> +    (name "ghc-pointedlist")
> +    (version "0.6.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://hackage.haskell.org/package/pointedlist/"
> +             "pointedlist-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l"))))
> +    (build-system haskell-build-system)
> +    (home-page
> +     "http://hackage.haskell.org/package/pointedlist")
> +    (synopsis
> +     "A zipper-like comonad which works as a list, tracking a position.")
> +    (description
> +     "A PointedList tracks the position in a non-empty list which works
> +similarly to a zipper. A current item is always required, and therefore
> +the list may never be empty. A circular PointedList wraps around to the
> +other end when progressing past the actual edge.")
> +    (license license:bsd-3)))

Hey again, Sergiu! I have a few suggestions for this package. I think
you forgot to run the linter :) which is okay! However, had you run it,
it would have warned you about the synopsis starting with an article,
the synopsis ending with a period, and the description not being double
spaced after each sentence punctuation. If you could reroll a V2 for
this, I would appreciate it!

Thanks!

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg <at> gnu.org> <brettg <at> posteo.net>

Message #11 received at 38897 <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> gmail.com>
To: 38897 <at> debbugs.gnu.org
Cc: Alexandru-Sergiu Marton <brown121407 <at> member.fsf.org>
Subject: [PATCH v2] gnu: Add ghc-pointedlist.
Date: Sat,  4 Jan 2020 10:46:55 +0200

* gnu/packages/haskell-xyz.scm (ghc-pointedlist): New variable.
---
Fix linter errors.

 gnu/packages/haskell-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index 03ae83d50e..3f408d60e3 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -8615,6 +8615,31 @@ system dependencies.")
 functions for the ghc-persistent package.")
     (license license:expat)))
 
+(define-public ghc-pointedlist
+  (package
+    (name "ghc-pointedlist")
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://hackage.haskell.org/package/pointedlist/"
+             "pointedlist-" version ".tar.gz"))
+       (sha256
+        (base32
+         "16xsrzqql7i4z6a3xy07sqnbyqdmcar1jiacla58y4mvkkwb0g3l"))))
+    (build-system haskell-build-system)
+    (home-page
+     "http://hackage.haskell.org/package/pointedlist")
+    (synopsis
+     "Zipper-like comonad which works as a list, tracking a position")
+    (description
+     "A PointedList tracks the position in a non-empty list which works
+similarly to a zipper.  A current item is always required, and therefore
+the list may never be empty.  A circular PointedList wraps around to the
+other end when progressing past the actual edge.")
+    (license license:bsd-3)))
+
 (define-public ghc-polyparse
   (package
     (name "ghc-polyparse")
-- 
2.24.1

Message #16 received at 38897-done <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Alexandru-Sergiu Marton <brown121407 <at> gmail.com>
Cc: 38897-done <at> debbugs.gnu.org,
 Alexandru-Sergiu Marton <brown121407 <at> member.fsf.org>
Subject: Re: [bug#38897] [PATCH v2] gnu: Add ghc-pointedlist.
Date: Tue, 07 Jan 2020 13:34:33 -0600

Hi Sergiu! Pushed with 451775a5675cdf1dfb9f4503427442b21bb5041a.

Thanks! Closing.

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg <at> gnu.org> <brettg <at> posteo.net>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.