GNU bug report logs - #38934
[PATCH] vc-dwim: die if no one-line summary.

Previous Next

Package: vc-dwim;

Reported by: Karl Berry <karl <at> freefriends.org>

Date: Sun, 5 Jan 2020 02:00:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38934 in the body.
You can then email your comments to 38934 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-vc-dwim <at> gnu.org:
bug#38934; Package vc-dwim. (Sun, 05 Jan 2020 02:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Karl Berry <karl <at> freefriends.org>:
New bug report received and forwarded. Copy sent to bug-vc-dwim <at> gnu.org. (Sun, 05 Jan 2020 02:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: bug-vc-dwim <at> gnu.org
Subject: [PATCH] vc-dwim: die if no one-line summary.
Date: Sat, 4 Jan 2020 18:59:21 -0700
[Message part 1 (text/plain, inline)]
Jim, for your consideration: die if no one-line summary is found and
--commit is specified, instead of committing unparsable/bogus data.

FWIW, I found it quite painful to recover from the commit when vcd
couldn't parse my entry and I accidentally committed anyway. -k

[vcd-die-if-no-summary.diff (application/octet-stream, attachment)]

Information forwarded to bug-vc-dwim <at> gnu.org:
bug#38934; Package vc-dwim. (Sun, 05 Jan 2020 05:57:02 GMT) Full text and rfc822 format available.

Message #8 received at 38934 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Karl Berry <karl <at> freefriends.org>
Cc: 38934 <at> debbugs.gnu.org
Subject: Re: [Bug-vc-dwim] bug#38934: [PATCH] vc-dwim: die if no one-line
 summary.
Date: Sat, 4 Jan 2020 21:56:00 -0800
[Message part 1 (text/plain, inline)]
On Sat, Jan 4, 2020 at 6:00 PM Karl Berry <karl <at> freefriends.org> wrote:
> Jim, for your consideration: die if no one-line summary is found and
> --commit is specified, instead of committing unparsable/bogus data.
>
> FWIW, I found it quite painful to recover from the commit when vcd
> couldn't parse my entry and I accidentally committed anyway. -k

Thanks for the suggestion.
I like it enough that I've adjusted the many resultant test failures
to accommodate (see the attached). If no one objects, I'll merge those
test changes into your commit and push everything tomorrow.
[vc-require-summary-tests.diff (application/octet-stream, attachment)]

Information forwarded to bug-vc-dwim <at> gnu.org:
bug#38934; Package vc-dwim. (Sun, 05 Jan 2020 18:54:01 GMT) Full text and rfc822 format available.

Message #11 received at 38934 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Karl Berry <karl <at> freefriends.org>
Cc: 38934 <at> debbugs.gnu.org
Subject: Re: [Bug-vc-dwim] bug#38934: [PATCH] vc-dwim: die if no one-line
 summary.
Date: Sun, 5 Jan 2020 10:53:18 -0800
[Message part 1 (text/plain, inline)]
On Sat, Jan 4, 2020 at 9:56 PM Jim Meyering <jim <at> meyering.net> wrote:
>
> On Sat, Jan 4, 2020 at 6:00 PM Karl Berry <karl <at> freefriends.org> wrote:
> > Jim, for your consideration: die if no one-line summary is found and
> > --commit is specified, instead of committing unparsable/bogus data.
> >
> > FWIW, I found it quite painful to recover from the commit when vcd
> > couldn't parse my entry and I accidentally committed anyway. -k
>
> Thanks for the suggestion.
> I like it enough that I've adjusted the many resultant test failures
> to accommodate (see the attached). If no one objects, I'll merge those
> test changes into your commit and push everything tomorrow.

Here's the merged commit I want to push later today.
Also adjusted NEWS.
[vc-require-summary.diff (application/octet-stream, attachment)]

Information forwarded to bug-vc-dwim <at> gnu.org:
bug#38934; Package vc-dwim. (Sun, 05 Jan 2020 22:47:02 GMT) Full text and rfc822 format available.

Message #14 received at 38934 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: jim <at> meyering.net
Cc: 38934 <at> debbugs.gnu.org
Subject: Re: [Bug-vc-dwim] bug#38934: [PATCH] vc-dwim: die if no one-line
 summary.
Date: Sun, 5 Jan 2020 15:46:22 -0700
    I like it enough that I've adjusted the many resultant test failures

Thanks much. I admit I totally spaced on thinking about the vcd tests.
(And I'm kind of glad I did, since I probably would have given up. :)

    Here's the merged commit I want to push later today.
    Also adjusted NEWS.

Great. Thanks again. -k




Reply sent to Jim Meyering <jim <at> meyering.net>:
You have taken responsibility. (Sun, 05 Jan 2020 22:54:02 GMT) Full text and rfc822 format available.

Notification sent to Karl Berry <karl <at> freefriends.org>:
bug acknowledged by developer. (Sun, 05 Jan 2020 22:54:02 GMT) Full text and rfc822 format available.

Message #19 received at 38934-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Karl Berry <karl <at> freefriends.org>
Cc: 38934-done <at> debbugs.gnu.org
Subject: Re: [Bug-vc-dwim] bug#38934: [PATCH] vc-dwim: die if no one-line
 summary.
Date: Sun, 5 Jan 2020 14:52:57 -0800
On Sun, Jan 5, 2020 at 2:46 PM Karl Berry <karl <at> freefriends.org> wrote:
>
>     I like it enough that I've adjusted the many resultant test failures
>
> Thanks much. I admit I totally spaced on thinking about the vcd tests.
> (And I'm kind of glad I did, since I probably would have given up. :)
>
>     Here's the merged commit I want to push later today.
>     Also adjusted NEWS.

pushed




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 03 Feb 2020 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 55 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.