GNU bug report logs - #38941
[PATCH 0/5] Support fluidsynth and opus in sdl(2)-mixer, and other tweaks

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Timotej Lazar <timotej.lazar@HIDDEN>; Keywords: patch; dated Sun, 5 Jan 2020 10:37:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 38941 <at> debbugs.gnu.org:


Received: (at 38941) by debbugs.gnu.org; 5 Jan 2020 12:23:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 05 07:23:52 2020
Received: from localhost ([127.0.0.1]:43756 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1io4wi-0001NG-85
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 07:23:52 -0500
Received: from dd26836.kasserver.com ([85.13.145.193]:34108)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1io4wf-0001N6-K7
 for 38941 <at> debbugs.gnu.org; Sun, 05 Jan 2020 07:23:50 -0500
Received: from localhost (unknown [185.17.13.127])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id A7A4933620C9;
 Sun,  5 Jan 2020 13:23:46 +0100 (CET)
Date: Sun, 5 Jan 2020 13:23:44 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
To: Timotej Lazar <timotej.lazar@HIDDEN>
Subject: Re: [bug#38941] [PATCH 0/5] Support fluidsynth and opus in
 sdl(2)-mixer, and other tweaks
Message-ID: <20200105132306.32d6f294@HIDDEN>
In-Reply-To: <87v9pqdwb1.fsf@HIDDEN>
References: <87v9pqdwb1.fsf@HIDDEN>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/TBesG/S8cWn._JJ8LTIJG12";
 protocol="application/pgp-signature"; micalg=pgp-sha256
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 38941
Cc: 38941 <at> debbugs.gnu.org, Ricardo Wurmus <rekado@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--Sig_/TBesG/S8cWn._JJ8LTIJG12
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

thanks for the patches!

On Sun, 05 Jan 2020 11:36:34 +0100
Timotej Lazar <timotej.lazar@HIDDEN> wrote:

> The MIDI backends need additional runtime configuration. Fluidsynth
> requires a soundfont to be installed and specified when running a
> program that uses sdl-mixer, e.g.:
>=20
>     SDL_SOUNDFONTS=3D/gnu/store/=E2=80=A6-fluid-3-2.1/share/soundfonts/Fl=
uidR3Mono_GM.sf3
>=20
> If this is not set, the bundled timidity backend is used, which can use
> the freepats samples. Configuration must be specified since only files
> under /etc are checked by default, e.g.:
>=20
>     TIMIDITY_CFG=3D/gnu/store/=E2=80=A6-freepats-20060219/share/freepats/=
freepats.cfg

> I=E2=80=99m not sure if and how default values for these vars can be spec=
ified
> for all programs using sdl-mixer, and I would prefer to leave the choice
> of backend to the user anyway.

> However, we should probably document them somewhere. Would a comment be e=
nough?

Let's put it in the description of the sdl-mixer package.
After all, it would document the usage of an interface that sdl-mixer provi=
des.

> Dependent packages can then wrap
> binaries to set required paths if needed.
>=20
> Alternatively we can add freepats and/or fluid as inputs to sdl(2)-mixer
> and patch the source to look for them in the store.

How often is it that a user switches MIDI soundfonts?

Does a user expect a default soundfont?

That would tell us whether we should provide such a default (and increase
the closure size of sdl2-mixer considerably, maybe?).

There's also a procedure "sdl-union" which already does sdl magic.  We could
also add some stuff for MIDI there, maybe.

In the mean time, I've applied your patchset to master since it only adds
functionality and only has few dependents.

Could you provide an update to the description or similar as a patch?

--Sig_/TBesG/S8cWn._JJ8LTIJG12
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4R1VAACgkQ5xo1VCww
uqUkzQf6Ayxl8b9l7o05e21UyDRzs++8WVScRrm4NMqO2EAwVpeu9QiWP+ySywVk
3IM4U/4b0RWu2CqwHIkiRBix8+HJpdL9aJrxIkNY20hE9WSegGY2loifvjmwBMy9
RRsmNrEq/xoXRSZxnO/+YUO+sF0imGEOq1OnHQgABiQWR+vQ2A5N3aS6hUGqJ+0/
/GUseXNzbtOald5y/leUWjbvVZ2k7E0xwxDN7hUpE5qZN/GyDodEmQ3hIZvIAMoJ
ddQdhnjCkez0jqFSZXDTryD0LRYUmlFC5YEkTTgxT437qE9RUvPs9J03qXfbGt+5
DsjVY3tcwyJVdqWAHxLgUKe1krs/yA==
=ZgLJ
-----END PGP SIGNATURE-----

--Sig_/TBesG/S8cWn._JJ8LTIJG12--




Information forwarded to guix-patches@HIDDEN:
bug#38941; Package guix-patches. Full text available.

Message received at 38941 <at> debbugs.gnu.org:


Received: (at 38941) by debbugs.gnu.org; 5 Jan 2020 10:46:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 05 05:46:08 2020
Received: from localhost ([127.0.0.1]:43716 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1io3Q7-0007JV-NN
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:08 -0500
Received: from araneo.si ([90.157.193.204]:38980)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3Q3-0007Hz-9C
 for 38941 <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:03 -0500
Received: from araneo.si (localhost.lan [127.0.0.1])
 by araneo.si (OpenSMTPD) with ESMTP id 1e265c1d
 for <38941 <at> debbugs.gnu.org>; Sun, 5 Jan 2020 10:46:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc
 :subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding; s=20180623; bh=/Mt4mRnOLQorAoeZuhQQD
 VRHs3g=; b=RWMBCE+O/ZiRn9YikFj3/Q+qM4b29Lmvm1bn7Hll+lYy4f12RE0uY
 iBFdVdMhP+vcWG84kypvKl2V/OoTR0xdKiHgHQfR+kOu/oDU46NI03Y4p/yXuT4a
 BxR7Pg5LuBeiMTa1ZIlf1gOpZmzg89/CcLCmiRJGsGGfzOJ/11nL2ynYKTcEJ4fj
 0zGWJDmNmDMGpmwWAMnZqc2v5trQn0/JeLbxjhrIPhweIkDAmTuet8Cx9ZHaJuF1
 v3Yq/OsOe7QNeIH9ae2KwAbsLSzux08bzh2kCR7cyDAwBGjVXw1fQa6alfxAbHKK
 8ne6O/7YNMB8aQvMnNVns78NgoMVCi9Ow==
Received: by araneo.si (OpenSMTPD) with ESMTPSA id 60e297c3
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sun, 5 Jan 2020 10:46:00 +0000 (UTC)
From: Timotej Lazar <timotej.lazar@HIDDEN>
To: 38941 <at> debbugs.gnu.org
Subject: [PATCH 5/5] gnu: sdl2-mixer: Enable opus support.
Date: Sun,  5 Jan 2020 11:45:51 +0100
Message-Id: <20200105104551.16961-5-timotej.lazar@HIDDEN>
X-Mailer: git-send-email 2.24.1
In-Reply-To: <20200105104551.16961-1-timotej.lazar@HIDDEN>
References: <20200105104551.16961-1-timotej.lazar@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 38941
Cc: Timotej Lazar <timotej.lazar@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/sdl.scm (sdl2-mixer)[inputs]: Add opusfile.
  [native-inputs]: Add pkg-config.
  [arguments]: Link opusfile at build time.
---
 gnu/packages/sdl.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index 80f3da9327..80725561fb 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -420,15 +420,19 @@ directory.")
       (substitute-keyword-arguments (package-arguments sdl-mixer)
          ((#:configure-flags flags)
           `(cons*
+            "--disable-music-opus-shared"
             ;; These options were renamed in SDL2 mixer. Keeping the inherited
             ;; variants produces a harmless warning.
             "--disable-music-mod-modplug-shared"
             "--disable-music-midi-fluidsynth-shared"
             ,flags))))
     (inputs
-     ;; The default MOD library changed in SDL2 mixer.
-     `(("libmodplug" ,libmodplug)
+     `(("opusfile" ,opusfile)
+       ;; The default MOD library changed in SDL2 mixer.
+       ("libmodplug" ,libmodplug)
        ,@(alist-delete "libmikmod" (package-inputs sdl-mixer))))
+    (native-inputs
+     `(("pkgconfig" ,pkg-config))) ; Needed to find the opus library.
     (propagated-inputs
      (propagated-inputs-with-sdl2 sdl-mixer))))
 
-- 
2.24.1





Information forwarded to guix-patches@HIDDEN:
bug#38941; Package guix-patches. Full text available.

Message received at 38941 <at> debbugs.gnu.org:


Received: (at 38941) by debbugs.gnu.org; 5 Jan 2020 10:46:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 05 05:46:05 2020
Received: from localhost ([127.0.0.1]:43714 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1io3Q5-0007JH-Bi
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:05 -0500
Received: from araneo.si ([90.157.193.204]:38980)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3Q2-0007Hz-EL
 for 38941 <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:02 -0500
Received: from araneo.si (localhost.lan [127.0.0.1])
 by araneo.si (OpenSMTPD) with ESMTP id d889e407
 for <38941 <at> debbugs.gnu.org>; Sun, 5 Jan 2020 10:46:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc
 :subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding; s=20180623; bh=6gg/ptcKyLbOAN3C0loqW
 GnIYwc=; b=IeXaejR+4X8xItBMIi2v34U39lxFp9g/JjXPQluNVhKr0ndLhK7xg
 7Si4fMeCMXcdtB+RuPIxlvZiTnuUbOpbFOQZHOvX/H0n0pCPgt7TkqubrhSHE6Mp
 4TR2JT1/8dPo86uUcSHD27OfbjfnSuSUfEevVrFDp6cXFFEYhkCb+rsvPzoAOz3t
 8R9qesffqcPyvtmLeCjNNKst80KcKCqpBP2TdS+1mrMsHKrPWiJzCsbHBXnu8jkp
 5AI+Fj4fFsEHM8BBF3EULcXVUCbndiChWYZkNFW6kf1tRke0XhHUcMEy5rv0GQUs
 CKBCO975LRgTBeczhMmUm6C409bBUbmpg==
Received: by araneo.si (OpenSMTPD) with ESMTPSA id c14affe5
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sun, 5 Jan 2020 10:46:00 +0000 (UTC)
From: Timotej Lazar <timotej.lazar@HIDDEN>
To: 38941 <at> debbugs.gnu.org
Subject: [PATCH 4/5] gnu: sdl-mixer: Enable fluidsynth MIDI backend.
Date: Sun,  5 Jan 2020 11:45:50 +0100
Message-Id: <20200105104551.16961-4-timotej.lazar@HIDDEN>
X-Mailer: git-send-email 2.24.1
In-Reply-To: <20200105104551.16961-1-timotej.lazar@HIDDEN>
References: <20200105104551.16961-1-timotej.lazar@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 38941
Cc: Timotej Lazar <timotej.lazar@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/sdl.scm (sdl-mixer)[inputs]: Add fluidsynth and alphabetize.
[arguments]: Reformat.
---
 gnu/packages/sdl.scm | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index d441040cd6..80f3da9327 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -262,20 +262,21 @@ WEBP, XCF, XPM, and XV.")
                 "0alrhqgm40p4c92s26mimg9cm1y7rzr6m0p49687jxd9g6130i0n"))))
     (build-system gnu-build-system)
     (outputs '("out" "debug"))
-    ;; no check target
-    ;; use libmad instead of smpeg
-    ;; explicitly link against shared libraries instead of dlopening them
-    (arguments `(#:tests? #f
-                 #:configure-flags '("--enable-music-mp3-mad-gpl"
-                                     "--disable-music-mod-shared"
-                                     "--disable-music-fluidsynth-shared"
-                                     "--disable-music-ogg-shared"
-                                     "--disable-music-flac-shared")))
-    (inputs `(("libvorbis" ,libvorbis)
-              ("libflac" ,flac)
-              ("libmad" ,libmad)
-              ("libmikmod" ,libmikmod)))
-    ;; FIXME: Add libfluidsynth
+    (arguments
+     `(#:tests? #f ; No check target.
+       #:configure-flags
+       '("--enable-music-mp3-mad-gpl" ; Use libmad instead of smpeg.
+         ;; Explicitly link against shared libraries instead of dlopening them.
+         "--disable-music-flac-shared"
+         "--disable-music-fluidsynth-shared"
+         "--disable-music-mod-shared"
+         "--disable-music-ogg-shared")))
+    (inputs
+     `(("fluidsynth" ,fluidsynth)
+       ("libflac" ,flac)
+       ("libmad" ,libmad)
+       ("libmikmod" ,libmikmod)
+       ("libvorbis" ,libvorbis)))
     (propagated-inputs `(("sdl" ,sdl)))
     (synopsis "SDL multi-channel audio mixer library")
     (description "SDL_mixer is a multi-channel audio mixer library for SDL.
-- 
2.24.1





Information forwarded to guix-patches@HIDDEN:
bug#38941; Package guix-patches. Full text available.

Message received at 38941 <at> debbugs.gnu.org:


Received: (at 38941) by debbugs.gnu.org; 5 Jan 2020 10:46:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 05 05:46:05 2020
Received: from localhost ([127.0.0.1]:43712 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1io3Q4-0007J9-OO
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:05 -0500
Received: from araneo.si ([90.157.193.204]:38980)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3Q1-0007Hz-L3
 for 38941 <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:02 -0500
Received: from araneo.si (localhost.lan [127.0.0.1])
 by araneo.si (OpenSMTPD) with ESMTP id c055b163
 for <38941 <at> debbugs.gnu.org>; Sun, 5 Jan 2020 10:46:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc
 :subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding; s=20180623; bh=UzjmJDWT/L/D2/qM3/r/n
 BfjAgI=; b=Ie67/7uBeqgPJh3gbT6WSocWhhGHrGFbV4a3XgMj3nHtc+JCPl1hC
 +r6ntS696WSKjxclmsq5cNR30+DNWiV2gNWDyZYd7u6DmmcFBJqxIm4xMN8PZqy5
 /h2U7Bwx7gZGC10UqZ3EUc9sVsuM3N8cziLh+B1P5SwNrMxW8+9UISRr6EPoKsNe
 mbmfZEXkFVaLIPFqdthZri/+aLzsGMCZyghRbsH4hBO/IMxILYIGoucIlFED0HeT
 A7R/e0Wv9awyU290sAkWJiJlq9Ry0MmTMwR+VOVenruuMX39SOU1TxpUiVyDDcac
 CMsGCJXums2Cgxri4dvWoYoksan0RAO6w==
Received: by araneo.si (OpenSMTPD) with ESMTPSA id a9caabf0
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sun, 5 Jan 2020 10:45:59 +0000 (UTC)
From: Timotej Lazar <timotej.lazar@HIDDEN>
To: 38941 <at> debbugs.gnu.org
Subject: [PATCH 3/5] gnu: sdl2-mixer: Fix configure flags.
Date: Sun,  5 Jan 2020 11:45:49 +0100
Message-Id: <20200105104551.16961-3-timotej.lazar@HIDDEN>
X-Mailer: git-send-email 2.24.1
In-Reply-To: <20200105104551.16961-1-timotej.lazar@HIDDEN>
References: <20200105104551.16961-1-timotej.lazar@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 38941
Cc: Timotej Lazar <timotej.lazar@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Some configure options were renamed between SDL / SDL2 mixer; add new variants
to the derived package.

* gnu/packages/sdl.scm (sdl2-mixer)[arguments]: Fix flags to disable dynamic
  library loading.
---
 gnu/packages/sdl.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index 92d8f9a922..d441040cd6 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -415,6 +415,15 @@ directory.")
                    #t))
        (sha256
         (base32 "0694vsz5bjkcdgfdra6x9fq8vpzrl8m6q96gh58df7065hw5mkxl"))))
+    (arguments
+      (substitute-keyword-arguments (package-arguments sdl-mixer)
+         ((#:configure-flags flags)
+          `(cons*
+            ;; These options were renamed in SDL2 mixer. Keeping the inherited
+            ;; variants produces a harmless warning.
+            "--disable-music-mod-modplug-shared"
+            "--disable-music-midi-fluidsynth-shared"
+            ,flags))))
     (inputs
      ;; The default MOD library changed in SDL2 mixer.
      `(("libmodplug" ,libmodplug)
-- 
2.24.1





Information forwarded to guix-patches@HIDDEN:
bug#38941; Package guix-patches. Full text available.

Message received at 38941 <at> debbugs.gnu.org:


Received: (at 38941) by debbugs.gnu.org; 5 Jan 2020 10:46:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 05 05:46:04 2020
Received: from localhost ([127.0.0.1]:43710 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1io3Q4-0007J7-FJ
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:04 -0500
Received: from araneo.si ([90.157.193.204]:38980)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3Q0-0007Hz-Rr
 for 38941 <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:01 -0500
Received: from araneo.si (localhost.lan [127.0.0.1])
 by araneo.si (OpenSMTPD) with ESMTP id 27d27ed5
 for <38941 <at> debbugs.gnu.org>; Sun, 5 Jan 2020 10:45:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc
 :subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding; s=20180623; bh=/NNZMBgfkbdracNPcnmL5
 0odhPI=; b=qkT7z3a1Xr3yu4tcUtjiM7G3hqcUbYBRrGbYXJrtsiMjqAHy99Qu+
 3A+iYgumZbMfOaoFosX7iqgspm5b65qAXbJ60MGM/aQaGKdoxdewAMkKT+/crkbg
 uL68+gRPYQ4kW9jdZroamgPhKvdxDrgZ6nt5cWK5Md27r2dPyrOZeyoPYwiOxwwB
 Ol+P8Aa5AMIl7ttDfFlE/vfKXuvEqulHJvprYWvQWDsot+HIy63EU/Km9kdmL73Z
 gzbWS0jbGiuHcxLo+UvZSiPP73mo67MKWl1/8liFQPs6gh3+Ui2Kx2Oa5bQOXoBU
 8vELCoFeElQDb0Ercc3Va+KZuVyBQMlqg==
Received: by araneo.si (OpenSMTPD) with ESMTPSA id d864857e
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sun, 5 Jan 2020 10:45:59 +0000 (UTC)
From: Timotej Lazar <timotej.lazar@HIDDEN>
To: 38941 <at> debbugs.gnu.org
Subject: [PATCH 2/5] gnu: sdl-mixer: Remove unused configure flag.
Date: Sun,  5 Jan 2020 11:45:48 +0100
Message-Id: <20200105104551.16961-2-timotej.lazar@HIDDEN>
X-Mailer: git-send-email 2.24.1
In-Reply-To: <20200105104551.16961-1-timotej.lazar@HIDDEN>
References: <20200105104551.16961-1-timotej.lazar@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 38941
Cc: Timotej Lazar <timotej.lazar@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

The flag --disable-music-mp3-shared is only used when building with smpeg
instead of libmad, which is linked at build time by default.

* gnu/packages/sdl.scm (sdl-mixer)[arguments]: Remove unused configure flag.
---
 gnu/packages/sdl.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index beeec1b8ca..92d8f9a922 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -270,8 +270,7 @@ WEBP, XCF, XPM, and XV.")
                                      "--disable-music-mod-shared"
                                      "--disable-music-fluidsynth-shared"
                                      "--disable-music-ogg-shared"
-                                     "--disable-music-flac-shared"
-                                     "--disable-music-mp3-shared")))
+                                     "--disable-music-flac-shared")))
     (inputs `(("libvorbis" ,libvorbis)
               ("libflac" ,flac)
               ("libmad" ,libmad)
-- 
2.24.1





Information forwarded to guix-patches@HIDDEN:
bug#38941; Package guix-patches. Full text available.

Message received at 38941 <at> debbugs.gnu.org:


Received: (at 38941) by debbugs.gnu.org; 5 Jan 2020 10:46:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 05 05:46:02 2020
Received: from localhost ([127.0.0.1]:43704 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1io3Q2-0007IY-4o
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:02 -0500
Received: from araneo.si ([90.157.193.204]:38980)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3Pz-0007Hz-SB
 for 38941 <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:46:00 -0500
Received: from araneo.si (localhost.lan [127.0.0.1])
 by araneo.si (OpenSMTPD) with ESMTP id 75f25097
 for <38941 <at> debbugs.gnu.org>; Sun, 5 Jan 2020 10:45:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc
 :subject:date:message-id:mime-version:content-type
 :content-transfer-encoding; s=20180623; bh=zy0/1ocdQNZGfAr7SwHSV
 Ypc5e0=; b=jN6bbXZhOfVgvGp2G5RmYuLYELPcujqiRQ8Z3T3OhG2qJw4PrKjWP
 VmnLci54YAVx2zxo8ycj1NdyjOBXLGZ6Uq7TJMjbwzrqv1H5pE8FIYj99iugi8L1
 DgBiRcViX2EqhMFema0xbcKtdVWgfPq4h3iYKbQNAa1c6kne6zdSlLbS5dkesiR0
 aTkcdh0BKhygdGovtu4XYUYUkpO/63RIp8SYEf1lE2AiO09iq5pBDrE5gGiFjDR8
 1G9SrV1CeF1hDympj5zSYYUhYwc5Kif/D0mqsLqF29j0Ku/VFdK0/B0tKFPgUfqy
 0nBW5W2mq7EEtVzkKIOkJ7Mr+ThsN7U+g==
Received: by araneo.si (OpenSMTPD) with ESMTPSA id 5ad052d0
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sun, 5 Jan 2020 10:45:58 +0000 (UTC)
From: Timotej Lazar <timotej.lazar@HIDDEN>
To: 38941 <at> debbugs.gnu.org
Subject: [PATCH 1/5] gnu: sdl-mixer: Use correct inputs for MOD file support.
Date: Sun,  5 Jan 2020 11:45:47 +0100
Message-Id: <20200105104551.16961-1-timotej.lazar@HIDDEN>
X-Mailer: git-send-email 2.24.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 38941
Cc: Timotej Lazar <timotej.lazar@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Only one MOD backend is compiled, so specify (only) the correct inputs:
libmikmod for sdl-mixer and libmodplug for sdl2-mixer.

* gnu/packages/sdl.scm (sdl-mixer)[inputs]: Remove libmodplug.
* gnu/packages/sdl.scm (sdl2-mixer)[inputs]: Add libmodplug.
---
 gnu/packages/sdl.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index f7a34003d1..beeec1b8ca 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2019 Nicolas Goaziou <mail@HIDDEN>
 ;;; Copyright © 2019 Marius Bakke <mbakke@HIDDEN>
 ;;; Copyright © 2019 Pierre Neidhardt <mail@HIDDEN>
+;;; Copyright © 2020 Timotej Lazar <timotej.lazar@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -274,8 +275,7 @@ WEBP, XCF, XPM, and XV.")
     (inputs `(("libvorbis" ,libvorbis)
               ("libflac" ,flac)
               ("libmad" ,libmad)
-              ("libmikmod" ,libmikmod)
-              ("libmodplug" ,libmodplug)))
+              ("libmikmod" ,libmikmod)))
     ;; FIXME: Add libfluidsynth
     (propagated-inputs `(("sdl" ,sdl)))
     (synopsis "SDL multi-channel audio mixer library")
@@ -416,6 +416,10 @@ directory.")
                    #t))
        (sha256
         (base32 "0694vsz5bjkcdgfdra6x9fq8vpzrl8m6q96gh58df7065hw5mkxl"))))
+    (inputs
+     ;; The default MOD library changed in SDL2 mixer.
+     `(("libmodplug" ,libmodplug)
+       ,@(alist-delete "libmikmod" (package-inputs sdl-mixer))))
     (propagated-inputs
      (propagated-inputs-with-sdl2 sdl-mixer))))
 
-- 
2.24.1





Information forwarded to guix-patches@HIDDEN:
bug#38941; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 5 Jan 2020 10:36:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 05 05:36:49 2020
Received: from localhost ([127.0.0.1]:43688 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1io3H6-00073W-QE
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:36:49 -0500
Received: from lists.gnu.org ([209.51.188.17]:51624)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3H5-00073O-H7
 for submit <at> debbugs.gnu.org; Sun, 05 Jan 2020 05:36:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:42515)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3H1-0003SS-AW
 for guix-patches@HIDDEN; Sun, 05 Jan 2020 05:36:47 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED
 autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <timotej.lazar@HIDDEN>) id 1io3Gz-0005BG-6Z
 for guix-patches@HIDDEN; Sun, 05 Jan 2020 05:36:43 -0500
Received: from araneo.si ([90.157.193.204]:40560)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <timotej.lazar@HIDDEN>)
 id 1io3Gx-0004dl-IN
 for guix-patches@HIDDEN; Sun, 05 Jan 2020 05:36:41 -0500
Received: from araneo.si (localhost.lan [127.0.0.1])
 by araneo.si (OpenSMTPD) with ESMTP id 741ce65b
 for <guix-patches@HIDDEN>; Sun, 5 Jan 2020 10:36:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to
 :subject:date:message-id:mime-version:content-type
 :content-transfer-encoding; s=20180623; bh=Yv9JTRfcFkDMMMGvSAYIV
 CMNXyM=; b=x936qkccI9wf+eVT58nTl+6U6l9SefmCppUzADvFIBomtP+NRzEVs
 hLEka7NSaUonHkt2IK1VC1nEWy2z0oFqOCn3cE8DeaamtNc6+5JYXTuTOSU+nta7
 M2prP0D7qCAv/n8IwIW9S3ejkwOt07BK4vLW6HMxnvHh8yxUAeg7LEKEjkaC/DRb
 AC3aOHJ/Fb0GPzsD97tZ7Os5Ywtklt93DnvxO0i04f+xsH6Rp4g9AVsDEvGAPgGd
 ZSu6AUVQtRLt3KE7YtKCrcYV7f08set8NXhMvWRuBeHmp5QKFuy1wWDXbxo/sFCR
 MbDte7ei96yvHMN2KRoPIF0Cn29zY1Ppg==
Received: by araneo.si (OpenSMTPD) with ESMTPSA id f2f21c56
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <guix-patches@HIDDEN>;
 Sun, 5 Jan 2020 10:36:35 +0000 (UTC)
From: Timotej Lazar <timotej.lazar@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/5] Support fluidsynth and opus in sdl(2)-mixer,
 and other tweaks
Date: Sun, 05 Jan 2020 11:36:34 +0100
Message-ID: <87v9pqdwb1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 90.157.193.204
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi,

these patches improve sdl- and sdl2-mixer: fix dependencies and
configure flags that changed between the two versions, and enable
support for fluidsynth and opus libraries. I tested several dependent
packages, and everything seems to work OK.

The MIDI backends need additional runtime configuration. Fluidsynth
requires a soundfont to be installed and specified when running a
program that uses sdl-mixer, e.g.:

    SDL_SOUNDFONTS=3D/gnu/store/=E2=80=A6-fluid-3-2.1/share/soundfonts/Flui=
dR3Mono_GM.sf3

If this is not set, the bundled timidity backend is used, which can use
the freepats samples. Configuration must be specified since only files
under /etc are checked by default, e.g.:

    TIMIDITY_CFG=3D/gnu/store/=E2=80=A6-freepats-20060219/share/freepats/fr=
eepats.cfg

I=E2=80=99m not sure if and how default values for these vars can be specif=
ied
for all programs using sdl-mixer, and I would prefer to leave the choice
of backend to the user anyway. However, we should probably document them
somewhere. Would a comment be enough? Dependent packages can then wrap
binaries to set required paths if needed.

Alternatively we can add freepats and/or fluid as inputs to sdl(2)-mixer
and patch the source to look for them in the store.

Thanks!
Timotej

Timotej Lazar (5):
  gnu: sdl-mixer: Use correct inputs for MOD file support.
  gnu: sdl-mixer: Remove unused configure flag.
  gnu: sdl2-mixer: Fix configure flags.
  gnu: sdl-mixer: Enable fluidsynth MIDI backend.
  gnu: sdl2-mixer: Enable opus support.

 gnu/packages/sdl.scm | 49 +++++++++++++++++++++++++++++---------------
 1 file changed, 33 insertions(+), 16 deletions(-)

--=20
2.24.1




Acknowledgement sent to Timotej Lazar <timotej.lazar@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#38941; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 5 Jan 2020 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.