GNU bug report logs - #38957
[PATCH] gnu: Add python-pywinrm

Previous Next

Package: guix-patches;

Reported by: Alexandros Theodotou <alex <at> zrythm.org>

Date: Sun, 5 Jan 2020 20:45:01 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38957 in the body.
You can then email your comments to 38957 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Sun, 05 Jan 2020 20:45:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alexandros Theodotou <alex <at> zrythm.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 05 Jan 2020 20:45:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add python-pywinrm
Date: Sun, 05 Jan 2020 20:43:08 +0000
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-python-pywinrm.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Mon, 06 Jan 2020 09:23:01 GMT) Full text and rfc822 format available.

Message #8 received at 38957 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38957 <at> debbugs.gnu.org
Subject: Re: [bug#38957] [PATCH] gnu: Add python-pywinrm
Date: Mon, 06 Jan 2020 03:22:14 -0600
Alexandros Theodotou <alex <at> zrythm.org> writes:

> From 701f416b45990dfc8de2082bec4621479b2041cb Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Sun, 5 Jan 2020 20:39:24 +0000
> Subject: [PATCH] gnu: Add python-pywinrm.
>
> * gnu/packages/python-xyz.scm (python-pywinrm): New variable.
> * gnu/packages/python-web.scm (python-requests_ntlm): New variable.
> * gnu/packages/python-crypto.scm (python-ntlm-auth): New variable.
> * gnu/packages/python-crypto.scm (python-kerberos): New variable.
> ---
>  gnu/packages/python-crypto.scm | 56 ++++++++++++++++++++++++++++++++++
>  gnu/packages/python-web.scm    | 25 +++++++++++++++
>  gnu/packages/python-xyz.scm    | 31 +++++++++++++++++++
>  3 files changed, 112 insertions(+)
>
> diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
> index 63d3be17c2..61e1107248 100644
> --- a/gnu/packages/python-crypto.scm
> +++ b/gnu/packages/python-crypto.scm
> @@ -21,6 +21,7 @@
>  ;;; Copyright © 2018 Nam Nguyen <namn <at> berkeley.edu>
>  ;;; Copyright © 2019 Guillaume Le Vaillant <glv <at> posteo.net>
>  ;;; Copyright © 2019 Clément Lassieur <clement <at> lassieur.org>
> +;;; Copyright © 2020 Alexandros Theodotou <alex <at> zrythm.org>>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -45,6 +46,7 @@
>    #:use-module (gnu packages)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages crypto)
> +  #:use-module (gnu packages kerberos)
>    #:use-module (gnu packages libffi)
>    #:use-module (gnu packages multiprecision)
>    #:use-module (gnu packages protobuf)
> @@ -1135,3 +1137,57 @@ storing and retrieving sensitive information in your programs.")
>  package provides a tool to securely sign firmware images for booting by
>  MCUboot.")
>      (license license:expat)))
> +
> +(define-public python-ntlm-auth
> +  (package
> +    (name "python-ntlm-auth")
> +    (version "1.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "ntlm-auth" version))
> +       (sha256
> +        (base32
> +         "16mavidki4ma5ip8srqalr19gz4f5yn3cnmmgps1fmgfr24j63rm"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-cryptography" ,python-cryptography)))
> +    (home-page "https://github.com/jborean93/ntlm-auth")
> +    (synopsis
> +      "Calculates NTLM Authentication codes")
> +    (description
> +      "This library handles the low-level details of NTLM authentication for
> +use in authenticating with a service that uses NTLM.  It will create and parse
> +the 3 different message types in the order required and produce a base64
> +encoded value that can be attached to the HTTP header.
> +
> +The goal of this library is to offer full NTLM support including signing and
> +sealing of messages as well as supporting MIC for message integrity and the
> +ability to customise and set limits on the messages sent.  Please see Features
> +and Backlog for a list of what is and is not currently supported.")
> +    (license license:expat)))
> +
> +(define-public python-kerberos
> +  (package
> +    (name "python-kerberos")
> +    (version "1.3.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "kerberos" version))
> +       (sha256
> +        (base32
> +         "19663qxmma0i8bfbjc2iwy5hgq0g4pfb75r023v5dps68zfvffgh"))))
> +    (build-system python-build-system)
> +    (inputs
> +      `(("mit-krb5" ,mit-krb5)))
> +    (home-page "https://github.com/apple/ccs-pykerberos")
> +    (synopsis
> +      "Python Kerberos library used by CalendarServer")
> +    (description
> +      "This Python package is a high-level wrapper for Kerberos (GSSAPI)
> +operations.  The goal is to avoid having to build a module that wraps the
> +entire Kerberos.framework, and instead offer a limited set of functions that
> +do what is needed for client/server Kerberos authentication based on
> +<http://www.ietf.org/rfc/rfc4559.txt>.")
> +    (license license:asl2.0)))
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 179e64e0a1..7ea83808f0 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -31,6 +31,7 @@
>  ;;; Copyright © 2019 Brendan Tildesley <mail <at> brendan.scot>
>  ;;; Copyright © 2019 Pierre Langlois <pierre.langlois <at> gmx.com>
>  ;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
> +;;; Copyright © 2020 Alexandros Theodotou <alex <at> zrythm.org>>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3421,3 +3422,27 @@ Unicorn project.  The Gunicorn server is broadly compatible with
>  various web frameworks, simply implemented, light on server resources,
>  and fairly speedy.")
>    (license license:expat)))
> +
> +(define-public python-requests_ntlm
> +  (package
> +    (name "python-requests_ntlm")
> +    (version "1.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "requests_ntlm" version))
> +       (sha256
> +        (base32
> +         "0wgbqzaq9w7bas16b7brdb75f91bh3275fb459093bk1ihpck2ci"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-cryptography" ,python-cryptography)
> +       ("python-ntlm-auth" ,python-ntlm-auth)
> +       ("python-requests" ,python-requests)))
> +    (home-page "https://github.com/requests/requests-ntlm")
> +    (synopsis
> +      "NTLM authentication support for Requests")
> +    (description
> +      "This package allows for HTTP NTLM authentication using the requests
> +library.")
> +    (license license:isc)))
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index db43bd72e4..6e301a59ad 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -68,6 +68,7 @@
>  ;;; Copyright © 2019 Wiktor Żelazny <wzelazny <at> vurv.cz>
>  ;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
>  ;;; Copyright © 2019 Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>
> +;;; Copyright © 2020 Alexandros Theodotou <alex <at> zrythm.org>>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -107,6 +108,7 @@
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages graphviz)
>    #:use-module (gnu packages graphics)
> +  #:use-module (gnu packages gsasl)
>    #:use-module (gnu packages gstreamer)
>    #:use-module (gnu packages gtk)
>    #:use-module (gnu packages icu4c)
> @@ -17112,3 +17114,32 @@ scripts to load entry points more quickly.")
>  functional combinators.  Parser combinators are just higher-order functions
>  that take parsers as their arguments and return them as result values.")
>      (license license:expat)))
> +
> +(define-public python-pywinrm
> +  (package
> +    (name "python-pywinrm")
> +    (version "0.4.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "pywinrm" version))
> +       (sha256
> +        (base32
> +         "10gabhhg3rgacd5ahmi2r128z99fzbrbx6mz1nnq0dxmhmn5rpjf"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-six" ,python-six)
> +       ("python-requests_ntlm" ,python-requests_ntlm)
> +       ("python-xmltodict" ,python-xmltodict)
> +       ("python-kerberos" ,python-kerberos)))
> +    (native-inputs
> +      `(("python-mock" ,python-mock)
> +       ("python-pytest" ,python-pytest)))
> +    (home-page "https://github.com/diyan/pywinrm/")
> +    (synopsis
> +      "Python library for Windows Remote Management (WinRM)")
> +    (description
> +      "pywinrm is a Python client for the Windows Remote Management (WinRM)
> +service.  It allows you to invoke commands on target Windows machines from
> +any machine that can run Python.")
> +    (license license:expat)))

Hi Alexandros,

Thank you for your contribution! Could you please split these package
definitions into a patch series, rather than as a single patch? This is
preferable for how our Git workflow is utilized so that we can keep
track of packages individually in the commit log if we ever need to go
back and look at our records.

If you need help sending a patch series please do not hesistate to ask :).

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg <at> gnu.org> <brettg <at> posteo.net>




Information forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Wed, 08 Jan 2020 15:03:01 GMT) Full text and rfc822 format available.

Message #11 received at 38957 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Brett Gilio <brettg <at> gnu.org>
Cc: 38957 <at> debbugs.gnu.org
Subject: Re: [bug#38957] [PATCH] gnu: Add python-pywinrm
Date: Wed, 08 Jan 2020 15:02:26 +0000
[Message part 1 (text/plain, inline)]
Hi Brett,

Thanks for taking a look at this.

On Mon, 2020-01-06 at 03:22 -0600, Brett Gilio wrote:
> Could you please split these package
> definitions into a patch series, rather than as a single patch? This
> is
> preferable for how our Git workflow is utilized so that we can keep
> track of packages individually in the commit log if we ever need to
> go
> back and look at our records.

Attaching the split patches.

Thanks,
Alex
[0001-gnu-Add-python-kerberos.patch (text/x-patch, attachment)]
[0004-gnu-Add-python-pywinrm.patch (text/x-patch, attachment)]
[0003-gnu-Add-python-requests_ntlm.patch (text/x-patch, attachment)]
[0002-gnu-Add-python-ntlm-auth.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Sun, 22 Mar 2020 23:37:02 GMT) Full text and rfc822 format available.

Message #14 received at 38957 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 38957 <at> debbugs.gnu.org
Subject: [PATCH 4/4] gnu: Add python-pywinrm.
Date: Sun, 22 Mar 2020 23:36:45 +0000
From: Alexandros Theodotou <alex <at> zrythm.org>

* gnu/packages/python-xyz.scm (python-pywinrm): New variable.
---
 gnu/packages/python-xyz.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 65bc6df4aa..5ef459a589 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -70,6 +70,7 @@
 ;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;; Copyright © 2020 sirgazil <sirgazil <at> zoho.com>
 ;;; Copyright © 2020 Sebastian Schott <sschott <at> mailbox.org>
+;;; Copyright © 2020 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -110,6 +111,7 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages graphics)
+  #:use-module (gnu packages gsasl)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
@@ -5045,6 +5047,35 @@ localized only in frequency instead of in time and frequency.")
 (define-public python2-pywavelets
   (package-with-python2 python-pywavelets))
 
+(define-public python-pywinrm
+  (package
+    (name "python-pywinrm")
+    (version "0.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pywinrm" version))
+       (sha256
+        (base32
+         "10gabhhg3rgacd5ahmi2r128z99fzbrbx6mz1nnq0dxmhmn5rpjf"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-requests_ntlm" ,python-requests_ntlm)
+       ("python-xmltodict" ,python-xmltodict)
+       ("python-kerberos" ,python-kerberos)))
+    (native-inputs
+     `(("python-mock" ,python-mock)
+       ("python-pytest" ,python-pytest)))
+    (home-page "https://github.com/diyan/pywinrm/")
+    (synopsis
+     "Python library for Windows Remote Management (WinRM)")
+    (description
+     "pywinrm is a Python client for the Windows Remote Management (WinRM)
+service.  It allows you to invoke commands on target Windows machines from
+any machine that can run Python.")
+    (license license:expat)))
+
 (define-public python-xcffib
   (package
     (name "python-xcffib")
-- 
2.25.1





Information forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Sun, 22 Mar 2020 23:37:02 GMT) Full text and rfc822 format available.

Message #17 received at 38957 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 38957 <at> debbugs.gnu.org
Subject: [PATCH 2/4] gnu: Add python-ntlm-auth.
Date: Sun, 22 Mar 2020 23:36:43 +0000
From: Alexandros Theodotou <alex <at> zrythm.org>

* gnu/packages/python-crypto.scm (python-ntlm-auth): New variable.
---
 gnu/packages/python-crypto.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index e82599bb5f..0c4cfff959 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -1281,6 +1281,35 @@ package provides a tool to securely sign firmware images for booting by
 MCUboot.")
     (license license:expat)))
 
+(define-public python-ntlm-auth
+  (package
+    (name "python-ntlm-auth")
+    (version "1.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "ntlm-auth" version))
+       (sha256
+        (base32
+         "16mavidki4ma5ip8srqalr19gz4f5yn3cnmmgps1fmgfr24j63rm"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-cryptography" ,python-cryptography)))
+    (home-page "https://github.com/jborean93/ntlm-auth")
+    (synopsis
+      "Calculates NTLM Authentication codes")
+    (description
+      "This library handles the low-level details of NTLM authentication for
+use in authenticating with a service that uses NTLM.  It will create and parse
+the 3 different message types in the order required and produce a base64
+encoded value that can be attached to the HTTP header.
+
+The goal of this library is to offer full NTLM support including signing and
+sealing of messages as well as supporting MIC for message integrity and the
+ability to customise and set limits on the messages sent.  Please see Features
+and Backlog for a list of what is and is not currently supported.")
+    (license license:expat)))
+
 (define-public python-secretstorage
   (package
     (name "python-secretstorage")
-- 
2.25.1





Information forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Sun, 22 Mar 2020 23:37:02 GMT) Full text and rfc822 format available.

Message #20 received at 38957 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 38957 <at> debbugs.gnu.org
Subject: [PATCH 3/4] gnu: Add python-requests_ntlm.
Date: Sun, 22 Mar 2020 23:36:44 +0000
From: Alexandros Theodotou <alex <at> zrythm.org>

* gnu/packages/python-web.scm (python-requests_ntlm): New variable.
---
 gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b02ffd5f58..6f6b5fd4d3 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -33,6 +33,7 @@
 ;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;; Copyright © 2020 Evan Straw <evan.straw99 <at> gmail.com>
+;;; Copyright © 2020 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1422,6 +1423,30 @@ than Python’s urllib2 library.")
 (define-public python2-requests
   (package-with-python2 python-requests))
 
+(define-public python-requests_ntlm
+  (package
+    (name "python-requests_ntlm")
+    (version "1.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "requests_ntlm" version))
+       (sha256
+        (base32
+         "0wgbqzaq9w7bas16b7brdb75f91bh3275fb459093bk1ihpck2ci"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-cryptography" ,python-cryptography)
+       ("python-ntlm-auth" ,python-ntlm-auth)
+       ("python-requests" ,python-requests)))
+    (home-page "https://github.com/requests/requests-ntlm")
+    (synopsis
+      "NTLM authentication support for Requests")
+    (description
+      "This package allows for HTTP NTLM authentication using the requests
+library.")
+    (license license:isc)))
+
 (define-public python-requests-mock
   (package
     (name "python-requests-mock")
-- 
2.25.1





Information forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Sun, 22 Mar 2020 23:37:03 GMT) Full text and rfc822 format available.

Message #23 received at 38957 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 38957 <at> debbugs.gnu.org
Subject: [PATCH 1/4] gnu: Add python-kerberos.
Date: Sun, 22 Mar 2020 23:36:42 +0000
From: Alexandros Theodotou <alex <at> zrythm.org>

* gnu/packages/python-crypto.scm (python-kerberos): New variable.
---
 gnu/packages/python-crypto.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index 0601799c2b..e82599bb5f 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2018 Nam Nguyen <namn <at> berkeley.edu>
 ;;; Copyright © 2019 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2019 Clément Lassieur <clement <at> lassieur.org>
+;;; Copyright © 2020 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -45,6 +46,7 @@
   #:use-module (gnu packages)
   #:use-module (gnu packages check)
   #:use-module (gnu packages crypto)
+  #:use-module (gnu packages kerberos)
   #:use-module (gnu packages libffi)
   #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages password-utils)
@@ -309,6 +311,31 @@ etc.).  The package is structured to make adding new modules easy.")
             "python"
             (package-inputs pycrypto)))))))
 
+(define-public python-kerberos
+  (package
+    (name "python-kerberos")
+    (version "1.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "kerberos" version))
+       (sha256
+        (base32
+         "19663qxmma0i8bfbjc2iwy5hgq0g4pfb75r023v5dps68zfvffgh"))))
+    (build-system python-build-system)
+    (inputs
+      `(("mit-krb5" ,mit-krb5)))
+    (home-page "https://github.com/apple/ccs-pykerberos")
+    (synopsis
+      "Python Kerberos library used by CalendarServer")
+    (description
+      "This Python package is a high-level wrapper for Kerberos (GSSAPI)
+operations.  The goal is to avoid having to build a module that wraps the
+entire Kerberos.framework, and instead offer a limited set of functions that
+do what is needed for client/server Kerberos authentication based on
+<http://www.ietf.org/rfc/rfc4559.txt>.")
+    (license license:asl2.0)))
+
 (define-public python-keyring
   (package
     (name "python-keyring")
-- 
2.25.1





Information forwarded to guix-patches <at> gnu.org:
bug#38957; Package guix-patches. (Sun, 22 Mar 2020 23:40:01 GMT) Full text and rfc822 format available.

Message #26 received at 38957 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38957 <at> debbugs.gnu.org, Brett Gilio <brettg <at> gnu.org>
Subject: Re: [bug#38957] [PATCH] gnu: Add python-pywinrm
Date: Sun, 22 Mar 2020 23:39:13 +0000
[Message part 1 (text/plain, inline)]
Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi Brett,
>
> Thanks for taking a look at this.
>
> On Mon, 2020-01-06 at 03:22 -0600, Brett Gilio wrote:
>> Could you please split these package
>> definitions into a patch series, rather than as a single patch? This
>> is
>> preferable for how our Git workflow is utilized so that we can keep
>> track of packages individually in the commit log if we ever need to
>> go
>> back and look at our records.
>
> Attaching the split patches.

Hi Alexandros,

Sorry it's been so long to look more at these patches. I've had a look
today and they look good to me. I had to fix some merge conflicts, and I
changed the indentation in a couple of places, so I've sent the changed
patches to the bug now.

I'll let others take a look, and merge in a few days if it's all looking
good.

Thanks,

Chris
[signature.asc (application/pgp-signature, inline)]

Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Thu, 26 Mar 2020 19:16:02 GMT) Full text and rfc822 format available.

Notification sent to Alexandros Theodotou <alex <at> zrythm.org>:
bug acknowledged by developer. (Thu, 26 Mar 2020 19:16:02 GMT) Full text and rfc822 format available.

Message #31 received at 38957-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38957-done <at> debbugs.gnu.org
Subject: Re: [bug#38957] [PATCH] gnu: Add python-pywinrm
Date: Thu, 26 Mar 2020 19:15:49 +0000
[Message part 1 (text/plain, inline)]
Christopher Baines <mail <at> cbaines.net> writes:

> Alexandros Theodotou <alex <at> zrythm.org> writes:
>
>> Hi Brett,
>>
>> Thanks for taking a look at this.
>>
>> On Mon, 2020-01-06 at 03:22 -0600, Brett Gilio wrote:
>>> Could you please split these package
>>> definitions into a patch series, rather than as a single patch? This
>>> is
>>> preferable for how our Git workflow is utilized so that we can keep
>>> track of packages individually in the commit log if we ever need to
>>> go
>>> back and look at our records.
>>
>> Attaching the split patches.
>
> Hi Alexandros,
>
> Sorry it's been so long to look more at these patches. I've had a look
> today and they look good to me. I had to fix some merge conflicts, and I
> changed the indentation in a couple of places, so I've sent the changed
> patches to the bug now.
>
> I'll let others take a look, and merge in a few days if it's all looking
> good.

I've gone ahead and pushed these patches to master as
9b0c95cc6877229da0816e7b962090966a8577de.

Thanks Alexandros!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 24 Apr 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 361 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.