GNU bug report logs - #39004
[PATCH] gnu: pcmanfm-qt: fix open file issue

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39004 in the body.
You can then email your comments to 39004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: pcmanfm-qt: fix open file issue
Date: Tue, 07 Jan 2020 11:30:57 +0330

[Message part 1 (text/plain, inline)]

Hello,

following patch fix the open file by double-click issue in pcmanfm-qt 
which is previously reported on:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38926


--
Regards
Reza Alizadeh Majd
PantherX Team

[0001-gnu-pcmanfm-qt-fix-double-click-issue.patch (application/octet-stream, attachment)]

Message #8 received at 39004 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
Cc: 39004 <at> debbugs.gnu.org
Subject: Re: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
Date: Tue, 7 Jan 2020 10:52:14 +0100

[Message part 1 (text/plain, inline)]

Hi Reza,

thanks for the patch.  I think that it is the right way for now.

But GIO_LAUNCH_DESKTOP is not interpreted as a list by glib.

It would be better to communicate intent by constructing GIO_LAUNCH_DESKTOP as

               (wrap-program (string-append out "/bin/pcmanfm-qt")
                 `("GIO_LAUNCH_DESKTOP" =
                   (,(string-append glib "/bin/gio-launch-desktop"))))

.

Otherwise, with ":" and "prefix" it very much sounded like a list.

Also, could you make it check whether /bin/gio-launch-desktop exists and
error out otherwise?  That is in order for us to notice the workaround
later when we move the gio-launch-desktop executable.

(if (file-exists? ".........../bin/gio-launch-desktop")
    (wrap-program ........)
    (error "Could not find gio-launch-desktop"))

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 39004 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 39004 <at> debbugs.gnu.org
Subject: Re: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
Date: Tue, 07 Jan 2020 13:47:53 +0330

[Message part 1 (text/plain, inline)]

Hi Danny, 

On Tue, Jan 7, 2020, at 1:22 PM, Danny Milosavljevic wrote:
> Hi Reza,
> 
> thanks for the patch.  I think that it is the right way for now.
> 
> But GIO_LAUNCH_DESKTOP is not interpreted as a list by glib.
> 
> It would be better to communicate intent by constructing GIO_LAUNCH_DESKTOP as
> 
>                (wrap-program (string-append out "/bin/pcmanfm-qt")
>                  `("GIO_LAUNCH_DESKTOP" =
>                    (,(string-append glib "/bin/gio-launch-desktop"))))
> 
> .
> 
> Otherwise, with ":" and "prefix" it very much sounded like a list.
> 
> Also, could you make it check whether /bin/gio-launch-desktop exists and
> error out otherwise?  That is in order for us to notice the workaround
> later when we move the gio-launch-desktop executable.
> 
> (if (file-exists? ".........../bin/gio-launch-desktop")
>     (wrap-program ........)
>     (error "Could not find gio-launch-desktop"))
>


Thanks for your guidance, I updated the patch and applied both of 

- GIO_LAUNCH_DESKTOP variable format
- gio-launch-desktop existence check 

to this new patch. 


-- 
Regards
Reza Alizadeh Majd
PantherX Team

[0001-gnu-pcmanfm-qt-fix-double-click-issue.patch (application/octet-stream, attachment)]

Message #14 received at 39004 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: 39004 <at> debbugs.gnu.org
Subject: Re: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
Date: Sat, 11 Jan 2020 11:08:05 +0330

Hi, 

it could be great to have this patch merged, if there is no other issues 
 existed with this change. 

-- 
Regards
Reza Alizadeh Majd
PantherX Team

Message #19 received at 39004-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>, 39004-done <at> debbugs.gnu.org
Cc: 38926-done <at> debbugs.gnu.org
Subject: Re: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
Date: Sat, 11 Jan 2020 21:28:42 +0100

[Message part 1 (text/plain, inline)]

Hi Reza,

"Reza Alizadeh Majd" <r.majd <at> pantherx.org> writes:

> it could be great to have this patch merged, if there is no other issues 
>  existed with this change. 

I've applied the patch, with minor cosmetic adjustments (fixing typo,
naming the input "glib:bin" as we usually do), as well as a commit
message following our guidelines.

Thanks for the bug report and fix!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.