GNU bug report logs - #39013
[PATCH] gnu: Add abseil-cpp.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Roel Janssen <roel@HIDDEN>; Keywords: patch; dated Tue, 7 Jan 2020 15:08:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 39013 <at> debbugs.gnu.org:


Received: (at 39013) by debbugs.gnu.org; 9 Jan 2020 21:53:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 09 16:53:20 2020
Received: from localhost ([127.0.0.1]:53188 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ipfjz-0003j2-Tm
	for submit <at> debbugs.gnu.org; Thu, 09 Jan 2020 16:53:20 -0500
Received: from eggs.gnu.org ([209.51.188.92]:47105)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1ipfjz-0003iq-6z
 for 39013 <at> debbugs.gnu.org; Thu, 09 Jan 2020 16:53:19 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:36499)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1ipfjt-0002bM-WC
 for 39013 <at> debbugs.gnu.org; Thu, 09 Jan 2020 16:53:14 -0500
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58916 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1ipfjt-0001TD-6U; Thu, 09 Jan 2020 16:53:13 -0500
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Roel Janssen <roel@HIDDEN>
Subject: Re: [bug#39013] [PATCH] gnu: Add abseil-cpp.
References: <1f9fb8236e2a652ea4389c8d18b663307b275153.camel@HIDDEN>
Date: Thu, 09 Jan 2020 22:53:11 +0100
In-Reply-To: <1f9fb8236e2a652ea4389c8d18b663307b275153.camel@HIDDEN> (Roel
 Janssen's message of "Tue, 07 Jan 2020 16:07:21 +0100")
Message-ID: <87sgkos3eg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 39013
Cc: 39013 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Roel,

Roel Janssen <roel@HIDDEN> skribis:

> There are two not-so-perfect things with the patch:
> 1. I had to use the latest Git commit because it adds bits to build
> shared libraries.

Sounds good to me.

> 2. I disabled the tests because it attempts to download "googletest".=20
> I tried modifying the build system to use "googletest" from Guix but
> that wasn't succesful.

There are packages such as =E2=80=98encfs=E2=80=99 where we simply unpack t=
he source of
our =E2=80=98googletest=E2=80=99 package in the right place.  Would what wo=
rk here?

> From 06ed0284561463c087ec0f16f9c35fc7926f22df Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@HIDDEN>
> Date: Tue, 7 Jan 2020 16:02:28 +0100
> Subject: [PATCH] gnu: Add abseil-cpp.
>
> * gnu/packages/machine-learning.scm (abseil-cpp): New variable.

[...]

> +      (description "Abseil is an open-source collection of C++ library c=
ode

s/an open-source/a/

> +designed to augment the C++ standard library.  The Abseil library code is
> +collected from Google's own C++ code base, has been extensively tested a=
nd
> +used in production, and is the same code we depend on in our daily coding
> +lives.")

Who=E2=80=99s =E2=80=9Cwe=E2=80=9D?  :-)  Would be great if you could make =
that more factual.

Apart from that it LGTM.

Thanks,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#39013; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Jan 2020 15:07:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 07 10:07:31 2020
Received: from localhost ([127.0.0.1]:49027 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ioqSB-0000rV-El
	for submit <at> debbugs.gnu.org; Tue, 07 Jan 2020 10:07:31 -0500
Received: from lists.gnu.org ([209.51.188.17]:36889)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <roel@HIDDEN>) id 1ioqS9-0000rN-En
 for submit <at> debbugs.gnu.org; Tue, 07 Jan 2020 10:07:30 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:55434)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <roel@HIDDEN>) id 1ioqS7-0002Tj-Js
 for guix-patches@HIDDEN; Tue, 07 Jan 2020 10:07:28 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED,BAYES_50,
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48013)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <roel@HIDDEN>)
 id 1ioqS7-0004AB-DL
 for guix-patches@HIDDEN; Tue, 07 Jan 2020 10:07:27 -0500
Received: from [143.121.198.62] (port=57380 helo=cog147)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <roel@HIDDEN>) id 1ioqS4-0006Bv-38
 for guix-patches@HIDDEN; Tue, 07 Jan 2020 10:07:25 -0500
Message-ID: <1f9fb8236e2a652ea4389c8d18b663307b275153.camel@HIDDEN>
Subject: [PATCH] gnu: Add abseil-cpp.
From: Roel Janssen <roel@HIDDEN>
To: guix-patches@HIDDEN
Date: Tue, 07 Jan 2020 16:07:21 +0100
Content-Type: multipart/mixed; boundary="=-24IBmCLu/9UF+tUEzOl9"
X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 
Mime-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


--=-24IBmCLu/9UF+tUEzOl9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Dear Guix,

The following patch adds abseil-cpp.  I want to add it because it seems
to be a dependency of tensorflow-1.15.0 (which I am trying to update
to).

There are two not-so-perfect things with the patch:
1. I had to use the latest Git commit because it adds bits to build
shared libraries.
2. I disabled the tests because it attempts to download "googletest". 
I tried modifying the build system to use "googletest" from Guix but
that wasn't succesful.

Nevertheless, I hope this patch is acceptable.

Kind regards,
Roel Janssen


--=-24IBmCLu/9UF+tUEzOl9
Content-Disposition: attachment; filename="0001-gnu-Add-abseil-cpp.patch"
Content-Type: text/x-patch; name="0001-gnu-Add-abseil-cpp.patch"; charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSAwNmVkMDI4NDU2MTQ2M2MwODdlYzBmMTZmOWMzNWZjNzkyNmYyMmRmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2VsIEphbnNzZW4gPHJvZWxAZ251Lm9yZz4KRGF0ZTogVHVl
LCA3IEphbiAyMDIwIDE2OjAyOjI4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBBZGQgYWJz
ZWlsLWNwcC4KCiogZ251L3BhY2thZ2VzL21hY2hpbmUtbGVhcm5pbmcuc2NtIChhYnNlaWwtY3Bw
KTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNjbSB8
IDI4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNl
cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL21hY2hpbmUtbGVhcm5pbmcuc2Nt
IGIvZ251L3BhY2thZ2VzL21hY2hpbmUtbGVhcm5pbmcuc2NtCmluZGV4IDcxOTQwMWQ2OWEuLjkx
Y2M0ZmUwOTEgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNjbQor
KysgYi9nbnUvcGFja2FnZXMvbWFjaGluZS1sZWFybmluZy5zY20KQEAgLTEzMTYsNiArMTMxNiwz
NCBAQCBtaWxlIG9mIGRpc3RyaWJ1dGVkIGNvbXB1dGluZyB0byBjb25uZWN0IGRldmljZXMsIG1v
YmlsZSBhcHBsaWNhdGlvbnMgYW5kCiBicm93c2VycyB0byBiYWNrZW5kIHNlcnZpY2VzLiIpCiAg
ICAgKGxpY2Vuc2UgbGljZW5zZTphc2wyLjApKSkKIAorKGRlZmluZS1wdWJsaWMgYWJzZWlsLWNw
cAorICA7OyBXZSB1c2UgdGhpcyBjb21taXQgYmVjYXVzZSBpdCBjb250YWlucyBjaGFuZ2VzIHRv
IHRoZSBidWlsZCBzeXN0ZW0gdG8KKyAgOzsgYWxsb3cgYnVpbGRpbmcgc2hhcmVkIGxpYnJhcmll
cy4KKyAgKGxldCAoKGNvbW1pdCAiYTA0ODIwM2E4ODFmMTFmNGI3YjhkZjVmYjU2M2FlYzg1NTIy
ZjhkYiIpKQorICAgIChwYWNrYWdlCisgICAgICAobmFtZSAiYWJzZWlsLWNwcCIpCisgICAgICAo
dmVyc2lvbiAoc3RyaW5nLWFwcGVuZCAiMjAxOTA4MDgtIiAoc3RyaW5nLXRha2UgY29tbWl0IDcp
KSkKKyAgICAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgICAgIChtZXRob2QgZ2l0LWZl
dGNoKQorICAgICAgICAgICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAg
ICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vYWJzZWlsL2Fic2VpbC1jcHAuZ2l0IikK
KyAgICAgICAgICAgICAgICAgICAgICAoY29tbWl0IGNvbW1pdCkpKQorICAgICAgICAgICAgICAg
IChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgICAgICAg
ICAoc2hhMjU2CisgICAgICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAgICIx
M3YzYmtmeWhyY2w5YW0wamN6NGNmYmZjNXJuM2FjbTl6NHdtMDFwbjM2dmNndncybDRzIikpKSkK
KyAgICAgIChidWlsZC1zeXN0ZW0gY21ha2UtYnVpbGQtc3lzdGVtKQorICAgICAgKGFyZ3VtZW50
cyBgKCM6Y29uZmlndXJlLWZsYWdzIChsaXN0ICItREJVSUxEX1NIQVJFRF9MSUJTPU9OIikKKyAg
ICAgICAgICAgICAgICAgICAjOnRlc3RzPyAjZikpIDsgVGVzdHMgYXR0ZW1wdCB0byBkb3dubG9h
ZCBnb29nbGV0ZXN0LgorICAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9hYnNlaWwuaW8iKQorICAg
ICAgKHN5bm9wc2lzICJBdWdtZW50ZWQgQysrIHN0YW5kYXJkIGxpYnJhcnkiKQorICAgICAgKGRl
c2NyaXB0aW9uICJBYnNlaWwgaXMgYW4gb3Blbi1zb3VyY2UgY29sbGVjdGlvbiBvZiBDKysgbGli
cmFyeSBjb2RlCitkZXNpZ25lZCB0byBhdWdtZW50IHRoZSBDKysgc3RhbmRhcmQgbGlicmFyeS4g
IFRoZSBBYnNlaWwgbGlicmFyeSBjb2RlIGlzCitjb2xsZWN0ZWQgZnJvbSBHb29nbGUncyBvd24g
QysrIGNvZGUgYmFzZSwgaGFzIGJlZW4gZXh0ZW5zaXZlbHkgdGVzdGVkIGFuZAordXNlZCBpbiBw
cm9kdWN0aW9uLCBhbmQgaXMgdGhlIHNhbWUgY29kZSB3ZSBkZXBlbmQgb24gaW4gb3VyIGRhaWx5
IGNvZGluZworbGl2ZXMuIikKKyAgICAgIChsaWNlbnNlIGxpY2Vuc2U6YXNsMi4wKSkpKQorCiA7
OyBOb3RlIHRoYXQgVGVuc29yZmxvdyBpbmNsdWRlcyBhICJ0aGlyZF9wYXJ0eSIgZGlyZWN0b3J5
LCB3aGljaCBzZWVtcyB0byBub3QKIDs7IG9ubHkgY29udGFpbiBtb2RpZmllZCBzdWJzZXRzIG9m
IHVwc3RyZWFtIGxpYnJhcnkgc291cmNlIGNvZGUsIGJ1dCBhbHNvCiA7OyBhZGFwdGVyIGhlYWRl
cnMgcHJvdmlkZWQgYnkgR29vZ2xlIChzdWNoIGFzIHRoZSBmZnQuaCBoZWFkZXIsIHdoaWNoIGlz
IG5vdAotLSAKMi4xNy4xCgo=


--=-24IBmCLu/9UF+tUEzOl9--





Acknowledgement sent to Roel Janssen <roel@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#39013; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 9 Jan 2020 22:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.