X-Loop: help-debbugs@HIDDEN Subject: bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region' Resent-From: Alexander Shukaev <emacs@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 07 Jan 2020 16:20:01 +0000 Resent-Message-ID: <handler.39015.B.157841397810392 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 39015 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 39015 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.157841397810392 (code B ref -1); Tue, 07 Jan 2020 16:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2020 16:19:38 +0000 Received: from localhost ([127.0.0.1]:49100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1iorZy-0002hY-Kf for submit <at> debbugs.gnu.org; Tue, 07 Jan 2020 11:19:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:54458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <emacs@HIDDEN>) id 1iorZw-0002hR-T0 for submit <at> debbugs.gnu.org; Tue, 07 Jan 2020 11:19:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40785) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <emacs@HIDDEN>) id 1iorZv-0005lV-RB for bug-gnu-emacs@HIDDEN; Tue, 07 Jan 2020 11:19:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <emacs@HIDDEN>) id 1iorZu-0007Ej-Lz for bug-gnu-emacs@HIDDEN; Tue, 07 Jan 2020 11:19:35 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:46995) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <emacs@HIDDEN>) id 1iorZu-0007DN-GA for bug-gnu-emacs@HIDDEN; Tue, 07 Jan 2020 11:19:34 -0500 X-Originating-IP: 79.134.79.103 Received: from [192.168.0.110] (unknown [79.134.79.103]) (Authenticated sender: forum@HIDDEN) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CAAD12000D for <bug-gnu-emacs@HIDDEN>; Tue, 7 Jan 2020 16:19:30 +0000 (UTC) From: Alexander Shukaev <emacs@HIDDEN> Message-ID: <7da1738e-1e8a-3c12-31bf-741ee171db5c@HIDDEN> Date: Tue, 7 Jan 2020 17:19:29 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.200 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Not sure why in the first place `isearch-complete1' uses some custom auto-completion implementation that is different from a conventional solution, perhaps historical reasons. Thus, I believe that reusing either `completion-at-point' or `completion-in-region' to implement that functionality is much better in the long run. This would also allow packages, which customize completion behavior, to hook into `isearch' auto-completion as well. See also [1] for example. [1] https://github.com/abo-abo/swiper/issues/1882
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Alexander Shukaev <emacs@HIDDEN> Subject: bug#39015: Acknowledgement (`isearch-complete1' should use `completion-at-point' or `completion-in-region') Message-ID: <handler.39015.B.157841397810392.ack <at> debbugs.gnu.org> References: <7da1738e-1e8a-3c12-31bf-741ee171db5c@HIDDEN> X-Gnu-PR-Message: ack 39015 X-Gnu-PR-Package: emacs Reply-To: 39015 <at> debbugs.gnu.org Date: Tue, 07 Jan 2020 16:20:01 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 39015 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 39015: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39015 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region' Resent-From: Juri Linkov <juri@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 20 Jan 2020 00:43:02 +0000 Resent-Message-ID: <handler.39015.B39015.15794809643924 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 39015 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alexander Shukaev <emacs@HIDDEN> Cc: 39015 <at> debbugs.gnu.org Received: via spool by 39015-submit <at> debbugs.gnu.org id=B39015.15794809643924 (code B ref 39015); Mon, 20 Jan 2020 00:43:02 +0000 Received: (at 39015) by debbugs.gnu.org; 20 Jan 2020 00:42:44 +0000 Received: from localhost ([127.0.0.1]:44186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1itL9Q-00011E-91 for submit <at> debbugs.gnu.org; Sun, 19 Jan 2020 19:42:44 -0500 Received: from eastern.birch.relay.mailchannels.net ([23.83.209.55]:31059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1itL9O-000114-VR for 39015 <at> debbugs.gnu.org; Sun, 19 Jan 2020 19:42:43 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B91A1E1130; Mon, 20 Jan 2020 00:42:39 +0000 (UTC) Received: from pdx1-sub0-mail-a96.g.dreamhost.com (100-96-11-8.trex.outbound.svc.cluster.local [100.96.11.8]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 292C4E10C1; Mon, 20 Jan 2020 00:42:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from pdx1-sub0-mail-a96.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 20 Jan 2020 00:42:39 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN X-MailChannels-Auth-Id: dreamhost X-Shrill-Bored: 5e6bd6b4054c0cc1_1579480959573_686788688 X-MC-Loop-Signature: 1579480959573:2580974660 X-MC-Ingress-Time: 1579480959572 Received: from pdx1-sub0-mail-a96.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a96.g.dreamhost.com (Postfix) with ESMTP id 103F67F074; Sun, 19 Jan 2020 16:42:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=a8510jNaaDmQH2hLOQihq6rKY1w=; b= ssatTfY7vtCC79/FT9PJ7hrdRHJ0Sf896IGIRIihLb0O1iQgQLloKCQKry1kgviP vWgC59wR1SMp7nKw7QpIOKnSffm4id0lRFoNnniWW1tjBHx9qLaQZyqlSeA/xmG+ Gx2Mz/Ej06O3b1tbqLrCdM9EojL/tuty45GEFMyvhVo= Received: from mail.jurta.org (m91-129-103-201.cust.tele2.ee [91.129.103.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@HIDDEN) by pdx1-sub0-mail-a96.g.dreamhost.com (Postfix) with ESMTPSA id 698607F075; Sun, 19 Jan 2020 16:42:31 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a96 From: Juri Linkov <juri@HIDDEN> Organization: LINKOV.NET References: <7da1738e-1e8a-3c12-31bf-741ee171db5c@HIDDEN> Date: Mon, 20 Jan 2020 02:27:06 +0200 In-Reply-To: <7da1738e-1e8a-3c12-31bf-741ee171db5c@HIDDEN> (Alexander Shukaev's message of "Tue, 7 Jan 2020 17:19:29 +0100") Message-ID: <87v9p7km5h.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrudeggddvgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhgnhhurdhorhhgnecukfhppeeluddruddvledruddtfedrvddtudenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrddvtddupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvghmrggtshestehlvgigrghnuggvrhdrufhhuhhkrggvvhdrnhgrmhgvnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > Not sure why in the first place `isearch-complete1' uses some custom > auto-completion implementation that is different from a conventional > solution, perhaps historical reasons. Thus, I believe that reusing either > `completion-at-point' or `completion-in-region' to implement that > functionality is much better in the long run. This would also allow > packages, which customize completion behavior, to hook into `isearch' > auto-completion as well. See also [1] for example. > > [1] https://github.com/abo-abo/swiper/issues/1882 Based on this solution https://lists.gnu.org/archive/html/emacs-devel/2020-01/msg00447.html it should be possible to write a patch that would hook into `isearch' auto-completion. I seems I can't do this since I don't understand how to test it.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.