GNU logs - #39021, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#39021] [PATCH] Add Keybase
Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 07 Jan 2020 20:02:01 +0000
Resent-Message-ID: <handler.39021.B.157842726315822 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 39021 <at> debbugs.gnu.org
Date: Tue, 7 Jan 2020 21:00:39 +0100
From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Message-ID: <20200107200039.jga75muq7excgpqu@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="u552dxktsdzvxzzr"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--u552dxktsdzvxzzr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi Guix,

please find attached a set of patches that adds the non-GUI parts of
Keybase (the GUI is an Electron application - as far as I am aware,
there are no similar packages in Guix, so packaging the GUI requires a
significant amount of further work).

Unresolved question: in other distributions, the package provides user
units for systemd. Should the Guix package provide Shepherd services to
be ran as the user? If so, are there any other examples I could look at
and draw inspiration from? Also, I haven't been able to find any
documentation on how to set up user shepherd, apart from a passing
mention of that being possible in the documentation. I would appreciate
any pointers on the topic.

Regards,
Jakub Kądziołka

--u552dxktsdzvxzzr
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-build-system-go-Allow-providing-additional-build-fla.patch"
Content-Transfer-Encoding: 8bit

From 0d744787c48c7184a70dda9fc1bb2c0d334fc080 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Date: Sun, 5 Jan 2020 17:13:20 +0100
Subject: [PATCH 1/2] build-system/go: Allow providing additional build flags

* guix/build-system/go.scm (build-flags): New argument.
* guix/build/go-build-system.scm (build): Use apply to pass the
  additional arguments to invoke.
---
 guix/build-system/go.scm       | 3 +++
 guix/build/go-build-system.scm | 7 ++++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm
index 1b916af8f9..86f57079b1 100644
--- a/guix/build-system/go.scm
+++ b/guix/build-system/go.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Petter <petter@HIDDEN>
 ;;; Copyright © 2017 Leo Famulari <leo@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -82,6 +83,7 @@
                    (install-source? #t)
                    (import-path "")
                    (unpack-path "")
+                   (build-flags '())
                    (tests? #t)
                    (allow-go-reference? #f)
                    (system (%current-system))
@@ -109,6 +111,7 @@
                 #:install-source? ,install-source?
                 #:import-path ,import-path
                 #:unpack-path ,unpack-path
+                #:build-flags ,build-flags
                 #:tests? ,tests?
                 #:allow-go-reference? ,allow-go-reference?
                 #:inputs %build-inputs)))
diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm
index 4bc0156a88..49887848f6 100644
--- a/guix/build/go-build-system.scm
+++ b/guix/build/go-build-system.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016 Petter <petter@HIDDEN>
 ;;; Copyright © 2017, 2019 Leo Famulari <leo@HIDDEN>
 ;;; Copyright © 2019 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -209,18 +210,18 @@ unpacking."
                 (_ #f))
               inputs))))
 
-(define* (build #:key import-path #:allow-other-keys)
+(define* (build #:key import-path build-flags #:allow-other-keys)
   "Build the package named by IMPORT-PATH."
   (with-throw-handler
     #t
     (lambda _
-      (invoke "go" "install"
+      (apply invoke "go" "install"
               "-v" ; print the name of packages as they are compiled
               "-x" ; print each command as it is invoked
               ;; Respectively, strip the symbol table and debug
               ;; information, and the DWARF symbol table.
               "-ldflags=-s -w"
-              import-path))
+              `(,@build-flags ,import-path)))
     (lambda (key . args)
       (display (string-append "Building '" import-path "' failed.\n"
                               "Here are the results of `go env`:\n"))
-- 
2.24.1


--u552dxktsdzvxzzr
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment; filename="0002-gnu-Add-keybase.patch"
Content-Transfer-Encoding: 8bit

From 3de233a2d8e6bdb4723844337b69b6612616c9c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Date: Tue, 7 Jan 2020 20:29:21 +0100
Subject: [PATCH 2/2] gnu: Add keybase.

* gnu/packages/crypto.scm
  (keybase-component): New function.
  (keybase, git-remote-keybase, kbfs): New variables.
---
 gnu/packages/crypto.scm | 49 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index dd49c12e5b..c78515ae68 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2018 Tim Gesthuizen <tim.gesthuizen@HIDDEN>
 ;;; Copyright © 2019 Pierre Neidhardt <mail@HIDDEN>
 ;;; Copyright © 2019 Tanguy Le Carrour <tanguy@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -69,6 +70,7 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system perl)
   #:use-module (guix build utils)
   #:use-module (srfi srfi-1)
@@ -1040,3 +1042,50 @@ minisign uses a slightly different format to store secret keys.  Minisign
 signatures include trusted comments in addition to untrusted comments.
 Trusted comments are signed, thus verified, before being displayed.")
     (license license:isc)))
+
+(define* (keybase-component #:key name repo-path synopsis description)
+  (package
+    (name name)
+    (version "5.1.1")
+    (source (origin
+              (method url-fetch)
+              (uri
+                (string-append "https://github.com/keybase/client/releases/download/v"
+                               version "/keybase-v" version ".tar.xz"))
+              (sha256
+                (base32
+                  "1i6waaprdr89k3lrg36hn11f5z8j0n2iv6gpyrynbh2h128cfpwy"))))
+    (build-system go-build-system)
+    (arguments
+     `(#:import-path ,(string-append "github.com/keybase/client/go/" repo-path)
+       #:unpack-path "github.com/keybase/client"
+       #:build-flags '("-tags" "production")
+       #:install-source? #f))
+    (home-page "https://keybase.io")
+    (synopsis synopsis)
+    (description description)
+    (license license:bsd-3)))
+
+(define-public keybase
+  (keybase-component
+    #:name "keybase"
+    #:repo-path "keybase"
+    #:synopsis "Command-line client for Keybase"
+    #:description "Keybase is a key directory that maps social media identities
+to encryption keys in a publically auditable manner.  End-to-end encrypted chat,
+cloud storage and git hosting is also provided."))
+
+(define-public git-remote-keybase
+  (keybase-component
+    #:name "git-remote-keybase"
+    #:repo-path "kbfs/kbfsgit/git-remote-keybase"
+    #:synopsis "Git remote helper for Keybase encrypted repositories"
+    #:description "keybase-kbfsgit provides the git remote helper that handles
+@code{keybase://} URIs."))
+
+(define-public kbfs
+  (keybase-component
+    #:name "kbfs"
+    #:repo-path "kbfs/kbfsfuse"
+    #:synopsis "FUSE handler for the Keybase filesystem"
+    #:description "Handles mounting /keybase"))
-- 
2.24.1


--u552dxktsdzvxzzr--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Subject: bug#39021: Acknowledgement ([PATCH] Add Keybase)
Message-ID: <handler.39021.B.157842726315822.ack <at> debbugs.gnu.org>
References: <20200107200039.jga75muq7excgpqu@HIDDEN>
X-Gnu-PR-Message: ack 39021
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 39021 <at> debbugs.gnu.org
Date: Tue, 07 Jan 2020 20:02:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 39021 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
39021: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39021
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#39021] go package rebuilds
References: <20200107200039.jga75muq7excgpqu@HIDDEN>
In-Reply-To: <20200107200039.jga75muq7excgpqu@HIDDEN>
Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 24 Jan 2020 18:35:02 +0000
Resent-Message-ID: <handler.39021.B39021.157989087431360 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 39021 <at> debbugs.gnu.org
Cc: me@HIDDEN
Date: Fri, 24 Jan 2020 19:34:28 +0100
From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Message-ID: <20200124183428.iruqasedecsusbgw@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

With regards to the modification of go-build-system in this patchstack,
it seems that this would cause "only" <180 packages to be rebuilt:

~/guix$ rg -w go-build-system gnu/packages | wc -l
172
~/guix$ guix refresh --list-dependent go
Building the following 52 packages would ensure 176 dependent packages
are rebuilt: [...]

This has been discussed on IRC, and since some time has since passed, I
want to put the relevant link here, for future reference:
http://logs.guix.gnu.org/guix/2020-01-19.log#215122

Regards,
Jakub Kądziołka

Message sent to guix-patches@HIDDEN:

Subject: [bug#39021] [PATCH 1/2 v2] build-system/go: Allow providing additional build flags
References: <20200107200039.jga75muq7excgpqu@HIDDEN>
In-Reply-To: <20200107200039.jga75muq7excgpqu@HIDDEN>
Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 28 Jan 2020 21:55:01 +0000
Resent-Message-ID: <handler.39021.B39021.158024845131719 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 39021 <at> debbugs.gnu.org
Date: Tue, 28 Jan 2020 22:54:05 +0100
From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Message-ID: <20200128215405.b5nyh4tiewzxrjjq@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* guix/build-system/go.scm (build-flags): New argument.
* guix/build/go-build-system.scm (build): Use apply to pass the
  additional arguments to invoke.
---
I have discovered a bug when testing v1 of this patch locally - some Go
packages have been failing to build due to a quoting mishap. This is now
fixed.

Diff between patches:
-                   (build-flags '())
+                   (build-flags ''())
[this note should be automatically removed by git am]
---
 guix/build-system/go.scm       | 3 +++
 guix/build/go-build-system.scm | 7 ++++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm
index 1b916af8f9..f8ebaefb27 100644
--- a/guix/build-system/go.scm
+++ b/guix/build-system/go.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Petter <petter@HIDDEN>
 ;;; Copyright © 2017 Leo Famulari <leo@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -82,6 +83,7 @@
                    (install-source? #t)
                    (import-path "")
                    (unpack-path "")
+                   (build-flags ''())
                    (tests? #t)
                    (allow-go-reference? #f)
                    (system (%current-system))
@@ -109,6 +111,7 @@
                 #:install-source? ,install-source?
                 #:import-path ,import-path
                 #:unpack-path ,unpack-path
+                #:build-flags ,build-flags
                 #:tests? ,tests?
                 #:allow-go-reference? ,allow-go-reference?
                 #:inputs %build-inputs)))
diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm
index 4bc0156a88..49887848f6 100644
--- a/guix/build/go-build-system.scm
+++ b/guix/build/go-build-system.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016 Petter <petter@HIDDEN>
 ;;; Copyright © 2017, 2019 Leo Famulari <leo@HIDDEN>
 ;;; Copyright © 2019 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -209,18 +210,18 @@ unpacking."
                 (_ #f))
               inputs))))
 
-(define* (build #:key import-path #:allow-other-keys)
+(define* (build #:key import-path build-flags #:allow-other-keys)
   "Build the package named by IMPORT-PATH."
   (with-throw-handler
     #t
     (lambda _
-      (invoke "go" "install"
+      (apply invoke "go" "install"
               "-v" ; print the name of packages as they are compiled
               "-x" ; print each command as it is invoked
               ;; Respectively, strip the symbol table and debug
               ;; information, and the DWARF symbol table.
               "-ldflags=-s -w"
-              import-path))
+              `(,@build-flags ,import-path)))
     (lambda (key . args)
       (display (string-append "Building '" import-path "' failed.\n"
                               "Here are the results of `go env`:\n"))
-- 
2.25.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#39021] [PATCH] Add Keybase
Resent-From: Leo Famulari <leo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 08 Feb 2020 00:21:02 +0000
Resent-Message-ID: <handler.39021.B39021.158112123626543 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 39021
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Cc: 39021 <at> debbugs.gnu.org
Received: via spool by 39021-submit <at> debbugs.gnu.org id=B39021.158112123626543
          (code B ref 39021); Sat, 08 Feb 2020 00:21:02 +0000
Received: (at 39021) by debbugs.gnu.org; 8 Feb 2020 00:20:36 +0000
Received: from localhost ([127.0.0.1]:50470 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1j0DrQ-0006u3-DZ
	for submit <at> debbugs.gnu.org; Fri, 07 Feb 2020 19:20:36 -0500
Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:47423)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1j0DrO-0006tq-Rt
 for 39021 <at> debbugs.gnu.org; Fri, 07 Feb 2020 19:20:35 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 18B6044D;
 Fri,  7 Feb 2020 19:20:29 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Fri, 07 Feb 2020 19:20:29 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
 bh=pgdgQmg51U6MknYNeQxfQ4YdSEe4/3EQjMBOYu/ApN8=; b=i1adKXqsHT+d
 3XGMbhLl0T0QWF1XjWPGuk/5N+/NgoVfcn6oL11RngC+7zH/k7UmC/o40GtA2Zzi
 Ar1lal6V6T8N2hNQ1cUWtUb+GrHdIjt+6yOPVBvkuZyhzvnM7iOeFm3T2C0df++u
 gZKAGl7t4gS9Xq2FLVWFko+S3ZnO7r4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=pgdgQmg51U6MknYNeQxfQ4YdSEe4/3EQjMBOYu/Ap
 N8=; b=UdvS5M+SwAl99v/SSRz5U7pfamiJbi9PsOZaWbgnXT/EijUtXSDE6R3pY
 KuEOHDe5oKKOZarr1Y8hRRc6tuGowtZb8QNyiyTwammJ315gBrE9oCotykXBme7C
 BMrzajvXhBQVrOg+bQE2g2DZubiQacZr4W5lteS4fi3Jj4u519Jh45qJEkWgg7fU
 kUvb2hLxq8vEHhKTzEMIhkBlrQmxgd5DiiCTsCbXb90vsgv8O9S9iGxfZbCHe9/o
 Z8Cj3bz7ST0vqPygyov9Xvz9g2RXI8x2KT7I0ynZ0IK2RQwpD7mOGVCXtWry87g6
 kwxNGkmf99CRRK5AtB/rAqzQzFEVw==
X-ME-Sender: <xms:zP49Xq5qbvYw37AWWBYVtEfrHzL7pq87HTXRkwOLcPgf1YVl2au6vw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrheeigddvvdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjgesthekre
 dttddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr
 rhhirdhnrghmvgeqnecuffhomhgrihhnpeguthhhohhmphhsohhnrdhushdpghhithhhuh
 gsrdgtohhmnecukfhppedujedvrdehkedrvddtfedrudeikeenucevlhhushhtvghrufhi
 iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnh
 grmhgv
X-ME-Proxy: <xmx:zP49XnLn7omt15BBn1-LMEhIidAVM2cIYhV2_gW5KBxbJWmkg1T9Nw>
 <xmx:zP49XthjUKGj-Q_0LZBVw7azm4CiworG2AuX2b4KQKpa7uvijJ50MQ>
 <xmx:zP49XhLOmQz_9TSaJpCulWBNtsyhbjt-XOhRQs0DOplT41kg8tXycw>
 <xmx:zP49Xtl8e9Nk2H0DJD8uDM3rXqSjwDbDWxv0bYoYqEg5GzEr-SbDPg>
Received: from localhost (unknown [172.58.203.168])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4AD053280060;
 Fri,  7 Feb 2020 19:20:28 -0500 (EST)
Date: Fri, 7 Feb 2020 19:20:20 -0500
From: Leo Famulari <leo@HIDDEN>
Message-ID: <20200208002020.GD12194@HIDDEN>
References: <20200107200039.jga75muq7excgpqu@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200107200039.jga75muq7excgpqu@HIDDEN>
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Tue, Jan 07, 2020 at 09:00:39PM +0100, Jakub Kądziołka wrote:
> please find attached a set of patches that adds the non-GUI parts of
> Keybase (the GUI is an Electron application - as far as I am aware,
> there are no similar packages in Guix, so packaging the GUI requires a
> significant amount of further work).

I don't *think* we have any Electron packages, but we do have Chromium
(and qtwebengine) and Node.js, so I hope it's possible.

> Unresolved question: in other distributions, the package provides user
> units for systemd. Should the Guix package provide Shepherd services to
> be ran as the user? If so, are there any other examples I could look at
> and draw inspiration from? Also, I haven't been able to find any
> documentation on how to set up user shepherd, apart from a passing
> mention of that being possible in the documentation. I would appreciate
> any pointers on the topic.

We don't really do this kind of thing — adding features or service
manager files to upstream packages.

As for user shepherd, there's an example here:

https://git.dthompson.us/dotfiles.git/blob/HEAD:/dotfiles/.config/shepherd/init.scm

There's a lot going on there but the important parts are
(register-services ...), (make <service> ...), (action ...), and
(for-each start ...)

Then you just invoke `shepherd`.

> From 0d744787c48c7184a70dda9fc1bb2c0d334fc080 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
> Date: Sun, 5 Jan 2020 17:13:20 +0100
> Subject: [PATCH 1/2] build-system/go: Allow providing additional build flags
> 
> * guix/build-system/go.scm (build-flags): New argument.
> * guix/build/go-build-system.scm (build): Use apply to pass the
>   additional arguments to invoke.

Nice, LGTM!

> From 3de233a2d8e6bdb4723844337b69b6612616c9c5 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
> Date: Tue, 7 Jan 2020 20:29:21 +0100
> Subject: [PATCH 2/2] gnu: Add keybase.
> 
> * gnu/packages/crypto.scm
>   (keybase-component): New function.
>   (keybase, git-remote-keybase, kbfs): New variables.

This is enough of it's own thing that we can make a new (gnu packages
keybase) module.

> +(define* (keybase-component #:key name repo-path synopsis description)

We avoid abbreviations, so maybe "repository-path"? Bonus points if we
can make it more descriptive.

Can you take a look at the bundled ("vendored") dependencies:

https://github.com/keybase/client/tree/master/go/vendor

We strive to avoid using these, but sometimes we do, as in the Docker
package. It's not really idiomatic to unbundle things in Go. But we need
to at least make sure all the bundled dependencies are freely licensed.

Also, please run `guix lint` on these packages and make sure the
descriptions are written in complete sentences.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#39021] [PATCH] Add Keybase
Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 11 Feb 2020 16:37:02 +0000
Resent-Message-ID: <handler.39021.B39021.158143898717748 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 39021
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Leo Famulari <leo@HIDDEN>
Cc: 39021 <at> debbugs.gnu.org
Received: via spool by 39021-submit <at> debbugs.gnu.org id=B39021.158143898717748
          (code B ref 39021); Tue, 11 Feb 2020 16:37:02 +0000
Received: (at 39021) by debbugs.gnu.org; 11 Feb 2020 16:36:27 +0000
Received: from localhost ([127.0.0.1]:57416 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1j1YWR-0004cC-BL
	for submit <at> debbugs.gnu.org; Tue, 11 Feb 2020 11:36:27 -0500
Received: from pat.zlotemysli.pl ([37.59.186.212]:40448)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kuba@HIDDEN>) id 1j1YWP-0004c2-D0
 for 39021 <at> debbugs.gnu.org; Tue, 11 Feb 2020 11:36:26 -0500
Received: (qmail 27791 invoked by uid 1009); 11 Feb 2020 17:36:23 +0100
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
 (envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st 
 (clamdscan: 0.98.6/25720. spamassassin: 3.4.0. perlscan: 2.08st.  
 Clear:RC:1(188.123.215.55):. 
 Processed in 0.027707 secs); 11 Feb 2020 16:36:23 -0000
Received: from unknown (HELO gravity) (kuba@HIDDEN@188.123.215.55)
 by pat.zlotemysli.pl with SMTP; 11 Feb 2020 17:36:23 +0100
Date: Tue, 11 Feb 2020 17:36:54 +0100
From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Message-ID: <20200211163654.v5jz5bf7audo7unh@gravity>
References: <20200107200039.jga75muq7excgpqu@HIDDEN>
 <20200208002020.GD12194@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="3gvbgjxfgdn3uwba"
Content-Disposition: inline
In-Reply-To: <20200208002020.GD12194@HIDDEN>
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--3gvbgjxfgdn3uwba
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> > From 3de233a2d8e6bdb4723844337b69b6612616c9c5 Mon Sep 17 00:00:00 2001
> > From: =3D?UTF-8?q?Jakub=3D20K=3DC4=3D85dzio=3DC5=3D82ka?=3D <kuba@kadzi=
olka.net>
> > Date: Tue, 7 Jan 2020 20:29:21 +0100
> > Subject: [PATCH 2/2] gnu: Add keybase.
> >=20
> > * gnu/packages/crypto.scm
> >   (keybase-component): New function.
> >   (keybase, git-remote-keybase, kbfs): New variables.
>=20
> This is enough of it's own thing that we can make a new (gnu packages
> keybase) module.

Sure, will do.

> > +(define* (keybase-component #:key name repo-path synopsis description)
>=20
> We avoid abbreviations, so maybe "repository-path"? Bonus points if we
> can make it more descriptive.

I can't think of anything more descriptive, as it's literally the path
in the repository the component is at.

> Can you take a look at the bundled ("vendored") dependencies:
>=20
> https://github.com/keybase/client/tree/master/go/vendor
>=20
> We strive to avoid using these, but sometimes we do, as in the Docker
> package. It's not really idiomatic to unbundle things in Go. But we need
> to at least make sure all the bundled dependencies are freely licensed.

Apart from licensing concerns, what are the arguments for splitting this
into separate packages? I feel like this is just busywork...

> Also, please run `guix lint` on these packages and make sure the
> descriptions are written in complete sentences.

Ah, sure, somehow I forgot to do this before.

--3gvbgjxfgdn3uwba
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5C2CEACgkQ4xWnWEYT
FWRv+A//fqKTVj3IEWYOSUS7lHMiUYVpaQg/k5m0a9pmEP/L0BWegAhixRYrLKh6
fupoXjGxryPbKG6rOh2eiZ8F46lJSjrlPYyXdBgD5mwzQR/UZ7QuBKgu66BBPpiR
97JEMdPje6BO2ImYY+JlIeQWg1MpgrxmujqfGn3QeLxtD3w9HOtfSXsesU1n0gyb
GHxK6hzlXI6Q5al2aEfEmGK7OG4ycCwLgPoIrZH0g+VuyGpufxTDCa69TN6aNT1n
sqnuvizd1U0sfoDruVdphWCMGvyNrnzZTx8GHsYnd+i5yTTHYunQQ8f1ZoOgoFck
uR4Xfcw9sQ2ytoHWUB6TwEhiF/dT/QUTERBT+WApSAp+ksSVwN7ZskB6wAGHvuTk
G4D25zBk23gnDKeXj68zkmitQv/UqM8xirXQXOIV2195Q7+vNk1b8au9CIMSTNvC
HDnSKdNAhvzf3pb7kCsNadMQ2DgPl1M9xMxR8k2JxWwokWxPrh4N/9CM2jmYBs0e
1gWIxABbC79mJuZqSAHMVR0LFX41RWuFrYQWU1LwlrYBzj8XPq0/o62418q2uaob
mkEF8T03BpNEptHzj5UBzn7BZkmdQCPy8GmlTwRDJOL+1finU5QbGzejQZqkaNB6
S+elhku+3J/vTdFGoPAZPkO9QzH3fpep/0rJJbT6Ko0LRpaMwY4=
=3uIp
-----END PGP SIGNATURE-----

--3gvbgjxfgdn3uwba--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#39021] [PATCH] Add Keybase
Resent-From: Leo Famulari <leo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 11 Feb 2020 17:37:02 +0000
Resent-Message-ID: <handler.39021.B39021.158144260423239 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 39021
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
Cc: 39021 <at> debbugs.gnu.org
Received: via spool by 39021-submit <at> debbugs.gnu.org id=B39021.158144260423239
          (code B ref 39021); Tue, 11 Feb 2020 17:37:02 +0000
Received: (at 39021) by debbugs.gnu.org; 11 Feb 2020 17:36:44 +0000
Received: from localhost ([127.0.0.1]:57455 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1j1ZSm-00062l-2v
	for submit <at> debbugs.gnu.org; Tue, 11 Feb 2020 12:36:44 -0500
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43875)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1j1ZSj-00062X-RF
 for 39021 <at> debbugs.gnu.org; Tue, 11 Feb 2020 12:36:42 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id A60A04B3;
 Tue, 11 Feb 2020 12:36:35 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Tue, 11 Feb 2020 12:36:35 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
 bh=hi8xDAfyJTwvJSmZPj0AmcxeDx0LNioNOejPId5UOlc=; b=jLMfHKkNKSPU
 bC/e1/xsq3OK30evgZ5yhTl86tXQy6qse+vKTOGnw/ZdH75Vdk1+uZABgbl/76Xm
 86hfiXnhvjYPFQCk7KYIVoVsJWhXlPGRiwhWBCw1zcTTRjAO8MWJ2Am+c6YhUkqx
 u1fw41r49AYxXhSVKC6PoxRQ8O8V15E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=hi8xDAfyJTwvJSmZPj0AmcxeDx0LNioNOejPId5UO
 lc=; b=2vzDhCph1lsUPjqJMMs9P/hOgCfbFxm5li2js8KFlBCEKppEKVYVI8Zfp
 Mb4fKuKhTCvZdy2YduIwyCvvHKRC3Mn5HHB906ql70NvbkV9uTfCgPfPewkyVsnn
 2IaF4OoTH8S0VSUgci5gmGnIku3QOopI5yGSaq7ieIovSkv5L9s4XcQaZ+0rF8wa
 iH0t1TlSMR0qXu/h4Q3qJwHgPhUkDeXBkRtWeo+K7bZZGua7sWmlcChdZSBWOw0h
 jzQcSTONPy4/aFsiwo9YDCo0ABwRgQlZaJePB1oQIghAUPFLimJZuFvyiC6eJW7o
 /bO4u6pFursWeZmTqGpsO77LJ0nvA==
X-ME-Sender: <xms:IuZCXqPpcCITVRWs9Fk0lW0ze20xRDkiFK1j-y9IGn5FwJ7FVuP9Vg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrieefgdeliecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjgesthekre
 dttddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr
 rhhirdhnrghmvgeqnecukfhppeejiedruddvgedrudefkedrieefnecuvehluhhsthgvrh
 fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhi
 rdhnrghmvg
X-ME-Proxy: <xmx:IuZCXuP_HI-bBBgBxK2KLeR79_NdXg6XJvYR696D7a8zIryEewm1fw>
 <xmx:IuZCXj41z-BENGyeRJyqS9_a4lT6nAGBedSWwURLxB0jVAR0Yo4geQ>
 <xmx:IuZCXqZ7_nys_0inFxIVrYvhL19P6Qv24SWLgZTB2Opph8vWhi_DrQ>
 <xmx:I-ZCXv7VG-XHenovWUyEiIB9TUQuSWMFV5VjedQmgvCACIAhByiCgg>
Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63])
 by mail.messagingengine.com (Postfix) with ESMTPA id A37E330606FB;
 Tue, 11 Feb 2020 12:36:34 -0500 (EST)
Date: Tue, 11 Feb 2020 12:36:34 -0500
From: Leo Famulari <leo@HIDDEN>
Message-ID: <20200211173634.GB9442@HIDDEN>
References: <20200107200039.jga75muq7excgpqu@HIDDEN>
 <20200208002020.GD12194@HIDDEN>
 <20200211163654.v5jz5bf7audo7unh@gravity>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200211163654.v5jz5bf7audo7unh@gravity>
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Tue, Feb 11, 2020 at 05:36:54PM +0100, Jakub Kądziołka wrote:
> > We strive to avoid using these, but sometimes we do, as in the Docker
> > package. It's not really idiomatic to unbundle things in Go. But we need
> > to at least make sure all the bundled dependencies are freely licensed.
> 
> Apart from licensing concerns, what are the arguments for splitting this
> into separate packages? I feel like this is just busywork...

The question of licensing is unrelated to bundling, sorry if that wasn't
clear. The only thing you have to do here is make sure they are all
freely licensed.

To clarify, those bundled dependencies *are* separate packages,
developed by different organizations.

It's the standard in Guix (and every major GNU/Linux distro) to not
allow bundled dependencies because they make the graph of software
basically uninspectable and unmaintainable using the distro's normal
tools, as well as having the potential to waste time and space building
multiple versions of a package if it is bundled in more than one place
or already present as its own package. It negates all the advantages of
creating a distrubtion, especially for Go binaries, which can be
trivially deployed on any system, including Guix, without any extra
work.

But like I said, it's normal to bundle things in Go land, where there is
really no principled concept of dependency management or versioned
releases, and as time goes by changes to the Go compiler make it harder
and harder to unbundle. I did do it for Syncthing and I can confirm it
was a lot of work for no clear benefit. Excepting the standard library,
Go libraries do not even get security updates because nobody is looking
closely at them.

Last modified: Tue, 11 Feb 2020 17:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.