GNU bug report logs - #39039
[PATCH 2/2] gnu: Add zrythm.

Previous Next

Package: guix-patches;

Reported by: Alexandros Theodotou <alex <at> zrythm.org>

Date: Wed, 8 Jan 2020 14:37:01 UTC

Severity: normal

Tags: patch

Merged with 39038

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39039 in the body.
You can then email your comments to 39039 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#39039; Package guix-patches. (Wed, 08 Jan 2020 14:37:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alexandros Theodotou <alex <at> zrythm.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 08 Jan 2020 14:37:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH 2/2] gnu: Add zrythm.
Date: Wed, 08 Jan 2020 14:36:43 +0000
[Message part 1 (text/plain, inline)]
Hi,

Attaching the patch for Zrythm.

Thanks,
Alex
[0002-gnu-Add-zrythm.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#39039; Package guix-patches. (Thu, 09 Jan 2020 22:33:02 GMT) Full text and rfc822 format available.

Message #8 received at 39039 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 39039 <at> debbugs.gnu.org
Subject: Re: [bug#39039] [PATCH 2/2] gnu: Add zrythm.
Date: Thu, 9 Jan 2020 23:32:36 +0100
[Message part 1 (text/plain, inline)]
xdg-utils seems to only contain binaries.  Yet, zrythm is not patched to refer
to them.  Are you sure they are used?
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#39039; Package guix-patches. (Thu, 09 Jan 2020 22:45:02 GMT) Full text and rfc822 format available.

Message #11 received at 39039 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 39039 <at> debbugs.gnu.org
Subject: Re: [bug#39039] [PATCH 2/2] gnu: Add zrythm.
Date: Thu, 09 Jan 2020 22:44:30 +0000
[Message part 1 (text/plain, inline)]
Hi Danny,

It calls xdg-open at runtime using popen(), to open directories in the
user's file browser app. See io_open_directory() in src/utils/io.c.

Thanks,
Alex

On Thu, 2020-01-09 at 23:32 +0100, Danny Milosavljevic wrote:
> xdg-utils seems to only contain binaries.  Yet, zrythm is not patched
> to refer
> to them.  Are you sure they are used?
[signature.asc (application/pgp-signature, inline)]

Merged 39038 39039. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 27 Jan 2020 22:07:02 GMT) Full text and rfc822 format available.

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 27 Jan 2020 22:20:02 GMT) Full text and rfc822 format available.

Notification sent to Alexandros Theodotou <alex <at> zrythm.org>:
bug acknowledged by developer. (Mon, 27 Jan 2020 22:20:02 GMT) Full text and rfc822 format available.

Message #18 received at 39039-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 39039-done <at> debbugs.gnu.org
Subject: Re: [bug#39039] [PATCH 2/2] gnu: Add zrythm.
Date: Mon, 27 Jan 2020 23:19:22 +0100
[Message part 1 (text/plain, inline)]
Hi,

Alexandros Theodotou <alex <at> zrythm.org> skribis:

> From 008f999d55f995b41de02bdd02de9fb4042653b3 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Wed, 8 Jan 2020 14:31:05 +0000
> Subject: [PATCH 2/2] gnu: Add zrythm.
>
> * gnu/packages/music.scm (zrythm): New variable.

I’ve applied the patch.

However, note that zrythm doesn’t keep any run-time reference to
‘xdg-utils’:

  guix gc --references \
  /gnu/store/6ahg92sk3akaspbvcd8vawkndjq97rf3-zrythm-0.7.345 |grep xdg-
  # nothing

That means that, at run time, it won’t find ‘xdg-open’ unless the user
explicitly adds it to their profile.  Could you take a look?

Furthermore, I get the usual:

--8<---------------cut here---------------start------------->8---
$ /gnu/store/6ahg92sk3akaspbvcd8vawkndjq97rf3-zrythm-0.7.345/bin/zrythm
[…]
(zrythm:31567): GLib-GIO-ERROR **: 23:13:27.284: Settings schema 'org.zrythm.Zrythm.preferences' is not installed

(zrythm:31567): GLib-GIO-ERROR **: 23:13:27.284: Settings schema 'org.zrythm.Zrythm' is not installed
Spurumo-/romppunkto-komando
--8<---------------cut here---------------end--------------->8---

… hence the attached patch, which I applied.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 55c66a8081..e378e9880b 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5152,9 +5152,9 @@ and as an LV2 plugin.")
           (base32
             "1csiwq38a1ckx23lairfpl7qjkz71wsa7a9vsxl3k58f9ybibiil"))))
    (build-system meson-build-system)
-   (outputs '("out"))
    (arguments
-    `(#:configure-flags
+    `(#:glib-or-gtk? #t
+      #:configure-flags
       `("-Denable_tests=true" "-Dmanpage=true"
         "-Dinstall_dseg_font=false" "-Denable_ffmpeg=true")))
    (inputs

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 27 Jan 2020 22:20:02 GMT) Full text and rfc822 format available.

Notification sent to Alexandros Theodotou <alex <at> zrythm.org>:
bug acknowledged by developer. (Mon, 27 Jan 2020 22:20:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 25 Feb 2020 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 33 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.