GNU bug report logs - #39094
27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message

Previous Next

Package: emacs;

Reported by: <lin.sun <at> zoom.us>

Date: Sun, 12 Jan 2020 08:07:01 UTC

Severity: normal

Tags: patch

Merged with 38014, 38416

Found in versions 26.3.50, 27.0.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39094 in the body.
You can then email your comments to 39094 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#39094; Package emacs. (Sun, 12 Jan 2020 08:07:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to <lin.sun <at> zoom.us>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 12 Jan 2020 08:07:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: <lin.sun <at> zoom.us>
To: <bug-gnu-emacs <at> gnu.org>,
	"'Eli Zaretskii'" <eliz <at> gnu.org>
Subject: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in
 makefile-move-to-macro to avoid error message
Date: Sun, 12 Jan 2020 16:06:43 +0800
[Message part 1 (text/plain, inline)]
Hi Eli,

The attachment is a patch to fix the complaint message from `makefile-move-to-macro' for the param for re-search-forward isn't escaped.
To reproduce the issue, just run follow commands in your shell,
$ echo 'AM_LIBTMP_LIBS:=$(shell X \--libs)' > /tmp/Makefile.am
$ emacs -Q --eval '(progn (global-ede-mode t)(semantic-mode t)(find-file "/tmp/Makefile.am"))'

Could you please review and apply the patch? 
Thank you.

B.R.
Lin Sun
[0001-Fix-the-error-message-from-makefile-move-to-macro.patch (application/octet-stream, attachment)]

Merged 38014 38416 39094. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 12 Jan 2020 13:59:01 GMT) Full text and rfc822 format available.

Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Fri, 17 Jan 2020 00:13:02 GMT) Full text and rfc822 format available.

Notification sent to <lin.sun <at> zoom.us>:
bug acknowledged by developer. (Fri, 17 Jan 2020 00:13:02 GMT) Full text and rfc822 format available.

Message #12 received at 39094-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Lin Sun <lin.sun <at> zoom.us>
Cc: 39094-done <at> debbugs.gnu.org
Subject: regexp-quote the param in makefile-move-to-macro to avoid error
 message
Date: Thu, 16 Jan 2020 16:12:01 -0800
Thanks for reporting that bug. I installed your patch into the master 
branch.




Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Fri, 17 Jan 2020 00:13:02 GMT) Full text and rfc822 format available.

Notification sent to <lin.sun <at> zoom.us>:
bug acknowledged by developer. (Fri, 17 Jan 2020 00:13:02 GMT) Full text and rfc822 format available.

Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Fri, 17 Jan 2020 00:13:02 GMT) Full text and rfc822 format available.

Notification sent to LinSun <lin.sun <at> zoom.us>:
bug acknowledged by developer. (Fri, 17 Jan 2020 00:13:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39094; Package emacs. (Fri, 17 Jan 2020 01:58:02 GMT) Full text and rfc822 format available.

Message #25 received at 39094-done <at> debbugs.gnu.org (full text, mbox):

From: <lin.sun <at> zoom.us>
To: "'Paul Eggert'" <eggert <at> cs.ucla.edu>
Cc: 39094-done <at> debbugs.gnu.org
Subject: RE: regexp-quote the param in makefile-move-to-macro to avoid error
 message
Date: Fri, 17 Jan 2020 09:57:09 +0800
>Thanks for reporting that bug. I installed your patch into the master branch.
Thank you Paul.





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#39094; Package emacs. (Fri, 17 Jan 2020 08:18:02 GMT) Full text and rfc822 format available.

Message #28 received at 39094 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 39094 <at> debbugs.gnu.org, lin.sun <at> zoom.us
Subject: Re: bug#39094: regexp-quote the param in makefile-move-to-macro to
 avoid error message
Date: Fri, 17 Jan 2020 10:17:23 +0200
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Thu, 16 Jan 2020 16:12:01 -0800
> Cc: 39094-done <at> debbugs.gnu.org
> 
> Thanks for reporting that bug. I installed your patch into the master 
> branch.

Thanks, but such safe bugfixes should go to the release branch.  I've
cherry-picked it now.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 16 Feb 2020 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 42 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.