GNU bug report logs - #39108
[PATCH] gnu: Add gst-editing-services.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39108 in the body.
You can then email your comments to 39108 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add gst-editing-services.
Date: Mon, 13 Jan 2020 00:40:27 +0100

* gnu/packages/gstreamer (gst-editing-services): New variable.
---
 gnu/packages/gstreamer.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 323e3ccfee..14dbf5a7ed 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -419,6 +419,37 @@ distribution problems in some jurisdictions, e.g. due to patent threats.")
 compression formats through the use of the libav library.")
     (license license:gpl2+)))
 
+(define-public gst-editing-services
+  (package
+    (name "gst-editing-services")
+    (version "1.16.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://gstreamer.freedesktop.org/src/" name "/"
+                    "gstreamer-editing-services-" version ".tar.xz"))
+              (sha256
+               (base32
+                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
+    (build-system gnu-build-system)
+    (arguments
+     ;; TODO: 16/22 failing tests with meson, 21 with gnu
+     `(#:tests? #f))
+    (inputs
+     `(("gst-plugins-base" ,gst-plugins-base)
+       ("libxml2" ,libxml2)))
+    (native-inputs
+     `(("flex" ,flex)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python)))
+    (home-page "https://gstreamer.freedesktop.org/")
+    (synopsis "GStreamer library for non-linear editors")
+    (description
+     "This is a high-level library for facilitating the creation of audio/video
+non-linear editors.")
+    (license license:gpl2+)))
+
 (define-public python-gst
   (package
     (name "python-gst")
-- 
2.24.1

Message #8 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Mon, 13 Jan 2020 23:48:18 +0100

[Message part 1 (text/plain, inline)]

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> * gnu/packages/gstreamer (gst-editing-services): New variable.

Thanks!

[...]
  
> +(define-public gst-editing-services
> +  (package
> +    (name "gst-editing-services")
> +    (version "1.16.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://gstreamer.freedesktop.org/src/" name "/"
> +                    "gstreamer-editing-services-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
> +    (build-system gnu-build-system)

IIRC gstreamer will no longer support gnu-build-system starting with
1.18.  So let's just go straight for Meson here, WDYT?

If you're up for it, it would be good to change the other gstreamer
packages already as well, to make the transition easier.

> +    (arguments
> +     ;; TODO: 16/22 failing tests with meson, 21 with gnu
> +     `(#:tests? #f))

When so many tests are failing, it is typically a sign that a dependency
or file is missing, e.g. execve("/bin/sh" ...) somewhere.  Can you try
to figure out what is causing these failures?

Otherwise LGTM, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Marius Bakke <mbakke <at> fastmail.com>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Tue, 14 Jan 2020 01:39:38 +0100

Am Montag, den 13.01.2020, 23:48 +0100 schrieb Marius Bakke:
> Leo Prikler <leo.prikler <at> student.tugraz.at> writes:
> 
> > * gnu/packages/gstreamer (gst-editing-services): New variable.
> 
> Thanks!
> 
> [...]
>   
> > +(define-public gst-editing-services
> > +  (package
> > +    (name "gst-editing-services")
> > +    (version "1.16.2")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > +                    "https://gstreamer.freedesktop.org/src/" name
> > "/"
> > +                    "gstreamer-editing-services-" version
> > ".tar.xz"))
> > +              (sha256
> > +               (base32
> > +                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc
> > 1hf"))))
> > +    (build-system gnu-build-system)
> 
> IIRC gstreamer will no longer support gnu-build-system starting with
> 1.18.  So let's just go straight for Meson here, WDYT?
Sure, why not?  It would at least build, though I've "tested" only the
gnu version in terms of actual editing capabilities (some lightweight
clip mixing).

> If you're up for it, it would be good to change the other gstreamer
> packages already as well, to make the transition easier.
> 
> > +    (arguments
> > +     ;; TODO: 16/22 failing tests with meson, 21 with gnu
> > +     `(#:tests? #f))
> 
> When so many tests are failing, it is typically a sign that a
> dependency
> or file is missing, e.g. execve("/bin/sh" ...) somewhere.  Can you
> try
> to figure out what is causing these failures?
Not easily, sadly.  Gstreamer 1.16.2 broke for me in some quite
interesting ways, even outside of packaging, and I have little trust in
my ability to fix it – other than applying some kind of workaround for
my personal use.  (See 39126 for details.)
From what I recall, most of the failing tests are not even failing,
they are erroring, outputting some critical message and a stack trace. 
The problem here is, that you get get critical errors if even just one
element inside a large pipeline behaves badly.  Of course, you can get
the same kind of error, but with a different message, if the plugin
can't even be found.

As far as building gstreamer with meson is concerned, I can look into
it, but the gstreamer package itself has 400 dependants and thus
belongs to staging.  I'm not quite sure whether we can get
implementation + reviews done before the 19th, but let's see what's
possible.

Regards,
Leo

Message #14 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Marius Bakke <mbakke <at> fastmail.com>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Wed, 15 Jan 2020 13:53:08 +0100

[Message part 1 (text/plain, inline)]

I composed a patch in which all of the basic gstreamer stuff (sans
python bindings) are ported to meson.  Perhaps someone might want this
patch to be split, so that each package is modified separately, but I
find that we can treat this as a logical unit as-is.

Of particular note is the disabling of the doc output.  It appears as
if gstreamer really does not know how to build documentation in meson
without the not-yet packaged hotdoc.  However, with there being fewer
dependencies on the plugins rather than gstreamer itself, it should be
possible to port them later.

Finally, I've noticed that gst-plugins-base builds without gl or
wayland support.  Should I add a patch for this or is it fine as-is?

Regards,
Leo

[0002-gnu-Port-gstreamer-to-meson-build-system.patch (text/x-patch, attachment)]

Message #17 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Marius Bakke <mbakke <at> fastmail.com>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Thu, 23 Jan 2020 13:31:47 +0100

[Message part 1 (text/plain, inline)]

I've noticed, that staging gstreamer builds with meson now, resolving
this part of the discussion.  I've also noticed some cosmetic errors in
my initial patch, so I'm sending updated versions, one for master and
one for staging (only offsets appear to differ), so that the patch
keeps working after an eventual merge.

Regards,
Leo

[0001-master-gnu-Add-gst-editing-services.patch (text/x-patch, attachment)]

[0001-staging-gnu-Add-gst-editing-services.patch (text/x-patch, attachment)]

Message #20 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Marius Bakke <mbakke <at> fastmail.com>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Tue, 11 Feb 2020 17:12:57 +0100

Am Donnerstag, den 23.01.2020, 13:31 +0100 schrieb Leo Prikler:
> I've noticed, that staging gstreamer builds with meson now, resolving
> this part of the discussion.  I've also noticed some cosmetic errors
> in
> my initial patch, so I'm sending updated versions, one for master and
> one for staging (only offsets appear to differ), so that the patch
> keeps working after an eventual merge.
Just ensuring this is not forgotten.  Since staging is merged now, the
staging patch is the one to apply.

Message #23 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Fri, 14 Feb 2020 16:58:46 +0100

[Message part 1 (text/plain, inline)]

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> I've noticed, that staging gstreamer builds with meson now, resolving
> this part of the discussion.  I've also noticed some cosmetic errors in
> my initial patch, so I'm sending updated versions, one for master and
> one for staging (only offsets appear to differ), so that the patch
> keeps working after an eventual merge.

Oh no, I missed that you had alredy ported GStreamer to the Meson build
system in a previous email!  Sorry for the duplicate work.

I notice in this patch that gst-editing-services still uses
gnu-build-system, can you update it to use meson-build-system instead?

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Marius Bakke <mbakke <at> fastmail.com>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Fri, 14 Feb 2020 17:09:01 +0100

[Message part 1 (text/plain, inline)]

Am Freitag, den 14.02.2020, 16:58 +0100 schrieb Marius Bakke:
> Oh no, I missed that you had alredy ported GStreamer to the Meson
> build
> system in a previous email!  Sorry for the duplicate work.
> 
> I notice in this patch that gst-editing-services still uses
> gnu-build-system, can you update it to use meson-build-system
> instead?
Ahh, my bad.  Updated version is attached.

[0001-gnu-Add-gst-editing-services.patch (text/x-patch, attachment)]

Message #29 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Fri, 14 Feb 2020 17:12:35 +0100

[Message part 1 (text/plain, inline)]

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> Am Freitag, den 14.02.2020, 16:58 +0100 schrieb Marius Bakke:
>> Oh no, I missed that you had alredy ported GStreamer to the Meson
>> build
>> system in a previous email!  Sorry for the duplicate work.
>> 
>> I notice in this patch that gst-editing-services still uses
>> gnu-build-system, can you update it to use meson-build-system
>> instead?
> Ahh, my bad.  Updated version is attached.

I'm getting a strange build failure with this patch:


...
Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2
Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and cmake)

tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig dependency

A full log can be found at /tmp/guix-build-gst-editing-services-1.16.2.drv-0/build/meson-logs/meson-log.txt

I suppose it needs 'gst-plugins-bad'?

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 39108 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Marius Bakke <mbakke <at> fastmail.com>, 39108 <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Fri, 14 Feb 2020 17:42:12 +0100

[Message part 1 (text/plain, inline)]

Am Freitag, den 14.02.2020, 17:12 +0100 schrieb Marius Bakke:
> I'm getting a strange build failure with this patch:
> 
> 
> ...
> Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2
> Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and
> cmake)
> 
> tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig
> dependency
> 
> A full log can be found at /tmp/guix-build-gst-editing-services-
> 1.16.2.drv-0/build/meson-logs/meson-log.txt
> 
> I suppose it needs 'gst-plugins-bad'?
Indeed, it does, though interestingly just for tests, which are
currently broken.  I already had this back when I tried meson, but have
since forgot about it.  There are no actual references to it, so I've
made it a native input.  As far as using it is concerned, I think one
might be able to do without a certain set of plugins depending on the
codecs used.  Either way, I'm not really sure whether it should
propagate the main plugin set.

I also added the good plugins even if they are not mentioned, just to
be on the safe side.  

[0001-gnu-Add-gst-editing-services.patch (text/x-patch, attachment)]

Message #37 received at 39108-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 39108-done <at> debbugs.gnu.org
Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Date: Fri, 14 Feb 2020 17:51:07 +0100

[Message part 1 (text/plain, inline)]

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> Am Freitag, den 14.02.2020, 17:12 +0100 schrieb Marius Bakke:
>> I'm getting a strange build failure with this patch:
>> 
>> 
>> ...
>> Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2
>> Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and
>> cmake)
>> 
>> tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig
>> dependency
>> 
>> A full log can be found at /tmp/guix-build-gst-editing-services-
>> 1.16.2.drv-0/build/meson-logs/meson-log.txt
>> 
>> I suppose it needs 'gst-plugins-bad'?
> Indeed, it does, though interestingly just for tests, which are
> currently broken.  I already had this back when I tried meson, but have
> since forgot about it.  There are no actual references to it, so I've
> made it a native input.  As far as using it is concerned, I think one
> might be able to do without a certain set of plugins depending on the
> codecs used.  Either way, I'm not really sure whether it should
> propagate the main plugin set.
>
> I also added the good plugins even if they are not mentioned, just to
> be on the safe side.  

OK.  I changed the TODO to a FIXME and added a copyright line for you.

Pushed in 64fc4f3705423c83c680a95d8dea81a39fce9a70, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.