GNU bug report logs - #39146
[PATCH] gnu: icecat: Remove compiler paths from about:buildconfig

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Jakub Kądziołka <kuba@HIDDEN>; Keywords: patch; dated Wed, 15 Jan 2020 22:22:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 39146 <at> debbugs.gnu.org:


Received: (at 39146) by debbugs.gnu.org; 22 Jan 2020 20:13:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 15:13:34 2020
Received: from localhost ([127.0.0.1]:51395 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iuMNW-0006qw-EZ
	for submit <at> debbugs.gnu.org; Wed, 22 Jan 2020 15:13:34 -0500
Received: from tobias.gr ([80.241.217.52]:60772)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1iuMNT-0006qj-Gl
 for 39146 <at> debbugs.gnu.org; Wed, 22 Jan 2020 15:13:28 -0500
Received: by tobias.gr (OpenSMTPD) with ESMTP id 56170c57;
 Wed, 22 Jan 2020 20:13:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:date:message-id:mime-version:content-type
 :content-transfer-encoding; s=2018; i=me@HIDDEN; bh=NAstZ3MqJ
 Bqtpclwe0gXOa8qXd2+jbv6l6InFy//TLM=; b=Hz3Tj06I11AaB8sGu5m0v+LXS
 wdtI3u5pEinyOA0vqxfj28JRDFRVLeR739/JD85xMTrAq81onAsFdFVjuA/kDrro
 QJKCMg/mI/5GtZZqBPl3rQxrqVZZUL/vThhEPZBbKfYCFmK++ZfWTXCT54xlcBm3
 TgfYiuEoFhP+g/1HuR2n/afTVxIaDIPgtbgFXI3tIU0gvh/ccOSb1iTvqYei6IZB
 yi66RQ0rn1a5Zrmk3ZdJ28p+JwDTvTYQlUOvdVrA0HzCAbbYItqAn2cqnIpr6LMw
 yE5vdRb6KL7DBPLz0q5+DoJSyMzZ/NcGFdjxngxkKtxZRsUc2iPafcsKLVs+A==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 3871112c
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 22 Jan 2020 20:13:25 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: 39146 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: icecat: Remove about:buildconfig store references.
Date: Wed, 22 Jan 2020 21:13:13 +0100
Message-Id: <20200122201313.27946-1-me@HIDDEN>
X-Mailer: git-send-email 2.24.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 39146
Cc: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/gnuzilla.scm (icecat)[arguments]:
New ‘neutralise-store-references’ phase.

Reported-by: Jakub Kądziołka <kuba@HIDDEN>
---

So,

Here's a version that correctly calls %store-directory.  Tested again, output looks the same.

Jakub: I accidentally kept your copyright line in v1, but didn't actually use your code (although part of your comment survives :-).  Is the Reported-by above acceptable?

Kind regards,

T G-R

 gnu/packages/gnuzilla.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index ae0c58eedb..96c3c78e98 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -7,7 +7,7 @@
 ;;; Copyright © 2016 Alex Griffin <a@HIDDEN>
 ;;; Copyright © 2017 Clément Lassieur <clement@HIDDEN>
 ;;; Copyright © 2017 ng0 <ng0@HIDDEN>
-;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@HIDDEN>
+;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice <me@HIDDEN>
 ;;; Copyright © 2018 Ricardo Wurmus <rekado@HIDDEN>
 ;;; Copyright © 2019 Ivan Petkov <ivanppetkov@HIDDEN>
 ;;; Copyright © 2020 Oleg Pykhalov <go.wigust@HIDDEN>
@@ -1067,6 +1067,15 @@ from forcing GEXP-PROMISE."
                                 (force-output)
                                 (retry (- remaining-attempts 1))))
                        (apply build args)))))))
+         (add-after 'build 'neutralise-store-references
+           (lambda _
+             ;; Mangle the store references to compilers & other build tools in
+             ;; about:buildconfig, reducing IceCat's closure by 1 GiB on x86-64.
+             (substitute*
+                 "dist/bin/chrome/toolkit/content/global/buildconfig.html"
+               (((format #f "(~a/)([0-9a-z]{32})" (%store-directory)) _ store hash)
+                (string-append store (string-take hash 8) "…")))
+             #t))
          (add-before 'configure 'install-desktop-entry
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Install the '.desktop' file.
-- 
2.23.0





Information forwarded to guix-patches@HIDDEN:
bug#39146; Package guix-patches. Full text available.

Message received at 39146 <at> debbugs.gnu.org:


Received: (at 39146) by debbugs.gnu.org; 22 Jan 2020 14:39:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 09:39:34 2020
Received: from localhost ([127.0.0.1]:49322 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iuHAM-0008OX-2h
	for submit <at> debbugs.gnu.org; Wed, 22 Jan 2020 09:39:34 -0500
Received: from pat.zlotemysli.pl ([37.59.186.212]:55584)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kuba@HIDDEN>) id 1iuHAJ-0008ON-S5
 for 39146 <at> debbugs.gnu.org; Wed, 22 Jan 2020 09:39:32 -0500
Received: (qmail 10902 invoked by uid 1009); 22 Jan 2020 15:39:29 +0100
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
 (envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st 
 (clamdscan: 0.98.6/25702. spamassassin: 3.4.0. perlscan: 2.08st.  
 Clear:RC:1(188.123.215.55):. 
 Processed in 0.02435 secs); 22 Jan 2020 14:39:29 -0000
Received: from unknown (HELO zdrowyportier.kadziolka.net)
 (kuba@HIDDEN@188.123.215.55)
 by pat.zlotemysli.pl with SMTP; 22 Jan 2020 15:39:29 +0100
Date: Wed, 22 Jan 2020 15:39:28 +0100
From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN>
To: Tobias Geerinckx-Rice <me@HIDDEN>, 39146 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: icecat: Remove about:buildconfig store references.
Message-ID: <20200122143928.6cr5vc6vbspjqkrf@HIDDEN>
References: <20200122013406.3476-1-me@HIDDEN>
 <20200122135107.73z6upacjwial3zq@HIDDEN>
 <87o8uvlgnn.fsf@nckx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87o8uvlgnn.fsf@nckx>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 39146
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wed, Jan 22, 2020 at 03:19:06PM +0100, Tobias Geerinckx-Rice wrote:
> Jakub,
> 
> Did you mean to send this off-list?  Either's fine by me.
Whoops, not at all. I need to configure mutt to default to
reply-to-all... adding the list back into CC.

> Jakub Kądziołka 写道:
> > Firstly, note that /gnu/store/ is not guaranteed to be the store path,
> > since this parameter can be changed by passing --with-store-dir to
> > ./configure.
> 
> Er, whoops, of course.  I was going to replace that after testing. By the
> time they'd finished I'd forgot.
> 
> > I assume you tested this patch? When I tried to do my substitutions
> > after the expansion is done, but before the files are packaged into
> > a zip-like file, I couldn't find a good place to hook in the build.
> 
> Indeed.  The result is stored in lib/icecat/omni.ja, which is an
> uncompressed (so GC works) zip file.
> 
> > Also, there's already some code to help with removing references in
> > guix/build/utils.scm (remove-store-references), but the result you get
> > with what you're proposing seems much more user-friendly.
> 
> Heh, thank you!  That's intentional.  :-)
> 
> Remove-store-references' length-preservation is great in some cases
> (compiled executables, binary data, weird code, …) but this wasn't a good
> fit.
> 
> Thanks for taking a look; I'll test & send a (%store-directory) fix.  Thanks
> for your enthousiastic contributions to Guix in general.

A short while after switching to Guix, I read this on Reddit:
| If you're looking to just use one of these distros without actively
| contributing back, I'd go with NixOS right now. If you're an enthusiast
| that wants to contribute to one of these two projects, GuixSD needs more
| help to reach critical mass.
( -- https://www.reddit.com/r/NixOS/comments/9zwiee/nixos_vs_guixsd/eb6zqcu/)
This, together with the fact that Guix is quite easy to hack on, has
inspired me to contribute.

> > Looks like you haven't updated your git in a while ;)
> 
> Nope, just other people's.
> 
> My Guix sqlite DB was corrupted beyond repair in December, I've been limping
> along using ‘guix pack’s from my build farm ever since, because it was never
> the ‘right time’ to reinstall…
>
> I blame Guix for making that even possible and relatively painless.
>
> Kind regards,
> 
> T G-R
> 




Information forwarded to guix-patches@HIDDEN:
bug#39146; Package guix-patches. Full text available.

Message received at 39146 <at> debbugs.gnu.org:


Received: (at 39146) by debbugs.gnu.org; 22 Jan 2020 01:34:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 21 20:34:25 2020
Received: from localhost ([127.0.0.1]:48765 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iu4uX-0004RD-3A
	for submit <at> debbugs.gnu.org; Tue, 21 Jan 2020 20:34:25 -0500
Received: from tobias.gr ([80.241.217.52]:53228)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1iu4uU-0004R0-K0
 for 39146 <at> debbugs.gnu.org; Tue, 21 Jan 2020 20:34:24 -0500
Received: by tobias.gr (OpenSMTPD) with ESMTP id f3444ebd;
 Wed, 22 Jan 2020 01:34:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:date:message-id:mime-version:content-type
 :content-transfer-encoding; s=2018; i=me@HIDDEN; bh=/BYX/sPQ+
 1mf8WkSFgMfsLWpMBCMB0nmmgYNZnzQ92I=; b=lT1XmB59+4DdRgR2HJYFLSZ/C
 aHaX43X1BBkhg7GQzpJSINn0ZraS1IJH9Va+ZAnSd50s5MejzX0vVJouO3E1r8nn
 W0gcrCgby5MBsfDHVDm0tMVAHMK3kq+/Tr5hnZMujibI+HDck+aQ8bc12TefrKLf
 M2H0w2VDWLOkU0JAgtbqz/FnyUOSN/zlFe4h0SP+YPUukZBFijkGe4H40EXtwVB4
 NFNNMKdw5ULLXLUrTMHjc30DZsoTNdwL1BUVKE01KWVod0bz00sRb++W7FM+s/8e
 8q659gp9wcaCJBzQFIpbY8etgEHnKOPUnSyRUFKNUoIbWvyEULCakhT7oT4Kg==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 03307af9
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 22 Jan 2020 01:34:20 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: 39146 <at> debbugs.gnu.org
Subject: [PATCH] gnu: icecat: Remove about:buildconfig store references.
Date: Wed, 22 Jan 2020 02:34:06 +0100
Message-Id: <20200122013406.3476-1-me@HIDDEN>
X-Mailer: git-send-email 2.24.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 39146
Cc: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

* gnu/packages/gnuzilla.scm (icecat)[arguments]:
New ‘neutralise-store-references’ phase.

Reported-by: Jakub Kądziołka <kuba@HIDDEN>
---

Jakub, IceCats,

What do you think of this attempt at robustness?  Any drawbacks I've missed?

Kind regards,

T G-R

 gnu/packages/gnuzilla.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index ae0c58eedb..d4a793971c 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2018 Ricardo Wurmus <rekado@HIDDEN>
 ;;; Copyright © 2019 Ivan Petkov <ivanppetkov@HIDDEN>
 ;;; Copyright © 2020 Oleg Pykhalov <go.wigust@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1067,6 +1068,15 @@ from forcing GEXP-PROMISE."
                                 (force-output)
                                 (retry (- remaining-attempts 1))))
                        (apply build args)))))))
+         (add-after 'build 'neutralise-store-references
+           (lambda _
+             ;; Mangle the store references to compilers & other build tools in
+             ;; about:buildconfig, reducing IceCat's closure by 1 GiB on x86-64.
+             (substitute*
+                 "dist/bin/chrome/toolkit/content/global/buildconfig.html"
+               (("(/gnu/store/)([0-9a-z]{32})" all store hash)
+                (string-append store (string-take hash 8) "…")))
+             #t))
          (add-before 'configure 'install-desktop-entry
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Install the '.desktop' file.
-- 
2.23.0





Information forwarded to guix-patches@HIDDEN:
bug#39146; Package guix-patches. Full text available.

Message received at 39146 <at> debbugs.gnu.org:


Received: (at 39146) by debbugs.gnu.org; 21 Jan 2020 18:06:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 21 13:06:05 2020
Received: from localhost ([127.0.0.1]:48442 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1itxua-0002Cs-No
	for submit <at> debbugs.gnu.org; Tue, 21 Jan 2020 13:06:05 -0500
Received: from tobias.gr ([80.241.217.52]:39578)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1itxuU-0002Cg-0m
 for 39146 <at> debbugs.gnu.org; Tue, 21 Jan 2020 13:05:59 -0500
Received: by tobias.gr (OpenSMTPD) with ESMTP id 30efd8a3
 for <39146 <at> debbugs.gnu.org>; Tue, 21 Jan 2020 18:05:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=Ia+crO20Ya7OY9pTpgeghH
 ARbb3Ox5YwsFF0IH6Zn4M=; b=ajI+QsysOhnAj6g8sZNFn+k12CHaQ+Ck2v9Tik
 5IoKI6J0cVOBciH8uJZohI03uopZYDf+CXDaISM4vBUVezaBpqlfuJsSGhed+aXH
 YCHn/5Kj9lfgEEP629AT1CFZqLuT5eJpNPw4znx3E5fCIqJ+AEpOArxD4Z/8dlAM
 Bc15HMk0+dYmw3Sd1SebkKsiJBgkaEusD62Hxp2VD1diUlYgdnpRiw3IyDIswh2l
 K8PTEGlcj5Ug7NX5ZgqOcvjY/huy7xvZGlBpRWo5oge6PzgsQw+CcgDNQw31ukL0
 wj6WiPXjZWhGFVZaG+gn/IcM9UAo/R/Ck8jdCJ/PgpySATaA==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 69721d98
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <39146 <at> debbugs.gnu.org>;
 Tue, 21 Jan 2020 18:05:51 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: 39146 <at> debbugs.gnu.org
Subject: Re: [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from
 about:buildconfig
References: <20200115222115.322ymuuqkwlnbl3v@HIDDEN>
 <20200121173711.5gegrl233dtjneni@HIDDEN>
In-reply-to: <20200121173711.5gegrl233dtjneni@HIDDEN>
Date: Tue, 21 Jan 2020 19:05:52 +0100
Message-ID: <87pnfcadmn.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 39146
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Jakub,

Jakub K=C4=85dzio=C5=82ka =E5=86=99=E9=81=93=EF=BC=9A
> +         (add-after 'unpack 'dont-store-compiler-paths
> +           (lambda _
> +             ;; Remove references to the compilers used from=20
> the output. Reduces
> +             ;; `guix size icecat' by 1 GiB on x86-64.
> +             (let ((zap "Store reference removed"))
> +               (substitute* "toolkit/content/buildconfig.html"
> +                 (("@CC@") zap)
> +                 (("@CXX@") zap)
> +                 (("@RUSTC@") zap)
> +                 (("@MOZ_CONFIGURE_OPTIONS@") zap)))))

Thanks!  This is a fine fix, but I wonder if you know where/how=20
this file is processed by the build system?  I think scanning for=20
and neutralising any store reference in the final HTML would be=20
less error-prone.

Thoughts?

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl4nPYAACgkQ2Imw8BjF
STyPnxAAsDRHnbr7nV8huW7TSkhi7bNZB/NTDi28JxSZTZ1uMcFv4jpeNJSA0ygv
FIRbg/oaSpB+dggMzXbE9tQQ+Uiod/U3a7TVu2moCJ5WbhPanTsfF0ysIwipsF/C
lJUpKsxhO+xRS70BvEJlm9cTTle13dej+8Q2f4BE3vv9A/fr5K+69yMRxHgd9lgf
9RpIVM9IGjJX0XtftyAju3RXJP+RZ/oU0jv3xFtTEnCaXKCvP0UnqmRcKsXw9X2D
NvPWIo0n2RKjH4TMc8Ub4YKyCFaoa+B5feAu5yg1S0YgBJ94p4n1o1fAQ5//XjXi
51SeHHS4jFkx47qG0TQ6UryQmewDgpTrfLa9rY4vsdmfYBuB/ajeNyhyPQjZuXnT
9XRsNVhObSOyehEqEBbKeYYqWjT3gO5kiLZY0KkqJIaPb06TUGXqCbfve7QfI+DM
KgZqehpAiFZiVyI+i9mN5nfi1BAh/3MSKqzN8HcunVMvNFI3mwq8OTiKsxKor1oL
9nbhoCB0U4z8/g5KUaXHIJZxhkvR6ygcvvEm4qUewa7ggRmiTgAAiDY0qb97EjYm
ZnJNYwJNm3ARaLImQp3K2lrfXvsW3bxg2bS5ZA0J5Q9iiVnY7569VIDavRUy5hUH
YijGNdh6K5lmfrSwXUKF1wXGdXUiA24NFISZeyIC5FhLaUCzLgk=
=Ke1n
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#39146; Package guix-patches. Full text available.

Message received at 39146 <at> debbugs.gnu.org:


Received: (at 39146) by debbugs.gnu.org; 21 Jan 2020 17:52:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 21 12:52:21 2020
Received: from localhost ([127.0.0.1]:48408 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1itxhJ-0008IO-Ai
	for submit <at> debbugs.gnu.org; Tue, 21 Jan 2020 12:52:21 -0500
Received: from dd26836.kasserver.com ([85.13.145.193]:36694)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1itxhD-0008IA-3O
 for 39146 <at> debbugs.gnu.org; Tue, 21 Jan 2020 12:52:16 -0500
Received: from localhost (089144220057.atnat0029.highway.webapn.at
 [89.144.220.57])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id D5AA03368239;
 Tue, 21 Jan 2020 18:52:07 +0100 (CET)
Date: Tue, 21 Jan 2020 18:52:02 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
To: Mark H Weaver <mhw@HIDDEN>
Subject: Re: [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from
 about:buildconfig
Message-ID: <20200121185202.4cfbdc37@HIDDEN>
In-Reply-To: <20200121173711.5gegrl233dtjneni@HIDDEN>
References: <20200115222115.322ymuuqkwlnbl3v@HIDDEN>
 <20200121173711.5gegrl233dtjneni@HIDDEN>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/bmP3AAnmQYLWWuJMWX6lznC";
 protocol="application/pgp-signature"; micalg=pgp-sha256
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 39146
Cc: Jakub =?utf-8?Q?K=C4=85dzio=C5=82ka?= <kuba@HIDDEN>,
 Marius Bakke <mbakke@HIDDEN>, 39146 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--Sig_/bmP3AAnmQYLWWuJMWX6lznC
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Mark,

since we have to touch Rust anyway, the icecat patch from Jakub below could=
 also
go to guix staging.

Is the patch OK?  Should we do it?

--Sig_/bmP3AAnmQYLWWuJMWX6lznC
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4nOkIACgkQ5xo1VCww
uqX5Rwf+K43re5qCuPBnebeoxybnm/rOxrM7K1RpxB5x3iB3i5M8GlAHVP1R0AlW
obBv38xJ+/zAciW5G4BsBGaEm99Wc69kWJ/iRIhooMT/w8gVHkBScGxGDZ6P7yr/
6ZDIJqbXs2LOLme+w4kzyWAQUTCDvABdjfBvXjmPe0CSv8845Z9iJfqCPI/qSlL0
my78StN0sdjeKTDMRCrhN7AdneHxOF5ksI9/7smxcUDTtEQzdx0IOYvBZETGtPdX
4/lxZ07GRgePA3X3eORQ2f0zo1plMTkv69VCa3vgMUT6EYbTMWC/HfkiWiuO2lLN
9kdgLUwCuOQbah0Q9NvCLz0RbAJ1ww==
=2A7a
-----END PGP SIGNATURE-----

--Sig_/bmP3AAnmQYLWWuJMWX6lznC--




Information forwarded to guix-patches@HIDDEN:
bug#39146; Package guix-patches. Full text available.

Message received at 39146 <at> debbugs.gnu.org:


Received: (at 39146) by debbugs.gnu.org; 21 Jan 2020 17:37:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 21 12:37:24 2020
Received: from localhost ([127.0.0.1]:48386 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1itxSr-0007tV-Gu
	for submit <at> debbugs.gnu.org; Tue, 21 Jan 2020 12:37:24 -0500
Received: from pat.zlotemysli.pl ([37.59.186.212]:60444)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kuba@HIDDEN>) id 1itxSm-0007tI-11
 for 39146 <at> debbugs.gnu.org; Tue, 21 Jan 2020 12:37:19 -0500
Received: (qmail 16253 invoked by uid 1009); 21 Jan 2020 18:37:13 +0100
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
 (envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st 
 (clamdscan: 0.98.6/25701. spamassassin: 3.4.0. perlscan: 2.08st.  
 Clear:RC:1(188.123.215.55):. 
 Processed in 0.008782 secs); 21 Jan 2020 17:37:13 -0000
Received: from unknown (HELO zdrowyportier.kadziolka.net)
 (kuba@HIDDEN@188.123.215.55)
 by pat.zlotemysli.pl with SMTP; 21 Jan 2020 18:37:13 +0100
Date: Tue, 21 Jan 2020 18:37:11 +0100
From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN>
To: 39146 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: icecat: Remove compiler paths from about:buildconfig
Message-ID: <20200121173711.5gegrl233dtjneni@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 39146
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/gnuzilla.scm
  (icecat)[arguments](dont-store-compiler-paths): New phase.
---
 gnu/packages/gnuzilla.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index ae0c58eedb..d32333ca96 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2018 Ricardo Wurmus <rekado@HIDDEN>
 ;;; Copyright © 2019 Ivan Petkov <ivanppetkov@HIDDEN>
 ;;; Copyright © 2020 Oleg Pykhalov <go.wigust@HIDDEN>
+;;; Copyright © 2020 Jakub Kądziołka <kuba@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -906,6 +907,16 @@ from forcing GEXP-PROMISE."
                                       "-p1" "--input" file))))
                          (or native-inputs inputs)))
              #t))
+         (add-after 'unpack 'dont-store-compiler-paths
+           (lambda _
+             ;; Remove references to the compilers used from the output. Reduces
+             ;; `guix size icecat' by 1 GiB on x86-64.
+             (let ((zap "Store reference removed"))
+               (substitute* "toolkit/content/buildconfig.html"
+                 (("@CC@") zap)
+                 (("@CXX@") zap)
+                 (("@RUSTC@") zap)
+                 (("@MOZ_CONFIGURE_OPTIONS@") zap)))))
          (add-after 'apply-guix-specific-patches 'remove-bundled-libraries
            (lambda _
              ;; Remove bundled libraries that we don't use, since they may
-- 
2.25.0





Information forwarded to guix-patches@HIDDEN:
bug#39146; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 15 Jan 2020 22:21:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 15 17:21:23 2020
Received: from localhost ([127.0.0.1]:36437 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1irr2R-0005yF-Kb
	for submit <at> debbugs.gnu.org; Wed, 15 Jan 2020 17:21:23 -0500
Received: from lists.gnu.org ([209.51.188.17]:37375)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kuba@HIDDEN>) id 1irr2P-0005y8-OV
 for submit <at> debbugs.gnu.org; Wed, 15 Jan 2020 17:21:22 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35559)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <kuba@HIDDEN>) id 1irr2O-0000NV-PV
 for guix-patches@HIDDEN; Wed, 15 Jan 2020 17:21:21 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE,
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <kuba@HIDDEN>) id 1irr2N-0006NP-OO
 for guix-patches@HIDDEN; Wed, 15 Jan 2020 17:21:20 -0500
Received: from pat.zlotemysli.pl ([37.59.186.212]:39754)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <kuba@HIDDEN>) id 1irr2N-0006MG-EK
 for guix-patches@HIDDEN; Wed, 15 Jan 2020 17:21:19 -0500
Received: (qmail 5381 invoked by uid 1009); 15 Jan 2020 23:21:17 +0100
Received: from 188.123.215.55 (kuba@HIDDEN@188.123.215.55) by pat
 (envelope-from <kuba@HIDDEN>, uid 1002) with qmail-scanner-2.08st 
 (clamdscan: 0.98.6/25695. spamassassin: 3.4.0. perlscan: 2.08st.  
 Clear:RC:1(188.123.215.55):. 
 Processed in 0.008668 secs); 15 Jan 2020 22:21:17 -0000
Received: from unknown (HELO zdrowyportier.kadziolka.net)
 (kuba@HIDDEN@188.123.215.55)
 by pat.zlotemysli.pl with SMTP; 15 Jan 2020 23:21:17 +0100
Date: Wed, 15 Jan 2020 23:21:15 +0100
From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= <kuba@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: icecat: Remove compiler paths from about:buildconfig
Message-ID: <20200115222115.322ymuuqkwlnbl3v@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 37.59.186.212
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

* gnu/packages/gnuzilla.scm
  (icecat)[arguments](dont-store-compiler-paths): New phase.
---
 gnu/packages/gnuzilla.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index c619cd5d55..ae155e51ba 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -890,6 +890,16 @@ from forcing GEXP-PROMISE."
              (substitute* '("browser/confvars.sh")
                (("MOZ_SERVICES_SYNC=0") "MOZ_SERVICES_SYNC=1"))
              #t))
+         (add-after 'unpack 'dont-store-compiler-paths
+           (lambda _
+             ;; Remove references to the compilers used from the output. Reduces
+             ;; `guix size icecat' by 1 GiB on x86-64.
+             (let ((zap "Store reference removed"))
+               (substitute* "toolkit/content/buildconfig.html"
+                 (("@CC@") zap)
+                 (("@CXX@") zap)
+                 (("@RUSTC@") zap)
+                 (("@MOZ_CONFIGURE_OPTIONS@") zap)))))
          (add-after 'unpack 'apply-guix-specific-patches
            (lambda* (#:key inputs native-inputs #:allow-other-keys)
              (let ((patch (string-append (assoc-ref (or native-inputs inputs)
-- 
2.24.1





Acknowledgement sent to Jakub Kądziołka <kuba@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#39146; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 22 Jan 2020 20:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.