GNU bug report logs - #39180
27.0.50; [PATCH] Use expressions as memory location in gdb-mi memory buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39180 in the body.
You can then email your comments to 39180 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 27.0.50; [PATCH] Use expressions as memory location in gdb-mi memory
 buffer
Date: Sat, 18 Jan 2020 15:54:35 -0500

[Message part 1 (text/plain, inline)]

Currently gdb-mi does allow expressions as memory address, but it translates it to a fixed address. This patch makes gdb to store the expression and re-evaluate on updates. So the address changes as expression’s value changes.

[memory.patch (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 27.0.50 (build 3, x86_64-apple-darwin19.0.0, NS appkit-1894.10 Version 10.15.1 (Build 19B88))
of 2019-11-30 built on missSilver
Repository revision: e2828795d73637577c7726965974a047fe2d7119
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.2

Recent messages:
Checking 24 files in /Users/yuan/attic/emacs/lisp/cedet...
Checking 59 files in /Users/yuan/attic/emacs/lisp/calendar...
Checking 87 files in /Users/yuan/attic/emacs/lisp/calc...
Checking 113 files in /Users/yuan/attic/emacs/lisp/obsolete...
Checking for load-path shadows...done
Auto-saving...
Quit
C-x C-g is undefined
Quit
Buffer *unsent mail to bug-gnu-emacs <at> gnu.org*<2> modified; kill anyway? (y or n) y

Configured using:
'configure --with-modules --with-pdumper=yes
--oldincludedir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/libxml2/'

Configured features:
NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
THREADS PDUMPER LCMS2

Important settings:
  value of $LC_CTYPE: UTF-8
  value of $LANG: en_CN.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  magit-todos-mode: t
  bug-reference-prog-mode: t
  desktop-save-mode: t
  ghelp-global-minor-mode: t
  minibuffer-electric-default-mode: t
  flymake-mode: t
  global-magit-file-mode: t
  magit-file-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  shell-dirtrack-mode: t
  flyspell-mode: t
  outshine-mode: t
  ws-butler-global-mode: t
  ws-butler-mode: t
  minions-mode: t
  eyebrowse-mode: t
  savehist-mode: t
  global-hl-todo-mode: t
  hl-todo-mode: t
  global-highlight-parentheses-mode: t
  highlight-parentheses-mode: t
  rainbow-delimiters-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  electric-pair-mode: t
  winner-mode: t
  aggressive-indent-mode: t
  ivy-prescient-mode: t
  prescient-persist-mode: t
  recentf-mode: t
  which-key-mode: t
  general-override-mode: t
  outline-minor-mode: t
  ivy-mode: t
  company-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-quote-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  transient-mark-mode: t
  hs-minor-mode: t

Load-path shadows:
/Users/yuan/.emacs.d/ranch/winman/windman hides /Users/yuan/.emacs.d/ranch/windman/windman
/Users/yuan/.emacs.d/ranch/nerd-font/test/test-helper hides /Users/yuan/.emacs.d/ranch/doom-themes/test/test-helper
/Users/yuan/.emacs.d/ranch/julia-mode/julia-mode hides /Users/yuan/.emacs.d/package/julia-mode-20190813.1326/julia-mode
/Users/yuan/.emacs.d/ranch/julia-mode/julia-latexsubs hides /Users/yuan/.emacs.d/package/julia-mode-20190813.1326/julia-latexsubs
/Users/yuan/.emacs.d/ranch/matlab-emacs/mlint hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/mlint
/Users/yuan/.emacs.d/ranch/matlab-emacs/company-matlab-shell hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/company-matlab-shell
/Users/yuan/.emacs.d/ranch/matlab-emacs/linemark hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/linemark
/Users/yuan/.emacs.d/ranch/matlab-emacs/semanticdb-matlab hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/semanticdb-matlab
/Users/yuan/.emacs.d/ranch/matlab-emacs/semantic-matlab hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/semantic-matlab
/Users/yuan/.emacs.d/ranch/matlab-emacs/srecode-matlab hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/srecode-matlab
/Users/yuan/.emacs.d/ranch/matlab-emacs/matlab hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/matlab
/Users/yuan/.emacs.d/ranch/matlab-emacs/cedet-matlab hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/cedet-matlab
/Users/yuan/.emacs.d/ranch/matlab-emacs/tlc hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/tlc
/Users/yuan/.emacs.d/ranch/matlab-emacs/matlab-publish hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/matlab-publish
/Users/yuan/.emacs.d/ranch/matlab-emacs/matlab-mode-pkg hides /Users/yuan/.emacs.d/package/matlab-mode-20180928.1526/matlab-mode-pkg
/Users/yuan/.emacs.d/package/faceup-20170925.1946/faceup hides /Users/yuan/attic/emacs/lisp/emacs-lisp/faceup

Features:
(magit-todos pcre2el rxt re-builder grep checkdoc lisp-mnt bug-reference
vc-mtn vc-hg ffap tramp tramp-loaddefs trampver tramp-integration
files-x tramp-compat parse-time iso8601 ls-lisp shadow sort mail-extr
emacsbug sendmail vc-git vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc
vc-dispatcher magit-bookmark bookmark company-oddmuse company-keywords
company-etags etags fileloop company-gtags company-dabbrev-code
company-dabbrev company-files company-capf company-cmake company-xcode
company-clang company-semantic company-eclim company-template
company-bbdb hideshow desktop frameset trivial-copy ghelp-eglot
ghelp-helpful ghelp-builtin ghelp cus-edit cus-start cus-load
luna-publish utility pause luna-general-config minibuf-eldef eglot array
jsonrpc ert pp ewoc debug flymake-proc flymake warnings url-util
magit-submodule magit-obsolete magit-blame magit-stash magit-reflog
magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote
magit-commit magit-sequence magit-notes magit-worktree magit-tag
magit-merge magit-branch magit-reset magit-files magit-refs magit-status
magit magit-repos magit-apply magit-wip magit-log which-func magit-diff
smerge-mode diff-mode magit-core magit-autorevert autorevert filenotify
magit-margin magit-transient magit-process magit-mode transient
git-commit magit-git magit-section magit-utils crm log-edit message rmc
puny rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr
mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor
async-bytecomp async shell server flyspell ispell outshine
outshine-org-cmds outorg isolate inline expand-region
text-mode-expansions the-org-mode-expansions er-basic-expansions
thingatpt expand-region-core expand-region-custom ws-butler minions
eyebrowse savehist buffer-move windmove hl-todo highlight-parentheses
rainbow-delimiters doom-cyberpunk-theme undo-tree diff
doom-one-light-theme elec-pair winner doom-themes doom-themes-base
windman aggressive-indent find-char ivy-prescient prescient recentf-ext
recentf tree-widget wid-edit which-key general helpful imenu trace
edebug backtrace info-look f dash-functional help-fns radix-tree
elisp-refs s loop dash org-element avl-tree generator org advice
org-macro org-footnote org-pcomplete pcomplete org-list org-faces
org-entities time-date noutline outline org-version ob-emacs-lisp ob
ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint
ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func
cal-menu calendar cal-loaddefs counsel xdg xref project dired
dired-loaddefs compile comint ansi-color swiper cl-extra help-mode ivy
delsel ring colir color ivy-overlay company edmacro kmacro pcase
use-package use-package-ensure use-package-delight use-package-diminish
use-package-bind-key bind-key easy-mmode use-package-core finder-inf
tex-site info cowboy package easymenu browse-url url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars cl-loaddefs cl-lib lunary
lunary-ui luna-f rx seq byte-opt gv bytecomp byte-compile cconv tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 197959 23437)
(symbols 48 9374 49)
(strings 32 38335 2058)
(string-bytes 1 1116712)
(vectors 16 24652)
(vector-slots 8 289694 28446)
(floats 8 511 434)
(intervals 56 14675 1317)
(buffers 1000 27))

Message #8 received at 39180 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 39180 <at> debbugs.gnu.org
Subject: Re: bug#39180: 27.0.50;
 [PATCH] Use expressions as memory location in gdb-mi memory buffer
Date: Fri, 31 Jan 2020 12:05:43 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 18 Jan 2020 15:54:35 -0500
> 
> Currently gdb-mi does allow expressions as memory address, but it translates it to a fixed address. This patch makes gdb to store the expression and re-evaluate on updates. So the address changes as expression’s value changes.

Thanks.

Are these 4 patches needed to add the above improvement, or is each
part of the series independent, and could be applied on its own right?

If the entire series should be applied in a single transaction, please
make then a single patch, as that makes it easier to review and
apply.  Otherwise, please explain what is the rationale for each part
separately, because I don't think I understand it.

> Before the memory buffer evaluates the expression as address
> and use the fixed result in each stop. This change stores the
> expression itself and reevaluates it in each stop for an address.
> Then displays the value of the memory at that address.

Two spaces between sentences (here and elsewhere in the patch),
please.

> lisp/progmodes/gdb-mi.el (gdb-memory-address-expression): new
>   (gdb-memory-address): change default value, add docstring
>   (def-gdb-trigger-and-handler gdb-invalidate-memory,
>   gdb-memory-set-address): replace ’gdb-memory-address’ with
>     ’gdb-memory-address-expression’
>   (gdb-memory-header): Add display for ’gdb-memory-address-expression’,
>     move the mouse event from address to expression

Please quote symbols 'like this'.

> * lisp/progmodes/gdb-mi.el (gdb-read-memory-custom):
> Break infinite loop. Change ’error’ to ’user-error’

I don't understand what infinite loop are you alluding to here, and
how did it come into existence.

> * lisp/progmodes/gdb-mi.el (gdb-memory-header):
> Protect against nil value

And what is the problem you are trying to solve here?

> * lisp/progmodes/gdb-mi.el (gdb--memory-display-warning): new
> (gdb-read-memory-custom, gdb-memory-header): Add warning

And what is this part about?

Message #11 received at 39180 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 39180 <at> debbugs.gnu.org
Subject: Re: bug#39180: 27.0.50; [PATCH] Use expressions as memory location in
 gdb-mi memory buffer
Date: Fri, 31 Jan 2020 21:25:00 -0500

[Message part 1 (text/plain, inline)]

> On Jan 31, 2020, at 5:05 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Sat, 18 Jan 2020 15:54:35 -0500
>> 
>> Currently gdb-mi does allow expressions as memory address, but it translates it to a fixed address. This patch makes gdb to store the expression and re-evaluate on updates. So the address changes as expression’s value changes.
> 
> Thanks.
> 
> Are these 4 patches needed to add the above improvement, or is each
> part of the series independent, and could be applied on its own right?
> 

I merged them into one.

> If the entire series should be applied in a single transaction, please
> make then a single patch, as that makes it easier to review and
> apply.  Otherwise, please explain what is the rationale for each part
> separately, because I don't think I understand it.
> 
>> Before the memory buffer evaluates the expression as address
>> and use the fixed result in each stop. This change stores the
>> expression itself and reevaluates it in each stop for an address.
>> Then displays the value of the memory at that address.
> 
> Two spaces between sentences (here and elsewhere in the patch),
> please.
> 
>> lisp/progmodes/gdb-mi.el (gdb-memory-address-expression): new
>>  (gdb-memory-address): change default value, add docstring
>>  (def-gdb-trigger-and-handler gdb-invalidate-memory,
>>  gdb-memory-set-address): replace ’gdb-memory-address’ with
>>    ’gdb-memory-address-expression’
>>  (gdb-memory-header): Add display for ’gdb-memory-address-expression’,
>>    move the mouse event from address to expression
> 
> Please quote symbols 'like this'.

Both fixed.

> 
>> * lisp/progmodes/gdb-mi.el (gdb-read-memory-custom):
>> Break infinite loop. Change ’error’ to ’user-error’
> 
> I don't understand what infinite loop are you alluding to here, and
> how did it come into existence.

Added some comments to explain.

> 
>> * lisp/progmodes/gdb-mi.el (gdb-memory-header):
>> Protect against nil value
> 
> And what is the problem you are trying to solve here?

Added some comments.

> 
>> * lisp/progmodes/gdb-mi.el (gdb--memory-display-warning): new
>> (gdb-read-memory-custom, gdb-memory-header): Add warning
> 
> And what is this part about?

Added some explanation in commit message and docstring of gdb--memory-display-warning.

And here is the new patch.

Yuan

[memory-fixed.patch (application/octet-stream, attachment)]

Message #16 received at 39180-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 39180-done <at> debbugs.gnu.org
Subject: Re: bug#39180: 27.0.50; [PATCH] Use expressions as memory location in
 gdb-mi memory buffer
Date: Sat, 08 Feb 2020 11:51:37 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Fri, 31 Jan 2020 21:25:00 -0500
> Cc: 39180 <at> debbugs.gnu.org
> 
> And here is the new patch.

Thanks, I pushed it to the master branch.  I had to make some minor
editing changes in the commit log message; please see what I changed
and try to follow this style in the future.

Message #19 received at 39180-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 39180-done <at> debbugs.gnu.org
Subject: Re: bug#39180: 27.0.50; [PATCH] Use expressions as memory location in
 gdb-mi memory buffer
Date: Sun, 9 Feb 2020 23:45:50 -0500

> On Feb 8, 2020, at 4:51 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Fri, 31 Jan 2020 21:25:00 -0500
>> Cc: 39180 <at> debbugs.gnu.org
>> 
>> And here is the new patch.
> 
> Thanks, I pushed it to the master branch.  I had to make some minor
> editing changes in the commit log message; please see what I changed
> and try to follow this style in the future.

Got it. I will.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.