GNU bug report logs - #39201
[PATCH] gnu: Add r-deconstructsigs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39201 in the body.
You can then email your comments to 39201 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add r-deconstructsigs.
Date: Mon, 20 Jan 2020 13:18:30 +0100

[Message part 1 (text/plain, inline)]

Dear Guix,

Here's a patch to add r-deconstructsigs.  I added it to the cran module
because that's where it originates from, but it takes a reference
genome from bioconductor.  So I had to use the bioconductor module.  Is
that OK?

Thanks for your hard work and valuable time.

Kind regards,
Roel Janssen

[0001-gnu-Add-r-deconstructsigs.patch (text/x-patch, attachment)]

Message #8 received at 39201 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: roel <at> gnu.org
Cc: 39201 <at> debbugs.gnu.org
Subject: Re: [bug#39201] [PATCH] gnu: Add r-deconstructsigs.
Date: Mon, 20 Jan 2020 14:16:50 +0100

Hi Roel,

> Here's a patch to add r-deconstructsigs.  I added it to the cran module
> because that's where it originates from, but it takes a reference
> genome from bioconductor.  So I had to use the bioconductor module.  Is
> that OK?

Please add the package to the bioconductor module instead and add a
comment above to explain why.  (That’s what we’ve done for other
packages like this.)

--
Ricardo

Message #11 received at 39201 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 39201 <at> debbugs.gnu.org
Subject: Re: [bug#39201] [PATCH] gnu: Add r-deconstructsigs.
Date: Mon, 20 Jan 2020 20:32:56 +0100

[Message part 1 (text/plain, inline)]

Hi Ricardo!

On Mon, 2020-01-20 at 14:16 +0100, Ricardo Wurmus wrote:
> Hi Roel,
> 
> > Here's a patch to add r-deconstructsigs.  I added it to the cran module
> > because that's where it originates from, but it takes a reference
> > genome from bioconductor.  So I had to use the bioconductor module.  Is
> > that OK?
> 
> Please add the package to the bioconductor module instead and add a
> comment above to explain why.  (That’s what we’ve done for other
> packages like this.)

So I did.  Thanks for pointing this out.
I attached the new patch.

Thanks Ricardo!

Kind regards,
Roel Janssen

[0001-gnu-Add-r-deconstructsigs.patch (text/x-patch, attachment)]

Message #16 received at 39201-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Roel Janssen <roel <at> gnu.org>
Cc: 39201-done <at> debbugs.gnu.org
Subject: Re: [bug#39201] [PATCH] gnu: Add r-deconstructsigs.
Date: Mon, 27 Jan 2020 22:31:58 +0100

Hi Roel,

sorry for the delay.  I pushed this to the master branch with commit
a38bf7c843.

Thanks!

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.