GNU bug report logs - #39214
Updates to etc/guix-install.sh

Previous Next

Package: guix-patches;

Reported by: Prafulla Giri <pratheblackdiamond <at> gmail.com>

Date: Tue, 21 Jan 2020 07:12:02 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39214 in the body.
You can then email your comments to 39214 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#39214; Package guix-patches. (Tue, 21 Jan 2020 07:12:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Prafulla Giri <pratheblackdiamond <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 21 Jan 2020 07:12:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Updates to etc/guix-install.sh
Date: Tue, 21 Jan 2020 12:56:34 +0545
[Message part 1 (text/plain, inline)]
Esteemed Maintainer,

Attached are two patches as a follow-up to
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39049 that was just recently
applied to the main source tree.

Patch 1 exports the INFOPATH and makes the up-to-date guix info manual
available to the user via both /usr/bin/info and $GUIX_PROFILE/bin/info
(previously `info guix` would either show the out-of-date info file
installed during installation or throw a "No menu item 'guix' in node
'(dir)Top" error if the $GUIX_PROFILE/bin/info was invoked, or if the info
pages weren't installed during installation).

Patch 2 adds a defensive test against (highly unlikely) cases where
/etc/profile.d might not exist, and creates it. The function does not quit
on failure because it is possible that /etc/profile is still configured to
read /etc/profile.d/*.sh files. Even if it is not, guix.sh will merely sit
in /etc/profile.d and cause no changes to the user's environment.

These changes caused no regressions in my local machine.

I hope this helps more foreign distro users in their journey with Guix.
[Message part 2 (text/html, inline)]
[0001-guix-install.sh-Export-INFOPATH-to-contain-updated-g.patch (text/x-patch, attachment)]
[0002-guix-install.sh-Create-etc-profile.d-if-it-does-not-.patch (text/x-patch, attachment)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sun, 26 Jan 2020 22:21:01 GMT) Full text and rfc822 format available.

Notification sent to Prafulla Giri <pratheblackdiamond <at> gmail.com>:
bug acknowledged by developer. (Sun, 26 Jan 2020 22:21:02 GMT) Full text and rfc822 format available.

Message #10 received at 39214-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Prafulla Giri <pratheblackdiamond <at> gmail.com>
Cc: 39214-done <at> debbugs.gnu.org
Subject: Re: [bug#39214] Updates to etc/guix-install.sh
Date: Sun, 26 Jan 2020 23:19:51 +0100
Hello,

Prafulla Giri <pratheblackdiamond <at> gmail.com> skribis:

> From 0f98891feb2cc3cb4c529c65d789cdfc955cfc41 Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
> Date: Tue, 21 Jan 2020 12:25:24 +0545
> Subject: [PATCH 1/2] guix-install.sh: Export INFOPATH to contain updated guix
>  info-pages
>
> * etc/guix-install.sh (sys_create_init_profile): Export INFOPATH to include
> the updated info-pages from ~/.config/guix/current/share/info.  This also makes
> sure that both /usr/bin/info and $GUIX_PROFILE/bin/info can read guix info pages
> without throwing "no menu item 'guix' in node dir(Top)" error.

> From dcd2180c36dc0319ebc3ab821879015e30bba94e Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
> Date: Tue, 21 Jan 2020 12:34:10 +0545
> Subject: [PATCH 2/2] guix-install.sh: Create /etc/profile.d if it does not
>  exist
> 
> * etc/guix-install.sh (sys_create_init_profile): Add code to create
> /etc/profile.d if it somehow does not exist; the function still carries
> on because it is possible that /etc/profile is still configured to read
> the *.sh files from /etc/profile.d, if they exist.

Applied both, thank you!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 24 Feb 2020 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 34 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.