Received: (at 39275) by debbugs.gnu.org; 9 Mar 2026 11:53:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 09 07:53:05 2026
Received: from localhost ([127.0.0.1]:44652 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vzZAV-0007sV-QN
for submit <at> debbugs.gnu.org; Mon, 09 Mar 2026 07:53:05 -0400
Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:59791)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <zimon.toutoune@HIDDEN>)
id 1vzZAG-0007pe-NK
for 39275 <at> debbugs.gnu.org; Mon, 09 Mar 2026 07:52:49 -0400
Received: by mail-wr1-x42f.google.com with SMTP id
ffacd0b85a97d-439b7a87fb5so5148016f8f.3
for <39275 <at> debbugs.gnu.org>; Mon, 09 Mar 2026 04:52:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1773057167; x=1773661967; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=EVU1Q4bkSBkkw6Vl8eTLRMMx9Z0bFqHofRDUW7Syud8=;
b=AbwnavLU3bd1HRvybRggYyCOveI/wBORw3s0knIpfhVhmn0n2lCldhWvhUPadwQErw
2yEA+FsFriOg9bPWoHuL5mhD+Yz+Q5Bh3vf4vo/5sYId8LfXJAu97A1WzH4cG0527BIe
yIyaRAEqYyL4qlBjSFVi5x7UqdhyQYtTB2SEzRx8hT3v22bkZwpVPlceP1gopNc2WrBi
XGr4MJTpgjCglgIA4G7qhdCTEutBfXtUEO8lAqhblTO0D5VVlAWopzGlD5n3laNnA7A+
HUKVc86CA1LKcp0w9ctqFNqb5PVfWEmsU5TYyPKOOybPjVPhGRJkDnIRkip1v+X4aPKZ
fT/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1773057167; x=1773661967;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-gg
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=EVU1Q4bkSBkkw6Vl8eTLRMMx9Z0bFqHofRDUW7Syud8=;
b=k11vjmUko8SeNTrdpHg0ldoPXoQM3EHlsGfvoeL1OTu7JY0ue6JpWA8XGIXYqpjgbb
5L8B82EHvk9bPvGVJSgBI6Q6uFc40RNjvJQNK3dCGLEfieALmRh8TUOEeBzaQKwOlHwo
bspNWQoZg1HuFRu1CSkmnT5+MgSS9fuEC0fbq9POrbAbD6hrHvc2vv7Y7MHW4tj2s/6d
cqlHlwIjEVxVnnsUdsw8Fp/YtsFW4any4mMbZ/b8EHdM9F/qJn/wREZj2rQlgLwB415O
3ra8obyZK13hGVRiWtT7/mUuigEzE/EDjpfQvLIsA9Y93wt3YFCZgb1Pmy9l3VhZlbN3
qeOw==
X-Forwarded-Encrypted: i=1;
AJvYcCUlNmcYlFbGpYEZKhvPNztgx60/KKvP6RCMAlNmJ65w4hH2FQPaEffWzClO5zU9cKU0Ko3l1A==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzMwQuGnPxqvn5TjtJGfLTdu6B6jKO1XbrAkRHEqJEZ9E++YykE
Hxu+8e83Vw0+LmkUJ3clf7d7+BdQwrKOGfQyGSCPgUw8wCBONGUtTV1SwC8aKA==
X-Gm-Gg: ATEYQzz2i8lr1H7IPa2AjzgNeMPsftvZM2eHsg2kSzSIDwi0cuqcxP4iuH9nxI12ZtX
kOr3JT+3hDWGTFzAfxxGwtRG0POREZih4rCLXMo9nKYe48Ng6wvVLL2YQhOuzjyJKSBM/HlxQK6
HgJ3XpE7rQ1pUjOpwdgu68yVjl0uWhhE/XaDttjx2unHqBEStALtOkq3FVsY7gf4gC+eCTNn6ZH
jCUe2Lm+3+SjLUOwUR3+IHuDpUedlOI0YEEL8Y6Fe7+WmGo2Uxx71PDKiE2CdM6Wt5UjWipMGZh
JBYV5c/hWwILg1upmS78xLO0EiPMbCOf3a4buufrTt0eOZHrAeKGARTWp0CKDWUxl99pyoByOGt
Ts8u5rflw4mI5vdl4A/6992u4u3x7n2zk7reYJmh92ByVwMZP/So/nmG3RCWC7/i5dm64MtKTxy
ULe7tg1r5lI8vu4houIRe2xD33v4PRlaYH+QWc6rrbTkCf9N5o2ZtKd7Ub8Zs+fApWhsZfVw==
X-Received: by 2002:a05:6000:2285:b0:439:b811:11f1 with SMTP id
ffacd0b85a97d-439da66a2fbmr19126241f8f.31.1773057167477;
Mon, 09 Mar 2026 04:52:47 -0700 (PDT)
Received: from lili (nat-dsi-209.net.univ-paris-diderot.fr. [81.194.30.209])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-439dad8d840sm28865620f8f.8.2026.03.09.04.52.46
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 09 Mar 2026 04:52:47 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Christopher Baines <mail@HIDDEN>
Subject: Re: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
In-Reply-To: <87o8upialv.fsf@HIDDEN> (Christopher Baines's message of
"Mon, 27 Jan 2020 08:09:48 +0000")
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
<871rro6iis.fsf@HIDDEN> <20200125123027.50a6ab1a@HIDDEN>
<87r1zmikj6.fsf@HIDDEN>
<999e82b162db35d396932eb2c1d5a20f68c00959.camel@HIDDEN>
<87o8upialv.fsf@HIDDEN>
Date: Mon, 09 Mar 2026 12:43:36 +0100
Message-ID: <87ldg1tehj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 4.6 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi, For more context,
see: https://issues.guix.gnu.org/issue/39275
Content analysis details: (4.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS
[81.194.30.209 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2a00:1450:4864:20:0:0:0:42f listed in]
[list.dnswl.org]
X-Debbugs-Envelope-To: 39275
Cc: Danny Milosavljevic <dannym@HIDDEN>,
Jesse Gibbons <jgibbons2357@HIDDEN>, 39275 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 3.6 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi, For more context, see: https://issues.guix.gnu.org/issue/39275
Content analysis details: (3.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[2a00:1450:4864:20:0:0:0:42f listed in]
[list.dnswl.org]
3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS
[81.194.30.209 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi,
For more context, see:
https://issues.guix.gnu.org/issue/39275
On Mon, 27 Jan 2020 at 08:09, Christopher Baines <mail@HIDDEN> wrote:
> Sending a new patch would be great. Adding something anywhere in the
> commit message is fine by me.
Well, something probably had fell into the crack.
Since the patch is about the addition of one package as inputs for
supporting MIDI, if I understand correctly, and considering it=E2=80=99s ma=
ny
years old, therefore I=E2=80=99m closing this submission.
Feel free to re-send to Codeberg if it=E2=80=99s still worth.
Cheers,
simon
guix-patches@HIDDEN:bug#39275; Package guix-patches.
Full text available.
Received: (at 39275) by debbugs.gnu.org; 27 Jan 2020 08:09:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 27 03:09:57 2020
Received: from localhost ([127.0.0.1]:57786 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ivzT3-0005s4-89
for submit <at> debbugs.gnu.org; Mon, 27 Jan 2020 03:09:57 -0500
Received: from mira.cbaines.net ([212.71.252.8]:49614)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1ivzT0-0005ru-N3
for 39275 <at> debbugs.gnu.org; Mon, 27 Jan 2020 03:09:55 -0500
Received: from localhost (unknown [46.237.162.0])
by mira.cbaines.net (Postfix) with ESMTPSA id 8120317A0A;
Mon, 27 Jan 2020 08:09:53 +0000 (GMT)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id 05d99897;
Mon, 27 Jan 2020 08:09:51 +0000 (UTC)
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
<871rro6iis.fsf@HIDDEN> <20200125123027.50a6ab1a@HIDDEN>
<87r1zmikj6.fsf@HIDDEN>
<999e82b162db35d396932eb2c1d5a20f68c00959.camel@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.3
From: Christopher Baines <mail@HIDDEN>
To: Jesse Gibbons <jgibbons2357@HIDDEN>
Subject: Re: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
In-reply-to: <999e82b162db35d396932eb2c1d5a20f68c00959.camel@HIDDEN>
Date: Mon, 27 Jan 2020 08:09:48 +0000
Message-ID: <87o8upialv.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 39275
Cc: Danny Milosavljevic <dannym@HIDDEN>, 39275 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Jesse Gibbons <jgibbons2357@HIDDEN> writes:
> On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote:
>> Error verifying signature: Failed to execute gpg.
>> Danny Milosavljevic <dannym@HIDDEN> writes:
>>
>> > Hi,
>> >
>> > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".
>> >
>> > > It would be good to put something in the commit message about why
>> > > this
>> > > is happening, as it's not obvious to me at least.
>> >
>> > I disagree in general because I've seen before what that leads to:
>> > Half the source code (the comments) end up in the commit messages
>> > instead.
>> > Eventually (because of some merge or something) those get lost, or
>> > (because of a new commit) those get hidden.
>> > Now someone is going to overlook it.
>>
>> I'm not suggesting documenting code in commit messages, just saying
>> something about the motivation/intention with the change is useful.
>> The
>> message you suggest meets this criteria perfectly.
>>
>> > So I'd put documentation into comments, except when it's ephemeral
>> > ("news").
>> >
>> > Also, in the special case of Guix the reason why we add an input
>> > later is
>> > "we forgot to add it earlier and it was optional to the package and
>> > thus the
>> > package built" most of the time. So the commit message would
>> > always be
>> > "we forgot earlier".
>>
>> So I would say that "we forgot earlier" isn't a motivation, or
>> descriptive of intent (although maybe it meets the "why this is
>> happening" I mentioned earlier, but that was maybe poorly
>> explained)..
>>
>> > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and
>> > nobody
>> > noticed.
>> >
>> > We could have the subject say "Add MIDI support" because it
>> > communicates more
>> > clearly what this commit does for users. And that's the news :)
>>
>> Yeah, I think that's good. At least in the context I was looking at
>> this, trying to review the change, knowing what the intent is allows
>> me
>> to check if that's been satisfied (trying to play some MIDI content
>> with
>> VLC before and after).
>>
>> Chris
>
> Sorry for not explaining the intention. Do you want me to send a new
> patch mentioning the added MIDI support? Should I put that in the
> commit title, or in a comment?
Sending a new patch would be great. Adding something anywhere in the
commit message is fine by me.
Thanks,
Chris
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKSBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4umsxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xe6Vw/3UBcW3H6i1pLsnSrmqUYyJqcPi4cYF4RoI+MytogkvoWNAdocSyFwS26V
/d486+3WVgTH+iBQjAeFGBBOWk4qaHPqhxbo5ri+xrrlcKH3G4Qm4t4okMai1Y4I
uRcTAQ8ktZzOf0/f7p0pxopTBgf4Hh2no7N8Qa59jRieWc8QDzRr2sC/DPiyC9QE
0iurU4zJGG2NjHx5tUDt/5zuAlhR9HO74ZZHBQx7QPAoafmqJSAhex9pClMYjkEV
irRJCKeI+ylbi+uXtg9LN9yX8HbG6TcFhgSRWp8FFva4i+bV737BQXlcE0sm7p87
5F7cUvE/c2BbbngTqpQ0mxmmz80C1iLvjHUS2iJTjsYXd4k7D5MwnyRIvEKh63Vp
VQPSV0jq0WAwmdXOB816nTjejUZWwBQyJ1y3w4wM2bH2Oc1g0gCNpFhg7pka/Ewk
4yfSQB2OcN927XMRYniKZU5lQ1GdHY8iNO8IQVtFiMDthACMOqqNCYlJjT2pdWW6
PvzXC2ZxWd2ihdPlGZ0CNqHu6BsFkGqUEqanOKBib4mW4NqqobClB7G0qBlA2clr
niGGbdct+W/GoaYocnN7cplW6B5cQmjrszRIDUPm6uYqYt1+U1vV994Oh2gxiPqV
IMv1sK7RW+ksgHV+R88dbv92ByVx7aYJMfQoENlLLycjzqO8NQ==
=yV0R
-----END PGP SIGNATURE-----
--=-=-=--
guix-patches@HIDDEN:bug#39275; Package guix-patches.
Full text available.
Received: (at 39275) by debbugs.gnu.org; 27 Jan 2020 00:56:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 26 19:56:22 2020
Received: from localhost ([127.0.0.1]:57672 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ivshS-0003eR-KW
for submit <at> debbugs.gnu.org; Sun, 26 Jan 2020 19:56:22 -0500
Received: from mail-pj1-f66.google.com ([209.85.216.66]:53538)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jgibbons2357@HIDDEN>) id 1ivshR-0003eE-AL
for 39275 <at> debbugs.gnu.org; Sun, 26 Jan 2020 19:56:21 -0500
Received: by mail-pj1-f66.google.com with SMTP id n96so2284585pjc.3
for <39275 <at> debbugs.gnu.org>; Sun, 26 Jan 2020 16:56:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=message-id:subject:from:to:cc:date:in-reply-to:references
:user-agent:mime-version:content-transfer-encoding;
bh=/SMT27xEpeWBGmKZN1BmTjjZrWYhLeN+8LZ0sBo6YqI=;
b=Se1R7dRbyd3DQp192qFVVRxsSdbIESrFS03cPEpGGcwto3b3lpxZg5rGrwN2uirD5p
kXiFNJubfX+6OIv9asj9NFZ5iO0D73/4kpfu/ydIcly4klpvjIq5OOIBjX/RJQxbacoY
Dk0daGtAYt96XmE6TeY/Mkgaqm107eIa4A/wkjhe+O43tNawGyitDHWs3TBBo3WFvOM8
bl1BnZz+NnK2dJHYzyxJty58oJMsUgHsnWi1UqJnTDBC2bm1bH/d0x/LqSAbwvActFkx
IVytwfoULEp62QP/syp5ZBOTj3ySs+2D/oEHUt3OgIOA60K7JvYwaRYXY593ZAwndwmg
cRvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:user-agent:mime-version:content-transfer-encoding;
bh=/SMT27xEpeWBGmKZN1BmTjjZrWYhLeN+8LZ0sBo6YqI=;
b=N9uNxyvuZ629KykiY4lFyLYs2mOHFFrXe+3UIxa/KFJRuI3GTmmGNJj53QilRcX17J
gxMZPJTvGxjc23qhCvQ6+LA6URU7M312Yeilev0d/gPp/QWUPvJQ718fd1OxEa31Azyx
ktIjPCnmHaEOXxQGsOSSCene+UTFac8vf5o2n1MFbujLRO5pvHh+7XquyNdwV7xP4SEA
AW1TYhuJwc8yDOHd1sHw330v0ycEVHZZXldQbgkwP8VXX0Lbdijexaakv/ipBVLiESvt
hOg+0M6HzupG874f+gkiLZduXJG444W4o6NsGge8KnhRN6PZ+kzENdfzjeQeaMjqP/KU
UjyA==
X-Gm-Message-State: APjAAAWHAxYzAi7wKL05MtGaNbeVmUCt1q08yCCfMQaKcY3B+0KqTYD+
55LnD2XQXhQLic4RAEcpWBDb0Qqf
X-Google-Smtp-Source: APXvYqyvxnfs0Rfzx8feEZi1QLWovCG2W3yZqbTKA0xBRoPcZS7LqJBiHl6P/gk+QDCIK8bzqPJ6OA==
X-Received: by 2002:a17:902:680c:: with SMTP id
h12mr10911537plk.102.1580086575289;
Sun, 26 Jan 2020 16:56:15 -0800 (PST)
Received: from [192.168.1.13] ([199.68.53.171])
by smtp.gmail.com with ESMTPSA id i17sm13413424pfr.67.2020.01.26.16.56.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 26 Jan 2020 16:56:14 -0800 (PST)
Message-ID: <999e82b162db35d396932eb2c1d5a20f68c00959.camel@HIDDEN>
Subject: Re: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
From: Jesse Gibbons <jgibbons2357@HIDDEN>
To: Christopher Baines <mail@HIDDEN>, Danny Milosavljevic
<dannym@HIDDEN>
Date: Sun, 26 Jan 2020 17:56:13 -0700
In-Reply-To: <87r1zmikj6.fsf@HIDDEN>
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
<871rro6iis.fsf@HIDDEN> <20200125123027.50a6ab1a@HIDDEN>
<87r1zmikj6.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.4
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 39275
Cc: 39275 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote:
> Error verifying signature: Failed to execute gpg.
> Danny Milosavljevic <dannym@HIDDEN> writes:
>
> > Hi,
> >
> > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".
> >
> > > It would be good to put something in the commit message about why
> > > this
> > > is happening, as it's not obvious to me at least.
> >
> > I disagree in general because I've seen before what that leads to:
> > Half the source code (the comments) end up in the commit messages
> > instead.
> > Eventually (because of some merge or something) those get lost, or
> > (because of a new commit) those get hidden.
> > Now someone is going to overlook it.
>
> I'm not suggesting documenting code in commit messages, just saying
> something about the motivation/intention with the change is useful.
> The
> message you suggest meets this criteria perfectly.
>
> > So I'd put documentation into comments, except when it's ephemeral
> > ("news").
> >
> > Also, in the special case of Guix the reason why we add an input
> > later is
> > "we forgot to add it earlier and it was optional to the package and
> > thus the
> > package built" most of the time. So the commit message would
> > always be
> > "we forgot earlier".
>
> So I would say that "we forgot earlier" isn't a motivation, or
> descriptive of intent (although maybe it meets the "why this is
> happening" I mentioned earlier, but that was maybe poorly
> explained)..
>
> > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and
> > nobody
> > noticed.
> >
> > We could have the subject say "Add MIDI support" because it
> > communicates more
> > clearly what this commit does for users. And that's the news :)
>
> Yeah, I think that's good. At least in the context I was looking at
> this, trying to review the change, knowing what the intent is allows
> me
> to check if that's been satisfied (trying to play some MIDI content
> with
> VLC before and after).
>
> Chris
Sorry for not explaining the intention. Do you want me to send a new
patch mentioning the added MIDI support? Should I put that in the
commit title, or in a comment?
guix-patches@HIDDEN:bug#39275; Package guix-patches.
Full text available.
Received: (at 39275) by debbugs.gnu.org; 26 Jan 2020 10:23:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 26 05:23:16 2020
Received: from localhost ([127.0.0.1]:56538 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ivf4W-0007gT-2x
for submit <at> debbugs.gnu.org; Sun, 26 Jan 2020 05:23:16 -0500
Received: from mira.cbaines.net ([212.71.252.8]:48860)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1ivf4U-0007gL-Ot
for 39275 <at> debbugs.gnu.org; Sun, 26 Jan 2020 05:23:15 -0500
Received: from localhost (unknown [46.237.162.0])
by mira.cbaines.net (Postfix) with ESMTPSA id C0F6817924;
Sun, 26 Jan 2020 10:23:13 +0000 (GMT)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id 186f420e;
Sun, 26 Jan 2020 10:23:11 +0000 (UTC)
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
<871rro6iis.fsf@HIDDEN> <20200125123027.50a6ab1a@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.3
From: Christopher Baines <mail@HIDDEN>
To: Danny Milosavljevic <dannym@HIDDEN>
Subject: Re: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
In-reply-to: <20200125123027.50a6ab1a@HIDDEN>
Date: Sun, 26 Jan 2020 10:23:09 +0000
Message-ID: <87r1zmikj6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 39275
Cc: 39275 <at> debbugs.gnu.org, jgibbons2357@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Danny Milosavljevic <dannym@HIDDEN> writes:
> Hi,
>
> I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".
>
>> It would be good to put something in the commit message about why this
>> is happening, as it's not obvious to me at least.
>
> I disagree in general because I've seen before what that leads to:
> Half the source code (the comments) end up in the commit messages instead.
> Eventually (because of some merge or something) those get lost, or
> (because of a new commit) those get hidden.
> Now someone is going to overlook it.
I'm not suggesting documenting code in commit messages, just saying
something about the motivation/intention with the change is useful. The
message you suggest meets this criteria perfectly.
> So I'd put documentation into comments, except when it's ephemeral ("news").
>
> Also, in the special case of Guix the reason why we add an input later is
> "we forgot to add it earlier and it was optional to the package and thus the
> package built" most of the time. So the commit message would always be
> "we forgot earlier".
So I would say that "we forgot earlier" isn't a motivation, or
descriptive of intent (although maybe it meets the "why this is
happening" I mentioned earlier, but that was maybe poorly explained)..
> In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody
> noticed.
>
> We could have the subject say "Add MIDI support" because it communicates more
> clearly what this commit does for users. And that's the news :)
Yeah, I think that's good. At least in the context I was looking at
this, trying to review the change, knowing what the intent is allows me
to check if that's been satisfied (trying to play some MIDI content with
VLC before and after).
Chris
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4taI1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XdIXA/8DFwiy59RysatwCaD7WUTjwtjcmL50rvaGt4mD+hoxK7RuxJY/9zWEJ8M
ArkgrBby4JeTiV9m5gsu3WSSF/f6mVr6W3lSPsQGLIFL8/5Xs3ZLvIrulM6Lua0c
Q6WnLZtQqaf4Um+5NsVxEUkP+ZgNLawLfwGsCBd52TpBEJXEakx3bw8f2uVt7yFR
lgkdljrRP+DjhbS55ZkJYCqFwH5rA4ohHz8NccjTihdI4vuVhJqSogt/4yLvJgHG
tVzmc1QUG1fecdTgwj04oZ9ntPR83516Ow79Y+9vJ6P+chb0obGgV3eDXUFegQ3o
OvlgpfkvER/seY5CWqrC67MilTG+kD2ANDr1YYLiUithd3szm0ooelD+0jkk12tq
WrZ/Jbp1RhfMuE14jskGst/V17+jzOUeTfjFXATJ76LsOVWY3xzU0EAr74VQsitD
75YQDIFTtENmDHic+wrqqiW/dELC6UGamct38kCJZEzLutU3VbxuOP1VjUuY3pxy
K3Xgesz8HYYURx7tSEvVau+wxT1JOfqalkgkk+v9ND/qviNw59poS6eO99G67b0M
OnxBQV7itLrAPSqhgynIjRvF2pC/05kfe8lNxEr96kB/ddAt55g5GcBVQknpltxz
hFw2T6aY0soDCxlDyYxBVlkP7JdPJSqUQzh79rl9cvgksCIGwg8=
=QQ0Q
-----END PGP SIGNATURE-----
--=-=-=--
guix-patches@HIDDEN:bug#39275; Package guix-patches.
Full text available.
Received: (at 39275) by debbugs.gnu.org; 25 Jan 2020 11:30:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 25 06:30:35 2020
Received: from localhost ([127.0.0.1]:55015 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ivJe7-0002N8-7F
for submit <at> debbugs.gnu.org; Sat, 25 Jan 2020 06:30:35 -0500
Received: from dd26836.kasserver.com ([85.13.145.193]:47366)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dannym@HIDDEN>) id 1ivJe5-0002My-1F
for 39275 <at> debbugs.gnu.org; Sat, 25 Jan 2020 06:30:33 -0500
Received: from localhost (unknown [185.17.13.127])
by dd26836.kasserver.com (Postfix) with ESMTPSA id 729503361DF0;
Sat, 25 Jan 2020 12:30:31 +0100 (CET)
Date: Sat, 25 Jan 2020 12:30:27 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
To: Christopher Baines <mail@HIDDEN>, jgibbons2357@HIDDEN
Subject: Re: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
Message-ID: <20200125123027.50a6ab1a@HIDDEN>
In-Reply-To: <871rro6iis.fsf@HIDDEN>
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
<871rro6iis.fsf@HIDDEN>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/uw5eHZ8XpWtrHVD=+zrG1fG";
protocol="application/pgp-signature"; micalg=pgp-sha256
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 39275
Cc: 39275 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--Sig_/uw5eHZ8XpWtrHVD=+zrG1fG
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Hi,
I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".
> It would be good to put something in the commit message about why this
> is happening, as it's not obvious to me at least.
I disagree in general because I've seen before what that leads to:
Half the source code (the comments) end up in the commit messages instead.
Eventually (because of some merge or something) those get lost, or
(because of a new commit) those get hidden.
Now someone is going to overlook it.
So I'd put documentation into comments, except when it's ephemeral ("news").
Also, in the special case of Guix the reason why we add an input later is
"we forgot to add it earlier and it was optional to the package and thus the
package built" most of the time. So the commit message would always be
"we forgot earlier".
In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody
noticed.
We could have the subject say "Add MIDI support" because it communicates mo=
re
clearly what this commit does for users. And that's the news :)
--Sig_/uw5eHZ8XpWtrHVD=+zrG1fG
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4sJtMACgkQ5xo1VCww
uqW6kgf+N9sb5cn0u0bbHONcvsSF8EDZsCFubO2yiQFvQ6TnV2WxWZEOOlI8LuNH
Zuwhg3sFDarX9lp2ol3ZMb/rTrmKR7STm3NRFW4bZeVp8kQYxAt7VW5kl29oRR+n
U77/9rNpyeOd0OOcfG6+6suumMWC2VSlw3DbjtcGrwFxJX0n+Z9y8EPn8/WqXW3p
q82laSqg9X/z8e4FT17e8XQJJkBhPSzcEeT/R0ykxc02SDDVSal53EoRNoIuJZqJ
5/n/S7SXbtxU1DkEUHuDA/eajZZpif9pJIq/xy+sGHOSJ2vJqgpGQ26P7TEJCZ9p
IPXYWDMUpMMTG0VOd/OCqyV85SZngg==
=Nvop
-----END PGP SIGNATURE-----
--Sig_/uw5eHZ8XpWtrHVD=+zrG1fG--
guix-patches@HIDDEN:bug#39275; Package guix-patches.
Full text available.
Received: (at 39275) by debbugs.gnu.org; 25 Jan 2020 08:35:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 25 03:35:15 2020
Received: from localhost ([127.0.0.1]:54947 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ivGuR-0006h5-Gp
for submit <at> debbugs.gnu.org; Sat, 25 Jan 2020 03:35:15 -0500
Received: from mira.cbaines.net ([212.71.252.8]:48004)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1ivGuP-0006gx-9E
for 39275 <at> debbugs.gnu.org; Sat, 25 Jan 2020 03:35:13 -0500
Received: from localhost (unknown [46.237.162.0])
by mira.cbaines.net (Postfix) with ESMTPSA id 182FC17A05;
Sat, 25 Jan 2020 08:35:12 +0000 (GMT)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id cd0fd2a3;
Sat, 25 Jan 2020 08:35:09 +0000 (UTC)
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.3
From: Christopher Baines <mail@HIDDEN>
To: jgibbons2357@HIDDEN
Subject: Re: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
In-reply-to: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
Date: Sat, 25 Jan 2020 08:35:07 +0000
Message-ID: <871rro6iis.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 39275
Cc: 39275 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Jesse Gibbons <jgibbons2357@HIDDEN> writes:
> * gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth.
> ---
> gnu/packages/video.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index ee7108753f..53d9a794f8 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of
> ffmpeg.")
> ("dbus" ,dbus)
> ("eudev" ,eudev)
> ("flac" ,flac)
> + ("fluidsynth" ,fluidsynth)
> ("ffmpeg" ,ffmpeg)
> ("fontconfig" ,fontconfig)
> ("freetype" ,freetype)
Hi Jesse,
It would be good to put something in the commit message about why this
is happening, as it's not obvious to me at least.
Thanks,
Chris
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4r/btfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XczQw//b8laG3y8dbmTqN/yifAq7xtLUO0p48yLwAU/7omVl+SSuabLBvgIKlii
z/A/pqVoB8wsbJPK5uSTlYEdXzv811j/1n4LNihe7pVDoOrjf6rvuV1tpMcRiXr6
GN3z1vxiGvXSOznziShvGt91tjW0FXvRtyktppmjqgavbkqTgs4MHvhgPXY9no2u
5iTbJjA52wBJQVJgWhjLBg4tVBKamyP+jvxwEOkTI4wMdGlooX/e2rkqIHNhbh4N
tFO6hs8yDsrANHAqCTbGAoSSUvBc0Af/oJdpv/nJcahvgTaMnAU6HTNMembQ9WPM
qKiP/haDXxntY1j2xaz7rRDh/N4sX4BREEyhm25Oxce0t9BFnx5YeUlBknxBZKQh
M/0W62EZhOr0jFInh+U1pAbrrJEODM84tiYHElvybgf5kdB8x81yKm1Mgvx8BGhS
OHdfkj7ja+weRleqmHnbUqpXEgcp2Orwwo91d2jFV8AKcu5ZxduHkFz03x4UXpI/
e6C56GGuTORrnt0o4OXj6o89CEuXjc5rQYOhOJSOQ4ZGe2caAwKHeI4GyhAKdCxE
Kf2LGf1exg1I2zL+foCcYt2RrmGTAhDgDXiJiTisOfWhHdXkklFfKOaRjYrEjKjO
/CsDlr7EDfQGReJYz5OW1B+NugzKKiiPo4os1BlCEGj9ZbKFe08=
=kq5j
-----END PGP SIGNATURE-----
--=-=-=--
guix-patches@HIDDEN:bug#39275; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 25 Jan 2020 01:20:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 20:20:08 2020
Received: from localhost ([127.0.0.1]:54874 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ivA7M-0002tc-1c
for submit <at> debbugs.gnu.org; Fri, 24 Jan 2020 20:20:08 -0500
Received: from lists.gnu.org ([209.51.188.17]:44366)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jgibbons2357@HIDDEN>) id 1ivA7J-0002tQ-Lm
for submit <at> debbugs.gnu.org; Fri, 24 Jan 2020 20:20:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:38603)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <jgibbons2357@HIDDEN>) id 1ivA7H-0007Ce-Q0
for guix-patches@HIDDEN; Fri, 24 Jan 2020 20:20:05 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_05,
FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <jgibbons2357@HIDDEN>) id 1ivA7G-0003cI-Rv
for guix-patches@HIDDEN; Fri, 24 Jan 2020 20:20:03 -0500
Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:38560)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from <jgibbons2357@HIDDEN>)
id 1ivA7G-0003Z9-BP
for guix-patches@HIDDEN; Fri, 24 Jan 2020 20:20:02 -0500
Received: by mail-pf1-x42a.google.com with SMTP id x185so1942376pfc.5
for <guix-patches@HIDDEN>; Fri, 24 Jan 2020 17:20:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=message-id:subject:from:to:date:user-agent:mime-version
:content-transfer-encoding;
bh=wXzkPbNhX8nqCfbc1g0K7OcbkwsK8aHfFAHBIMgE7v8=;
b=lZh4tTOil9qPSOb7u8Hb67/tkJ0lDVLW19+CkNUR8Qj1GOohhrM7ypTQzlLaIjQj+/
ii3ldHZIIRGK7DG72Dn5K430wCsY89J/JB2lRcA+a15bkc4M5mEdFbvNoijrXZzAgdtJ
P+vg8y1BAUZuGLXfAsNh9cYl45tFk1xuqKBOKQMpaf9u/IxWBpuPMny1I/sYMSW+H92x
6iDvUGLcU6QP9MajX4smi42szCgL/rdiWp+18G7IEqfJUNQOmfoxu0xREqMs4/clnKdw
KRUI/rhbJwYsOaLH5Q0zplR8wGuXHgTObMTx2XGKfIYJFTkdcEV6QvjkmHWJ2xoFbxvQ
QH1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:date:user-agent
:mime-version:content-transfer-encoding;
bh=wXzkPbNhX8nqCfbc1g0K7OcbkwsK8aHfFAHBIMgE7v8=;
b=nNCLG++xwz50LMTN7IKU/rHN4gFEzHHQ7hXKjU3Y/RtFpgUIId69Q0WNlBifVeGnYu
sBS7q4JAvvlE1xq+5dDR5sA4H2GpKNN6K4Wbpqfwcgbs46F9kXzMHiVQO/9fpVjFdCWt
6stVig980KnNNeTFnl/GAN70NpCKiiWjiHXNKChUuNmXDwvMocV6aUD88KZ/5ic2CRc6
rJ+ZO7PeT60SsqC85wbaRi8pW/F2+CW8jKE/fFBehdFTE9t8Y0gJJWV3AukSk9WN/3Ry
30WMh0aEu03MsWF8dJjOuCuz8Tg+9CeqDJFJWDc288Nk5w0rxf1gOiE88v7G+ccNNZuv
O3Bg==
X-Gm-Message-State: APjAAAWcZ8XPU5SjsHN4VXpAU98/a4Q76Y9BrR2fIfTO5hKT9NpKUiFc
kCvg1hu1PDwSRs5bViogAIMRCwgR
X-Google-Smtp-Source: APXvYqwh1N1RZQixlTq7wUMJi7YEeKfUdsvVP6+sQ1ve4mrmV3rrjV+943pxnZbWtOi65ciAzv9fYg==
X-Received: by 2002:a65:6088:: with SMTP id t8mr7281624pgu.329.1579915199238;
Fri, 24 Jan 2020 17:19:59 -0800 (PST)
Received: from [192.168.1.13] ([199.68.53.171])
by smtp.gmail.com with ESMTPSA id b98sm7421214pjc.16.2020.01.24.17.19.57
for <guix-patches@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 24 Jan 2020 17:19:58 -0800 (PST)
Message-ID: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
Subject: [PATCH] gnu: vlc: add fluidsynth as input.
From: Jesse Gibbons <jgibbons2357@HIDDEN>
To: guix-patches@HIDDEN
Date: Fri, 24 Jan 2020 18:19:57 -0700
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.4
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-Received-From: 2607:f8b0:4864:20::42a
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth. ---
gnu/packages/video.scm | 1 + 1 file changed,
1 insertion(+) diff --git a/gnu/packages/video.scm
b/gnu/packages/video.scm index ee7108753f..53d9a794f8 100644 ---
a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm @@ -1118,6 +1118,7 @@ videoformats depend on
[...] Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
in digit (jgibbons2357[at]gmail.com)
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (jgibbons2357[at]gmail.com)
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/,
low trust [209.51.188.17 listed in list.dnswl.org]
2.0 SPOOFED_FREEMAIL No description available.
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)
* gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth.
---
gnu/packages/video.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ee7108753f..53d9a794f8 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of
ffmpeg.")
("dbus" ,dbus)
("eudev" ,eudev)
("flac" ,flac)
+ ("fluidsynth" ,fluidsynth)
("ffmpeg" ,ffmpeg)
("fontconfig" ,fontconfig)
("freetype" ,freetype)
Jesse Gibbons <jgibbons2357@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#39275; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.