GNU bug report logs - #39290
[PATCH] Correct regexp for flags in 'format' doc string

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39290 in the body.
You can then email your comments to 39290 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Correct regexp for flags in 'format' doc string
Date: Sun, 26 Jan 2020 15:21:02 +0100

[Message part 1 (text/plain, inline)]

The doc string for 'format' contains

  where field is [0-9]+ followed by a literal dollar "$", flags is
  [+ #-0]+, width is [0-9]+, and precision is a literal period "."
  followed by [0-9]+.

The spec for flags isn't a correct regexp; the hyphen should be last.  This matters, because people copy it into their code without thinking (observed in the wild).

Patch acceptable for emacs-27?

[0001-Correct-regexp-for-flags-in-format-doc-string.patch (application/octet-stream, attachment)]

Message #10 received at 39290-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 39290-done <at> debbugs.gnu.org
Subject: [PATCH] Correct regexp for flags in 'format' doc string
Date: Sun, 26 Jan 2020 10:08:17 -0800

Thanks, I installed that in your name into the emacs-27 branch. I think doc 
fixes like that are still good for the emacs-27 branch.

Message #13 received at 39290 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: mattiase <at> acm.org, 39290 <at> debbugs.gnu.org
Subject: Re: bug#39290: [PATCH] Correct regexp for flags in 'format' doc string
Date: Sun, 26 Jan 2020 21:19:13 +0200

> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Sun, 26 Jan 2020 10:08:17 -0800
> Cc: 39290-done <at> debbugs.gnu.org
> 
> Thanks, I installed that in your name into the emacs-27 branch. I think doc 
> fixes like that are still good for the emacs-27 branch.

Doc fixes are always good for the release branch.  It's in CONTRIBUTE.

Message #16 received at 39290 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 39290 <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#39290: [PATCH] Correct regexp for flags in 'format' doc string
Date: Sun, 26 Jan 2020 20:21:28 +0100

26 jan. 2020 kl. 20.19 skrev Eli Zaretskii <eliz <at> gnu.org>:
> 
>> Thanks, I installed that in your name into the emacs-27 branch. I think doc 
>> fixes like that are still good for the emacs-27 branch.
> 
> Doc fixes are always good for the release branch.  It's in CONTRIBUTE.

Thank you both!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.