GNU bug report logs - #39311
[PATCH] gnu: Add guix-vim.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39311 in the body.
You can then email your comments to 39311 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: Add guix-vim.
Date: Mon, 27 Jan 2020 19:20:32 +0200

* gnu/packages/vim.scm (guix-vim): New variable.
---
 gnu/packages/vim.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
index b5952e3e21..a2d715dc1c 100644
--- a/gnu/packages/vim.scm
+++ b/gnu/packages/vim.scm
@@ -938,3 +938,45 @@ through its msgpack-rpc API.")
 
 (define-public python2-pynvim
   (package-with-python2 python-pynvim))
+
+(define-public guix-vim
+  (package
+    (name "guix-vim")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://gitlab.com/Efraim/guix.vim")
+                     (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1f8h8m96fqh3f9hy87spgh9kdqzyxl11n9s3rywvyq5xhn489bnk"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (delete 'build)
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (vimfiles (string-append out "/share/vim/vimfiles"))
+                    (compiler (string-append vimfiles "/compiler"))
+                    (doc      (string-append vimfiles "/doc"))
+                    (indent   (string-append vimfiles "/indent"))
+                    (ftdetect (string-append vimfiles "/ftdetect"))
+                    (ftplugin (string-append vimfiles "/ftplugin"))
+                    (syntax   (string-append vimfiles "/syntax")))
+               (copy-recursively "compiler" compiler)
+               (copy-recursively "doc" doc)
+               (copy-recursively "indent" indent)
+               (copy-recursively "ftdetect" ftdetect)
+               (copy-recursively "ftplugin" ftplugin)
+               (copy-recursively "syntax" syntax)
+               #t))))))
+    (home-page "https://gitlab.com/Efraim/guix.vim")
+    (synopsis "Guix integration in Vim")
+    (description "This package provides support for GNU Guix in Vim.")
+    (license license:vim)))
-- 
2.25.0

Message #8 received at 39311 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 39311 <at> debbugs.gnu.org
Subject: Re: [bug#39311] [PATCH] gnu: Add guix-vim.
Date: Mon, 27 Jan 2020 23:28:20 +0100

Hi Efraim,

> * gnu/packages/vim.scm (guix-vim): New variable.
> ---
>  gnu/packages/vim.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
> index b5952e3e21..a2d715dc1c 100644
> --- a/gnu/packages/vim.scm
> +++ b/gnu/packages/vim.scm
> @@ -938,3 +938,45 @@ through its msgpack-rpc API.")
>  
>  (define-public python2-pynvim
>    (package-with-python2 python-pynvim))
> +
> +(define-public guix-vim

Looks like we usually prefix vim extensions with “vim-”, so should this
be “vim-guix” instead…?

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (vimfiles (string-append out "/share/vim/vimfiles"))
> +                    (compiler (string-append vimfiles "/compiler"))
> +                    (doc      (string-append vimfiles "/doc"))
> +                    (indent   (string-append vimfiles "/indent"))
> +                    (ftdetect (string-append vimfiles "/ftdetect"))
> +                    (ftplugin (string-append vimfiles "/ftplugin"))
> +                    (syntax   (string-append vimfiles "/syntax")))
> +               (copy-recursively "compiler" compiler)
> +               (copy-recursively "doc" doc)
> +               (copy-recursively "indent" indent)
> +               (copy-recursively "ftdetect" ftdetect)
> +               (copy-recursively "ftplugin" ftplugin)
> +               (copy-recursively "syntax" syntax)
> +               #t))))))

The repetition here tickles me a little.  How about this instead…?

(for-each (lambda (dir)
           (copy-recursively dir (string-append vimfiles "/" dir)))
          '("compiler" "doc" "indent" "ftdetect" "ftplugin" "syntax"))

-- 
Ricardo

Message #13 received at 39311-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 39311-done <at> debbugs.gnu.org
Subject: Re: [bug#39311] [PATCH] gnu: Add guix-vim.
Date: Tue, 28 Jan 2020 09:43:17 +0200

[Message part 1 (text/plain, inline)]

On Mon, Jan 27, 2020 at 11:28:20PM +0100, Ricardo Wurmus wrote:
> 
> Hi Efraim,
> 
> > * gnu/packages/vim.scm (guix-vim): New variable.
> > ---
> >  gnu/packages/vim.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 42 insertions(+)
> >
> > diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
> > index b5952e3e21..a2d715dc1c 100644
> > --- a/gnu/packages/vim.scm
> > +++ b/gnu/packages/vim.scm
> > @@ -938,3 +938,45 @@ through its msgpack-rpc API.")
> >  
> >  (define-public python2-pynvim
> >    (package-with-python2 python-pynvim))
> > +
> > +(define-public guix-vim
> 
> Looks like we usually prefix vim extensions with “vim-”, so should this
> be “vim-guix” instead…?

Good call

> 
> > +         (replace 'install
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let* ((out (assoc-ref outputs "out"))
> > +                    (vimfiles (string-append out "/share/vim/vimfiles"))
> > +                    (compiler (string-append vimfiles "/compiler"))
> > +                    (doc      (string-append vimfiles "/doc"))
> > +                    (indent   (string-append vimfiles "/indent"))
> > +                    (ftdetect (string-append vimfiles "/ftdetect"))
> > +                    (ftplugin (string-append vimfiles "/ftplugin"))
> > +                    (syntax   (string-append vimfiles "/syntax")))
> > +               (copy-recursively "compiler" compiler)
> > +               (copy-recursively "doc" doc)
> > +               (copy-recursively "indent" indent)
> > +               (copy-recursively "ftdetect" ftdetect)
> > +               (copy-recursively "ftplugin" ftplugin)
> > +               (copy-recursively "syntax" syntax)
> > +               #t))))))
> 
> The repetition here tickles me a little.  How about this instead…?
> 
> (for-each (lambda (dir)
>            (copy-recursively dir (string-append vimfiles "/" dir)))
>           '("compiler" "doc" "indent" "ftdetect" "ftplugin" "syntax"))

This will also be good if we ever get around to making a
vim-build-system.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.