GNU bug report logs - #39321
[PATCH] gnu: Add emacs-unkillable-scratch.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39321 in the body.
You can then email your comments to 39321 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <mab <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Amin Bandali <mab <at> gnu.org>
Subject: [PATCH] gnu: Add emacs-unkillable-scratch.
Date: Mon, 27 Jan 2020 18:51:21 -0500

* gnu/packages/emacs-xyz.scm (emacs-unkillable-scratch): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c5214405d0..0ff2f5d0c0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21125,3 +21125,26 @@ pattern guessed from thing under current cursor position.
 mercury-mode provided by Emacs as a wrapper around prolog-mode.")
       (home-page "https://github.com/ahungry/metal-mercury-mode")
       (license license:gpl3+))))
+
+(define-public emacs-unkillable-scratch
+  (let ((commit "b24c2a760529833f230c14cb02ff6e7ec92288ab")
+        (revision "0"))
+    (package
+      (name "emacs-unkillable-scratch")
+      (version (git-version "1.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/EricCrosson/unkillable-scratch.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "13wjbcxr3km4s96yhpavgs5acs5pvqv3ih1p84diqb3x3i6wd4pa"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/EricCrosson/unkillable-scratch")
+      (synopsis "Prevents the *scratch* buffer from being killed")
+      (description "@code{unkillable-scratch} helps prevent killing buffers
+matching a given regexp.")
+      (license license:gpl2+))))
-- 
2.25.0

Message #8 received at 39321 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Amin Bandali <mab <at> gnu.org>
Cc: 39321 <at> debbugs.gnu.org
Subject: Re: [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
Date: Tue, 28 Jan 2020 08:53:07 +0100

Hello,

Amin Bandali <mab <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-unkillable-scratch): New variable.

Thank you.

> +(define-public emacs-unkillable-scratch
> +  (let ((commit "b24c2a760529833f230c14cb02ff6e7ec92288ab")
> +        (revision "0"))
> +    (package
> +      (name "emacs-unkillable-scratch")
> +      (version (git-version "1.0.0" revision commit))

Is there any reason to use this particular commit? If so, please add
a comment in the definition. Otherwise, I suggest to stick to stable
releases.

Regards,

-- 
Nicolas Goaziou

Message #11 received at 39321 <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <mab <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39321 <at> debbugs.gnu.org
Subject: Re: [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
Date: Tue, 28 Jan 2020 03:26:26 -0500

[Message part 1 (text/plain, inline)]

Hello,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

[...]
>
> Is there any reason to use this particular commit? If so, please add
> a comment in the definition. Otherwise, I suggest to stick to stable
> releases.
>

The main reason is the introduction of a handy defcustom in [0], and
less importantly other small typo/doc fixes, and lack of a tagged
release in about a year.

[0]: https://github.com/EricCrosson/unkillable-scratch/commit/26102d5434e47c77219fce76c255cafb69b8e222

I think it would be nice if our package included the customization, but
if there’s a strong preference over using a tagged release including in
this case, I’d be happy to send a v2 definition to use a tagged version,
and later inherit from it in my personal channel to make a -git version
including the feature for my own use.

What do you think?

>
> Regards,

Thanks,
amin

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 39321 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Amin Bandali <mab <at> gnu.org>
Cc: 39321 <at> debbugs.gnu.org
Subject: Re: [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
Date: Tue, 28 Jan 2020 10:24:29 +0100

Amin Bandali <mab <at> gnu.org> writes:

> The main reason is the introduction of a handy defcustom in [0], and
> less importantly other small typo/doc fixes, and lack of a tagged
> release in about a year.
>
> [0]: https://github.com/EricCrosson/unkillable-scratch/commit/26102d5434e47c77219fce76c255cafb69b8e222
>
> I think it would be nice if our package included the customization, but
> if there’s a strong preference over using a tagged release including in
> this case, I’d be happy to send a v2 definition to use a tagged version,
> and later inherit from it in my personal channel to make a -git version
> including the feature for my own use.
>
> What do you think?

I'm fine with using the latest release, but could you add a comment
explaining the reasoning in the package definition and send it again?

Thank you!

Regards,

Message #17 received at 39321 <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <mab <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39321 <at> debbugs.gnu.org
Subject: Re: [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
Date: Tue, 28 Jan 2020 12:06:46 -0500

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

[...]
>
> I'm fine with using the latest release, but could you add a comment
> explaining the reasoning in the package definition and send it again?
>

If you meant latest “commit” rather than latest “release”, here’s a v2
that adds an explanatory comment about why we use the latest commit:

[0001-gnu-Add-emacs-unkillable-scratch.patch (text/x-patch, inline)]

From 2204aaf2dfb68f4d466404776805ab739e909b44 Mon Sep 17 00:00:00 2001
From: Amin Bandali <mab <at> gnu.org>
Date: Tue, 28 Jan 2020 12:01:27 -0500
Subject: [PATCH v2] gnu: Add emacs-unkillable-scratch.

* gnu/packages/emacs-xyz.scm (emacs-unkillable-scratch): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e5af72121a..d0ae1e3a04 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21212,3 +21212,29 @@ comment.")
     (description "@code{delight} enables customizing or hiding the
 mode-line text (lighter) of major and minor modes.")
     (license license:gpl3+)))
+
+(define-public emacs-unkillable-scratch
+  ;; Use the latest (unreleased) commit as of now, since it contains a handy
+  ;; `unkillable-scratch-do-not-reset-scratch-buffer' customization to not
+  ;; repopulate the scratch buffer with `initial-scratch-message'.
+  (let ((commit "b24c2a760529833f230c14cb02ff6e7ec92288ab")
+        (revision "0"))
+    (package
+      (name "emacs-unkillable-scratch")
+      (version (git-version "1.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/EricCrosson/unkillable-scratch.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "13wjbcxr3km4s96yhpavgs5acs5pvqv3ih1p84diqb3x3i6wd4pa"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/EricCrosson/unkillable-scratch")
+      (synopsis "Prevents the *scratch* buffer from being killed")
+      (description "@code{unkillable-scratch} helps prevent killing buffers
+matching a given regexp.")
+      (license license:gpl2+))))
-- 
2.25.0

[Message part 3 (text/plain, inline)]

>
> Thank you!
>
> Regards,
>

Cheers,
amin

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 39321-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Amin Bandali <mab <at> gnu.org>
Cc: 39321-done <at> debbugs.gnu.org
Subject: Re: [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
Date: Tue, 28 Jan 2020 20:21:22 +0100

Amin Bandali <mab <at> gnu.org> writes:

> If you meant latest “commit” rather than latest “release”,

Indeed.

> here’s a v2 that adds an explanatory comment about why we use the
> latest commit

Applied as e7c938b2bf591819a64ea0ecb51a863d71339da2. Thank you!

Regards,

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.