GNU bug report logs - #39514
[PATCH] update radare2 and cutter versions

Previous Next

Package: guix-patches;

Reported by: pinoaffe <at> airmail.cc

Date: Sat, 8 Feb 2020 19:18:02 UTC

Severity: normal

Tags: patch

Done: Jakub Kądziołka <kuba <at> kadziolka.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39514 in the body.
You can then email your comments to 39514 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#39514; Package guix-patches. (Sat, 08 Feb 2020 19:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to pinoaffe <at> airmail.cc:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 08 Feb 2020 19:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pinoaffe <at> airmail.cc
To: guix-patches <at> gnu.org
Subject: [PATCH] update radare2 and cutter versions
Date: Sat, 08 Feb 2020 16:53:30 +0100
update radare2 and cutter, they need to be updated at the same time 
since old cutter doesn't build with new radare2 and new cutter doesn't 
build with old radare2
---
 gnu/packages/engineering.scm | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 4db8109249..f76c2800e4 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1270,14 +1270,16 @@ bindings for Python, Java, OCaml and more.")
 (define-public radare2
   (package
     (name "radare2")
-    (version "3.5.1")
+    (version "4.2.1")
     (source (origin
-              (method url-fetch)
-              (uri (string-append "https://radare.mikelloc.com/get/" 
version "/"
-                                  "radare2-" version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/radareorg/radare2")
+                    (commit version)))
               (sha256
                (base32
-                
"174x5545fw2nyf000gd46hi7rx2bn3bw5bsnvizn9yi99pn7m4mw"))
+                
"14b9433cgc2nabhz836zfgvgh2dwailcmvy05krsa0inmzbvx9fg"))
+              (file-name (string-append name "-" version "-checkout"))
               (modules '((guix build utils)))
               (snippet
                '(begin
@@ -1290,7 +1292,7 @@ bindings for Python, Java, OCaml and more.")
                   #t))))
     (build-system gnu-build-system)
     (arguments
-     '(#:tests? #f                      ; tests require git and network 
access
+     '(#:tests? #f              ; tests require git and network access
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'mklibdir
@@ -1312,7 +1314,7 @@ bindings for Python, Java, OCaml and more.")
     (home-page "https://radare.org/")
     (synopsis "Portable reversing framework")
     (description
-      "Radare project started as a forensics tool, a scriptable 
commandline
+     "Radare project started as a forensics tool, a scriptable 
commandline
 hexadecimal editor able to open disk files, but later support for 
analyzing
 binaries, disassembling code, debugging programs, attaching to remote 
gdb
 servers, ...")
@@ -2089,7 +2091,7 @@ simulation.")
 (define-public cutter
   (package
     (name "cutter")
-    (version "1.8.3")
+    (version "1.10.1")
     (source
      (origin
        (method git-fetch)
@@ -2099,7 +2101,7 @@ simulation.")
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "03f3cdckh51anx9gd1b0ndb2fg7061hqngvygf32ky29mm2m2lyv"))))
+         "1gvsrcskcdd1hxrjpkpc657anmfs25f174vxk4wzvn385rnmrxd3"))))
     (build-system gnu-build-system)
     (arguments
      `(#:phases
-- 
2.25.0





Information forwarded to guix-patches <at> gnu.org:
bug#39514; Package guix-patches. (Sat, 15 Feb 2020 12:38:02 GMT) Full text and rfc822 format available.

Message #8 received at 39514 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: pinoaffe <at> airmail.cc, 39514 <at> debbugs.gnu.org
Subject: Re: [bug#39514] [PATCH] update radare2 and cutter versions
Date: Sat, 15 Feb 2020 13:38:15 +0100
[Message part 1 (text/plain, inline)]
Pinoaffe,

pinoaffe <at> airmail.cc 写道:
> update radare2 and cutter, they need to be updated at the same 
> time
> since old cutter doesn't build with new radare2 and new cutter 
> doesn't
> build with old radare2

This is a good reason not to separate the two, although I'm unsure 
what the commit message would look like.

> -    (version "3.5.1")
> +    (version "4.2.1")

Confusingly, their ‘releases’ page[0] lists 4.2.0 as ‘Latest 
release’.  As GitHub actively encourages poor release management 
this might just be an oversight, but it would be nice if this were 
clarified.  Is 4.2.1 generally accepted as the current stable 
release?

> +              (file-name (string-append name "-" version 
> "-checkout"))

There's a (git-file-name name version) helper that will do the 
same thing, prettier.

>      (description
> -      "Radare project started as a forensics tool, a scriptable
> commandline
> +     "Radare project started as a forensics tool, a scriptable

I'm going to improve the radare2 description on master so this 
hunk can be dropped.

Would you be willing to send a V2 patch to this bug number (and 
think of a good commit message following our standards[1])?  

Kind regards,

T G-R

[0]: https://github.com/radareorg/radare2/releasesu
[1]: https://guix.gnu.org/manual/en/guix.html#Submitting-Patches
[signature.asc (application/pgp-signature, inline)]

Reply sent to Jakub Kądziołka <kuba <at> kadziolka.net>:
You have taken responsibility. (Mon, 30 Mar 2020 02:36:52 GMT) Full text and rfc822 format available.

Notification sent to pinoaffe <at> airmail.cc:
bug acknowledged by developer. (Mon, 30 Mar 2020 02:36:53 GMT) Full text and rfc822 format available.

Message #13 received at 39514-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 39514-done <at> debbugs.gnu.org
Subject: Done: [PATCH] update radare2 and cutter versions
Date: Sun, 29 Mar 2020 00:14:13 +0100
[Message part 1 (text/plain, inline)]
These got pushed as two commits about a week ago by Ludovic, but it
seems he forgot to close the bug.

For reference:

commit 6f3475655a60e25328d6fc8a1ce4af19620f0a02
Author: pinoaffe <at> airmail.cc <pinoaffe <at> airmail.cc>
Date:   Sat Mar 21 08:58:35 2020 +0000

    gnu: cutter: Update to 1.10.1.

    * gnu/packages/engineering.scm (cutter): Update to 1.10.1.

    Signed-off-by: Ludovic Courtès <ludo <at> gnu.org>

commit fcc10cb2cbde9c104d394167ba354b0c9f2cd752
Author: pinoaffe <at> airmail.cc <pinoaffe <at> airmail.cc>
Date:   Sat Mar 21 08:57:21 2020 +0000

    gnu: radare2: Update to 4.2.1.

    * gnu/packages/engineering.scm (radare2): Update to 4.2.1.

    Signed-off-by: Ludovic Courtès <ludo <at> gnu.org>
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 27 Apr 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 363 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.