GNU bug report logs - #39576
qdbm: fix segfault during test

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39576 in the body.
You can then email your comments to 39576 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: guix-patches <at> gnu.org
Subject: qdbm: fix segfault during test
Date: Wed, 12 Feb 2020 16:14:57 +0100 (CET)

[Message part 1 (text/plain, inline)]

Hi Guix,

at some point, the package qdbm started running into a segfault 
during the test suite.   This small patch fixes that.

If it's ok, I can push the commit myself (I believe I still have 
commit rights), but since I haven't contributed in 2 years, I wanted 
to check if the patch meets all the requirements...

best,

Thomas

[0001-gnu-qdbm-Fix-segfault-during-tests.patch (text/x-patch, inline)]

From bd557d5f63197712bbe5cde8f4a80e152b7ec586 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert <at> gmail.com>
Date: Wed, 12 Feb 2020 15:31:49 +0100
Subject: [PATCH] gnu: qdbm: Fix segfault during tests.

gnu/packages/databses.scm (qdbm): Add "CFLAGS=-fPIC" to make-flags.
---
 gnu/packages/databases.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 587d993918..1cec7743b2 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -19,7 +19,7 @@
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a <at> scratchpost.org>
 ;;; Copyright © 2016, 2017, 2018, 2019 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017, 2018 Julien Lepiller <julien <at> lepiller.eu>
-;;; Copyright © 2017 Thomas Danckaert <post <at> thomasdanckaert.be>
+;;; Copyright © 2017, 2020 Thomas Danckaert <post <at> thomasdanckaert.be>
 ;;; Copyright © 2017 Jelle Licht <jlicht <at> fsfe.org>
 ;;; Copyright © 2017 Adriano Peluso <catonano <at> gmail.com>
 ;;; Copyright © 2017 Arun Isaac <arunisaac <at> systemreboot.net>
@@ -1060,9 +1060,10 @@ Most public APIs are compatible with @command{mysqlclient} and MySQLdb.")
          "0gmpvhn02pkq280ffmn4da1g4mdr1xxz7l80b7y4n7km1mrzwrml"))))
     (build-system gnu-build-system)
     (arguments
-     `( #:configure-flags (list (string-append "LDFLAGS=-Wl,-rpath="
-                                               (assoc-ref %outputs "out")
-                                               "/lib"))))
+     `(#:configure-flags (list (string-append "LDFLAGS=-Wl,-rpath="
+                                              (assoc-ref %outputs "out")
+                                              "/lib"))
+       #:make-flags '("CFLAGS=-fPIC")))
     (home-page "http://fallabs.com/qdbm")
     (synopsis "Key-value database")
     (description "QDBM is a library of routines for managing a
-- 
2.25.0

Message #8 received at 39576 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 39576 <at> debbugs.gnu.org
Subject: Re: [bug#39576] qdbm: fix segfault during test
Date: Wed, 12 Feb 2020 18:52:20 +0100

[Message part 1 (text/plain, inline)]

Thomas,

Thomas Danckaert 写道：
> at some point, the package qdbm started running into a segfault 
> during the test suite.   This small patch fixes that.
>
> If it's ok, I can push the commit myself (I believe I still have 
> commit rights), but since I haven't contributed in 2 years, I 
> wanted 
> to check if the patch meets all the requirements...

Glad to hear you're still a Guixer.

You're listed as ‘inactive’[0], but TBH I don't know what that 
means.  If you're unable to push and/or interested in reactivating 
your account, let us know.

> -     `( #:configure-flags (list (string-append 
> "LDFLAGS=-Wl,-rpath="
> -                                               (assoc-ref 
> %outputs "out")
> -                                               "/lib"))))
> +     `(#:configure-flags (list (string-append 
> "LDFLAGS=-Wl,-rpath="
> +                                              (assoc-ref 
> %outputs "out")
> +                                              "/lib"))

I'd add a short ‘Fix a segmentation fault in the test suite’ 
comment here.

> +       #:make-flags '("CFLAGS=-fPIC")))

Sticking to one idiom (list …) is slightly newbie-friendlier, but 
LGTM either way.

Thanks!

T G-R

[0]: https://savannah.gnu.org/project/memberlist.php?group=guix

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 39576-done <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: 39576-done <at> debbugs.gnu.org
Cc: me <at> tobias.gr
Subject: qdbm
Date: Sat, 22 Feb 2020 17:49:23 +0100 (CET)

Hi Tobias,

I haven't contributed in a while (a job change made it harder), but 
I'm still an enthusiastic user.

Sorry for the late reply!  It seems like your answer didn't get 
forwarded to my mailbox (either that, or I accidentally removed it... 
I feel both are equally likely), so I only noticed when browsing the 
guix-patches web interface some time later.

I followed your suggestion about (list ...) and pushed the patch 
(after some gpg key expiry date song and dance...).

Thomas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.