GNU bug report logs - #39608
defun occur does not use a coherent value for default-directory (fix included)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39608 in the body.
You can then email your comments to 39608 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stéphane Boucher <Stephane.Boucher <at> acceo.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: defun occur does not use a coherent value for default-directory
 (fix included)
Date: Fri, 14 Feb 2020 19:26:52 +0000

[Message part 1 (text/plain, inline)]

When occur creates an *Occur* buffer, the default-directory variable is implicitly set to the default-directory of the buffer the occurences came from.

When occur REUSES an existing *Occur* buffer, it does not update the default-directory variable.

Following is a patch for emacs 26.3:

--- replace.el.orig            2020-02-14 14:13:34.201656900 -0500
+++ replace.el  2020-02-14 14:17:35.330856900 -0500
@@ -1532,7 +1532,8 @@ (defun occur-1 (regexp nlines bufs &opti
   (let (occur-buf
               (active-bufs (delq nil (mapcar #'(lambda (buf)
                                                                                (when (buffer-live-p buf) buf))
-                                                                    bufs))))
+                                                                   bufs)))
+             (source-buffer-default-directory default-directory))
     ;; Handle the case where one of the buffers we're searching is the
     ;; output buffer.  Just rename it.
     (when (member buf-name (mapcar 'buffer-name active-bufs))
@@ -1544,6 +1545,8 @@ (defun occur-1 (regexp nlines bufs &opti
     (setq occur-buf (get-buffer-create buf-name))
     (with-current-buffer occur-buf
+      ;; make the default-directory of the *Occur* buffer match that of the buffer where the occurences come from
+      (setq default-directory source-buffer-default-directory)
       (if (stringp nlines)
                 (fundamental-mode) ;; This is for collect operation.
               (occur-mode))

[Message part 2 (text/html, inline)]

Message #12 received at 39608 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stéphane Boucher <Stephane.Boucher <at> acceo.com>
Cc: 39608 <at> debbugs.gnu.org
Subject: Re: bug#39608: defun occur does not use a coherent value for
 default-directory (fix included)
Date: Tue, 03 Mar 2020 00:16:01 +0200

> When occur creates an *Occur* buffer, the default-directory variable is
> implicitly set to the default-directory of the buffer the occurences came
> from.
>
> When occur REUSES an existing *Occur* buffer, it does not update the
> default-directory variable.

What default-directory do you expect in case of multi-occur
that displays occurrences from multiple buffers that might be
located in multiple directories?

Message #15 received at 39608 <at> debbugs.gnu.org (full text, mbox):

From: Stéphane Boucher <Stephane.Boucher <at> acceo.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: "39608 <at> debbugs.gnu.org" <39608 <at> debbugs.gnu.org>
Subject: RE: bug#39608: defun occur does not use a coherent value for
 default-directory (fix included)
Date: Tue, 3 Mar 2020 17:03:49 +0000

Defun occur only works with the current buffer.  I even provided a patch on how to fix it.

-----Original Message-----
From: Juri Linkov [mailto:juri <at> linkov.net] 
Sent: March 2, 2020 5:16 PM
To: Stéphane Boucher <Stephane.Boucher <at> acceo.com>
Cc: 39608 <at> debbugs.gnu.org
Subject: Re: bug#39608: defun occur does not use a coherent value for default-directory (fix included)

> When occur creates an *Occur* buffer, the default-directory variable 
> is implicitly set to the default-directory of the buffer the 
> occurences came from.
>
> When occur REUSES an existing *Occur* buffer, it does not update the 
> default-directory variable.

What default-directory do you expect in case of multi-occur that displays occurrences from multiple buffers that might be located in multiple directories?

Message #18 received at 39608 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stéphane Boucher <Stephane.Boucher <at> acceo.com>
Cc: "39608 <at> debbugs.gnu.org" <39608 <at> debbugs.gnu.org>
Subject: Re: bug#39608: defun occur does not use a coherent value for
 default-directory (fix included)
Date: Wed, 04 Mar 2020 02:06:24 +0200

tags 39608 fixed
close 39608 28.0.50
thanks

> Defun occur only works with the current buffer.  I even provided a patch on how to fix it.

Thanks for the patch, now pushed to master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.