GNU bug report logs - #39637
mongo-tools test fail with Go 1.13

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39637 in the body.
You can then email your comments to 39637 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: bug-guix <at> gnu.org
Subject: mongo-tools test fail with Go 1.13
Date: Sun, 16 Feb 2020 16:28:04 -0500 (EST)

Hi Guix,

After the recent Go 1.13 update, the test for mongo-tools package 
(currently at vervsion 3.4.0) fails with:

```
flag provided but not defined: -test.testlogfile
Usage of /tmp/guix-build-mongo-tools-3.4.24.drv-0/go-build972699285/b001/mongofiles.test:
  -convey-json
        When true, emits results in JSON blocks. Default: 'false'
  -convey-silent
        When true, all output from GoConvey is suppressed.
  -convey-story
        When true, emits story output, otherwise emits dot output. When not provided, this flag mirros the value of the '-test.v' flag
  -test.types string
        Comma-separated list of the types of tests to be run (default "unit")
FAIL    github.com/mongodb/mongo-tools/mongofiles       0.002s
FAIL
command "go" "test" "-v" "github.com/mongodb/mongo-tools/mongofiles" failed with status 1
```

I believe that this is related to a change in Go's testing module with 
1.13: https://golang.org/doc/go1.13#testing

For more information, also see the Go bug report: 
https://github.com/golang/go/issues/31859

Note that mongo-tools provides a number of tools in different Go packages, 
and the mongofiles tool is the only one that has this error.

I have tried to adding a call to flag.Parse() in TestMain, which I added, 
as described in the documentation [0], but that did not resolve the 
problem. I'm not exactly sure why. The same fix worked for containerd [1].

[0] https://golang.org/pkg/testing/#hdr-Main
[1] http://git.savannah.gnu.org/cgit/guix.git/commit/?id=13c8e747e86e39c0a8c6ec7da8c812d9bbcb682b

I wonder if the difference is that mongofiles does not use the flag 
package directly, but flag.Parse() is being called in the wrong place in 
one of its dependencies.

A note on versions: the problem persists in the latest release of 
mongo-tools in the 3.4 series, 3.4.24. I have not tried the other release 
series, 3.6, 4.0, and 4.2 because those require dependencies not yet 
packaged in Guix.

I have opened a bug report upstream: 
https://jira.mongodb.org/browse/TOOLS-2482

Thoughts or suggestions?

Best,
Jack

Message #8 received at 39637 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 39637 <at> debbugs.gnu.org
Subject: Re: mongo-tools test fail with Go 1.13
Date: Mon, 17 Feb 2020 10:54:28 -0500 (EST)

On Sun, 16 Feb 2020, Jack Hill wrote:

> I have opened a bug report upstream: 
> https://jira.mongodb.org/browse/TOOLS-2482

Upstream reports, "MongoDB 3.4 is now EOL so it is no longer supported. 
For MongoDB Tools specifically, we're only making critical fixes to 
versions <4.2." Therefore, it seems like the thing to do is to work on 
updating our mongo-tools package.

Best,
Jack

Message #11 received at 39637 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: Guix Devel <guix-devel <at> gnu.org>, 39637 <at> debbugs.gnu.org,
 zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: Policy to remove broken packages
Date: Mon, 22 Jun 2020 18:06:44 +0100

[Message part 1 (text/plain, inline)]

Jack Hill <jackhill <at> jackhill.us> writes:

> On Sat, 20 Jun 2020, Christopher Baines wrote:
>
>> Do you have any examples of packages that are currently broken, and
>> which you'd like to remove?
>
> Perhaps mongo-tools: https://issues.guix.gnu.org/39637
>
> It broke when Go was upgraded to 1.13, and changed the test library. I
> fixed some other Go packages that ran into this issue, but it wasn't
> as easy for mongo-tools. Our version is old, so it should be
> updated. For various reasons, I don't see this package being fixed in
> the short term.

mongo-tools is definitely failing to build, and it has been since the
11th of Feb (2020) I think.

It seems like you got further in understanding this than I did. Given
that this seems like a test failure, and I don't think there's anything
to suggest that the actual functionality doesn't work, the course of
action I see here is to disable either the failing tests, or running the
test suite entirely.

I originally packaged MongoDB and mongo-tools for Guix, but that was
before the licence of MongoDB changed, so I'm not sure about the long
term future of the packages. Keeping the packages we have actually
building though is still useful.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 39637 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Guix Devel <guix-devel <at> gnu.org>, Jack Hill <jackhill <at> jackhill.us>,
 39637 <at> debbugs.gnu.org
Subject: Re: Policy to remove broken packages
Date: Mon, 22 Jun 2020 14:45:11 -0400

On Mon, Jun 22, 2020 at 06:06:44PM +0100, Christopher Baines wrote:
> It seems like you got further in understanding this than I did. Given
> that this seems like a test failure, and I don't think there's anything
> to suggest that the actual functionality doesn't work, the course of
> action I see here is to disable either the failing tests, or running the
> test suite entirely.

Not having looked into it closely, I think that, in general, test
failures do indicate that actual functionality is broken. Of course it's
a different story in many cases since the Guix build environment is so
unusual.

Message #19 received at 39637-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 39637-done <at> debbugs.gnu.org
Subject: mongo-tool no longer in Guix, so the tests no longer fail
Date: Mon, 22 Mar 2021 12:49:47 -0400 (EDT)

mongo-tools was removed from Guix in commit 
097cf21d1d34f4f66a403c3fb6e15b6709c4dd8a so I'm closing this issue.

Best,
Jack

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.