GNU bug report logs - #39648
Reverse my commits on GNOME meta-package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39648 in the body.
You can then email your comments to 39648 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: bug-guix <at> gnu.org
Cc: dannym <at> scratchpost.org
Subject: Reverse my commits on GNOME meta-package
Date: Mon, 17 Feb 2020 13:41:23 -0500

[Message part 1 (text/plain, inline)]

Hello Guix!

@Danny

Could you please reverse my following commits:

1) d36fa50fbf8169018193774782fd21f1b13b9c0e

2) 7922b6f795eb575084546ec9bfb9d40508a9378e

3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f

4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b

I will re-test throughly and re-commit them later. I also apologize for
the mishap.

Thank you!

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 39648 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 39648 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Raghav Gururajan <raghavgururajan <at> disroot.org>
Subject: Re: bug#39648: Reverse my commits on GNOME meta-package
Date: Mon, 17 Feb 2020 20:02:59 +0100

[Message part 1 (text/plain, inline)]

Raghav Gururajan 写道：
> Could you please reverse my following commits:
>
> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
>
> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
>
> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
>
> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b

Copy-pasted from #guix:

Whoa there, that's drastic, let's put that on hold.

The first two only add packages (did they break anything? what?), 
the third has no effect on packages if your commit message is 
accurate.

The fourth is the only one that removes packages, and even that 
might be better tweaked (this time: with comments noting what each 
non-core package brings to the GNOME table) than flat-out 
reverted.

What do you think?

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 39648 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 39648 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: bug#39648: Reverse my commits on GNOME meta-package
Date: Mon, 17 Feb 2020 14:09:05 -0500

[Message part 1 (text/plain, inline)]

> Copy-pasted from #guix:
> 
> Whoa there, that's drastic, let's put that on hold.
> 
> The first two only add packages (did they break anything? what?), 
> the third has no effect on packages if your commit message is 
> accurate.
> 
> The fourth is the only one that removes packages, and even that 
> might be better tweaked (this time: with comments noting what each 
> non-core package brings to the GNOME table) than flat-out 
> reverted.
> 
> What do you think?

I made a mistake of not reading comments of previous commits that were
done to gnome meta-package. Since we got lot of feedbacks regarding
gnome experience, I will re-conyemplate my plans for gnome, make the
changes, test it throughly and then re-commit later.

Also, this reverse should be smooth and does not break anything. It
just takes the GNOME meta-package back to the time before I started
making my commits to it.

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 39648 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 39648 <at> debbugs.gnu.org,
 Raghav Gururajan <raghavgururajan <at> disroot.org>
Subject: Re: bug#39648: Reverse my commits on GNOME meta-package
Date: Mon, 17 Feb 2020 20:19:11 +0100

Hello Tobias,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix <at> gnu.org>
ezt írta (időpont: 2020. febr. 17., H, 20:03):
>
> Raghav Gururajan 写道：
> > Could you please reverse my following commits:
> >
> > 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
> >
> > 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
> >
> > 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
> >
> > 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.

I agree.

>
> The first two only add packages (did they break anything? what?),
> the third has no effect on packages if your commit message is
> accurate.

These findings are accurate. I checked the diff of the third, it's ok.

>
> The fourth is the only one that removes packages, and even that
> might be better tweaked (this time: with comments noting what each
> non-core package brings to the GNOME table) than flat-out
> reverted.
>

I believe the fourth can be reverted if needed.

> What do you think?
>
> Kind regards,
>
> T G-R


Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

Message #17 received at 39648 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Gábor Boskovits <boskovits <at> gmail.com>, Tobias
 Geerinckx-Rice <me <at> tobias.gr>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 39648 <at> debbugs.gnu.org
Subject: Re: bug#39648: Reverse my commits on GNOME meta-package
Date: Mon, 17 Feb 2020 14:25:41 -0500

[Message part 1 (text/plain, inline)]

> I believe the fourth can be reverted if needed.

Some packages that were removed, I made a mistake of not reading the
comments of why it were added in the first place. Some of them were
non-core and some were core but depracated. It gonna take some time for
me to read and understand their exact role and effect on GNOME
experience. Since I am planning+working on new changes anyway, I will
study and test them throughly all together to see how the experience is
and then commit them. :-)

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 39648 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 39646 <at> debbugs.gnu.org,
 39648 <at> debbugs.gnu.org, Raghav Gururajan <raghavgururajan <at> disroot.org>
Subject: Re: bug#39648: Reverse my commits on GNOME meta-package
Date: Sat, 22 Feb 2020 18:08:28 +0100

[Message part 1 (text/plain, inline)]

Hi Tobias & all!

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> Raghav Gururajan 写道：
>> Could you please reverse my following commits:
>>
>> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
>>
>> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
>>
>> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
>>
>> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.
>
> The first two only add packages (did they break anything? what?), the
> third has no effect on packages if your commit message is accurate.
>
> The fourth is the only one that removes packages, and even that might
> be better tweaked (this time: with comments noting what each non-core
> package brings to the GNOME table) than flat-out reverted.
>
> What do you think?

I agree.  As a stop-gap measure, I propose to commit the following
change real soon.  I’ve tested it in a VM; it addresses the points Andy
raised by re-adding the important bits mentioned in
<https://issues.guix.gnu.org/issue/39648>.

Raghav, don’t worry, we all make mistakes!  We can refine this calmly
later on.

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3c63ab283d..c64b182869 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7906,7 +7906,29 @@ world.")
        ("yelp" ,yelp)
      ;; Others
        ("hicolor-icon-theme" ,hicolor-icon-theme)
-       ("gnome-online-accounts" ,gnome-online-accounts)))
+       ("gnome-online-accounts" ,gnome-online-accounts)
+
+       ;; Packages not part of GNOME proper but that are needed for a good
+       ;; experience.  See <https://bugs.gnu.org/39646>.
+       ;; XXX: Find out exactly which ones are needed and why.
+       ("font-cantarell"            ,font-cantarell)
+       ("font-dejavu"               ,font-dejavu)
+       ("at-spi2-core"              ,at-spi2-core)
+       ("dbus"                      ,dbus)
+       ("dconf"                     ,dconf)
+       ("desktop-file-utils"        ,desktop-file-utils)
+       ("gnome-default-applications" ,gnome-default-applications)
+       ("gnome-themes-standard"     ,gnome-themes-standard)
+       ("gst-plugins-base"          ,gst-plugins-base)
+       ("gst-plugins-good"          ,gst-plugins-good)
+       ("gucharmap"                 ,gucharmap)
+       ("pinentry-gnome3"           ,pinentry-gnome3)
+       ("pulseaudio"                ,pulseaudio)
+       ("shared-mime-info"          ,shared-mime-info)
+       ("system-config-printer"     ,system-config-printer)
+       ("xdg-user-dirs"             ,xdg-user-dirs)
+       ("yelp"                      ,yelp)
+       ("zenity"                    ,zenity)))
     (synopsis "The GNU desktop environment")
     (home-page "https://www.gnome.org/")
     (description

Message #27 received at 39648 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Ludovic Courtès" <ludo <at> gnu.org>, "Tobias
 Geerinckx-Rice" <me <at> tobias.gr>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 39646 <at> debbugs.gnu.org,
 39648 <at> debbugs.gnu.org
Subject: Re: bug#39648: Reverse my commits on GNOME meta-package
Date: Sun, 23 Feb 2020 01:19:03 +0000

Hi Ludo!

> I agree. As a stop-gap measure, I propose to commit the following
> change real soon. I’ve tested it in a VM; it addresses the points Andy
> raised by re-adding the important bits mentioned in
> <https://issues.guix.gnu.org/issue/39648>.

Sure, I can do that.

> Raghav, don’t worry, we all make mistakes! We can refine this calmly
> later on.

Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)

Regards,
RG.

Message #30 received at 39648-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, 39646-done <at> debbugs.gnu.org,
 39648-done <at> debbugs.gnu.org
Subject: Re: bug#39648: Reverse my commits on GNOME meta-package
Date: Sun, 23 Feb 2020 12:48:07 +0100

Hi,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> skribis:

>> I agree. As a stop-gap measure, I propose to commit the following
>> change real soon. I’ve tested it in a VM; it addresses the points Andy
>> raised by re-adding the important bits mentioned in
>> <https://issues.guix.gnu.org/issue/39648>.
>
> Sure, I can do that.
>
>> Raghav, don’t worry, we all make mistakes! We can refine this calmly
>> later on.
>
> Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)

OK, pushed as 9f2fef4fb164df81034c2b114292d836a9f6d4f8.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.