GNU bug report logs - #39684
[PATCH] etc: Automatically download the pgp key

Previous Next

Package: guix-patches;

Reported by: Julien Lepiller <julien <at> lepiller.eu>

Date: Thu, 20 Feb 2020 01:23:01 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39684 in the body.
You can then email your comments to 39684 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#39684; Package guix-patches. (Thu, 20 Feb 2020 01:23:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Julien Lepiller <julien <at> lepiller.eu>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 20 Feb 2020 01:23:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] etc: Automatically download the pgp key
Date: Thu, 20 Feb 2020 02:22:20 +0100
Hi guix,

this patch should improve the way the gpg key is fetched. Instead of
asking the user to copy the command, when the user passes
--allow-import-gpg, the script will import the gpg key by itself.

The rationale behind this is a user complaining a few weeks ago on the
Fediverse that the installation video didn't work. In fact, they didn't
understand the gpg command and failed to import the key; mentionning
--allow-import-gpg in the video should help in that case :)




Information forwarded to guix-patches <at> gnu.org:
bug#39684; Package guix-patches. (Thu, 20 Feb 2020 12:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 39684 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 39684 <at> debbugs.gnu.org
Subject: Re: [bug#39684] [PATCH] etc: Automatically download the pgp key
Date: Thu, 20 Feb 2020 13:41:59 +0100
[Message part 1 (text/plain, inline)]
Le Thu, 20 Feb 2020 02:22:20 +0100,
Julien Lepiller <julien <at> lepiller.eu> a écrit :

> Hi guix,
> 
> this patch should improve the way the gpg key is fetched. Instead of
> asking the user to copy the command, when the user passes
> --allow-import-gpg, the script will import the gpg key by itself.
> 
> The rationale behind this is a user complaining a few weeks ago on the
> Fediverse that the installation video didn't work. In fact, they
> didn't understand the gpg command and failed to import the key;
> mentionning --allow-import-gpg in the video should help in that case
> :)
> 
> 
> 

Here is the patch :)
[0001-etc-Add-an-allow-import-gpg-option-to-the-installer-.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#39684; Package guix-patches. (Wed, 18 Mar 2020 10:00:02 GMT) Full text and rfc822 format available.

Message #11 received at 39684 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 39684 <at> debbugs.gnu.org
Subject: Re: [bug#39684] [PATCH] etc: Automatically download the pgp key
Date: Wed, 18 Mar 2020 10:59:00 +0100
Hi Julien!

Julien Lepiller <julien <at> lepiller.eu> skribis:

>>From aebea6bcfa615bc644c9afa1120eeb34f0956c5a Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Thu, 20 Feb 2020 02:14:39 +0100
> Subject: [PATCH] etc: Add an `allow-import-gpg' option to the installer
>  script.
>
> * etc/guix-install.sh: Add an `allow-import-gpg' option to support
> fetching the OpenPGP public key automatically.

Sounds like a good idea.

> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -57,6 +57,7 @@ INF="[ INFO ] "
>  DEBUG=0
>  GNU_URL="https://ftp.gnu.org/gnu/guix/"
>  OPENPGP_SIGNING_KEY_ID="3CE464558A84FDC69DB40CFB090B11993D9AEBB5"
> +GPG_IMPORT=0

Perhaps define:

  OPENPGP_KEY_URL="https://sv.gnu.org/people/viewgpg.php?user_id=15145"

and use it everywhere?

>  # This script needs to know where root's home directory is.  However, we
>  # cannot simply use the HOME environment variable, since there is no guarantee
> @@ -109,9 +110,14 @@ chk_gpg_keyring()
>      # Without --dry-run this command will create a ~/.gnupg owned by root on
>      # systems where gpg has never been used, causing errors and confusion.
>      gpg --dry-run --list-keys ${OPENPGP_SIGNING_KEY_ID} >/dev/null 2>&1 || (
> -        _err "${ERR}Missing OpenPGP public key.  Fetch it with this command:"
> -        echo "  wget https://sv.gnu.org/people/viewgpg.php?user_id=15145 -qO - | gpg --import -"
> -        exit 1
> +        if [ "${GPG_IMPORT}" = "1" ]; then
> +          wget https://sv.gnu.org/people/viewgpg.php?user_id=15145 -qO - | gpg --import -

This would become wget "$OPENPGP_KEY_URL" (better use quotes).

Thanks!

Ludo’.




Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Fri, 19 Nov 2021 15:39:02 GMT) Full text and rfc822 format available.

Notification sent to Julien Lepiller <julien <at> lepiller.eu>:
bug acknowledged by developer. (Fri, 19 Nov 2021 15:39:02 GMT) Full text and rfc822 format available.

Message #16 received at 39684-close <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 39684-close <at> debbugs.gnu.org
Subject: etc: Automatically download the gpg key
Date: Fri, 19 Nov 2021 10:38:42 -0500
[Message part 1 (text/plain, inline)]
An equivalent functionnality was implemented independently, so closing. Thanks!
[Message part 2 (text/html, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 18 Dec 2021 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 91 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.