GNU bug report logs - #3972
23.1.50; c-mode sets M-q to c-fill-paragraph

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs,cc-mode; Severity: wishlist; Reported by: Lennart Borgman <lennart.borgman@HIDDEN>; dated Thu, 30 Jul 2009 05:55:04 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Severity set to 'wishlist' from 'normal' Request was from Andrew Hyatt <ahyatt@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 3972 <at> debbugs.gnu.org:

Received: (at 3972) by debbugs.gnu.org; 12 Feb 2016 04:17:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 11 23:17:23 2016
Received: from localhost ([127.0.0.1]:37169 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aU5AZ-0005ut-0e
	for submit <at> debbugs.gnu.org; Thu, 11 Feb 2016 23:17:23 -0500
Received: from mail-qk0-f178.google.com ([209.85.220.178]:36470)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <ahyatt@HIDDEN>) id 1aU5AX-0005ug-JO
 for 3972 <at> debbugs.gnu.org; Thu, 11 Feb 2016 23:17:21 -0500
Received: by mail-qk0-f178.google.com with SMTP id s68so27360607qkh.3
 for <3972 <at> debbugs.gnu.org>; Thu, 11 Feb 2016 20:17:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-type:content-transfer-encoding;
 bh=tsh0et4Ze/J2Cd9iBHnO6iYiIxnaypAQ2RJiqsPrmdI=;
 b=dEVnh7pDnRmkvtc+4Q8VNeAWUyXa+WIaT7w9/2Wv4bl024pWCaRT8qyKcJ+UXb4hzt
 MiaUMaxzef80ZdDSQJa3GlYWdii1OsSPl50pEoa6OV1O+2ZNwd+5/pL211mBXfL/LlRI
 lbq/ySD4P7jjn9tbZz1XvnVHaMQzEmRQLVniPUpOQSN9WY80yyzJwDFF7aRS5Jo5QgZb
 8V6XdXRTjt/tDo8rXJ/vA+2oQhaca45adq58K63/gmPMHAbluKDFR0t2AIH45e0+a0Ca
 OaxHFWd3NSuTA3HZ0tPSLEhm98IeRJEkOVuPpALSSnFVkuzDy6vlN+BDyfGBvsyjc3JN
 QsNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-type
 :content-transfer-encoding;
 bh=tsh0et4Ze/J2Cd9iBHnO6iYiIxnaypAQ2RJiqsPrmdI=;
 b=EeE0iOc24qXrxCPVwFlwuhrcAEb9reYna/Fw0j8uuzS32u4eBsHie++3wUD9RioKIF
 voaCwVswY4OCWjHXGMeaIW+4794CZrjhw+pSs4ebhMfSqqB4rWTBBaw6QOplXVNynbge
 ZwqDFD2kcSN04YwxD856y+iSHRIejYpiG9DRbYP9p82XIM9acN2PGAA9QNAJlnOr2Xkx
 S1gQkPTFmVPtl655LGL2+jQ1vYf+liknF66uZWRcQEpRRBhXTEbBCe8Hn8ljo9+3jS3A
 WDjnQpZpKsw6PeCmxO1MxJ/qCPqmXDiS28FzHDR7pQpjXWxfYShk8peM5rD7eyVGyf6/
 FuMQ==
X-Gm-Message-State: AG10YORXs66R/NfvdP8e9T+DNFGDb+9zJA+Gjfhq2oqEKGNjV9EJBjDydzs/6ZG9RirfIw==
X-Received: by 10.55.23.224 with SMTP id 93mr46905882qkx.64.1455250636284;
 Thu, 11 Feb 2016 20:17:16 -0800 (PST)
Received: from Andrews-MacBook-Pro.local.ahyatt-laptop
 (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199])
 by smtp.gmail.com with ESMTPSA id q66sm4804592qhb.31.2016.02.11.20.17.13
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 11 Feb 2016 20:17:14 -0800 (PST)
From: Andrew Hyatt <ahyatt@HIDDEN>
To: Lennart Borgman <lennart.borgman@HIDDEN>
Subject: Re: bug#3972: 23.1.50; c-mode sets M-q to c-fill-paragraph
References: <e01d8a50907292247i1c057389rc76136a033e27db7@HIDDEN>
 <20090730104722.GA2397@HIDDEN>
 <e01d8a50907300640y63dec176pd19df68d33ce27ec@HIDDEN>
 <e01d8a50907300744q3ac2b65bqf603f92302aa4f92@HIDDEN>
 <e01d8a50907301752r7b9cd343xa00d8244f6feace8@HIDDEN>
Date: Thu, 11 Feb 2016 23:17:13 -0500
In-Reply-To: <e01d8a50907301752r7b9cd343xa00d8244f6feace8@HIDDEN>
 (Lennart Borgman's message of "Fri, 31 Jul 2009 02:52:02 +0200")
Message-ID: <m2r3gizho6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 3972
Cc: Alan Mackenzie <acm@HIDDEN>, 3972 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Lennart Borgman <lennart.borgman@HIDDEN> writes:

> On Thu, Jul 30, 2009 at 4:44 PM, Lennart
> Borgman<lennart.borgman@HIDDEN> wrote:
>> On Thu, Jul 30, 2009 at 3:40 PM, Lennart
>> Borgman<lennart.borgman@HIDDEN> wrote:
>>
>>> The problem I am actually fighting is a bit different I believe.
>>> c-fill-paragraph is a bit complicated so I am not sure. What I see
>>> when I am testing is that c-fill-paragraph works in some MuMaMo chunks
>>> (ie a chunk of the buffer with one major mode, other than in the
>>> chunks before and after it) and not others, though in both cases the
>>> major mode is php-mode. My guess so far is that it is because of a
>>> (widen) somewhere inside c-fill-paragraph that makes a call to
>>> something, perhaps to syntax-ppss or similar, come back with bad
>>> information (since it is influenced by contents in other chunks).
>>>
>>> What do you think about this guess?
>>
>> I tried to flet widen to ignore. That worked, but when trying to byte
>> compile I got:
>>
>> =C2=A0mumamo.el:6734:57:Error: Byte-compiling a redefinition of `widen'
>> will not work - use `labels' instead
>>
>> But `labels' does a lexical binding, not a dynamic binding so that
>> obviously will not work. So now I don't know what to do...
>> defadvice...?
>
>
> I decided to use defadvice on `widen' (+ enable/disable) for the
> moment. It seems to work fine.
>
> However that c-fill-paragraph is bound to M-q is still a problem, I
> had to rebind that.
>
> I noticed some other problems:
>
> - The doc string for fill-paragraph-function does not say anything
> about the functions arguments.
> - The arguments to c-fill-paragraph is not the expected ones though it
> is used as fill-paragraph-function. (But it works - and I don't
> understand why at the moment...)
>
> Also the double role of c-fill-paragraph is perhaps a difficult design
> (it is used both for M-x and fill-paragraph-function).

This bug feels like a wishlist to me. I don't see a user-visible issue,
just (valid-seeming) design issues. The documentation does seem like a
potential bug, but I'd assume that any function defined in
fill-paragraph-function won't be called with any arguments, since they
aren't mentioned (and I'm not sure which arguments would make sense
anyway).

I'm going to mark this as wishlist, but feel free to disagree.

Information forwarded to bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN:
bug#3972; Package emacs,cc-mode. Full text available.

bug reassigned from package 'emacs' to 'emacs,cc-mode'. Request was from Glenn Morris <rgm@HIDDEN> to control@HIDDEN. Full text available.

Message received at 3972@HIDDEN:

Received: (at 3972) by emacsbugs.donarmstrong.com; 31 Jul 2009 02:19:08 +0000
From lennart.borgman@HIDDEN Thu Jul 30 19:19:08 2009
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available.
	hammytokens:Tokens not available.
X-Spam-Status: No, score=-1.8 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER
	autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02
Received: from mail-yw0-f186.google.com (mail-yw0-f186.google.com [209.85.211.186])
	by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6V2J39Y027881
	for <3972@HIDDEN>; Thu, 30 Jul 2009 19:19:05 -0700
Received: by ywh16 with SMTP id 16so1400555ywh.24
        for <3972@HIDDEN>; Thu, 30 Jul 2009 19:18:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=nJKAIxHIL6LyIehGp8FuxgoBqzRs9c4l6V0+HZLq8XY=;
        b=W7SnVbyxb3gWqaR/bqGiOlTSzwhqxd9JbbIEXPtyWrWh08atPnT1uaEp+YGOJujqxP
         lFbY5laHEhy5TQ4SfZoVaDfxm3fp+CKCbPA31BjBMzcC+5ygmg/psq4vi5lqDUc62zJp
         3KiJiTL/ZuW4wU0EWE+lNOVM+Satr1Zy+nSm0=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=oG/14yrW+PJ9e1XxH5MTFm/GM1m+hXPS0I3uk8vb8ABwtB2cdrVQcffrNcNUi6jCkk
         ARHpb1lLJCkMd76hX9M6wZvwD6JgiyZPK/V/5oiBOJQTYoJvK+BoSi/uICz0Z7yVF8PM
         3VLYePT88P0DlcE7uN/9DiUWernMtvyokQ0Xw=
MIME-Version: 1.0
Received: by 10.100.208.9 with SMTP id f9mr2543436ang.55.1249001522298; Thu, 
	30 Jul 2009 17:52:02 -0700 (PDT)
In-Reply-To: <e01d8a50907300744q3ac2b65bqf603f92302aa4f92@HIDDEN>
References: <e01d8a50907292247i1c057389rc76136a033e27db7@HIDDEN>
	 <20090730104722.GA2397@HIDDEN>
	 <e01d8a50907300640y63dec176pd19df68d33ce27ec@HIDDEN>
	 <e01d8a50907300744q3ac2b65bqf603f92302aa4f92@HIDDEN>
Date: Fri, 31 Jul 2009 02:52:02 +0200
Message-ID: <e01d8a50907301752r7b9cd343xa00d8244f6feace8@HIDDEN>
Subject: Re: bug#3972: 23.1.50; c-mode sets M-q to c-fill-paragraph
From: Lennart Borgman <lennart.borgman@HIDDEN>
To: Alan Mackenzie <acm@HIDDEN>
Cc: 3972 <at> debbugs.gnu.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 30, 2009 at 4:44 PM, Lennart
Borgman<lennart.borgman@HIDDEN> wrote:
> On Thu, Jul 30, 2009 at 3:40 PM, Lennart
> Borgman<lennart.borgman@HIDDEN> wrote:
>
>> The problem I am actually fighting is a bit different I believe.
>> c-fill-paragraph is a bit complicated so I am not sure. What I see
>> when I am testing is that c-fill-paragraph works in some MuMaMo chunks
>> (ie a chunk of the buffer with one major mode, other than in the
>> chunks before and after it) and not others, though in both cases the
>> major mode is php-mode. My guess so far is that it is because of a
>> (widen) somewhere inside c-fill-paragraph that makes a call to
>> something, perhaps to syntax-ppss or similar, come back with bad
>> information (since it is influenced by contents in other chunks).
>>
>> What do you think about this guess?
>
> I tried to flet widen to ignore. That worked, but when trying to byte
> compile I got:
>
> =C2=A0mumamo.el:6734:57:Error: Byte-compiling a redefinition of `widen'
> will not work - use `labels' instead
>
> But `labels' does a lexical binding, not a dynamic binding so that
> obviously will not work. So now I don't know what to do...
> defadvice...?


I decided to use defadvice on `widen' (+ enable/disable) for the
moment. It seems to work fine.

However that c-fill-paragraph is bound to M-q is still a problem, I
had to rebind that.

I noticed some other problems:

- The doc string for fill-paragraph-function does not say anything
about the functions arguments.
- The arguments to c-fill-paragraph is not the expected ones though it
is used as fill-paragraph-function. (But it works - and I don't
understand why at the moment...)

Also the double role of c-fill-paragraph is perhaps a difficult design
(it is used both for M-x and fill-paragraph-function).

Acknowledgement sent to Lennart Borgman <lennart.borgman@HIDDEN>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs@HIDDEN>. Full text available.