GNU bug report logs - #39739
New: ac-geiser

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39739 in the body.
You can then email your comments to 39739 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>
To: guix-patches <at> gnu.org
Subject: New: ac-geiser
Date: Sat, 22 Feb 2020 14:29:09 +0100

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-emacs-ac-geiser.patch (text/x-patch, attachment)]

Message #8 received at 39739 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>, 39739 <at> debbugs.gnu.org
Subject: Re: [bug#39739] New: ac-geiser
Date: Sat, 22 Feb 2020 18:01:10 +0000

Hi Jeremy,

Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr> writes:

> Subject: [PATCH 1/1] gnu: Add emacs-ac-geiser.
>
>   * gnu/packages/emacs-xyz.scm (emacs-ac-geiser): New variable

To follow this project's conventions, I think the leading spaces should
be dropped and a period added at the end.

> +(define-public emacs-ac-geiser
> +  (package
> +    (name "emacs-ac-geiser")
> +    (version "0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://stable.melpa.org/packages/ac-geiser-"
> +             version
> +             ".tar"))

Hmm, I see only one existing package definition that uses a
stable.melpa.org URL, and it looks like these URLs should be avoided for
mutability reasons:

  https://lists.gnu.org/archive/html/guix-patches/2019-03/msg00367.html

Can you replace this with a git-fetch from GitHub?

> +       (sha256
> +        (base32
> +         "17l5bpzpldzyazbpjg67f17x3n5q081xffx4jz7jblbk7bcybzrj"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-geiser" ,emacs-geiser)
> +       ("emacs-auto-complete" ,emacs-auto-complete)))
> +    (home-page "https://github.com/xiaohanyu/ac-geiser/")
> +    (synopsis "Auto-complete backend for geiser")
> +    (description
> +     "Provides one auto-complete source for Scheme projects using geiser.
> +")

style nit: Please put this closing quote and parenthesis on the previous
line.

> +    (license license:bsd-3)))

This does match what's in the LICENSE file, but the header in
ac-geiser.el claims that it's gpl3+.  Perhaps it's worth asking upstream
for clarification.

Message #11 received at 39739 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>
To: 39739 <at> debbugs.gnu.org
Subject: Here is the patch updated
Date: Thu, 19 Mar 2020 00:22:34 +0100

[Message part 1 (text/plain, inline)]

Freely yours,

Jérémy

[0001-gnu-Add-emacs-ac-geiser.patch (text/x-patch, attachment)]

Message #14 received at 39739 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>, 39739 <at> debbugs.gnu.org
Subject: Re: [bug#39739] Here is the patch updated
Date: Thu, 19 Mar 2020 02:39:27 +0000

Hi Jérémy,

Thanks for the update and for clarifying the license with the author.

Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr> writes:

> +;;; Copyright © 2020 Jérémy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>

This has a trivial conflict with master (4a0399e277 at the time I
applied it for testing).  That'd be easy for whoever eventually commits
your patch to clean up, but, if you resend the patch for the other
reasons I mention below, it'd be good to resolve it on your end by
moving that to a newer base.

> +(define-public emacs-ac-geiser
> +  (package
> +    (name "emacs-ac-geiser")
> +    (version "0.1")
> +    (source
> +     (origin

You should specify a `file-name' so that the directory in the store
contains the package name.  Note that you can run `guix lint' to catch
issues like these:

  $ pre-inst-env guix lint emacs-ac-geiser
  gnu/packages/emacs-xyz.scm:21842:5: emacs-ac-geiser <at> 0.1: the source
  file name should contain the package name

> +       (uri (git-reference
> +             (url "https://github.com/xiaohanyu/ac-geiser.git")
> +             (commit "502d18a8a0bd4b5fdd495a99299ba2a632c5cd9a")))

This commit is a couple of commits after the v0.1 tag, so you can
represent that with something like

  (let ((commit "abcdef...")
        (revision "0"))
    (package
      ...
      (version (git-version "0.1" revision commit))
      (source
       (origin
         (uri (git-reference
               (url "https://github.com/xiaohanyu/ac-geiser.git")
               (commit "abcdef...")))

You can find a good number of examples in emacs-xyz.scm.

Because the author clarified the license in the next commit
(93818c936ee7e2f1ba1b315578bde363a7d43d05), I think that'd be a good
commit to use.

> +       (method git-fetch)
> +       (sha256 (base32 "0h2kakb4f5hgzf5l2kpqngalcmc4402lkg1pvs88c8z4rqp2vfvz"))))

Formatting/consistency nit: Most packages put "(base32 ..." on a new
line.  I think the same is true, to a lesser extent, for the value of
propagated-inputs below.

> +    (build-system emacs-build-system)
> +    (propagated-inputs `(("geiser" ,emacs-geiser)
> +                         ("auto-complete" ,emacs-auto-complete)))
> +    (synopsis "Auto-complete backend for geiser")
> +    (description "Provides one auto-complete source for Scheme projects using geiser.")
> +    (license license:bsd-3)
> +    (home-page "https://github.com/xiaohanyu/ac-geiser")))

Thanks!

Message #17 received at 39739 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>
To: Kyle Meyer <kyle <at> kyleam.com>, 39739 <at> debbugs.gnu.org
Subject: Re: [bug#39739] Here is the patch updated
Date: Fri, 27 Mar 2020 15:54:56 +0100

[Message part 1 (text/plain, inline)]

Le jeudi 19 mars 2020 à 02:39 +0000, Kyle Meyer a écrit :
> Hi Jérémy,
> 
> Thanks for the update and for clarifying the license with the author.
> 
> Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr> writes:
> 
> > +;;; Copyright © 2020 Jérémy Korwin-Zmijowski <
> > jeremy <at> korwin-zmijowski.fr>
> 
> This has a trivial conflict with master (4a0399e277 at the time I
> applied it for testing).  That'd be easy for whoever eventually
> commits
> your patch to clean up, but, if you resend the patch for the other
> reasons I mention below, it'd be good to resolve it on your end by
> moving that to a newer base.
> 
> > +(define-public emacs-ac-geiser
> > +  (package
> > +    (name "emacs-ac-geiser")
> > +    (version "0.1")
> > +    (source
> > +     (origin
> 
> You should specify a `file-name' so that the directory in the store
> contains the package name.  Note that you can run `guix lint' to
> catch
> issues like these:
> 
>   $ pre-inst-env guix lint emacs-ac-geiser
>   gnu/packages/emacs-xyz.scm:21842:5: emacs-ac-geiser <at> 0.1: the source
>   file name should contain the package name
> 
> > +       (uri (git-reference
> > +             (url "https://github.com/xiaohanyu/ac-geiser.git")
> > +             (commit "502d18a8a0bd4b5fdd495a99299ba2a632c5cd9a")))
> 
> This commit is a couple of commits after the v0.1 tag, so you can
> represent that with something like
> 
>   (let ((commit "abcdef...")
>         (revision "0"))
>     (package
>       ...
>       (version (git-version "0.1" revision commit))
>       (source
>        (origin
>          (uri (git-reference
>                (url "https://github.com/xiaohanyu/ac-geiser.git")
>                (commit "abcdef...")))
> 
> You can find a good number of examples in emacs-xyz.scm.
> 
> Because the author clarified the license in the next commit
> (93818c936ee7e2f1ba1b315578bde363a7d43d05), I think that'd be a good
> commit to use.
> 
> > +       (method git-fetch)
> > +       (sha256 (base32
> > "0h2kakb4f5hgzf5l2kpqngalcmc4402lkg1pvs88c8z4rqp2vfvz"))))
> 
> Formatting/consistency nit: Most packages put "(base32 ..." on a new
> line.  I think the same is true, to a lesser extent, for the value of
> propagated-inputs below.
> 
> > +    (build-system emacs-build-system)
> > +    (propagated-inputs `(("geiser" ,emacs-geiser)
> > +                         ("auto-complete" ,emacs-auto-complete)))
> > +    (synopsis "Auto-complete backend for geiser")
> > +    (description "Provides one auto-complete source for Scheme
> > projects using geiser.")
> > +    (license license:bsd-3)
> > +    (home-page "https://github.com/xiaohanyu/ac-geiser")))
> 
> Thanks!

Hey Kyle,

I hope this one can do the job !

As I see three commits after the 0.1 release, I valued revision to 3.

Take care.

Jérémy

[0001-gnu-Add-emacs-ac-geiser.patch (text/x-patch, attachment)]

Message #20 received at 39739 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>
Cc: Kyle Meyer <kyle <at> kyleam.com>, 39739 <at> debbugs.gnu.org
Subject: Re: [bug#39739] Here is the patch updated
Date: Fri, 27 Mar 2020 16:47:28 -0400

On Fri, Mar 27, 2020 at 03:54:56PM +0100, Jeremy Korwin-Zmijowski wrote:
> As I see three commits after the 0.1 release, I valued revision to 3.

The revision field refers to the Guix package revision [0]. It's up to
the patch author if we start at 0 or 1, though.

[0] See the manual section Version Numbers

Message #23 received at 39739 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>
To: Leo Famulari <leo <at> famulari.name>
Cc: Kyle Meyer <kyle <at> kyleam.com>, 39739 <at> debbugs.gnu.org
Subject: Re: [bug#39739] Here is the patch updated
Date: Fri, 27 Mar 2020 23:38:35 +0100

[Message part 1 (text/plain, inline)]

Le vendredi 27 mars 2020 à 16:47 -0400, Leo Famulari a écrit :
> On Fri, Mar 27, 2020 at 03:54:56PM +0100, Jeremy Korwin-Zmijowski
> wrote:
> > As I see three commits after the 0.1 release, I valued revision to
> > 3.
> 
> The revision field refers to the Guix package revision [0]. It's up
> to
> the patch author if we start at 0 or 1, though.
> 
> [0] See the manual section Version Numbers

Hi Leo !

Thank you for pointing this out. I set revision to 0.

Jérémy

[0001-gnu-Add-emacs-ac-geiser.patch (text/x-patch, attachment)]

Message #26 received at 39739 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>, 39739 <at> debbugs.gnu.org
Subject: Re: [bug#39739] Here is the patch updated
Date: Sat, 28 Mar 2020 03:28:43 +0000

Hi Jérémy,

Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr> writes:
> Hey Kyle,
>
> I hope this one can do the job !

After the last iteration you sent to address Leo's comment, the patch
looks good to me.

Thanks for the updates.

Message #31 received at 39739-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>,
 Leo Famulari <leo <at> famulari.name>
Cc: Kyle Meyer <kyle <at> kyleam.com>, 39739-done <at> debbugs.gnu.org
Subject: Re: [bug#39739] Here is the patch updated
Date: Thu, 02 Apr 2020 18:33:59 +0200

[Message part 1 (text/plain, inline)]

Jeremy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr> writes:

> Le vendredi 27 mars 2020 à 16:47 -0400, Leo Famulari a écrit :
>> On Fri, Mar 27, 2020 at 03:54:56PM +0100, Jeremy Korwin-Zmijowski
>> wrote:
>> > As I see three commits after the 0.1 release, I valued revision to
>> > 3.
>> 
>> The revision field refers to the Guix package revision [0]. It's up
>> to
>> the patch author if we start at 0 or 1, though.
>> 
>> [0] See the manual section Version Numbers
>
> Hi Leo !
>
> Thank you for pointing this out. I set revision to 0.
>
> Jérémy
> From b1dfe04260e6a2127cdf59239989485a2dc3b5ea Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Korwin-Zmijowski?=
>  <jeremy <at> korwin-zmijowski.fr>
> Date: Fri, 27 Mar 2020 15:49:53 +0100
> Subject: [PATCH 1/1] gnu: Add emacs-ac-geiser. * gnu/packages/emacs-xyz.scm
>  (emacs-ac-geiser): New variable.

Applied!  I fixed the missing newline in the commit message and turned
the description into a full sentence. 

Also thanks for making upstream clarify the license situation!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.