GNU bug report logs - #39741
[PATCH 5/7] gnu: java-openjfx-swt: Add new variable.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39741 in the body.
You can then email your comments to 39741 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: guix-patches <at> gnu.org
Subject: [PATCH 5/7] gnu: java-openjfx-swt: Add new variable.
Date: Sat, 22 Feb 2020 21:17:53 +0100

---
 gnu/packages/java.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index f2a3861501..60f220f873 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -3059,6 +3059,19 @@ distribution.")))
            (propagated-inputs
             `(("java-openjfx-graphics" ,java-openjfx-graphics)))))
 
+(define-public java-openjfx-swt
+  (package (inherit java-openjfx-build)
+           (name "java-openjfx-swt")
+           (arguments
+            `(#:jar-name "java-openjfx-swt.jar"
+              #:source-dir "modules/swt/src/main/java"
+              #:tests? #f))
+           (inputs
+            `(("antlr3" ,antlr3)
+              ("java-stringtemplate" ,java-stringtemplate)))
+           (propagated-inputs
+            `(("java-openjfx-graphics" ,java-openjfx-graphics)))))
+
 (define-public java-openjfx-media
   (package (inherit java-openjfx-build)
     (name "java-openjfx-media")
-- 
2.24.1

Message #10 received at 39741 <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: 39741 <at> debbugs.gnu.org
Cc: Alexey Abramov <levenson <at> mmer.org>
Subject: [v2] gnu: java-openjfx-swt: Add new variable.
Date: Mon,  9 Mar 2020 17:41:46 +0100

---
 gnu/packages/java.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 6d3f0f6771..1625195120 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -3097,6 +3097,19 @@ distribution.")))
     (propagated-inputs
      `(("java-openjfx-graphics" ,java-openjfx-graphics)))))
 
+(define-public java-openjfx-swt
+  (package (inherit java-openjfx-build)
+    (name "java-openjfx-swt")
+    (arguments
+     `(#:jar-name "java-openjfx-swt.jar"
+       #:source-dir "modules/swt/src/main/java"
+       #:tests? #f))
+    (inputs
+     `(("antlr3" ,antlr3)
+       ("java-stringtemplate" ,java-stringtemplate)))
+    (propagated-inputs
+     `(("java-openjfx-graphics" ,java-openjfx-graphics)))))
+
 (define-public java-openjfx-media
   (package (inherit java-openjfx-build)
     (name "java-openjfx-media")
-- 
2.24.1

Message #13 received at 39741 <at> debbugs.gnu.org (full text, mbox):

From: levenson <at> mmer.org
To: Leo Famulari <leo <at> famulari.name>
Cc: 39745 <at> debbugs.gnu.org, 39741 <at> debbugs.gnu.org,
 Alexey Abramov <levenson <at> mmer.org>
Subject: Re: [bug#39745] [PATCH 4/7] gnu: java-openjfx-swing: Add new variable.
Date: Mon, 09 Mar 2020 23:08:14 +0100

Thank you!

Leo Famulari <leo <at> famulari.name> writes:

> On Sat, Feb 22, 2020 at 09:17:52PM +0100, Alexey Abramov wrote:
>> * gnu/packages/java.scm (java-openjfx-build): Add patch to the base package.
>> * gnu/packages/patches/java-openjfx-build-swing-compile-JFXPanel-with-JDK-8.patch: Fix swing compilation for jdk8.
>
> This commit adds the patch file but also makes a new package
> java-openjfx-swing. Adding the patch to java-openjfx-build and adding
> the new package should be done in separate commits.

I split the change into two separated commits. v3

> Also remember to add the patch to 'gnu/local.mk'.
>
>> +From 173e65937d9e76872df51f7ba39c9d58986dc38f Mon Sep 17 00:00:00 2001
>> +From: Alexey Abramov <levenson <at> mmer.org>
>> +Date: Fri, 3 Jan 2020 01:17:45 +0100
>> +Subject: [PATCH] java-openjfx-build: Cannot compile JFXPanel with JDK 8
>> +
>> +For more info please see https://bugs.openjdk.java.net/browse/JDK-8149967
>
> This link is great but please add a brief summary of why we need the
> patch and what it does (one or two sentences is enough).

--
Alexey

Message #16 received at 39741 <at> debbugs.gnu.org (full text, mbox):

From: levenson <at> mmer.org
To: Leo Famulari <leo <at> famulari.name>
Cc: 39746 <at> debbugs.gnu.org, 39741 <at> debbugs.gnu.org,
 Alexey Abramov <levenson <at> mmer.org>
Subject: Re: [bug#39746] [PATCH 7/7] gnu: java-openjfx-web: Add new variable.
Date: Mon, 09 Mar 2020 23:13:05 +0100

Leo Famulari <leo <at> famulari.name> writes:

> On Sat, Feb 22, 2020 at 09:17:55PM +0100, Alexey Abramov wrote:
>> * gnu/packages/java.scm (java-openjfx-build): Add patch to the base package.
>> * gnu/packages/patches/java-openjfx-build-web-Check-xlocale.h-header-file.patch: New
>>   file. Remove hardcoded xlocale definitions.
>
> I have the same comments as previously. We need to fix up the commit
> message, add java-openjfx-web in a separate commit, and add some
> description to the xlocale patch file.

I fixed the comment, add description to the patch and split the change
into two commits.

> Can you send a revised patch series? You can add the argument
> '--subject-prefix=v2' to your `git send-email` or `git format-patch`
> command to distinguish the new patches from the old ones.
>
> Thanks!

Thank you for subject-prefix tip! 

-- 
Alexey

Message #19 received at 39741 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 39746 <at> debbugs.gnu.org, 39741 <at> debbugs.gnu.org,
 Alexey Abramov <levenson <at> mmer.org>, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#39746] [PATCH 7/7] gnu: java-openjfx-web: Add new variable.
Date: Tue, 17 Mar 2020 23:17:41 +0100

[Message part 1 (text/plain, inline)]

Alexey,

levenson <at> mmer.org 写道：
> Thank you for subject-prefix tip! 

The shorter ‘-v2’ will do the right thing too.

(While writing this I found out it's not documented in the man 
page, but it works.)

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.