GNU bug report logs - #39742
[PATCH 1/7] gnu: java-openjfx-build: Add helpful patch.

Previous Next

Package: guix-patches;

Reported by: Alexey Abramov <levenson <at> mmer.org>

Date: Sat, 22 Feb 2020 20:20:03 UTC

Severity: normal

Tags: patch

Merged with 39741, 39743, 39744, 39745, 39746, 39747

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39742 in the body.
You can then email your comments to 39742 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Sat, 22 Feb 2020 20:20:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alexey Abramov <levenson <at> mmer.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 22 Feb 2020 20:20:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch.
Date: Sat, 22 Feb 2020 21:17:49 +0100
* gnu/packages/java.scm: Add patch
* gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New
  file. Allows you to run gradlew to run properly. Useful for debugging.
---
 gnu/packages/java.scm                              |  3 ++-
 .../java-openjfx-build-get_guix_jdk_version.patch  | 14 ++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 9371901e1f..01541ee419 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -2355,7 +2355,8 @@ new Date();"))
               (file-name (string-append name "-" version "-checkout"))
               (sha256
                (base32
-                "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))))
+                "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))
+              (patches (search-patches "java-openjfx-build-get_guix_jdk_version.patch"))))
     (build-system ant-build-system)
     (arguments
      `(#:jar-name "java-openjfx.jar"
diff --git a/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
new file mode 100644
index 0000000000..214ef9949c
--- /dev/null
+++ b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
@@ -0,0 +1,14 @@
+--- a/build.gradle
++++ b/build.gradle
+@@ -742,9 +742,9 @@
+     if (inStream.readLine() != null) {
+         String v = inStream.readLine();
+         if (v != null) {
+-            int ib = v.indexOf(" (build ");
++            int ib = v.indexOf(" (guix build ");
+             if (ib != -1) {
+-                String ver = v.substring(ib + 8, v.size() - 1);
++                String ver = v.substring(ib + 13, v.size() - 1);
+ 
+                 defineProperty("jdkRuntimeVersion", ver)
+                 defineProperty("jdkVersion", jdkRuntimeVersion.split("-")[0])
-- 
2.24.1





Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Tue, 03 Mar 2020 17:34:02 GMT) Full text and rfc822 format available.

Message #8 received at 39742 <at> debbugs.gnu.org (full text, mbox):

From: levenson <at> mmer.org
To: guix-devel <at> gnu.org
Cc: 39742 <at> debbugs.gnu.org
Subject: Re: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful
 patch.
Date: Tue, 03 Mar 2020 18:33:34 +0100
Hi

I packaged openjfx and would like to get some review. Can someone take a look?

Alexey Abramov <levenson <at> mmer.org> writes:

> * gnu/packages/java.scm: Add patch
> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New
>   file. Allows you to run gradlew to run properly. Useful for debugging.
> ---
>  gnu/packages/java.scm                              |  3 ++-
>  .../java-openjfx-build-get_guix_jdk_version.patch  | 14 ++++++++++++++
>  2 files changed, 16 insertions(+), 1 deletion(-)
>  create mode 100644 gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 9371901e1f..01541ee419 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2355,7 +2355,8 @@ new Date();"))
>                (file-name (string-append name "-" version "-checkout"))
>                (sha256
>                 (base32
> -                "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))))
> +                "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))
> +              (patches (search-patches "java-openjfx-build-get_guix_jdk_version.patch"))))
>      (build-system ant-build-system)
>      (arguments
>       `(#:jar-name "java-openjfx.jar"
> diff --git a/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
> new file mode 100644
> index 0000000000..214ef9949c
> --- /dev/null
> +++ b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
> @@ -0,0 +1,14 @@
> +--- a/build.gradle
> ++++ b/build.gradle
> +@@ -742,9 +742,9 @@
> +     if (inStream.readLine() != null) {
> +         String v = inStream.readLine();
> +         if (v != null) {
> +-            int ib = v.indexOf(" (build ");
> ++            int ib = v.indexOf(" (guix build ");
> +             if (ib != -1) {
> +-                String ver = v.substring(ib + 8, v.size() - 1);
> ++                String ver = v.substring(ib + 13, v.size() - 1);
> + 
> +                 defineProperty("jdkRuntimeVersion", ver)
> +                 defineProperty("jdkVersion", jdkRuntimeVersion.split("-")[0])

-- 
Alexey




Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Wed, 04 Mar 2020 02:57:01 GMT) Full text and rfc822 format available.

Message #11 received at 39742 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: 39742 <at> debbugs.gnu.org
Subject: Re: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful
 patch.
Date: Tue, 3 Mar 2020 21:56:07 -0500
Hi,

Thanks for these patches and sorry for the delay in review! There are a
lot of patches and it takes a while to get through them.

On Sat, Feb 22, 2020 at 09:17:49PM +0100, Alexey Abramov wrote:
> * gnu/packages/java.scm: Add patch
> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New
>   file. Allows you to run gradlew to run properly. Useful for debugging.

The commit message needs a couple changes, to something like this:

------
* gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/java.scm (java-openjfx-build)[source]: Use it.
------

We don't need to describe the patch in the commit message. Instead, we
explain it in a comment at the beginning of the patch file itself. This
is easier for the people that will read the patch later. The comment
should explain what the patch does and where it came from, including
links to bug reports and external patch sources, if they exist.

We need to register the new patch file in 'gnu/local.mk', so that it
gets distributed in the Guix release process.

And finally, we need to name the package variable (java-openjfx-build)
that the patch is being used by.

Here is an example from an older commit:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ca5e404f9a1ff81a38a32578c9c3a6c866482a9a




Merged 39741 39742 39743 39744 39745 39746 39747. Request was from Leo Famulari <leo <at> famulari.name> to control <at> debbugs.gnu.org. (Wed, 04 Mar 2020 03:15:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Thu, 05 Mar 2020 19:10:01 GMT) Full text and rfc822 format available.

Message #16 received at 39742 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 39742 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful
 patch.
Date: Thu, 5 Mar 2020 20:09:25 +0100
[Message part 1 (text/plain, inline)]
Hi Alexey,

On Sat, 22 Feb 2020 21:17:49 +0100
Alexey Abramov <levenson <at> mmer.org> wrote:

> * gnu/packages/java.scm: Add patch
> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch:
> New file. Allows you to run gradlew to run properly. Useful for
> debugging. ---

This sentence sounds suspicious :-)

In Guix, we build everything from source. If we need a compiler,
library, or build-tool, we build that also from source.

Here, the problem is that:

gradle/wrapper/gradle-wrapper.jar

is a binary JAR-file included in the sources, which is used by the
'gradlew' script. This jar-file should not be part of the original
sources used to to compile this package.

Whenever sources contain unwanted binaries, we use 'snippets' to remove
them before doing any further steps. You will find them in many places
in the java.scm file, just search for 'snippet', for example in the
package java-cisd-jhdf5.

For using gradle, we need to compile gradle from sources, but this is
very hard, there are some bootstrapping problems involed in this.

So, first we should first snipp away the jar-files from the original
java-openjfx-build package by Julien.

And second, I hope you don't rely on the gradle build in any way
here :-)

Björn

>  gnu/packages/java.scm                              |  3 ++-
>  .../java-openjfx-build-get_guix_jdk_version.patch  | 14
> ++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-)
>  create mode 100644
> gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 9371901e1f..01541ee419 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2355,7 +2355,8 @@ new Date();"))
>                (file-name (string-append name "-" version
> "-checkout")) (sha256
>                 (base32
> -
> "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))))
> +
> "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))
> +              (patches (search-patches
> "java-openjfx-build-get_guix_jdk_version.patch")))) (build-system
> ant-build-system) (arguments
>       `(#:jar-name "java-openjfx.jar"
> diff --git
> a/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
> b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
> new file mode 100644 index 0000000000..214ef9949c --- /dev/null
> +++
> b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
> @@ -0,0 +1,14 @@ +--- a/build.gradle
> ++++ b/build.gradle
> +@@ -742,9 +742,9 @@
> +     if (inStream.readLine() != null) {
> +         String v = inStream.readLine();
> +         if (v != null) {
> +-            int ib = v.indexOf(" (build ");
> ++            int ib = v.indexOf(" (guix build ");
> +             if (ib != -1) {
> +-                String ver = v.substring(ib + 8, v.size() - 1);
> ++                String ver = v.substring(ib + 13, v.size() - 1);
> + 
> +                 defineProperty("jdkRuntimeVersion", ver)
> +                 defineProperty("jdkVersion",
> jdkRuntimeVersion.split("-")[0])

[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Thu, 05 Mar 2020 20:11:02 GMT) Full text and rfc822 format available.

Message #19 received at 39742 <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 39742 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful
 patch.
Date: Thu, 05 Mar 2020 21:10:01 +0100
Hi,

I have been trying to compile it so many times, so I patched the file for 
easy debugging )

I traced some confusing parts of a build.gradle using gradlew ...  
--verbose to translate it in Scheme.


Alexey

On March 5, 2020 19:38:40 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> 
wrote:

> Hi Alexey,
>
> On Sat, 22 Feb 2020 21:17:49 +0100
> Alexey Abramov <levenson <at> mmer.org> wrote:
>
>> * gnu/packages/java.scm: Add patch
>> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch:
>> New file. Allows you to run gradlew to run properly. Useful for
>> debugging. ---
>
> This sentence sounds suspicious :-)
>
> In Guix, we build everything from source. If we need a compiler,
> library, or build-tool, we build that also from source.
>
> Here, the problem is that:
>
> gradle/wrapper/gradle-wrapper.jar
>
> is a binary JAR-file included in the sources, which is used by the
> 'gradlew' script. This jar-file should not be part of the original
> sources used to to compile this package.
>
> Whenever sources contain unwanted binaries, we use 'snippets' to remove
> them before doing any further steps. You will find them in many places
> in the java.scm file, just search for 'snippet', for example in the
> package java-cisd-jhdf5.
>
> For using gradle, we need to compile gradle from sources, but this is
> very hard, there are some bootstrapping problems involed in this.
>
> So, first we should first snipp away the jar-files from the original
> java-openjfx-build package by Julien.
>
> And second, I hope you don't rely on the gradle build in any way
> here :-)
>
> Björn
>
>> gnu/packages/java.scm                              |  3 ++-
>> .../java-openjfx-build-get_guix_jdk_version.patch  | 14
>> ++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-)
>> create mode 100644
>> gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>>
>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> index 9371901e1f..01541ee419 100644
>> --- a/gnu/packages/java.scm
>> +++ b/gnu/packages/java.scm
>> @@ -2355,7 +2355,8 @@ new Date();"))
>>       (file-name (string-append name "-" version
>> "-checkout")) (sha256
>>        (base32
>> -
>> "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))))
>> +
>> "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))
>> +              (patches (search-patches
>> "java-openjfx-build-get_guix_jdk_version.patch")))) (build-system
>> ant-build-system) (arguments
>> `(#:jar-name "java-openjfx.jar"
>> diff --git
>> a/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>> b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>> new file mode 100644 index 0000000000..214ef9949c --- /dev/null
>> +++
>> b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>> @@ -0,0 +1,14 @@ +--- a/build.gradle
>> ++++ b/build.gradle
>> +@@ -742,9 +742,9 @@
>> +     if (inStream.readLine() != null) {
>> +         String v = inStream.readLine();
>> +         if (v != null) {
>> +-            int ib = v.indexOf(" (build ");
>> ++            int ib = v.indexOf(" (guix build ");
>> +             if (ib != -1) {
>> +-                String ver = v.substring(ib + 8, v.size() - 1);
>> ++                String ver = v.substring(ib + 13, v.size() - 1);
>> +
>> +                 defineProperty("jdkRuntimeVersion", ver)
>> +                 defineProperty("jdkVersion",
>> jdkRuntimeVersion.split("-")[0])







Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Thu, 05 Mar 2020 20:43:02 GMT) Full text and rfc822 format available.

Message #22 received at 39742 <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 39742 <at> debbugs.gnu.org
Subject: Re: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful
 patch.
Date: Thu, 05 Mar 2020 21:42:01 +0100
Many thanks! I will fix these in the next patches.

Alexey

On March 4, 2020 03:25:36 Leo Famulari <leo <at> famulari.name> wrote:

> Hi,
>
> Thanks for these patches and sorry for the delay in review! There are a
> lot of patches and it takes a while to get through them.
>
> On Sat, Feb 22, 2020 at 09:17:49PM +0100, Alexey Abramov wrote:
>> * gnu/packages/java.scm: Add patch
>> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New
>> file. Allows you to run gradlew to run properly. Useful for debugging.
>
> The commit message needs a couple changes, to something like this:
>
> ------
> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/java.scm (java-openjfx-build)[source]: Use it.
> ------
>
> We don't need to describe the patch in the commit message. Instead, we
> explain it in a comment at the beginning of the patch file itself. This
> is easier for the people that will read the patch later. The comment
> should explain what the patch does and where it came from, including
> links to bug reports and external patch sources, if they exist.
>
> We need to register the new patch file in 'gnu/local.mk', so that it
> gets distributed in the Guix release process.
>
> And finally, we need to name the package variable (java-openjfx-build)
> that the patch is being used by.
>
> Here is an example from an older commit:
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ca5e404f9a1ff81a38a32578c9c3a6c866482a9a







Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Thu, 05 Mar 2020 21:36:02 GMT) Full text and rfc822 format available.

Message #25 received at 39742 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 39742 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful
 patch.
Date: Thu, 5 Mar 2020 22:35:31 +0100
[Message part 1 (text/plain, inline)]
On Thu, 5 Mar 2020 20:09:25 +0100
Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> wrote:

> Here, the problem is that:
> 
> gradle/wrapper/gradle-wrapper.jar

[..]

> So, first we should first snipp away the jar-files from the original
> java-openjfx-build package by Julien.

I fixed that in the java-openjfx-build package under commit:

2c2b1ef85448681d858f447ac6fed6679a95209f

 
Björn

[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Sun, 08 Mar 2020 19:41:02 GMT) Full text and rfc822 format available.

Message #28 received at 39742 <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: 39742 <at> debbugs.gnu.org
Cc: Alexey Abramov <levenson <at> mmer.org>
Subject: [v2] gnu: java-openjfx-build: Add helpful patch.
Date: Sun,  8 Mar 2020 20:40:00 +0100
* gnu/packages/java.scm (java-openjfx-build)[source]: Use it.
* gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
---
 gnu/local.mk                                  |  1 +
 gnu/packages/java.scm                         |  3 +-
 ...a-openjfx-build-get_guix_jdk_version.patch | 37 +++++++++++++++++++
 3 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index f6c56ceb28..0bcbde7301 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1033,6 +1033,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/java-apache-ivy-port-to-latest-bouncycastle.patch	\
   %D%/packages/patches/java-commons-collections-fix-java8.patch \
   %D%/packages/patches/java-jeromq-fix-tests.patch		\
+  %D%/packages/patches/java-openjfx-build-get_guix_jdk_version.patch    \
   %D%/packages/patches/java-powermock-fix-java-files.patch		\
   %D%/packages/patches/java-simple-xml-fix-tests.patch		\
   %D%/packages/patches/java-svg-salamander-Fix-non-det.patch	\
diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 5229eeda06..a46d4013d8 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -2361,7 +2361,8 @@ new Date();"))
                   #t))
               (sha256
                (base32
-                "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))))
+                "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))
+              (patches (search-patches "java-openjfx-build-get_guix_jdk_version.patch"))))
     (build-system ant-build-system)
     (arguments
      `(#:jar-name "java-openjfx.jar"
diff --git a/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
new file mode 100644
index 0000000000..4ebdadc671
--- /dev/null
+++ b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
@@ -0,0 +1,37 @@
+From d156313340d3edcd78751ea8ed5e66c7668275c3 Mon Sep 17 00:00:00 2001
+From: Alexey Abramov <levenson <at> mmer.org>
+Date: Sun, 8 Mar 2020 20:07:22 +0100
+Subject: [PATCH] openjfx: Determine the version of Java in JDK_HOME
+
+Icedtea contains guix in its version, so build.gradle failes to run. Openjfx
+packaging is not trivial, so you will probably need to try build it with
+gradlew.
+
+---
+ build.gradle | 5 ++---
+ 1 file changed, 2 insertions(+), 3 deletions(-)
+
+diff --git a/build.gradle b/build.gradle
+index df82f63..2c626cd 100644
+--- a/build.gradle
++++ b/build.gradle
+@@ -742,9 +742,9 @@ try {
+     if (inStream.readLine() != null) {
+         String v = inStream.readLine();
+         if (v != null) {
+-            int ib = v.indexOf(" (build ");
++            int ib = v.indexOf(" (guix build ");
+             if (ib != -1) {
+-                String ver = v.substring(ib + 8, v.size() - 1);
++                String ver = v.substring(ib + 13, v.size() - 1);
+ 
+                 defineProperty("jdkRuntimeVersion", ver)
+                 defineProperty("jdkVersion", jdkRuntimeVersion.split("-")[0])
+@@ -3540,4 +3540,3 @@ compileTargets { t ->
+         }
+     )
+ }
+-
+-- 
+2.24.1
+
-- 
2.24.1





Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 15 Mar 2020 18:21:02 GMT) Full text and rfc822 format available.

Notification sent to Alexey Abramov <levenson <at> mmer.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 18:21:02 GMT) Full text and rfc822 format available.

Message #33 received at 39742-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: 39742-done <at> debbugs.gnu.org
Subject: Re: [bug#39742] [v2] gnu: java-openjfx-build: Add helpful patch.
Date: Sun, 15 Mar 2020 14:19:53 -0400
I'm closing this bug ticket because Alexey is still working on some of
the patches and it's confusing to have the patches spread over multiple
tickets, even though we merged them. Alexey will open a new ticket soon.




Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 15 Mar 2020 18:21:02 GMT) Full text and rfc822 format available.

Notification sent to Alexey Abramov <levenson <at> mmer.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 18:21:02 GMT) Full text and rfc822 format available.

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 15 Mar 2020 18:21:02 GMT) Full text and rfc822 format available.

Notification sent to Alexey Abramov <levenson <at> mmer.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 18:21:02 GMT) Full text and rfc822 format available.

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 15 Mar 2020 18:21:03 GMT) Full text and rfc822 format available.

Notification sent to Alexey Abramov <levenson <at> mmer.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 18:21:03 GMT) Full text and rfc822 format available.

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 15 Mar 2020 18:21:03 GMT) Full text and rfc822 format available.

Notification sent to Alexey Abramov <levenson <at> mmer.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 18:21:03 GMT) Full text and rfc822 format available.

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 15 Mar 2020 18:21:03 GMT) Full text and rfc822 format available.

Notification sent to Alexey Abramov <levenson <at> mmer.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 18:21:03 GMT) Full text and rfc822 format available.

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 15 Mar 2020 18:21:03 GMT) Full text and rfc822 format available.

Notification sent to Alexey Abramov <levenson <at> mmer.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 18:21:04 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#39742; Package guix-patches. (Tue, 17 Mar 2020 21:13:01 GMT) Full text and rfc822 format available.

Message #66 received at 39742-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Leo Famulari <leo <at> famulari.name>
Cc: 39742-done <at> debbugs.gnu.org, Alexey Abramov <levenson <at> mmer.org>
Subject: Re: bug#39742: [v2] gnu: java-openjfx-build: Add helpful patch.
Date: Tue, 17 Mar 2020 22:12:41 +0100
[Message part 1 (text/plain, inline)]
On Sun, 15 Mar 2020 14:19:53 -0400
Leo Famulari <leo <at> famulari.name> wrote:

> I'm closing this bug ticket because Alexey is still working on some of
> the patches and it's confusing to have the patches spread over
> multiple tickets, even though we merged them. Alexey will open a new
> ticket soon.

Thanks for the information. I'm happy to review the patches, but was
very confused about the different mails and patches.

Alexey, if you need some help, don't hesitate to ask.

Björn

[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 15 Apr 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 12 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.