GNU logs - #39770, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#39770: mount-file-system fails to mount NFS file system
Resent-From: maxim.cournoyer@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 24 Feb 2020 19:40:01 +0000
Resent-Message-ID: <handler.39770.B.15825731604511 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 39770 <at> debbugs.gnu.org
From: maxim.cournoyer@HIDDEN
Date: Mon, 24 Feb 2020 14:39:13 -0500
Message-ID: <875zfvixlq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

The mount-file-system call used in our init RAM disk (see: (gnu build
file-systems)) doesn't produce the correct system call as can be
demontstrated by the following C program:

--8<---------------cut here---------------start------------->8---
#include <errno.h>
#include <stdio.h>
#include <string.h>
#include <sys/mount.h>

/* int mount(const char *source, const char *target, */
/* 	  const char *filesystemtype, unsigned long mountflags, */
/* 	  const void *data); */

int main() {
  //char *src = "192.168.51.34:/mnt/scratch/yocto-sstate";
  char *src = "192.168.51.34:/mnt/scratch/yocto-sstate";
  char *target = "/mnt/scratch/yocto-sstate";
  char *type = "nfs";
  unsigned long mountflags = 0;
  char *data = "addr=192.168.51.34";  //file system specific options

  int ret = 0;
  ret = mount(src, target, type, mountflags, data);

  if (ret == -1); {
    int errsv = errno;
    printf("mount() failed with error: %s\n", strerror(errsv));
  }
}

--8<---------------cut here---------------end--------------->8---

Running the program with strace, we can see that it failed with a
connection refused error:

--8<---------------cut here---------------start------------->8---
/* mount("192.168.51.34:/mnt/scratch/yocto-sstate", "/mnt/scratch/yocto-sstate", "nfs", 0, "addr=192.168.51.34") = -1 ECONNREFUSED (Connection refused) */
--8<---------------cut here---------------end--------------->8---


When having nfs-utils installed and tracing mount.nfs with:

--8<---------------cut here---------------start------------->8---
strace -f -s320 mount j1-slave1.sfl.team:/mnt/scratch/yocto-dldir /mnt/scratch/yocto-dldir -t nfs
--8<---------------cut here---------------end--------------->8---

We can see that the working invocation reads as:

--8<---------------cut here---------------start------------->8---
mount("j1-slave1.sfl.team:/mnt/scratch/yocto-dldir", "/mnt/scratch/yocto-dldir", "nfs", 0, "vers=4.2,addr=192.168.51.34,clientaddr=192.168.49.249")
--8<---------------cut here---------------end--------------->8---

It seems we're missing either a "vers" (doubtful) or more likely the
"clientaddr" option.

Maxim

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: maxim.cournoyer@HIDDEN
Subject: bug#39770: Acknowledgement (mount-file-system fails to mount NFS
 file system)
Message-ID: <handler.39770.B.15825731604511.ack <at> debbugs.gnu.org>
References: <875zfvixlq.fsf@HIDDEN>
X-Gnu-PR-Message: ack 39770
X-Gnu-PR-Package: guix
Reply-To: 39770 <at> debbugs.gnu.org
Date: Mon, 24 Feb 2020 19:40:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 39770 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
39770: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39770
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#39770: mount-file-system fails to mount NFS file system
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 24 Feb 2020 21:22:01 +0000
Resent-Message-ID: <handler.39770.B39770.158257929121981 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 39770 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <875zfvixlq.fsf@HIDDEN>
Date: Mon, 24 Feb 2020 16:21:21 -0500
In-Reply-To: <875zfvixlq.fsf@HIDDEN>
 (maxim cournoyer's message of "Mon, 24 Feb 2020 14:39:13 -0500")
Message-ID: <871rqjisvi.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Hi,

maxim.cournoyer@HIDDEN writes:

[...]

> It seems we're missing either a "vers" (doubtful) or more likely the
> "clientaddr" option.

It turns out that the "vers" (or more specifically, "nfsvers") option
was mandatory to resolve this error.  What "mount.nfs" from
nfs-utils seems to do is start with "4.2", then retry upon errors lesser
versions.

The attached patch adds the required "nfsvers=4.2" option by default, or
honors a user specified one.  No retry is done.  Note that it currently
uses file system options represented as an alist, but this is likely to
change as the code review on "allow booting from a Btrfs subvolume"
progresses (the current patch is based atop of
<https://bugs.gnu.org/37305>).

Maxim


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-build-file-systems-Specify-a-nfsvers-option-by-defau.patch

From 6cbae0746dbeb736dc8c037183038eca2f7867fd Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Mon, 24 Feb 2020 16:09:10 -0500
Subject: [PATCH] build: file-systems: Specify a "nfsvers" option by default
 for NFS.

Without it, the mount system call fails with an ECONNREFUSED (Connection
refused) error.

* gnu/build/file-systems.scm (nfs-source->ip-address): Add procedure, with
code moved from...
(mount-file-system): ...the inner `mount-nfs' procedure, now removed.  The NFS
specific required options default values are now computed and added to the
regular options.  Honor any user given "addr", "nfsvers" or "vers" option."
Remove the call to `mount-nfs', no longer needed.
---
 gnu/build/file-systems.scm | 59 +++++++++++++++++++++-----------------
 1 file changed, 33 insertions(+), 26 deletions(-)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 76c143654d..fdeb12e825 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -640,36 +640,45 @@ corresponds to the symbols listed in FLAGS."
       (()
        0))))
 
+(define (nfs-source->ip-address source)
+  "Return the IP address from the source component of a network file-system."
+  (let* ((idx (string-rindex source #\:))
+         (host-part (string-take source idx))
+         ;; Strip [] from around host if present
+         (host (match (string-split host-part (string->char-set "[]"))
+                 (("" h "") h)
+                 ((h) h)))
+         (aa (match (getaddrinfo host "nfs") ((x . _) x)))
+         (sa (addrinfo:addr aa)))
+    (inet-ntop (sockaddr:fam sa)
+               (sockaddr:addr sa))))
+
 (define* (mount-file-system fs #:key (root "/root"))
   "Mount the file system described by FS, a <file-system> object, under ROOT."
 
-  (define (mount-nfs source mount-point type flags options)
-    (let* ((idx (string-rindex source #\:))
-           (host-part (string-take source idx))
-           ;; Strip [] from around host if present
-           (host (match (string-split host-part (string->char-set "[]"))
-                 (("" h "") h)
-                 ((h) h)))
-           (aa (match (getaddrinfo host "nfs") ((x . _) x)))
-           (sa (addrinfo:addr aa))
-           (inet-addr (inet-ntop (sockaddr:fam sa)
-                                 (sockaddr:addr sa))))
-
-      ;; Mounting an NFS file system requires passing the address
-      ;; of the server in the addr= option
-      (mount source mount-point type flags
-             (string-append "addr="
-                            inet-addr
-                            (if options
-                                (string-append "," options)
-                                "")))))
   (let* ((type        (file-system-type fs))
          (nfs? (string-prefix? "nfs" type))
+         (source      (canonicalize-device-spec (file-system-device fs)))
          (fs-options (file-system-options fs))
-         (options (if (null? fs-options)
+         (fs-options*
+          (if nfs?
+              ;; Do not override user specified "addr", "nfsvers" or "vers",
+              ;; but provide default values as otherwise mount fails to
+              ;; connect.
+              `(,@fs-options
+                ,@(if (member "addr" fs-options)
+                      '()
+                      (list (format #f "addr=~a"
+                                    (nfs-source->ip-address source))))
+                ,@(if (or (assoc-ref fs-options "nfsvers")
+                          (assoc-ref fs-options "vers"))
+                      '()
+                      (list "nfsvers=4.2")))
+              fs-options))
+         (options (if (null? fs-options*)
                       #f
-                      (file-system-options->string fs-options)))
-         (source      (canonicalize-device-spec (file-system-device fs)))
+                      (file-system-options->string fs-options*)))
+
          (mount-point (string-append root "/"
                                      (file-system-mount-point fs)))
          (flags       (mount-flags->bit-mask (file-system-flags fs))))
@@ -685,9 +694,7 @@ corresponds to the symbols listed in FLAGS."
           (call-with-output-file mount-point (const #t)))
         (mkdir-p mount-point))
 
-    (if nfs?
-        (mount-nfs source mount-point type flags options)
-        (mount source mount-point type flags options))
+    (mount source mount-point type flags options)
 
     ;; For read-only bind mounts, an extra remount is needed, as per
     ;; <http://lwn.net/Articles/281157/>, which still applies to Linux 4.0.
-- 
2.25.0


--=-=-=--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 3 Oct 2020 02:19:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 02 22:19:02 2020
Received: from localhost ([127.0.0.1]:42786 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kOX8Y-000769-8v
	for submit <at> debbugs.gnu.org; Fri, 02 Oct 2020 22:19:02 -0400
Received: from mail-qt1-f174.google.com ([209.85.160.174]:34144)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1kOX8U-00075l-4w
 for control <at> debbugs.gnu.org; Fri, 02 Oct 2020 22:19:01 -0400
Received: by mail-qt1-f174.google.com with SMTP id 19so4349984qtp.1
 for <control <at> debbugs.gnu.org>; Fri, 02 Oct 2020 19:18:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:message-id:to:from:subject;
 bh=Yx5t+LvnpiflFgWuNiQIjp4gN3VMnECImCBXVgCay0Q=;
 b=eztSPCu9X8DftlvlvtAiJJ+w/pcvu8Re8H5RiPeZcMOjVPTurQ9Z6181ikfFS9A0UP
 yiv6LXj72xYWCDvcKCfDhG6NgjV4LI60LHgfIlKWA4YmZM6Yn0LDAfrQIgNQ7tKgGO8B
 OfUEG8kTUY+2ebkjNkxAij/eCWRcOkkAlCcLVsdrA7fDCH3S3W7t49pm3e0aY4TNgnFv
 xtyY719sqch9ld+UkMgQMHGhQ0skB/TkHd/335BgXyCIsQ6E++AfwZWI2GjNwnI6CjUA
 Tz6yq9bPFNDK9oDsZ+0CC6evAcsE9CYRYHmWNuC4uU9Inv2DrpnkE8Bu+nEPgCOfc4E3
 PuJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:message-id:to:from:subject;
 bh=Yx5t+LvnpiflFgWuNiQIjp4gN3VMnECImCBXVgCay0Q=;
 b=K7X/H0noSEA5rkBKv3xQGOayG8jHRP4pZ9h0yIfwyAEMUPiYJp3S6FNMypApSs61WB
 STitLduKOJcMU73yMueqzXKy5FYJsWLb4C/K0ntzsiQKECXaVU5wwvh48/ONaeyj+1MZ
 y44uJUJKqx7t3FDXgfESvTN70UkCpHe43SIe3XRg8eXYgkbnsIVeXi4cdIlQOq27nI0w
 Mu2WWYKfdcGCc76PH097mRJ631LrPm4DnQVUoqiP/GZoDFK1r86f7qgOz43CVdK+kx/Q
 U1uy0dsrxxQLsOgG57UsE3x8Ex7X8npPYWnuldjzqoEmVWFRJfoNgWIT4ez0s2V9ZBmD
 uaZg==
X-Gm-Message-State: AOAM533+YenhQ2AdA+xDQDoVDEXO17M9JbhmvrffmnIH7okd9+9Yvuyf
 4Rg9s3f07GGpBSSBgjGbQwStZ4UF6sgmEw==
X-Google-Smtp-Source: ABdhPJxTksqzCSgNUrKdu6jS773bLJfiNZXkSs5ihyRC9jWuhuNyKcyjXVKHRMDyrZ9OTGyKoxjHRA==
X-Received: by 2002:ac8:5159:: with SMTP id h25mr5121059qtn.328.1601691532597; 
 Fri, 02 Oct 2020 19:18:52 -0700 (PDT)
Received: from hurd (dsl-10-135-18.b2b2c.ca. [72.10.135.18])
 by smtp.gmail.com with ESMTPSA id s15sm2454211qkj.21.2020.10.02.19.18.52
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 02 Oct 2020 19:18:52 -0700 (PDT)
Date: Fri, 02 Oct 2020 22:20:34 -0400
Message-Id: <87a6x4m4nh.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: control message for bug #39770
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 39770 + patch
quit

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 8 Aug 2021 03:50:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 07 23:50:17 2021
Received: from localhost ([127.0.0.1]:53415 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mCZpJ-0001AB-1R
	for submit <at> debbugs.gnu.org; Sat, 07 Aug 2021 23:50:17 -0400
Received: from mail-qv1-f48.google.com ([209.85.219.48]:43003)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1mCZpG-00019s-OB
 for control <at> debbugs.gnu.org; Sat, 07 Aug 2021 23:50:15 -0400
Received: by mail-qv1-f48.google.com with SMTP id f91so7265952qva.9
 for <control <at> debbugs.gnu.org>; Sat, 07 Aug 2021 20:50:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:message-id:to:from:subject;
 bh=glfAW2iMQSb9m2qmLEut5lzehjwYu5qc4wkz02OKAA0=;
 b=ID7mE8MAzlM4q9TSCmGuYq8thZU6n5sNs8Y2JYoo0AetpkDC6uSATPFBlbWbypTdf7
 82uxe5CmlF+Eqtntgoy/AOGqFZOwnQ4z1YrPHo6AZd7L9CyYV3DP+okKtodA2C+JmSw8
 KR8HRrSOkltT3qWOZ7ovvvDt89U9GBBxb5UpwTGVMmIF/huP8Ldi1vENYeaw//97YvPF
 RX89r4hyKeFxnpX5WnlCnVPARaxrHdRABkvDxndaQ7Yjg7cH5tjxZERAM8+DDklk235m
 qLtIvQl8p8v/HSEI2nYOGwUIKtnaiJNoKou9Td0xBvUsa5GB7cQXN1bhd9D2Vx974H5X
 Rd6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:message-id:to:from:subject;
 bh=glfAW2iMQSb9m2qmLEut5lzehjwYu5qc4wkz02OKAA0=;
 b=sTm0ntVNZDbbOs0HwzaIj9GUl8uzmezm8jWAR6HUvYwo93GlDYk7fRSS1CuvvKTEJV
 XKPcuShpHQpZ97PIMsoxCy65OPX4uKkhyB99QaYOIo6h/AI8lyl4iedU+3+p1ugyiqPM
 7iHVdZh+A2lEYIp6iZHasKnzjaNsex3XP9t7Hb94wCHLSS8nUdCWJ4DI8BbhHppiBtVP
 sJgf4R/OfEV/YU+fTCCkPeRsYmpy2jIskT+tH/7Q4kG72xEBMjvVyNDBy8AHP8Yzr2R8
 BU1YNbh7sQb89phLqQNdti3HfptEEDjDeQN4tYjicQn9gdLv6+jx/W4UVpgZ+dqud4B6
 2X9w==
X-Gm-Message-State: AOAM531NJZjALE9AWINWdUVJBKCEMpAJvsr6y5M/8LzqhF6pe7WGf7CI
 VZ/8VFGgkVc2DcRfmPFkN1bvmc3KiycxKA==
X-Google-Smtp-Source: ABdhPJx66XnU2ajzWFIt1VLT8NxyKQlJJFsHjuReWpbJG3Nbnlga98Yi5XSF31g7YGCog9VgDr6r3A==
X-Received: by 2002:a05:6214:5182:: with SMTP id
 kl2mr7163058qvb.19.1628394608988; 
 Sat, 07 Aug 2021 20:50:08 -0700 (PDT)
Received: from hurd (dsl-10-131-144.b2b2c.ca. [72.10.131.144])
 by smtp.gmail.com with ESMTPSA id s14sm7477410qke.1.2021.08.07.20.50.08
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 07 Aug 2021 20:50:08 -0700 (PDT)
Date: Sat, 07 Aug 2021 23:50:08 -0400
Message-Id: <87y29c389b.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: control message for bug #39770
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

merge 39770 47706
quit

Last modified: Sun, 8 Aug 2021 04:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.