GNU bug report logs - #39783
[PATCH] gnu: gsettings-desktop-schemas: patch monospace font.

Previous Next

Package: guix-patches;

Reported by: Leo Prikler <leo.prikler <at> student.tugraz.at>

Date: Tue, 25 Feb 2020 15:00:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39783 in the body.
You can then email your comments to 39783 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#39783; Package guix-patches. (Tue, 25 Feb 2020 15:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 25 Feb 2020 15:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gsettings-desktop-schemas: patch monospace font.
Date: Tue, 25 Feb 2020 15:59:10 +0100
* gnu/packages/gnome.scm (gsettings-desktop-schemas)[arguments]<phases>:
Rename `set-adwaita-theme-file-name' to the more generic `patch-schemas'.
Add patch for the monospace font (Source Code Pro 10 -> Monospace 11).
Adjust comments.
---
 gnu/packages/gnome.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index af45ceb505..e066b4c93c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1575,15 +1575,17 @@ on the GNOME Desktop with a single simple application.")
     (build-system meson-build-system)
     (arguments
      '(#:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'set-adwaita-theme-file-name
+                  (add-after 'unpack 'patch-schemas
                     (lambda* (#:key inputs #:allow-other-keys)
-                      ;; Provide the correct file name of the default GNOME
-                      ;; background, 'adwaita-timed.xml'.
                       (let ((theme (assoc-ref inputs "gnome-backgrounds")))
                         (substitute* (find-files "schemas"
                                                  "\\.gschema\\.xml\\.in$")
+                          ;; Provide the correct file name of the default GNOME
+                          ;; background, 'adwaita-timed.xml'.
                           (("@datadir@/backgrounds/gnome")
-                           (string-append theme "/share/backgrounds/gnome")))
+                           (string-append theme "/share/backgrounds/gnome"))
+                          ;; Do not reference fonts, that may not exist.
+                          (("'Source Code Pro 10'") "'Monospace 11'"))
                         #t))))))
     (inputs
      `(("glib" ,glib)
-- 
2.25.1





Information forwarded to guix-patches <at> gnu.org:
bug#39783; Package guix-patches. (Sun, 15 Mar 2020 13:42:01 GMT) Full text and rfc822 format available.

Message #8 received at 39783 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: 39783 <at> debbugs.gnu.org
Subject: [bug#39783] [PATCH] gnu: gsettings-desktop-schemas: patch monospace
 font.
Date: Sun, 15 Mar 2020 14:41:26 +0100
It appears this has fallen under the radar.
To perhaps clarify the intent of this patch, it fixes the bug, where
GNOME Terminal and other stuff that relies on the Monospace font being
defined appears quite ugly with the default settings.

Regards,
Leo





Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Fri, 20 Mar 2020 18:03:02 GMT) Full text and rfc822 format available.

Notification sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
bug acknowledged by developer. (Fri, 20 Mar 2020 18:03:02 GMT) Full text and rfc822 format available.

Message #13 received at 39783-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 39783-done <at> debbugs.gnu.org
Subject: Re: [bug#39783] [PATCH] gnu: gsettings-desktop-schemas: patch
 monospace font.
Date: Fri, 20 Mar 2020 19:02:40 +0100
[Message part 1 (text/plain, inline)]
Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> * gnu/packages/gnome.scm (gsettings-desktop-schemas)[arguments]<phases>:
> Rename `set-adwaita-theme-file-name' to the more generic `patch-schemas'.
> Add patch for the monospace font (Source Code Pro 10 -> Monospace 11).
> Adjust comments.

Thanks for finding the root cause of the broken default gnome-terminal
font.  Since there has been no feedback in a couple of weeks, I went
ahead and applied it.

I also updated your copyright header.  Thanks!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 18 Apr 2020 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 346 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.