GNU bug report logs - #39786
[PATCH] Add dragonfly-reverb.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39786 in the body.
You can then email your comments to 39786 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] Add dragonfly-reverb.
Date: Tue, 25 Feb 2020 15:20:12 +0000

[Message part 1 (text/plain, inline)]

Hi,

This patch adds dragonfly reverb, a popular reverb plugin.

Unfortunately it doesn't have an install target so I resorted to
copying the files manually.

Thanks,
Alex

[0001-gnu-Add-dragonfly-reverb.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 39786 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: 39786 <at> debbugs.gnu.org
Subject: Re: bug#39786: Acknowledgement ([PATCH] Add dragonfly-reverb.)
Date: Wed, 26 Feb 2020 21:49:09 +0000

[Message part 1 (text/plain, inline)]

I have removed VST because it is not really necessary. This now only
outputs LV2 and standalone versions.

To test that the plugin works, you can run the following if you already
have JACK running:
LV2_PATH=/gnu/store/xbhdmal9ybvw8yrynmimmj0z9cg2v6aj-dragonfly-reverb-
2.0.0/lib/lv2 jalv.gtk3 urn:dragonfly:room
LV2_PATH=/gnu/store/xbhdmal9ybvw8yrynmimmj0z9cg2v6aj-dragonfly-reverb-2.0.0/lib/lv2 jalv.gtk3 https://github.com/michaelwillis/dragonfly-reverb
If you don't have JACK running (most likely case), you can run a dummy
server temporarily with `jackd -ddummy`.

Thanks,
Alex

[0001-gnu-Add-dragonfly-reverb.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 39786 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 39786 <at> debbugs.gnu.org
Subject: Re: [bug#39786] [PATCH] Add dragonfly-reverb.
Date: Sat, 21 Mar 2020 17:46:17 +0100

Hello,

Alexandros Theodotou <alex <at> zrythm.org> writes:

> This patch adds dragonfly reverb, a popular reverb plugin.

Thank you!

> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out   (assoc-ref outputs "out"))
> +                    (bin   (string-append out "/bin"))
> +                    (vst   (string-append out "/lib/vst"))
> +                    (lv2   (string-append out "/lib/lv2")))
> +               (mkdir-p bin)
> +               (mkdir-p vst)
> +               (mkdir-p lv2)
> +
> +               ;; Install VST
> +               (for-each
> +                 (lambda (file)
> +                   (install-file file vst))
> +                 (find-files "bin" "\\-vst.so$"))

Since you use `install-file' you don't need to `mkdir-p' beforehand,
i.e., you can drop (mkdir-p vst) above.

> +               ;; Install standalone
> +               (install-file "bin/DragonflyRoomReverb" bin)
> +               (install-file "bin/DragonflyHallReverb" bin)

Ditto, you can drop (mkdir-p bin).

> +               #t))))))
> +    (inputs
> +     `(("jack" ,jack-1)
> +       ("libx11" ,libx11)
> +       ("mesa" ,mesa)))
> +    (native-inputs
> +     `(("lv2" ,lv2)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "Concert hall reverb and room reverb effects")
> +    (description
> +     "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb. Both are available as VST and LV2 plugins,

You need to add two spaces after full stops.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #14 received at 39786 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39786 <at> debbugs.gnu.org
Subject: Re: [bug#39786] [PATCH] Add dragonfly-reverb.
Date: Sat, 21 Mar 2020 19:09:48 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the feedback.

Attaching the updated patch. I also removed some unneeded dependencies.

Thanks,
Alex

2020-03-21 (土) の 17:46 +0100 に Nicolas Goaziou さんは書きました:
> Hello,
> 
> Alexandros Theodotou <alex <at> zrythm.org> writes:
> 
> > This patch adds dragonfly reverb, a popular reverb plugin.
> 
> Thank you!
> 
> > +           (lambda* (#:key inputs outputs #:allow-other-keys)
> > +             (let* ((out   (assoc-ref outputs "out"))
> > +                    (bin   (string-append out "/bin"))
> > +                    (vst   (string-append out "/lib/vst"))
> > +                    (lv2   (string-append out "/lib/lv2")))
> > +               (mkdir-p bin)
> > +               (mkdir-p vst)
> > +               (mkdir-p lv2)
> > +
> > +               ;; Install VST
> > +               (for-each
> > +                 (lambda (file)
> > +                   (install-file file vst))
> > +                 (find-files "bin" "\\-vst.so$"))
> 
> Since you use `install-file' you don't need to `mkdir-p' beforehand,
> i.e., you can drop (mkdir-p vst) above.
> 
> > +               ;; Install standalone
> > +               (install-file "bin/DragonflyRoomReverb" bin)
> > +               (install-file "bin/DragonflyHallReverb" bin)
> 
> Ditto, you can drop (mkdir-p bin).
> 
> > +               #t))))))
> > +    (inputs
> > +     `(("jack" ,jack-1)
> > +       ("libx11" ,libx11)
> > +       ("mesa" ,mesa)))
> > +    (native-inputs
> > +     `(("lv2" ,lv2)
> > +       ("pkg-config" ,pkg-config)))
> > +    (synopsis "Concert hall reverb and room reverb effects")
> > +    (description
> > +     "Dragonfly Reverb is a bundle of two free audio effects: a
> > concert
> > +hall reverb and a room reverb. Both are available as VST and LV2
> > plugins,
> 
> You need to add two spaces after full stops.
> 
> Could you send an updated patch?
> 
> Regards,
> 

[0001-gnu-Add-dragonfly-reverb.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 39786-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 39786-done <at> debbugs.gnu.org
Subject: Re: [bug#39786] [PATCH] Add dragonfly-reverb.
Date: Sat, 21 Mar 2020 21:55:33 +0100

Hello,

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Attaching the updated patch. I also removed some unneeded
> dependencies.

Thank you! I applied your patch, with the following changes :

> +(define-public dragonfly-reverb

I fixed the indentation, which was a bit off,

> +           (lambda* (#:key inputs outputs #:allow-other-keys)

I removed `inputs' as it was not needed.

> +    (synopsis "Concert hall reverb and room reverb effects")
> +    (description
> +     "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb.  Both are available as LV2 plugins as well
> +as JACK standalone applications.")
> +    (home-page "https://michaelwillis.github.io/dragonfly-reverb/")

I moved `home-page' above `synopsis'.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.