GNU bug report logs -
#39786
[PATCH] Add dragonfly-reverb.
Previous Next
Reported by: Alexandros Theodotou <alex <at> zrythm.org>
Date: Tue, 25 Feb 2020 15:21:01 UTC
Severity: normal
Tags: patch
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39786 in the body.
You can then email your comments to 39786 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#39786
; Package
guix-patches
.
(Tue, 25 Feb 2020 15:21:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Alexandros Theodotou <alex <at> zrythm.org>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 25 Feb 2020 15:21:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
This patch adds dragonfly reverb, a popular reverb plugin.
Unfortunately it doesn't have an install target so I resorted to
copying the files manually.
Thanks,
Alex
[0001-gnu-Add-dragonfly-reverb.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#39786
; Package
guix-patches
.
(Wed, 26 Feb 2020 21:50:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 39786 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
I have removed VST because it is not really necessary. This now only
outputs LV2 and standalone versions.
To test that the plugin works, you can run the following if you already
have JACK running:
LV2_PATH=/gnu/store/xbhdmal9ybvw8yrynmimmj0z9cg2v6aj-dragonfly-reverb-
2.0.0/lib/lv2 jalv.gtk3 urn:dragonfly:room
LV2_PATH=/gnu/store/xbhdmal9ybvw8yrynmimmj0z9cg2v6aj-dragonfly-reverb-2.0.0/lib/lv2 jalv.gtk3 https://github.com/michaelwillis/dragonfly-reverb
If you don't have JACK running (most likely case), you can run a dummy
server temporarily with `jackd -ddummy`.
Thanks,
Alex
[0001-gnu-Add-dragonfly-reverb.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#39786
; Package
guix-patches
.
(Sat, 21 Mar 2020 16:47:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 39786 <at> debbugs.gnu.org (full text, mbox):
Hello,
Alexandros Theodotou <alex <at> zrythm.org> writes:
> This patch adds dragonfly reverb, a popular reverb plugin.
Thank you!
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (vst (string-append out "/lib/vst"))
> + (lv2 (string-append out "/lib/lv2")))
> + (mkdir-p bin)
> + (mkdir-p vst)
> + (mkdir-p lv2)
> +
> + ;; Install VST
> + (for-each
> + (lambda (file)
> + (install-file file vst))
> + (find-files "bin" "\\-vst.so$"))
Since you use `install-file' you don't need to `mkdir-p' beforehand,
i.e., you can drop (mkdir-p vst) above.
> + ;; Install standalone
> + (install-file "bin/DragonflyRoomReverb" bin)
> + (install-file "bin/DragonflyHallReverb" bin)
Ditto, you can drop (mkdir-p bin).
> + #t))))))
> + (inputs
> + `(("jack" ,jack-1)
> + ("libx11" ,libx11)
> + ("mesa" ,mesa)))
> + (native-inputs
> + `(("lv2" ,lv2)
> + ("pkg-config" ,pkg-config)))
> + (synopsis "Concert hall reverb and room reverb effects")
> + (description
> + "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb. Both are available as VST and LV2 plugins,
You need to add two spaces after full stops.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
Information forwarded
to
guix-patches <at> gnu.org
:
bug#39786
; Package
guix-patches
.
(Sat, 21 Mar 2020 19:10:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 39786 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
Thanks for the feedback.
Attaching the updated patch. I also removed some unneeded dependencies.
Thanks,
Alex
2020-03-21 (土) の 17:46 +0100 に Nicolas Goaziou さんは書きました:
> Hello,
>
> Alexandros Theodotou <alex <at> zrythm.org> writes:
>
> > This patch adds dragonfly reverb, a popular reverb plugin.
>
> Thank you!
>
> > + (lambda* (#:key inputs outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (vst (string-append out "/lib/vst"))
> > + (lv2 (string-append out "/lib/lv2")))
> > + (mkdir-p bin)
> > + (mkdir-p vst)
> > + (mkdir-p lv2)
> > +
> > + ;; Install VST
> > + (for-each
> > + (lambda (file)
> > + (install-file file vst))
> > + (find-files "bin" "\\-vst.so$"))
>
> Since you use `install-file' you don't need to `mkdir-p' beforehand,
> i.e., you can drop (mkdir-p vst) above.
>
> > + ;; Install standalone
> > + (install-file "bin/DragonflyRoomReverb" bin)
> > + (install-file "bin/DragonflyHallReverb" bin)
>
> Ditto, you can drop (mkdir-p bin).
>
> > + #t))))))
> > + (inputs
> > + `(("jack" ,jack-1)
> > + ("libx11" ,libx11)
> > + ("mesa" ,mesa)))
> > + (native-inputs
> > + `(("lv2" ,lv2)
> > + ("pkg-config" ,pkg-config)))
> > + (synopsis "Concert hall reverb and room reverb effects")
> > + (description
> > + "Dragonfly Reverb is a bundle of two free audio effects: a
> > concert
> > +hall reverb and a room reverb. Both are available as VST and LV2
> > plugins,
>
> You need to add two spaces after full stops.
>
> Could you send an updated patch?
>
> Regards,
>
[0001-gnu-Add-dragonfly-reverb.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
:
You have taken responsibility.
(Sat, 21 Mar 2020 20:56:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Alexandros Theodotou <alex <at> zrythm.org>
:
bug acknowledged by developer.
(Sat, 21 Mar 2020 20:56:02 GMT)
Full text and
rfc822 format available.
Message #19 received at 39786-done <at> debbugs.gnu.org (full text, mbox):
Hello,
Alexandros Theodotou <alex <at> zrythm.org> writes:
> Attaching the updated patch. I also removed some unneeded
> dependencies.
Thank you! I applied your patch, with the following changes :
> +(define-public dragonfly-reverb
I fixed the indentation, which was a bit off,
> + (lambda* (#:key inputs outputs #:allow-other-keys)
I removed `inputs' as it was not needed.
> + (synopsis "Concert hall reverb and room reverb effects")
> + (description
> + "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb. Both are available as LV2 plugins as well
> +as JACK standalone applications.")
> + (home-page "https://michaelwillis.github.io/dragonfly-reverb/")
I moved `home-page' above `synopsis'.
Regards,
--
Nicolas Goaziou
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sun, 19 Apr 2020 11:24:11 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 364 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.