GNU bug report logs - #39818
[PATCH] gnu: Add emacs-ddskk.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39818 in the body.
You can then email your comments to 39818 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Masaya Tojo <masaya <at> tojo.tokyo>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add emacs-ddskk.
Date: Fri, 28 Feb 2020 00:44:22 +0000

[Message part 1 (text/plain, inline)]

Hello.
* gnu/packages/emacs-xyz.scm (emacs-ddskk): New variable.

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a9b36dd882..116786d0d6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -60,6 +60,7 @@
;;; Copyright © 2020 Paul Garlick <pgarlick <at> tourbillion-technology.com>
;;; Copyright © 2020 Robert Smith <robertsmith <at> posteo.net>
;;; Copyright © 2020 Evan Straw <evan.straw99 <at> gmail.com>
+;;; Copyright © 2020 Masaya Tojo <masaya <at> tojo.tokyo>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -21667,3 +21668,26 @@ EXIF, XMP and IPTC.")
generate random passwords and insert them into the current buffer.  It also
supports generation of phonetic and numeric passwords.")
     (license license:artistic2.0)))
+
+(define emacs-ddskk
+  (package
+    (name "emacs-ddskk")
+    (version "17.0.50")
+    (home-page "https://github.com/skk-dev/ddskk")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit "b7bf6fa0e0fbb562c27a887283627a8781de0a34")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1ysn73yysaxpm93y9d4g2hmnd7qhh6lv93wgkrdw1cx11xl1g7yk"))))
+    (build-system emacs-build-system)
+    (inputs `(("inetutils" ,inetutils)))
+    (synopsis "Simple Kana to Kanji conversion program")
+    (description "Daredevil SKK is a version of SKK (Simple Kana to Kanji
+ conversion program, an input method of Japanese) maintained by the SKK
+ development team at http://openlab.jp/skk.")
+    (license license:gpl2+)))

[Message part 2 (text/html, inline)]

Message #8 received at 39818 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Masaya Tojo <masaya <at> tojo.tokyo>
Cc: 39818 <at> debbugs.gnu.org
Subject: Re: [bug#39818] [PATCH] gnu: Add emacs-ddskk.
Date: Sat, 29 Feb 2020 20:35:34 +0100

Hello,

Masaya Tojo <masaya <at> tojo.tokyo> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ddskk): New variable.

Thank you!

> +(define emacs-ddskk

Wouldn't it be emacs-skk, since one need to (require 'skk)?

> +  (package
> +    (name "emacs-ddskk")
> +    (version "17.0.50")

Is it an unstable version? Latest release seems to be 16.3. If so, if
there is a strong reason to use it instead, we should give it in
a comment.

> +    (home-page "https://github.com/skk-dev/ddskk")

This should be at the end of the package definition, right above
`synopsis'.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url home-page)
> +             (commit "b7bf6fa0e0fbb562c27a887283627a8781de0a34")))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1ysn73yysaxpm93y9d4g2hmnd7qhh6lv93wgkrdw1cx11xl1g7yk"))))
> +    (build-system emacs-build-system)
> +    (inputs `(("inetutils" ,inetutils)))
> +    (synopsis "Simple Kana to Kanji conversion program")
> +    (description "Daredevil SKK is a version of SKK (Simple Kana to Kanji
> + conversion program, an input method of Japanese) 

is a version of @acronym{SKK, Simple Kana to Kanji} conversion program,
an input method of Japanese.

> + maintained by the SKK development team at http://openlab.jp/skk.")

We may want to drop that part, not very useful in the package
description. However, if you keep it, it should be
@url{http://openlab.jp/skk}.

BTW, I cannot apply your patch. Could you send an updated revision with
the changes suggested above?

Regards,

-- 
Nicolas Goaziou

Message #11 received at 39818 <at> debbugs.gnu.org (full text, mbox):

From: Masaya Tojo <masaya <at> tojo.tokyo>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39818 <at> debbugs.gnu.org <39818 <at> debbugs.gnu.org>
Subject: RE: [bug#39818] [PATCH] gnu: Add emacs-ddskk.
Date: Mon, 2 Mar 2020 23:40:13 +0000

[Message part 1 (text/plain, inline)]

Thank you for the review.

 
> Is it an unstable version? Latest release seems to be 16.3. If so, if
there is a strong reason to use it instead, we should give it in
a comment.

 
I tried to build 16.3 version but it fail. The cause is that skk-lookup.el needs an external file and that skk-xemacs.el needs be xemacs. There ware fixed at 17.0.50 version. 

After 17.x is released, I will apply all your suggestions and send patch again.

 
--

 
Masaya Tojo

[Message part 2 (text/html, inline)]

Message #14 received at 39818 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Masaya Tojo <masaya <at> tojo.tokyo>
Cc: "39818 <at> debbugs.gnu.org" <39818 <at> debbugs.gnu.org>
Subject: Re: [bug#39818] [PATCH] gnu: Add emacs-ddskk.
Date: Tue, 03 Mar 2020 09:05:38 +0100

Hello,

Masaya Tojo <masaya <at> tojo.tokyo> writes:

> I tried to build 16.3 version but it fail. The cause is that
> skk-lookup.el needs an external file and that skk-xemacs.el needs be
> xemacs. There ware fixed at 17.0.50 version. 
>
> After 17.x is released, I will apply all your suggestions and send
> patch again.

Another option is to re-send the package with the commit you chose,
along with a comment explaining why (e.g., exactly what you wrote
above), and update it later when 17.x is released.

WDYT?

Regards,

-- 
Nicolas Goaziou

Message #17 received at 39818 <at> debbugs.gnu.org (full text, mbox):

From: Masaya Tojo <masaya <at> tojo.tokyo>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39818 <at> debbugs.gnu.org <39818 <at> debbugs.gnu.org>
Subject: Re: [bug#39818] [PATCH] gnu: Add emacs-ddskk.
Date: Thu, 5 Mar 2020 14:13:29 +0000

[Message part 1 (text/plain, inline)]

Hello.

> Another option is to re-send the package with the commit you chose,
> along with a comment explaining why (e.g., exactly what you wrote
> above), and update it later when 17.x is released.
> 
> WDYT?

I think that re-send package along with comment explaining is good
choice. 

Although, I have found problems in my first patch. I solved them and
build version 16.3.

A build of my firth patch has two problems:
* It can't read info files.
* It can't read skk-tutorial.

For solve above, I needed to precisely follow installation manual of
ddskk.
https://github.com/skk-dev/ddskk/blob/ddskk-16.3_Kutomatsunai/READMEs/INSTALL


>>>> +(define emacs-ddskk  

>>> Wouldn't it be emacs-skk, since one need to (require 'skk)?

I researched to the history of ddskk's name. skk refer original skk.
Ddskk is extend of original skk , and original skk was developed other team.  It called ddskk for distiguish between it and original skk.
So I think that package name is `emacs-ddskk`. 
Actually debian and melpa use name of `ddskk`.

https://packages.debian.org/sid/utils/ddskk
https://melpa.org/#/ddskk


>>> is a version of @acronym{SKK, Simple Kana to Kanji} conversion
>>> program,

Thanks of teach `@acronym`. 
SKK is acronym of "Simple Kana to Kanji conversion program".

I resend new revision. 

Regards.

[0001-gnu-Add-emacs-ddskk.patch (text/x-patch, attachment)]

Message #22 received at 39818-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Masaya Tojo <masaya <at> tojo.tokyo>
Cc: 39818-done <at> debbugs.gnu.org
Subject: Re: [bug#39818] [PATCH] gnu: Add emacs-ddskk.
Date: Thu, 05 Mar 2020 19:26:22 +0100

Hello,

Masaya Tojo <masaya <at> tojo.tokyo> writes:

> I resend new revision.

Thank you!

I applied your patch as 5d0f33c2ab9aa0cdc51a35525e895a603eac78ea, with
the following changes:

- I used a top-level `version' and `code-name' variables instead of
  using release commit.
- I specified that the input method was on Emacs in description.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.