GNU bug report logs - #39820
wrong face is assigned to comment delimiter in lisp-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39820 in the body.
You can then email your comments to 39820 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: chuntaro <at> sakura-games.jp
To: bug-gnu-emacs <at> gnu.org
Subject: wrong face is assigned to comment delimiter in lisp-mode
Date: Fri, 28 Feb 2020 19:26:58 +0900

[Message part 1 (text/plain, inline)]

Start emacs -Q and evaluate the following with *scratch*.

(set-face-foreground 'font-lock-comment-face "green")
(set-face-foreground 'font-lock-comment-delimiter-face "red")

Open `foo.lisp' with C-x C-f and enter as follows.

#|
comment
|#

As a result, the correct face is not assigned to the closing delimiter.

#|      <- font-lock-comment-delimiter-face
comment <- font-lock-comment-face
|#      <- font-lock-comment-face <- Wrong face

Occurs in Emacs 25.2, 26.1 and 27.0.60.

Normally, both colors are the same, so no one may have noticed until now.
I noticed recently because I was using a zenburn theme with slightly
different colors.

-- 
chuntaro

[bug.png (image/png, attachment)]

Message #18 received at 39820 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: chuntaro <at> sakura-games.jp
Cc: 39820 <at> debbugs.gnu.org
Subject: Re: bug#39820: wrong face is assigned to comment delimiter in
 lisp-mode
Date: Fri, 29 Jan 2021 07:41:10 +0100

chuntaro <at> sakura-games.jp writes:

> As a result, the correct face is not assigned to the closing delimiter.
>
> #|      <- font-lock-comment-delimiter-face
> comment <- font-lock-comment-face
> |#      <- font-lock-comment-face <- Wrong face
>
> Occurs in Emacs 25.2, 26.1 and 27.0.60.

Thanks for the clear recipe for reproduction.

This should now be fixed in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 39820 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: chuntaro <at> sakura-games.jp
Cc: 39820 <at> debbugs.gnu.org
Subject: Re: bug#39820: wrong face is assigned to comment delimiter in
 lisp-mode
Date: Sun, 31 Jan 2021 07:59:02 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> chuntaro <at> sakura-games.jp writes:
>
>> As a result, the correct face is not assigned to the closing delimiter.
>>
>> #|      <- font-lock-comment-delimiter-face
>> comment <- font-lock-comment-face
>> |#      <- font-lock-comment-face <- Wrong face
>>
>> Occurs in Emacs 25.2, 26.1 and 27.0.60.
>
> Thanks for the clear recipe for reproduction.
>
> This should now be fixed in Emacs 28.

The fix wasn't the correct one (leading to M-; inserting |#), so I've
reverted it for now, and I'm reopening this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #36 received at 39820 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: chuntaro <chuntaro <at> sakura-games.jp>
Cc: 39820 <at> debbugs.gnu.org
Subject: Re: bug#39820: wrong face is assigned to comment delimiter in
 lisp-mode
Date: Tue, 02 Feb 2021 10:19:30 +0100

chuntaro <chuntaro <at> sakura-games.jp> writes:

> I think I was able to fix #39820 by doing the following.

Thanks; that fixes the problem here too, so I've pushed this to Emacs
28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.